Add more integration tests for resharing permissions

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Use the correct mountpoint to calculate

If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21767 from nextcloud/enh/lazy_register_navigation

Lazy register the navigation

Lazy register the navigation

This makes sure that we do not translate unneeded strings on for example
webdav requests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21746 from nextcloud/techdebt/noid/cloud_federation_api-bootstrap

Move cloud_federation_api to bootstrap mechanism

Merge pull request #21766 from nextcloud/fix/21761/regression-in-return-value

Fix regression in return value of OC_Util::checkDataDirectoryPermissi…

Fix regression in return value of OC_Util::checkDataDirectoryPermissions due to #21761

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21761 from nextcloud/fix/permission_check_translation

Kill another unneeded translation

[tx-robot] updated from transifex

Kill another unneeded translation

We should only translate things when we actually need them.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21758 from nextcloud/fix/routes/defaults

Fix supporting defaults for routes

Fix supporting defaults for routes

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21754 from nextcloud/td/no_translation_on_each_request

Only translate if we need the string

Only translate if we need the string

This translation was done in each call. Over and over and over again.
All while it was probably not used in 99.99999% of the cases. A small
gain. But still.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21729 from nextcloud/enh/noid/orphaned-mounts

Add removal of mounts without storages to files:cleanup command

Merge pull request #21745 from nextcloud/techdebt/noid/lookup_server_connector-bootstrap

Move lookup server connector to bootstrap mechanism

Merge pull request #21749 from nextcloud/techdebt/noid/contactsinteraction-bootstrap

Move contactsinteraction and comments to bootstrap mechanism

Move contactsinteraction to bootstrap mechanism

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Test for proper removal of mount entries

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Move cloud_federation_api to bootstrap mechanism

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Move lookup server connector to bootstrap mechanism

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21643 from nextcloud/enh/no_routeactionhadler_inits

Do not create a RouteActionHandler object for each route

Merge pull request #21741 from nextcloud/debt/noid/url-generator-does-not-implement-i-user-session

Fix type for $urlGenerator

Fix type for $urlGenerator

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #21739 from nextcloud/techdebt/14552/migrate-OC-initSession

Remove hook for initSession

[tx-robot] updated from transifex

Remove hook for initSession

It's not used anyways and allowed to manipulate the state of the session. Also removed the code handling this.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add removal of mounts without storages to files:cleanup command

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Do not create a RouteActionHandler object for each route

This is not required and doesn't allow us to be properly lazy. On top of
it this doesnt allow us to cache the routes (since closures/objects
can't be cached).

This is the first small step into cleaning up the routing we have

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21676 from J0WI/fix-chmod-on-fd

Fix chmod on file descriptor

Merge pull request #21725 from nextcloud/bugfix/21316/ie11-quoted-props

Fix main bundle on IE11

Bump bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Do not quote properties when optimizing bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Merge pull request #21460 from nextcloud/enhancement/systemtags-bootstrap

Move systemtags to the new bootstrap mechanism

Merge pull request #21639 from nextcloud/techdebt/noid/move-away-from-database-xml

Move away from database xml

Merge pull request #21714 from nextcloud/td/remove/getAppFolder

Remove old deprecated getAppFolder

Merge pull request #18867 from HolgerHees/patch-1

Update SecurityMiddleware.php

Remove old deprecated getAppFolder

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Update SecurityMiddleware.php

OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header.

in other areas OC::$WEBROOT is always used together with an /

Merge pull request #21717 from nextcloud/fix/tests/sharebymail

Fix sharebymail tests

Merge pull request #20729 from nextcloud/cleanup/noid/shared-tags-code

Tags.php and the old sharing mechanism

Merge pull request #21706 from nextcloud/bugfix/21698/add-a-clear-abuse-message

Add a clear message why you could end up there

Fix sharebymail tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #21713 from nextcloud/td/deprecate/register_rotues

Deprecate registerRoutes

Update class loaders

Signed-off-by: Joas Schilling <coding@schilljs.com>

Move user_ldap to migrations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Move files_trashbin to migrations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Move files_external to migrations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Move federatedfilesharing to migrations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Move federation to migrations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Deprecate registerRoutes

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Cascading effect - more code that now is not used anymore

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Tags.php and the old sharing mechanism

The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #21704 from nextcloud/fix/18895/fix-unit-tests

Fix unit tests from #18895

Merge pull request #21074 from jvsalo/shared-lock-multi-release

Fix releasing a shared lock multiple times

Merge pull request #21171 from nextcloud/enh/noid/tidy-up-group-ldap

tidy up Group_LDAP

Merge pull request #21222 from nextcloud/bugfix/18965/reduce-contacts-search-load

Reduce contacts search load

Merge pull request #21238 from nextcloud/techdebt/noid/deferrable-notification-apps

Allow notification apps to defer and flush the sending

Add a clear message why you could end up there

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix unit tests from #18895

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #18895 from nextcloud/bugfix/noid/fix_birthday_calendar_color

Changes the Birthday calendar color to slightly brighter one

Merge pull request #21665 from nextcloud/debt/noid/job-list

Fix wrong phpdoc for execute method

Merge pull request #21692 from nextcloud/cleanup/sharebymail

Cleanup share by mail a bit

Merge pull request #21581 from nextcloud/3rdparty/symfony/4.4.10

Bump symfony deps to 4.4.10

Use formal type hints instead of informal PHPDoc

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Bump symfony deps to 4.4.10

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Cleanup share by mail a bit

* Moved to ned IBootstrap
* Register everything via the capabilities api (So clients can use it as
  well)
  - This applies to the enforcing passwords
* Updated the sharing js code to use it
* removed app.php
* removed unused settings now
* typehints
* strict typing

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>

[tx-robot] updated from transifex

Merge pull request #21264 from stweil/master

build: Fix some typos (most of them found by codespell)

Merge pull request #21636 from nextcloud/lock-exception-readable-path

add proper paths to locking exceptions

Merge pull request #21626 from nextcloud/enhancement/injectible-callables

Callable parameter injection

Merge pull request #21686 from nextcloud/dependabot/npm_and_yarn/babel/core-7.10.4

Bump @babel/core from 7.10.3 to 7.10.4

Merge pull request #21533 from nextcloud/techdebt/noid/dedicated-method-to-get-a-users-language

Techdebt/noid/dedicated method to get a users language

Bump @babel/core from 7.10.3 to 7.10.4

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.10.3 to 7.10.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.4/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #21685 from nextcloud/dependabot/npm_and_yarn/babel/preset-env-7.10.4

Bump @babel/preset-env from 7.10.3 to 7.10.4

Merge pull request #21682 from nextcloud/dependabot/npm_and_yarn/eslint-plugin-import-2.22.0

Bump eslint-plugin-import from 2.21.2 to 2.22.0

[tx-robot] updated from transifex

Bump @babel/preset-env from 7.10.3 to 7.10.4

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.10.3 to 7.10.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.4/packages/babel-preset-env)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump eslint-plugin-import from 2.21.2 to 2.22.0

Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.21.2 to 2.22.0.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.21.2...v2.22.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Fix chmod on file descriptor

Signed-off-by: J0WI <J0WI@users.noreply.github.com>

Allow notification apps to defer and flush the sending

Signed-off-by: Joas Schilling <coding@schilljs.com>

Use \OCP\IContainer::injectFn to boot the admin_audit app

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Use \OCP\IContainer::injectFn to boot the Accessibility app

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Use \OCP\IContainer::injectFn to boot the DAV app

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Callable parameter injection

This is like what we have to DI and classes, but for callables.

The motivating factor is to get rid of *service locators* in the `boot`
method of apps as a new pattern is about to emerge where we have lots of
`query` calls on the app or server container in order to fetch some
services.

With this little helper it's possible to call another (public) method
and magically have everything injected.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #21280 from nextcloud/dependabot/npm_and_yarn/nextcloud/router-1.1.0

Bump @nextcloud/router from 1.0.2 to 1.1.0

Use the new method everywhere

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix wrong phpdoc for execute method

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #21662 from nextcloud/fix/s3-bucket-compat-static-call

Fix static method call for s3 bucket compat check

Merge pull request #20198 from nextcloud/enh/enable-codecov

Send coverage to codecov again

Merge pull request #21439 from nextcloud/feature/noid/move-autocomplete-filter-event-to-new-dispatcher-and-class

Move AutoComplete::filterResults to new event dispatcher and GenericE…

Merge pull request #21431 from nextcloud/search-filter-invalid-results

Filter out search results that have invalid encoding

Fix static method call for s3 bucket compat check

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Bump @nextcloud/router from 1.0.2 to 1.1.0

Bumps [@nextcloud/router](https://github.com/nextcloud/nextcloud-router) from 1.0.2 to 1.1.0.
- [Release notes](https://github.com/nextcloud/nextcloud-router/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-router/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-router/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

[tx-robot] updated from transifex

Merge pull request #21644 from nextcloud/bugfix/noid/typo-in-variable-name

Fix typo in variable name and make check more accurate

Merge pull request #21591 from nextcloud/debt/noid/set-path-for-ocm-permissions

Pass $path to ocmPermissions2ncPermissions

Merge pull request #21648 from nextcloud/bug/21647/tar-header

Add missing TarHeader.php

Merge pull request #21360 from nextcloud/root-storage-prevent-scanning

prevent the root storage from accidentally scanning user folders