source.dussan.org Git

Nick Burch [Tue, 15 Mar 2016 12:37:01 +0000 (12:37 +0000)]

One final invalid file type check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735071 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Mar 2016 12:30:45 +0000 (12:30 +0000)]

Before opening an OOXML file, check the first few bytes, and give helpful exceptions for common mistakes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735069 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Mar 2016 12:03:30 +0000 (12:03 +0000)]

Push all the zip opening logic into ZipHelper

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735064 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Mar 2016 11:56:28 +0000 (11:56 +0000)]

Fix inconsistent indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735063 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Mar 2016 11:54:16 +0000 (11:54 +0000)]

Fix inconsistent indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735061 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Mar 2016 11:50:57 +0000 (11:50 +0000)]

Start to give more helpful Exceptions from OPCPackage when non-OOXML files are passed to it

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735060 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 15 Mar 2016 11:15:38 +0000 (11:15 +0000)]

Add a test ODS file, for more helpful error messages

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1735056 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 14 Mar 2016 12:00:27 +0000 (12:00 +0000)]

Remove some useless lines of code, the initialAllocationSize is ignored in SXSSFRow() anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734925 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 14 Mar 2016 11:58:15 +0000 (11:58 +0000)]

Fix some IntelliJ warnings and adjust Javadoc of readFully() slightly to describe the behavior better.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734924 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 14 Mar 2016 00:42:59 +0000 (00:42 +0000)]

HSLF: Add support for system colors

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734865 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 13 Mar 2016 21:30:38 +0000 (21:30 +0000)]

Bug 56930: Add Workbook.getNames() to allow to query for names that appear multiple times

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734863 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 13 Mar 2016 21:30:27 +0000 (21:30 +0000)]

Bug 55791: Avoid using an existing file-name when creating a new slide, it could still be left over from previous partial removal

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734862 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 13 Mar 2016 21:30:18 +0000 (21:30 +0000)]

Bug 55668: Try to avoid NullPointerException when chaning cell type and formula leads to null-string by seting the cell to BLANK instead

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734861 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 13 Mar 2016 21:19:46 +0000 (21:19 +0000)]

Escape spaces in the URL

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734858 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 13 Mar 2016 19:31:32 +0000 (19:31 +0000)]

#59135 - Password gets truncated when using passwords longer than 15 characters for the function protectSheet()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734843 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 13 Mar 2016 14:12:43 +0000 (14:12 +0000)]

sonar fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734809 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 16:56:33 +0000 (16:56 +0000)]

Bug 57200: Do not try to delete the poifiles-tempdir as it can interfere when multiple applications are using SXSSF on the same machine.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734719 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 16:56:26 +0000 (16:56 +0000)]

Fix bug 56549: correctly calculate char index ranges for HWPF in the TextPieceTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734718 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 12 Mar 2016 13:33:53 +0000 (13:33 +0000)]

#59170 - Remove deprecated classes (POI 3.15) - *Workbook.setRepeatingRowsAndColumns()

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734701 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 11:45:34 +0000 (11:45 +0000)]

Apply patch to fix bug 57495: getTableArray method can not get 0 pos table

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734694 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 11:37:32 +0000 (11:37 +0000)]

Refactor some common code from the various Document-Factories into a helper class
Fix a potential file-handle-leak for password protected workbooks or slideshows

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734691 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 11:37:22 +0000 (11:37 +0000)]

Fix some cases where POI itself or the tests leaked file-handles
Also fix some IntelliJ warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734690 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 11:37:12 +0000 (11:37 +0000)]

Findbugs fixes
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 11:36:56 +0000 (11:36 +0000)]

Mark duplicated RecordFormatException as deprecated to be able to remove it at some point in the future

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734688 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 11:36:50 +0000 (11:36 +0000)]

Enable some tests that are ignored, actually run green and did not have any comment why they were ignored in the first place
Fix some compiler warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734687 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 12 Mar 2016 11:36:43 +0000 (11:36 +0000)]

Add test for bug 59098 which shows that this is fixed in 3.14.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734686 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 12 Mar 2016 00:34:26 +0000 (00:34 +0000)]

add fixcrlf to docs-target, to fix windows document generation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734654 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 12 Mar 2016 00:17:16 +0000 (00:17 +0000)]

#59170 - Remove deprecated classes (POI 3.15) - org.apache.poi.hssf/ss.util.Region

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734651 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 11 Mar 2016 23:14:09 +0000 (23:14 +0000)]

sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734641 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 10 Mar 2016 00:32:33 +0000 (00:32 +0000)]

sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734339 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Thu, 10 Mar 2016 00:20:34 +0000 (00:20 +0000)]

sonar fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734337 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 9 Mar 2016 21:36:26 +0000 (21:36 +0000)]

findbugs fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734319 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 9 Mar 2016 21:01:33 +0000 (21:01 +0000)]

fix class dependency error of #57031 / #59058 patch

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734312 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 9 Mar 2016 20:57:26 +0000 (20:57 +0000)]

Remove a superfluous/bloated log function, which String.format can do better and is only used once ...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734310 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Wed, 9 Mar 2016 10:57:52 +0000 (10:57 +0000)]

More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 9 Mar 2016 01:25:02 +0000 (01:25 +0000)]

#59058 - OOM when parsing docx after OPCPackage.open with File but not with InputStream (TIKA-1866)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734184 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 9 Mar 2016 00:41:02 +0000 (00:41 +0000)]

#57031 - Out of Memory when extracting text from attached files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734182 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 7 Mar 2016 08:32:11 +0000 (08:32 +0000)]

Fix source rebuilding verification after resulting binaries in dist-folder changed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733878 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 7 Mar 2016 01:58:26 +0000 (01:58 +0000)]

signing and repository upload via ant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733863 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 7 Mar 2016 01:53:47 +0000 (01:53 +0000)]

update doap to poi 3.14

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733862 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 3 Mar 2016 13:38:03 +0000 (13:38 +0000)]

Fixup last commit: don't remove the xmlbeans.marker files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733465 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Thu, 3 Mar 2016 13:36:26 +0000 (13:36 +0000)]

Switch to 3.15-beta1 in the sonar-build-files as well
Add a bit more cleanup and removal of old libs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733464 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 1 Mar 2016 18:11:14 +0000 (18:11 +0000)]

Comment and Javadoc updates

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1733119 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 1 Mar 2016 00:35:51 +0000 (00:35 +0000)]

switch to 3.15-beta1

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732983 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 1 Mar 2016 00:31:24 +0000 (00:31 +0000)]

3.14 release preparation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732981 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 1 Mar 2016 00:17:20 +0000 (00:17 +0000)]

3.14 release preparation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732977 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 29 Feb 2016 23:59:49 +0000 (23:59 +0000)]

#59056 - Render individual slideshow shapes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732974 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 29 Feb 2016 23:36:58 +0000 (23:36 +0000)]

Fix NPE of regression tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732972 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 28 Feb 2016 19:40:25 +0000 (19:40 +0000)]

Exclude file for bug 59074 for some more tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732783 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 28 Feb 2016 15:24:14 +0000 (15:24 +0000)]

find bugs fix - WMF_HEADER_MAGIC isn't final but should be

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732753 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 27 Feb 2016 10:23:53 +0000 (10:23 +0000)]

Also mark the file for bug 59074 as expected-failure for integration testing

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732620 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 27 Feb 2016 10:23:46 +0000 (10:23 +0000)]

Bug 57914: Provide a better error message for OOXML strict format which we do not support yet.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732619 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 27 Feb 2016 08:41:21 +0000 (08:41 +0000)]

Add missing file for bug 59074

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732612 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 27 Feb 2016 08:41:07 +0000 (08:41 +0000)]

Update to JaCoCo 0.7.6 to try to restore coverage on builds.a.o

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732611 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 26 Feb 2016 23:56:31 +0000 (23:56 +0000)]

#59074 More helpful exception if Excel 1-95 files are given to ExtractorFactory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732587 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 26 Feb 2016 23:43:59 +0000 (23:43 +0000)]

Refactor out the POIFS directory entry name for Excel 1-95 entries, and have ExtractorFactory detect (but not support) these old files

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732583 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 26 Feb 2016 23:32:54 +0000 (23:32 +0000)]

Fix inconsistent indents

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732580 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Fri, 26 Feb 2016 23:32:17 +0000 (23:32 +0000)]

Refactor to pull out the list of Excel 97+ directory entry names to a common place, avoiding duplication. Also starts on unit testing #59074

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732579 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Wed, 24 Feb 2016 22:43:51 +0000 (22:43 +0000)]

Regression fixes for H/XSLF and HWMF
see http://apache-poi.1045710.n5.nabble.com/3-14-beta-2-3-14-final-tt5721829.html

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732236 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 24 Feb 2016 22:39:11 +0000 (22:39 +0000)]

Bug 47245: Comment out check and exception in case row-records are missing for some cells as it seems POI is handling this gracefully and LibreOffice/Excel are as well

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732235 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 24 Feb 2016 22:38:53 +0000 (22:38 +0000)]

Add xlsx which verifies via the integration-tests that the namespace fix works

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1732234 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 23 Feb 2016 22:24:09 +0000 (22:24 +0000)]

#59021 Namespace aware processing fix for ReadOnlySharedStringsTable, to match the one recently added to XSSFSheetXMLHandler

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731986 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 23 Feb 2016 22:16:54 +0000 (22:16 +0000)]

Pull out two more XSSF namespace definitions as re-usable constants

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731980 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Tue, 23 Feb 2016 22:10:20 +0000 (22:10 +0000)]

Pull out http://schemas.openxmlformats.org/spreadsheetml/2006/main to a re-used constant

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731975 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Sun, 21 Feb 2016 21:17:23 +0000 (21:17 +0000)]

Patch from Jim King from bug #57989 - XSSFChart support for setting chart titles, plus get+set unit tests

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731566 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 21 Feb 2016 20:42:05 +0000 (20:42 +0000)]

One more possible resource leak when creating the TextExtractor fails with a RuntimeException or one of the named exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731561 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sun, 21 Feb 2016 20:41:56 +0000 (20:41 +0000)]

Include stacktrace of inner exception when block-positions are invalid in POIFSFileSystem

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731560 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Fri, 19 Feb 2016 15:46:26 +0000 (15:46 +0000)]

POI 59030 fix NPE in XWPFTableCell's getVerticalAlignment via Prasad Babu

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731257 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 18 Feb 2016 17:53:13 +0000 (17:53 +0000)]

bug 58896: comment out time-dependent test

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731101 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 18 Feb 2016 11:16:11 +0000 (11:16 +0000)]

Javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1731047 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 18 Feb 2016 04:05:45 +0000 (04:05 +0000)]

move trackColumnsForAutoSizingIfSXSSF into ITestDataProvider, replace ITestDataProvider.trackColumnsForAutosizing(Sheet, int...) with ITestDataProvider.trackAllColumnsForAutosizing(Sheet) to avoid cluttering unit tests with specific columns that will be autosized

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730999 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 18 Feb 2016 03:33:25 +0000 (03:33 +0000)]

bug 58896: add unit test to time Sheet.autoSizeColumn

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730997 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 18 Feb 2016 02:03:11 +0000 (02:03 +0000)]

avoid redundant null check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730994 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Thu, 18 Feb 2016 01:49:59 +0000 (01:49 +0000)]

59021 -- fix content extraction from namespaced elements in XSSFEventBasedExcelExtractor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730992 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 18 Feb 2016 01:33:14 +0000 (01:33 +0000)]

bug 56345: reject single-cell merged regions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730991 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Wed, 17 Feb 2016 21:35:22 +0000 (21:35 +0000)]

Add test which verifies that bug 52684 is not a problem (any more)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730948 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 15 Feb 2016 20:27:59 +0000 (20:27 +0000)]

bug 58339: patch from Patrick Zimmermann to allow OFFSET() to accept missing optional width or height parameters

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730606 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 15 Feb 2016 19:16:45 +0000 (19:16 +0000)]

Tried to reproduce bug 55476, but could not, added unit test anyway

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730598 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 15 Feb 2016 14:58:16 +0000 (14:58 +0000)]

Add details of the ignored errors where the HSSF spec provides a good description, and a bit more refactoring. #56892

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730543 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 15 Feb 2016 14:40:24 +0000 (14:40 +0000)]

Start generalising the IgnoredErrorType code for later HSSF use too #56892

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730540 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 15 Feb 2016 10:08:26 +0000 (10:08 +0000)]

No need to wrap OpenXML4JRuntimeException in another instance of itself and fix some compilation/javadoc warnings

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730482 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 15 Feb 2016 09:26:51 +0000 (09:26 +0000)]

GitHub PR 27: Add method to check for any protection in XWPFDocument, closes #27

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730471 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 15 Feb 2016 08:33:12 +0000 (08:33 +0000)]

Seems we need a cast here to compile with some newer JDKs, at least IntelliJ complains for me

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730464 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Mon, 15 Feb 2016 07:41:47 +0000 (07:41 +0000)]

Improve error messages to state which bounds are exceeded

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730463 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 13 Feb 2016 21:30:10 +0000 (21:30 +0000)]

Regression analysis: Cloning sheets failed on ctrlProps, i.e. checkboxes
and other GUI elements, add minimal support for these to allow clone to
succeed.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730275 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 13 Feb 2016 21:29:46 +0000 (21:29 +0000)]

Regression analysis: the additional testing of cloning sheets showed a
possible ArrayIndexOutOfBounds error which we can avoid to make cloning
fail a bit less.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730274 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 13 Feb 2016 21:29:23 +0000 (21:29 +0000)]

Ignore a failure during cloning if we exceed file-format limits

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1730273 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 12 Feb 2016 09:44:47 +0000 (09:44 +0000)]

bug 58996: Don't try to unset fill color if it is not set to avoid invalid access inside the Xml structures

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729964 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 11 Feb 2016 15:13:40 +0000 (15:13 +0000)]

Fix #57034 on SXSSF, and add a common unit test to show it was already fixed on the others + is now fixed for SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729849 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Thu, 11 Feb 2016 15:13:01 +0000 (15:13 +0000)]

Allow common tests to do auto-sizing even on SXSSF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1729848 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 6 Feb 2016 22:23:47 +0000 (22:23 +0000)]

Add example for adding videos

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728888 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Fri, 5 Feb 2016 22:03:44 +0000 (22:03 +0000)]

XSLF - fixed NPE when adding pictures with existing non-picture media files (e.g. movies)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728737 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Fri, 5 Feb 2016 07:51:35 +0000 (07:51 +0000)]

Remove file from expected failures after changes for bug 56880

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728612 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Tim Allison [Thu, 4 Feb 2016 19:54:15 +0000 (19:54 +0000)]

Bug 56880 - switch exception to logged warning that non-extended pascal strings are not supported. Full fix would add parsing for these strings.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1728547 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 31 Jan 2016 12:52:32 +0000 (12:52 +0000)]

remove deprecated (2009) HSSFComment#setColumn(short). int version is available.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727805 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 31 Jan 2016 12:33:00 +0000 (12:33 +0000)]

HSSFComment: note a final field

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727803 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 31 Jan 2016 12:14:55 +0000 (12:14 +0000)]

fix O(n^2) runtime unnecessarily recreating an array inside a for-loop

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727800 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 31 Jan 2016 04:04:56 +0000 (04:04 +0000)]

bug 58885: fix javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727777 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 31 Jan 2016 03:27:35 +0000 (03:27 +0000)]

bug 58885: performance regression on XSSFSheet.addMergedRegion(CellRangeAddress). Add an unsafe version of addMergedRegion that doesn't check for overlapping merged regions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727776 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Sat, 30 Jan 2016 11:02:54 +0000 (11:02 +0000)]

Adjust test to pass forbidden-apis-check

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1727693 13f79535-47bb-0310-9956-ffa450edef68