source.dussan.org Git

David North [Wed, 13 Jul 2016 16:40:47 +0000 (16:40 +0000)]

"cannot not" presumably means "cannot"

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752452 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 12 Jul 2016 15:40:18 +0000 (15:40 +0000)]

Fix name of new OLE2ScratchpadExtractorFactory

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752304 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 11 Jul 2016 23:00:40 +0000 (23:00 +0000)]

Remove un-used imports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752229 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 11 Jul 2016 22:57:42 +0000 (22:57 +0000)]

Last bit of reflection - get back to the full OOXML-enabled factory if we can

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752228 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 11 Jul 2016 22:53:22 +0000 (22:53 +0000)]

Exceptions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752227 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 11 Jul 2016 22:47:02 +0000 (22:47 +0000)]

Start moving logic over into the main and scratchpad jars for OLE2

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752226 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 11 Jul 2016 22:27:02 +0000 (22:27 +0000)]

Pull Scratchpad Extractor logic to own class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752225 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 11 Jul 2016 22:20:51 +0000 (22:20 +0000)]

Start to pull out some of the OLE2 logic, so we can then split some Scratchpad parts out

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752223 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 11 Jul 2016 22:17:34 +0000 (22:17 +0000)]

Notes on use

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752222 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Jul 2016 11:37:22 +0000 (11:37 +0000)]

add BaseTestCellUtil unit tests to cover setting cell style properties with an invalid value and using both valid Short and Enum values

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752079 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Jul 2016 11:18:55 +0000 (11:18 +0000)]

bug 59837: update CellUtil to handle VerticalAlignment and HorizontalAlignment enums

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752077 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Jul 2016 08:29:02 +0000 (08:29 +0000)]

bug 59837: replace CellStyle.ALIGN_ and CellStyle.VERTICAL_ constants with HorizontalAlignment and VerticalAlignment enums

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752066 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Jul 2016 06:54:36 +0000 (06:54 +0000)]

javadoc fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752063 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Jul 2016 06:52:16 +0000 (06:52 +0000)]

bug 59264: Unify interface for setting cell border line styles using BorderStyle enum instead of short code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752062 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Jul 2016 01:41:15 +0000 (01:41 +0000)]

Add comments describing Outlook .msg DirectoryNode names

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752054 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 10 Jul 2016 01:29:30 +0000 (01:29 +0000)]

move string literals out to array that can be for-looped over

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752053 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sat, 9 Jul 2016 18:52:26 +0000 (18:52 +0000)]

javadocs fixes (jdk8)
eclipse source clean-ups (final members, override annotations, for-each loops)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752037 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 9 Jul 2016 08:54:07 +0000 (08:54 +0000)]

add 2^x to POWER2 comments

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751992 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 9 Jul 2016 08:51:57 +0000 (08:51 +0000)]

bug 52949,59830: move module storage and decompressing into a standalone function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751990 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 9 Jul 2016 08:18:29 +0000 (08:18 +0000)]

bug 52949,59830: move module storage and decompressing into a standalone function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751987 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 9 Jul 2016 08:05:43 +0000 (08:05 +0000)]

bug 59830: attach context to any IOException (likely a result of reaching EOF on input stream)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751986 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 9 Jul 2016 06:38:16 +0000 (06:38 +0000)]

remove Internal UnhandledDataStructure.copyOfRange because function is available in JDK 1.6+ and we no longer support JDK 1.5

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751984 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 9 Jul 2016 06:30:12 +0000 (06:30 +0000)]

close streams if an exception is throw

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751983 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sat, 9 Jul 2016 05:39:56 +0000 (05:39 +0000)]

bug 59830: add context to why no more bytes could be read from input stream

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751982 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 22:28:28 +0000 (22:28 +0000)]

bug 59833: add getFillPatternEnum and setFillPattern(FillPatternType) to CellStyle; consolidate duplicated FillPattern constants in CellStyle to FillPatternType enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751972 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 18:45:15 +0000 (18:45 +0000)]

bug 55555: set fill pattern, foreground color, and background color order correctly to follow HSSFCellStyle's order requirement; patch from Qualtagh. This closes #33 on Github

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751955 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 18:05:02 +0000 (18:05 +0000)]

bug 56154: rename setLastModifiedBy to setLastModifiedByUser

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751950 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 17:59:01 +0000 (17:59 +0000)]

bug 56154: add @since annotations to getLastModifiedBy and setLastModifiedBy methods

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751949 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 17:56:54 +0000 (17:56 +0000)]

bug 56154: get and set last modified by user property; patch from Danil Lopatin

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751948 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 12:07:20 +0000 (12:07 +0000)]

convert OPC Compliance unit tests to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751891 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 11:55:21 +0000 (11:55 +0000)]

whitespace and +svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751890 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 11:53:28 +0000 (11:53 +0000)]

AllOpenXML4JInternalTests no longer needed in AllOpenXML4JTests suite because it was upgraded to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751889 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 11:42:01 +0000 (11:42 +0000)]

fix regular expression example

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751885 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 11:32:52 +0000 (11:32 +0000)]

bug 59826: ant script to apply patch.tar.gz files from bugzilla

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751883 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 09:10:03 +0000 (09:10 +0000)]

add crude unit test for ZipPackagePropertiesMarshaller

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751872 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 08:53:34 +0000 (08:53 +0000)]

convert to junit4

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751870 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Fri, 8 Jul 2016 08:38:28 +0000 (08:38 +0000)]

whitespace and +svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751867 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 23:20:34 +0000 (23:20 +0000)]

add @Internal annotations to implementations of Internal EvaluationWorkbook and EvaluationSheet interfaces; added @since annotations to clearAllCachedResultValues added in r1751836.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751843 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 23:00:07 +0000 (23:00 +0000)]

add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 22:46:06 +0000 (22:46 +0000)]

add getters for setIgnoreMissingWorkbooks and setDebugEvaluationOutputForNextEval; add internal decorator; getSupportedFunctionNames and getNotSupportedFunctionNames should return unmodifiable collections

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751840 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 22:38:09 +0000 (22:38 +0000)]

whitespace (3sp to 4sp)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751839 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 22:29:28 +0000 (22:29 +0000)]

whitespace (tabs to spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751838 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 22:27:32 +0000 (22:27 +0000)]

add @Override annotations to spreadsheet formula Evaluation classes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751837 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 22:22:10 +0000 (22:22 +0000)]

bug 59814: clear evaluation workbook and evaluation sheet caches. Patch from Greg Woolsey.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751836 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 21:48:30 +0000 (21:48 +0000)]

+svn:eol-style native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751835 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 02:27:13 +0000 (02:27 +0000)]

whitespace; +svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751744 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 02:25:42 +0000 (02:25 +0000)]

Findbugs-JDK8: log ignored exception

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751743 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 02:19:02 +0000 (02:19 +0000)]

bug 50795: move hack to avoid xmlbeans corrupt pointer to its own function

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751742 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 02:09:25 +0000 (02:09 +0000)]

bug 59805: tearDown should reset, not set, the LocaleUtil ThreadLocals (also avoid memory leaks)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751741 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 01:10:24 +0000 (01:10 +0000)]

bug 59805: avoid memory leaks if time zone or locale are never set or user never resets the time zone or locale; patch from apptaro

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751739 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 00:48:52 +0000 (00:48 +0000)]

findbugs: replace switch statement with fall-throughs with if statement, remove duplicate code

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751738 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Thu, 7 Jul 2016 00:12:04 +0000 (00:12 +0000)]

add comment about a bug found by findbugs-jdk8. Someone more familiar with HSLF should resolve this.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751737 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Jul 2016 09:23:34 +0000 (09:23 +0000)]

bug 59805: add LocaleUtil#resetUserTimeZone and #resetUserLocale methods that call ThreadLocal.remove to fix PermGen memory leaks for long-running threaded applications; patch from apptaro

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751641 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Jul 2016 08:52:40 +0000 (08:52 +0000)]

bug 59805: add unit test for LocaleUtil#getLocaleCalendar

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751629 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Jul 2016 08:12:08 +0000 (08:12 +0000)]

bug 59805: add unit test for LocaleUtil

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751620 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Wed, 6 Jul 2016 05:40:53 +0000 (05:40 +0000)]

bug 59805: make LocaleUtil a static class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751601 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Jul 2016 23:33:31 +0000 (23:33 +0000)]

bug 59804: javadoc update

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751574 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Jul 2016 23:26:32 +0000 (23:26 +0000)]

+svn:eol-style=native

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751572 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Jul 2016 23:22:49 +0000 (23:22 +0000)]

bug 59804: indicate when features were @Internal-ized

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751570 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Jul 2016 23:01:05 +0000 (23:01 +0000)]

bug 59804: add since attribute to @Internal annotation; add @Removal annotation to track when features will be removed

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751569 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Tue, 5 Jul 2016 22:57:50 +0000 (22:57 +0000)]

javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751568 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Tue, 5 Jul 2016 20:59:28 +0000 (20:59 +0000)]

bug 59784: replace 'signed' with 'signature (.asc)'; patch from Sebb

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751559 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Dominik Stadler [Tue, 5 Jul 2016 07:24:14 +0000 (07:24 +0000)]

Add a unit-test to verify that DataFormatter.formatCellValue() does format formula-results correctly

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751400 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Mon, 4 Jul 2016 23:45:19 +0000 (23:45 +0000)]

javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751387 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 4 Jul 2016 22:47:17 +0000 (22:47 +0000)]

When dumping a HMEF body that is a string not RTF, use a predictable encoding rather than whatever the property happened to have in the original file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751386 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 4 Jul 2016 22:41:46 +0000 (22:41 +0000)]

Fix HMEFMessage to allow fetching attributes by custom MAPI Properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751385 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 4 Jul 2016 20:55:07 +0000 (20:55 +0000)]

#59780 OPC support for a wider range of timezone'd created and modified date formats in package properties

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751379 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 4 Jul 2016 20:26:40 +0000 (20:26 +0000)]

Add ignored test for #59780, and specially-crafted test file

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751375 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 19:09:10 +0000 (19:09 +0000)]

bug 59796: XSSFTable#getRowCount off-by-one error

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751373 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 19:00:35 +0000 (19:00 +0000)]

typo

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751372 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 18:50:26 +0000 (18:50 +0000)]

mark BitField as internal use only

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751371 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 18:43:45 +0000 (18:43 +0000)]

pre for-each iteration over for index iteration

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751369 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 18:25:00 +0000 (18:25 +0000)]

bug 59795: add method to synchronize start and stop cell references with CTTable

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751368 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Nick Burch [Mon, 4 Jul 2016 18:06:14 +0000 (18:06 +0000)]

Try (as best as possible with no test file) to extract uncompressed HMEF test when that is there instead of Compressed RTF

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751361 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 13:49:44 +0000 (13:49 +0000)]

bug 59790,59791: add @since javadoc annotation to FormulaType and CellType

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751287 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 13:09:30 +0000 (13:09 +0000)]

bug 59791: CellFormat#ultimateType(Cell) should return an integer for backwards compatibility (use ultimateTypeEnum for now for CellType enums); re-add SXSSFCell(SXSSFRow, int) for backwards compatibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751273 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 12:35:49 +0000 (12:35 +0000)]

bug 59791: add @since to Cell, EvaluationCell, and FormulaEvaluator CellType getter javadocs

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751264 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 12:21:42 +0000 (12:21 +0000)]

bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 11:54:20 +0000 (11:54 +0000)]

bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 10:38:25 +0000 (10:38 +0000)]

reorganize imports (remove unused imports, sort alphabetically)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 10:15:18 +0000 (10:15 +0000)]

bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 09:45:46 +0000 (09:45 +0000)]

bug 59791: convert Cell Type to an enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 05:37:06 +0000 (05:37 +0000)]

bug 59790: convert FormulaType class to enum

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751210 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 05:00:55 +0000 (05:00 +0000)]

javadocs fix

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751209 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 03:06:11 +0000 (03:06 +0000)]

bug 59789: move HSSFComment shifting due to rowShift outside of for-loop for performance

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751198 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 02:58:38 +0000 (02:58 +0000)]

rearrange JavaDocs to match constructor ordering

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751197 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 02:14:02 +0000 (02:14 +0000)]

findbugs fixes

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751195 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 01:49:28 +0000 (01:49 +0000)]

bug 59773: replace for loops with for-each loops; javadocs fixes for JDK8

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751193 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 01:28:19 +0000 (01:28 +0000)]

add missing ASL license header from bug 59788 comment 2 r1751185

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751192 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 01:07:52 +0000 (01:07 +0000)]

bug 59166: suggest alternative implementations for TempFileCreationStrategy

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751190 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Mon, 4 Jul 2016 00:00:20 +0000 (00:00 +0000)]

bug 59788: move DefaultTempFileCreationStrategy from TempFile inner class to its own class

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751185 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Jul 2016 23:38:06 +0000 (23:38 +0000)]

javadocs fixes (jdk8)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751184 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 3 Jul 2016 23:33:36 +0000 (23:33 +0000)]

whitespace

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751183 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 3 Jul 2016 23:23:54 +0000 (23:23 +0000)]

make class attributes final; return unmodifiable lists

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751182 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 3 Jul 2016 23:17:11 +0000 (23:17 +0000)]

revert whitespace changes to ASF license; previous commit r1751180 contributed by sebb

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751181 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 3 Jul 2016 23:13:37 +0000 (23:13 +0000)]

bug 59786: fix NPE from winmail.dat files if message body is null

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751180 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 3 Jul 2016 23:05:52 +0000 (23:05 +0000)]

whitespace (3 spaces and tabs to 4 spaces)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751179 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 3 Jul 2016 22:59:41 +0000 (22:59 +0000)]

uncomment ignored unit tests so they at least compile

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751178 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Javen O'Neal [Sun, 3 Jul 2016 22:58:06 +0000 (22:58 +0000)]

bug 59788: create temporary directories

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751177 13f79535-47bb-0310-9956-ffa450edef68

commit | commitdiff | tree

Andreas Beeker [Sun, 3 Jul 2016 22:21:55 +0000 (22:21 +0000)]

deprecated DrawingManager

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751175 13f79535-47bb-0310-9956-ffa450edef68