fix: rework move into object store to better preserve fileids

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix(tests): Fix most obvious errors in ObjectStore tests

Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

perf(ObjectStoreStorage): Improve (slow) move on same object bucket

This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>

fix: write object to the correct urn when moving from another storage to object store

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #48880 from nextcloud/backport/48749/stable27

test: Adjust `files_external` tests for password confirmation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix: Add frontend code for password confirmation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix: add PasswordConfirmationRequired to create user storages endpoint

* add PasswordConfirmationRequired to update and delete method

Signed-off-by: yemkareems <yemkareems@gmail.com>

Merge pull request #49008 from nextcloud/backport/48992/stable27

fix: resolve conflict add PasswordConfirmationRequired to saveGlobalCredentials

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: add PasswordConfirmationRequired to saveGlobalCredentials

Co-authored-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
[skip ci]

Merge pull request #48975 from nextcloud/backport/48788/stable27

fix: conflicts resolved by adding PasswordConfirmationRequired to update method

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: cs fix namespace

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: add PasswordConfirmationRequired to the eternal storages mentioned in review

Signed-off-by: yemkareems <yemkareems@gmail.com>

Merge pull request #48960 from nextcloud/backport/48921/stable27

ci(psalm): Add missing imagick extension

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48526 from nextcloud/backport/48510/stable27

[stable27] fix(caldav): add missing handlers

Merge pull request #48928 from nextcloud/backport/48917/stable27

fix(dav): Cleanup view-only check

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48845 from nextcloud/backport/40367/stable27

[stable27]  Fix registerEventListener signature

Fix registerEventListener signature

It seems now psalm correctly supports this.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #48782 from nextcloud/automated/noid/stable27-update-code-signing-crl

[stable27] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

fix(caldav): add missing handlers

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #48493 from nextcloud/backport/48445/stable27

[stable27] fix(Auth): ignore missing token when trying to set password-unconfirmable

fix(Auth): ignore missing token when trying to set password-unconfirmable

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #48385 from nextcloud/backport/48359/stable27

[stable27] fix: Use placeholder for external storage password

Merge pull request #48297 from nextcloud/artonge/backport/stable27/47770

[stable27] fix(dav): Always respond custom error page on exceptions

fix: Prevent duplicate creation of print_exception function

Signed-off-by: Louis Chemineau <louis@chmn.me>

chore: Update smb-kerberos workflow

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #48378 from nextcloud/backport/48142/stable27

[stable27] feat(share): ensure unique share tokens with dynamic length adjustment

fix: Use hashed password in files_external settings

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix(share): Ensure unique share tokens

- check for token collisions and retry up to three times.
- throw after 3 attempts without finding a unique token.

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>

Merge pull request #48341 from nextcloud/automated/noid/stable27-update-ca-cert-bundle

[stable27] fix(security): Update CA certificate bundle

fix(security): Update CA certificate bundle

Signed-off-by: GitHub <noreply@github.com>

fix: Override start method of \Sabre\DAV\Server to remove exception output

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Drop unnecessary exit

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Replace conflicting tags in `xml_exception` template

The `<?xml` tag is interpreted as PHP short tags, so this causes errors.
Instead just print that part of the template.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(dav): Always respond custom error page on exceptions

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #48291 from nextcloud/backport/48282/stable27

[stable27] chore: add .git-blame-ignore-revs

chore: add .git-blame-ignore-revs

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #47864 from nextcloud/backport/46534/stable27

fix: Add direct parameter to flow auth v2

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #46677 from nextcloud/backport/44295/stable27

[stable27] Allow injecting the user temporarily for direct editing

fix(logging): Restore the option to log with debug level

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix: Implement option to temporarily set the user session

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: Do not use incognito mode for direct editing

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #47698 from nextcloud/backport/47627/stable27

[stable27] [LinkReferenceProvider] Better size check

Merge pull request #47703 from nextcloud/backport/47635/stable27

[stable27] [oauth2] Store hashed secret instead of encrypted

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(oauth2): fix tests

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

fix(oauth2): store hashed secret instead of encrypted

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

fix(linkReferenceProvider): better size check

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Merge pull request #47325 from nextcloud/backport/47227/stable27

[stable27] Apply group limit on remove from group

chore: Remove test not compatible with 27 and below

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix: Remove call to non-existing method in 28 and add missing use in test

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(tests): Fix PHP 8.0 compatibility

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(tests): Adapt tests to change of DefaultShareProvider constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix: Remove shares only if there are no more common groups between users

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore(tests): Test limiting sharing to same group

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix(files_sharing): Delete user shares if needed when user is removed from a group

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #47446 from nextcloud/backport/44369/stable27

 [stable27] fix: csrf check failed on public share with password

build: js assets

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix: csrf check failed on public share with password

Signed-off-by: Luka Trovic <luka@nextcloud.com>

fix: csrf check failed on public share with password

Signed-off-by: Luka Trovic <luka@nextcloud.com>

Merge pull request #47280 from nextcloud/backport/46881/stable27

[stable27] fix: try to find non-recursive share source

fix: try to find non-recursive share source

instead of always picking the first one, try to find one that won't blow up

Signed-off-by: Robin Appelman <robin@icewind.nl>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #47066 from nextcloud/backport/47043/stable27

[stable27] fix(inherited-shares): ignore top root folder

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(inherited-shares): ignore top root folder

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #47087 from nextcloud/backport/45193/stable27

[stable27] docs: added customclient_fdroid key to the config.sample.php file

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

docs: added customclient_fdroid config key to config.sample.php file

Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Bahman Jafarzadeh <bahman026@gmail.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #46861 from nextcloud/backport/46849/stable27

[stable27] fix: fix recursive share check

fix: fix recursive share check

Signed-off-by: Robin Appelman <robin@icewind.nl>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #46667 from nextcloud/backport/46640/stable27

[stable27] fix(Token): take over scope in token refresh with login by cookie

fix(Token): take over scope in token refresh with login by cookie

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
# Conflicts:
# lib/private/Authentication/Token/IProvider.php
# lib/private/Authentication/Token/Manager.php
# lib/private/Authentication/Token/PublicKeyTokenProvider.php

Merge pull request #46762 from nextcloud/backport/46672/stable27

[stable27] Avoid using partial file info as valid one

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #46741 from nextcloud/backport/46693/stable27

fix: Do not return partial file info if we have a cache entry

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: Ignore preview requests for invalid file ids

Signed-off-by: Julius Härtl <jus@bitgrid.net>

feat: add a specialized writeStream implementation for s3 external storage

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #46089 from nextcloud/backport/46073/stable27

fix: allows admin to edit global credentials

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>

Merge pull request #46682 from nextcloud/backport/46674/stable27