fix: remove caching in fetchListOfGroups

When using nested groups without a memberof overlay, then fetchListOfGroups is called from getGroupsByMember without applying the group filter.

In some setups, the "unfiltered" result is then written back to the group mapping table. That might cause random "An administrator removed you from group" activities.

I was unable to replicate it locally, but we got the feedback that the random activities stopped with the patch applied.

Ref: https://github.com/nextcloud/server/issues/42195

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #48268 from nextcloud/debt/noid/ignore-docker-image-lock-file

fix: skip the integrity check for nextcloud-init-sync.lock

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48274 from nextcloud/feat/noid/priority-notifications

feat(prioritynotifications): Allow some apps to mark notifications as priority

Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface

fix: Move storage constructor to specific interface

Merge pull request #48223 from nextcloud/feat/add-rector-config

Add rector config

fix(tests): Fix test to remove call to non-existing constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #48175 from nextcloud/followup/48086/fix-more-activity-providers

fix(activity): Update more activity providers to use new exceptions

Merge pull request #48215 from nextcloud/bugfix/noid/run-all-unit-tests

fix(tests): Fix test selection and run unit tests of DAV and user_status

fix(activity): Update more activity providers to use new exceptions

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #48207 from nextcloud/artonge/fix/prevent_missing_users_from_crashing_disabled_users_search

fix: Don't crash if disabled user is missing in the database

chore(rector): Move rector.php into the build folder

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #48275 from nextcloud/dependabot/github_actions/github-actions-560ea78344

chore(deps): Bump the github-actions group across 1 directory with 3 updates

chore: use a proper `@param` tag for IConstructableStorage constructor parameter

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

fix(users): Don't crash if disabled user is missing in the database

Signed-off-by: Louis Chemineau <louis@chmn.me>

chore(deps): Bump the github-actions group across 1 directory with 3 updates

Bumps the github-actions group with 3 updates in the / directory: [actions/setup-node](https://github.com/actions/setup-node), [cypress-io/github-action](https://github.com/cypress-io/github-action) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request).

Updates `actions/setup-node` from 4.0.3 to 4.0.4
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/1e60f620b9541d16bece96c5465dc8ee9832be0b...0a44ba7841725637a19e28fa30b79a866c81b0a6)

Updates `cypress-io/github-action` from 6.7.5 to 6.7.6
- [Release notes](https://github.com/cypress-io/github-action/releases)
- [Changelog](https://github.com/cypress-io/github-action/blob/master/CHANGELOG.md)
- [Commits](https://github.com/cypress-io/github-action/compare/496e7dc0edc421a9de8a36a31c793340e00c61bf...0da3c06ed8217b912deea9d8ee69630baed1737e)

Updates `peter-evans/create-pull-request` from 6.1.0 to 7.0.5
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](https://github.com/peter-evans/create-pull-request/compare/c5a7806660adbe173f04e3e038b0ccdcd758773c...5e914681df9dc83aa4e4905692ca88beb2f9e91f)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: cypress-io/github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>

fix: Move storage constructor to specific interface

That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #48266 from nextcloud/fix/psalm/enabled-find-unused-baseline-entry

fix(psalm): Enable findUnusedBaselineEntry

Signed-off-by: provokateurin <kate@provokateurin.de>

feat(prioritynotifications): Allow some apps to mark notifications as priority

They will be still send as push during DND.
Apps are currently limited to:
- twofactor_nextcloud_notification to help with login
- spreed which will only set it for pushes in manually picked conversations

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix: skip the integrity check for nextcloud-init-sync.lock

nextcloud-init-sync.lock is used by nextcloud/docker to prevent running the initialization script on multiple containers at the same time.

Ref: https://github.com/nextcloud/docker/issues/2299.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #48252 from nextcloud/dependabot/npm_and_yarn/sass-1.79.3

chore(deps-dev): Bump sass from 1.77.8 to 1.79.3

Bumps [sass](https://github.com/sass/dart-sass) from 1.77.8 to 1.79.3.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.77.8...1.79.3)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #48251 from nextcloud/dependabot/npm_and_yarn/vitest/coverage-v8-2.1.1

Merge pull request #48255 from nextcloud/dependabot/npm_and_yarn/tslib-2.7.0

Merge pull request #48246 from nextcloud/bug/noid/profile-clear-not-working

fix(profiler): clear command does not work

Merge pull request #48254 from nextcloud/dependabot/npm_and_yarn/nextcloud/axios-2.5.1

Merge pull request #48253 from nextcloud/dependabot/npm_and_yarn/focus-trap-7.6.0

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore(deps-dev): Bump tslib from 2.6.3 to 2.7.0

Bumps [tslib](https://github.com/Microsoft/tslib) from 2.6.3 to 2.7.0.
- [Release notes](https://github.com/Microsoft/tslib/releases)
- [Commits](https://github.com/Microsoft/tslib/compare/v2.6.3...v2.7.0)

---
updated-dependencies:
- dependency-name: tslib
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): Bump @nextcloud/axios from 2.5.0 to 2.5.1

Bumps [@nextcloud/axios](https://github.com/nextcloud/nextcloud-axios) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/nextcloud/nextcloud-axios/releases)
- [Changelog](https://github.com/nextcloud-libraries/nextcloud-axios/blob/v2.5.1/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-axios/compare/v2.5.0...v2.5.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/axios"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): Bump focus-trap from 7.5.4 to 7.6.0

Bumps [focus-trap](https://github.com/focus-trap/focus-trap) from 7.5.4 to 7.6.0.
- [Release notes](https://github.com/focus-trap/focus-trap/releases)
- [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/focus-trap/focus-trap/compare/v7.5.4...v7.6.0)

---
updated-dependencies:
- dependency-name: focus-trap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps-dev): Bump @vitest/coverage-v8 from 2.0.5 to 2.1.1

Bumps [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8) from 2.0.5 to 2.1.1.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.1/packages/coverage-v8)

---
updated-dependencies:
- dependency-name: "@vitest/coverage-v8"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #43968 from exi/custom-binary-search-paths

feat: make search path for BinaryFinder customizable.

Merge pull request #47782 from nextcloud/reworkShareExceptions

fix(l10n): Rephrasing some exceptions to be translated

fix(l10n): Rephrasing some exceptions to be translated

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: Fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Merge pull request #48152 from nextcloud/clean/version-ocp

chore(legacy): Introduce public version class and drop version methods from OC_Util

fix(profiler): clear command does not work

- The loop is supposed to delete the files first and then the directories.
- getPathInfo returns a SplFileInfo object for the parent (the folder in our case).
- A non-empty directory cannot be deleted.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

chore: Add rector script to composer.json

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: Apply rector configuration to apps folder

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: Add empty rector configuration

Only applying on apps for now, and only minimal type coverage level.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #48241 from nextcloud/chore/remove-legacy-files-scripts

feat: make search path for BinaryFinder customizable.

This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue #43922

Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Reno Reckling <e-github@wthack.de>

Merge pull request #48224 from nextcloud/object-store-trash-move

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore(legacy): Introduce public version ct plass and drop version methods from OC_Util

Signed-off-by: Julius Knorr <jus@bitgrid.net>

chore: Move legacy dialogs template from files to core until we can remove it

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore(files): Remove legacy style files

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore(files): Remove legacy UI scripts now that everything is migrated to Vue

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #47905 from nextcloud/fix/files-duplicated-nodes

fix(files): Ensure children are removed from folder and not duplicated

Merge pull request #47553 from nextcloud/chore/cleanup-warnings

chore: fix usage of deprecated functions and adjust code style

Merge pull request #48234 from nextcloud/bugfix/noid/remove-more-withConsecutive

fix(ci): Remove more withConsecutive in apps

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

test(files): Add tests for path handling

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(files): Ensure children are removed from folder and not duplicated

* Resolves https://github.com/nextcloud/server/issues/47904

We need to make sure that we only add one source (unique!) once as a child,
this is ensured by simply use a native `Set`.
Also we need to remove children on from folders when the `files:node:deleted`
event is emitted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore(assets): Recompile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(ci): Remove more withConsecutive in apps

Signed-off-by: Joas Schilling <coding@schilljs.com>

chore: fix usage of deprecated functions and adjust code style

This solves 57 ESLint warnings by replacing deprecated code with `@nextcloud/` libraries,
as well as adding missing type information, importing jQuery instead of relying on global one,
and the same with Moment.js.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48196 from nextcloud/chore/add-deprecation-date

chore: Add proper deprecation dates where missing

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

chore: Remove deprecated `Share_Helper::generateTarget` `$exclude` parameter

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore: Add proper deprecation dates where missing

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #47340 from nextcloud/fix/federation-certificate-store

fix(federation): Do not overwrite certificate bundle

fix(federation): Do not overwrite certificate bundle

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #48220 from nextcloud/chore/remove-travis

chore: Remove old travis related stuff

Merge pull request #48222 from nextcloud/object-store-move-db

fix: improve moving object store items to trashbin

Signed-off-by: Robin Appelman <robin@icewind.nl>

chore: Get rid of travis in DAV app

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Merge pull request #48217 from nextcloud/chore/prepare-oc_repair-unit10

chore: Cleanup and prepare `\OC\Repair\RepairMimeTypes` tests for PHPUnit 10

chore: Remove old travis related stuff

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

test: fix ContactsMigratorTest

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #48218 from nextcloud/ci/noid/prepare-phpunit-10

chore: Cleanup and prepare some app tests for PHPUnit 10

chore: Cleanup and prepare `\OC\Repair\RepairMimeTypes` tests for PHPUnit 10

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

perf: reuse cache info we already have when moving to object store

Signed-off-by: Robin Appelman <robin@icewind.nl>

chore: Cleanup and prepare some app tests for PHPUnit 10

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(user_status): Fix integration test of user status

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(tests): Fix test selection and run unit tests of DAV and user_status

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #48212 from nextcloud/fix/psalm/update-baseline

fix(psalm): Update psalm baseline

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #47399 from nextcloud/fix/47275/driverException

fix: expand select and group by for calendar reminder backend

Merge pull request #48187 from nextcloud/dependabot/npm_and_yarn/vueuse/components-11.1.0

Merge pull request #48181 from nextcloud/chore/deps/nextcloud-coding-standard

fix: expand select and group by for calandar reminder backend

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

chore(deps): Bump @vueuse/components from 11.0.3 to 11.1.0

Bumps [@vueuse/components](https://github.com/vueuse/vueuse/tree/HEAD/packages/components) from 11.0.3 to 11.1.0.
- [Release notes](https://github.com/vueuse/vueuse/releases)
- [Commits](https://github.com/vueuse/vueuse/commits/v11.1.0/packages/components)

---
updated-dependencies:
- dependency-name: "@vueuse/components"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore: Add nextcloud/coding-standard v1.3.1 update to git blame ignores

Signed-off-by: provokateurin <kate@provokateurin.de>

chore(deps): Update nextcloud/coding-standard to v1.3.1

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48192 from nextcloud/dependabot/npm_and_yarn/wait-on-8.0.1

chore(deps-dev): Bump wait-on from 7.2.0 to 8.0.1

Merge pull request #45471 from nextcloud/fix-setupcheck-filelocking

fix(setupChecks): Update Transactional File Locking instructions

Merge pull request #48188 from nextcloud/dependabot/npm_and_yarn/babel/plugin-transform-private-methods-7.25.4

fix(setupChecks): Having transactional file locking disabled is not supported

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

Merge pull request #48200 from nextcloud/share-reminder-sharding

fix: add sharding compatible version of share reminder job

fix: add sharding compatible version of share reminder job

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #47978 from nextcloud/chore/remove-ilogger

chore!: Remove `ILogger` and its friends

Merge pull request #48162 from nextcloud/bugfix/noid/array-keys

fix(autocomplete): Move known array keys to psalm docs

Merge pull request #48154 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

chore(tests): Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>