Merge pull request #49032 from nextcloud/backport/49009/stable25

fix(files-external): set password as sensitive

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #48962 from nextcloud/backport/48921/stable25

ci(psalm): Add missing imagick extension

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48524 from nextcloud/backport/48510/stable25

[stable25] fix(caldav): add missing handlers

Merge pull request #48926 from nextcloud/backport/48917/stable25

fix(dav): Cleanup view-only check

Signed-off-by: provokateurin <kate@provokateurin.de>

Merge pull request #48776 from nextcloud/automated/noid/stable25-update-code-signing-crl

[stable25] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

fix(caldav): add missing handlers

Signed-off-by: Anna Larch <anna@nextcloud.com>

Merge pull request #48383 from nextcloud/backport/48359/stable25

[stable25] fix: Use placeholder for external storage password

Merge pull request #48304 from nextcloud/backport/48297/stable25

[stable25] fix(dav): Always respond custom error page on exceptions

chore: Update smb-kerberos workflow

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Disable constructor in ErrorPagePluginTest

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Prevent duplicate creation of print_exception function

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Override start method of \Sabre\DAV\Server to remove exception output

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Replace conflicting tags in `xml_exception` template

The `<?xml` tag is interpreted as PHP short tags, so this causes errors.
Instead just print that part of the template.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix(dav): Always respond custom error page on exceptions

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #48376 from nextcloud/backport/48142/stable25

[stable25] feat(share): ensure unique share tokens with dynamic length adjustment

fix: Use hashed password in files_external settings

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix(share): Ensure unique share tokens

- check for token collisions and retry up to three times.
- throw after 3 attempts without finding a unique token.

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>

Merge pull request #48334 from nextcloud/automated/noid/stable25-update-ca-cert-bundle

[stable25] fix(security): Update CA certificate bundle

fix(security): Update CA certificate bundle

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #48289 from nextcloud/backport/48282/stable25

[stable25] chore: add .git-blame-ignore-revs

chore: add .git-blame-ignore-revs

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #46407 from nextcloud/backport/46388/stable25

[stable25] fix(workflows): Fix file systemtag cache

fix(workflows): Fix file systemtag cache

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #46262 from nextcloud/automated/noid/stable25-update-ca-cert-bundle

[stable25] fix(security): Update CA certificate bundle

fix(security): Update CA certificate bundle

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #46160 from nextcloud/automated/noid/stable25-update-code-signing-crl

[stable25] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #45858 from nextcloud/backport/45545/stable25

[stable25] fix(dav): Rate limit address book creation

Merge pull request #45924 from nextcloud/backport/45912/stable25

[stable25] ci: use precise ref for 3rdparty check

fix(dav): Rate limit address book creation

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>

Merge pull request #45760 from nextcloud/backport/45355/stable25

[stable25] fix: delete user credentials stored in storages_credentials when user gets deleted

Merge pull request #45830 from nextcloud/backport/45811/stable25

[stable25] test: add tests for ProfilePageController

ci: use precise ref for 3rdparty check

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

test: add tests for ProfilePageController

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

fix: added missing ICredentialsManager

fix: added missing ICredentialsManager

Signed-off-by: yemkareems <yemkareems@gmail.com>

fix: delete user credentials stored in storages_credentials when user gets deleted

Signed-off-by: yemkareems <yemkareems@gmail.com>
[skip ci]

Merge pull request #45462 from nextcloud/backport/45321/stable25

[stable25] fix: Correctly check result of function

Merge pull request #45464 from nextcloud/backport/45340/stable25

[stable25] fix: Extend SVG reference check

fix: Correctly check result of function

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix: Extend SVG reference check

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #44559 from nextcloud/backport/44339/stable25

[stable25] fix(share): use share owner to get ownership

Merge pull request #45008 from nextcloud/backport/44892/stable25

[stable25] fix(files): Also skip cross storage move with access control

fix(CI): Suppress psalm UndefinedClass

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(files): Also skip cross storage move with access control

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #44741 from nextcloud/backport/stable25/44736

[stable25] fix: Fix avatar images

test: Update tests

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix: Fix avatar images

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #44688 from nextcloud/backport/44678/stable25

[stable25] fix(3rdparty): Add a CI job to check 3rdparty integrity

fix(3rdparty): Add a CI job to check 3rdparty integrity

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(share): use share owner to confirm reshare

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #44476 from nextcloud/backport/44276/stable25

[stable25] fix(config): Make sure user keys are strings

Merge pull request #44517 from nextcloud/automated/noid/stable25-update-code-signing-crl

[stable25] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

fix(config): Make sure user keys are strings

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #44309 from nextcloud/backport/44299/stable25

[stable25] Forbid tagging readonly files

chore: Remove PHP8 constructor property promotions

25 supports 7.4

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(dav): Add missing use for OCP\Constants

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

chore: Break closure call on two lines to make it readable

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

fix(systemtags): Forbid tagging of readonly files

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #43845 from nextcloud/backport/43787/stable25

Merge pull request #44146 from nextcloud/automated/noid/stable25-update-ca-cert-bundle

[stable25] fix(security): Update CA certificate bundle

fix(security): Update CA certificate bundle

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #44077 from nextcloud/backport/43992/stable25

[stable25] fix: Avoid clear cache with prefix

fix: Avoid clear cache with prefix

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #43889 from nextcloud/backport/43599/stable25

[stable25] fix: Add bruteforce protection to email endpoint

Merge pull request #43781 from nextcloud/backport/43753/stable25

Merge pull request #43866 from nextcloud/backport/43768/stable25

Merge pull request #43870 from nextcloud/backport/43727/stable25

fix: Add bruteforce protection to email endpoint

Signed-off-by: Joas Schilling <coding@schilljs.com>

fix(dav): Rate limit calendar/subscription creation

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

fix(dav): Init ViewOnlyPlugin after auth

Signed-off-by: Louis Chemineau <louis@chmn.me>

Check node permissions when restoring a version

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #43749 from nextcloud/backport/40332/stable25

[stable25] Hide shares by disabled users

Merge pull request #43859 from nextcloud/backport/43727/stable25

[stable25] Check share status when touching versions

Check share attributes when downloading versions

Signed-off-by: Louis Chemineau <louis@chmn.me>

fix: Throw instead of yielding nothing when listing local directories

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix(tests): Adapt ManagerTest to new getAppValue call

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove modern PHP syntax, and apply codesniffer fixes in Share20/Manager.php

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Use nullsafe call syntax instead of additionnal check

Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>

Fix tests, add test for the new feature

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares from disabled users

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #43506 from nextcloud/automated/noid/stable25-update-code-signing-crl

[stable25] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #43376 from nextcloud/automated/noid/stable25-update-code-signing-crl

[stable25] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #43073 from nextcloud/automated/noid/stable25-update-code-signing-crl

[stable25] fix(security): Update code signing revocation list

fix(security): Update code signing revocation list

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #42909 from nextcloud/fix/caldav/update-acls-deletedcalendarobjectscollection-stable25

[stable25] fix(CalDAV): set acls for DeletedCalendarObjectsCollection

Merge pull request #42943 from nextcloud/backport/36471/stable25

[stable25] feat(theming): Only convert a background image if it benefits from it

fix(themeing): Add error handling to ImageManager

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

Add webp and large jpg test assets

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

feat(theming): Only convert a background image if it benefits from it

* WebP images are generally quite small, converting to pngs would increase
  the filesize a lot.
* Small JPEG and PNG images do not benefit from any conversion, so skip it.
* JPEG images will get quite bigger when converted to PNG so instead convert to progressive JPEG

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>

Merge pull request #42892 from nextcloud/backport/37346/stable25

[stable25] fix undefined method getExtStorageHome()

fix(CalDAV): set acls for DeletedCalendarObjectsCollection

Signed-off-by: Johannes Merkel <mail@johannesgge.de>

fix undefined method getExtStorageHome()

- adds a type check
- defines missing method in OfflineUser

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #42877 from nextcloud/backport/42563/stable25

[stable25] Update crl after revoke integration_homeassistant.csr