additional fix to #18730 #18733

regarding to advice from @kesselb

Wrong email sender fix #18730

Wrong email sender in app sharebymail when sending password to owner fix #18730

Merge pull request #18713 from nextcloud/fix/noid/do-remove-shares-generated-from-circles

remove non-circles-generated federated shares only

Merge pull request #18728 from simonspa/trashbin_exception

 Trash bin: fix exception triggered if no correct fileId is provided.

[tx-robot] updated from transifex

Trash bin: fix exception triggered if no correct fileId is provided.

This fixes #17115

Signed-off-by: Simon Spannagel <simon.spannagel@cern.ch>

Merge pull request #17861 from nextcloud/fix-tab-navigation-of-menu-in-public-share-pages

Fix tab navigation of menu in public share pages

Merge pull request #18724 from nextcloud/fix/18721/encode-uri-for-sidebar

Encode URI for file sidebar

Merge pull request #18707 from nextcloud/enh/pending_shares_overview

A pending shares overview

Add pending share list to frontend

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18710 from nextcloud/dependachristoph/composer/id3parser-0.1.1

Update ID3Parser to v1.1.0 for php7.4 compat

Merge pull request #18718 from nextcloud/fix/18711/others_with_access_only_with_reshare

Only show others with access if you have reshare permissions

Encode URI for file sidebar

Signed-off-by: Gary Kim <gary@garykim.dev>

Only show others with access if you have reshare permissions

Fixes #18711

If you do not have reshare permissions the others with access will throw
an error anyways. So better to just not show it ;)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Update ID3Parser to v1.1.0 for php7.4 compat

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #18576 from BernieO/bernieo-convertInteractive

enable option '--no-interaction' for db:convert-type

Merge pull request #18644 from nextcloud/harden/csrf_endpoint

Only allow requesting new CSRF tokens if it passes the SameSite Cooki…

remove non-circles-generated shares only

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #18701 from nextcloud/fix/18632/show_info_when_no_others_with_access_found

Show message if no other users with access are found

Merge pull request #18535 from nextcloud/enh/flow/newDispatcher

Use the new Events in Flow

A pending shares overview

Now that we accept shares we should show an overview of shares that are
pending. This first part is the small API to get a list of the currently
pending shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

[tx-robot] updated from transifex

Show message if no other users with access are found

Fixes #18632
Show a small subtitle if no other users with access are found.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18692 from nextcloud/wiswedel/wording/login

fix wording log in vs. login

Merge pull request #18696 from nextcloud/fix/18380/auto_accept_on_mail_open

Accept shares when you open mail

Accept shares when you open mail

Fixes #18380

When you open a direct share to yourself. We should autoaccept the
share.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

fix wording log in vs. login

"log in" is used as verb, while "login" is a noun.
In this case, what's supposed to be cancelled is the login process - therefore the noun must be used.

Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>

fix overlapping (#18473)

fix overlapping

Merge pull request #18672 from nextcloud/fix/17799/if_disabled_dont_show_link_shares

Don't show link shares in sidebar if disabled

Don't show link shares in sidebar if disabled

Fixes #17799

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18675 from nextcloud/fix/17774/no_email_suggestions_when_linkshare_disabled

Do not show e-mail suggestions if link shares are disabled

Do not show e-mail suggestions if link shares are disabled

For #17774

This removes the e-mail suggestions from the share input if link shares
are disabled. As e-mail shares use just link shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18687 from nextcloud/td/phpunit8/loggerTest

Fix the LoggerTests for phpunit

[#18645] Have custom login images cover the whole page (#18660)

[#18645] Have custom login images cover the whole page

Fix the LoggerTests for phpunit

Less deprecation warnings. YAY.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18674 from nextcloud/enh/no_global_GET

Do not use $_GET

[tx-robot] updated from transifex

Do not use $_GET

The appframework is more than capable of handling this properly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18669 from nextcloud/dependabot/npm_and_yarn/css-loader-3.4.1

Bump css-loader from 3.4.0 to 3.4.1

Bump css-loader from 3.4.0 to 3.4.1

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.4.0 to 3.4.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.4.0...v3.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18641 from HarHarLinks/patch-1

Fix typo in occ

Merge pull request #18668 from nextcloud/dependabot/npm_and_yarn/p-limit-2.2.2

Bump p-limit from 2.2.1 to 2.2.2

Merge pull request #18667 from nextcloud/dependabot/npm_and_yarn/eslint-config-nextcloud-0.1.1

Bump eslint-config-nextcloud from 0.1.0 to 0.1.1

Merge pull request #18665 from nextcloud/dependabot/npm_and_yarn/toastify-js-1.6.2

Bump toastify-js from 1.6.1 to 1.6.2

Bump toastify-js from 1.6.1 to 1.6.2

Bumps [toastify-js](https://github.com/apvarun/toastify-js) from 1.6.1 to 1.6.2.
- [Release notes](https://github.com/apvarun/toastify-js/releases)
- [Changelog](https://github.com/apvarun/toastify-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/apvarun/toastify-js/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

[tx-robot] updated from transifex

Bump p-limit from 2.2.1 to 2.2.2

Bumps [p-limit](https://github.com/sindresorhus/p-limit) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/sindresorhus/p-limit/releases)
- [Commits](https://github.com/sindresorhus/p-limit/compare/v2.2.1...v2.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump eslint-config-nextcloud from 0.1.0 to 0.1.1

Bumps [eslint-config-nextcloud](https://github.com/nextcloud/eslint-config-nextcloud) from 0.1.0 to 0.1.1.
- [Release notes](https://github.com/nextcloud/eslint-config-nextcloud/releases)
- [Commits](https://github.com/nextcloud/eslint-config-nextcloud/compare/v0.1.0...v0.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

[#18645] Have custom login images cover the whole page

Signed-off-by: Marius David Wieschollek <git.public@mdns.eu>

[tx-robot] updated from transifex

Fix CI

Signed-off-by: Kim Brose <kim.brose@rwth-aachen.de>

Only allow requesting new CSRF tokens if it passes the SameSite Cookie test

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18642 from nextcloud/design/settings-section

Settings: More spacing for development notice

Settings: More spacing for development notice

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>

Fix typo in occ

Signed-off-by: Kim Brose <kim.brose@rwth-aachen.de>

[tx-robot] updated from transifex

Merge pull request #18578 from nextcloud/version/18/rc1

18 RC 1

Bump ca-bundle

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

18 RC 1

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Use the new Events in Flow

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18583 from nextcloud/enh/18579/chrome-regex-brave-vivaldi-opera

Modify regex to match some other chromium browsers

Merge pull request #18612 from nextcloud/bugfix/flow-style

Workflow validity checks

confirm resharing rights if viewer is current owner (#18630)

confirm resharing rights if viewer is current owner

confirm resharing rights if viewer is current owner

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Merge pull request #18598 from nextcloud/dependabot/npm_and_yarn/nextcloud/logger-1.0.0

Bump @nextcloud/logger from 0.1.0 to 1.0.0

Bump bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Only ask for password when updating admin rules

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Load polyfill in workflow engine

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Refactor validity propagation

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Remove style loading of non-existing file

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix style of the sharing setting checkbox (#18628)

Fix style of the sharing setting checkbox

Bump @nextcloud/logger from 0.1.0 to 1.0.0

Bumps [@nextcloud/logger](https://github.com/nextcloud/nextcloud-logger) from 0.1.0 to 1.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-logger/releases)
- [Commits](https://github.com/nextcloud/nextcloud-logger/compare/v0.1.0...v1.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Move scroll container to inner element (#18615)

Move scroll container to inner element

Merge pull request #18596 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-1.0.0

Bump @nextcloud/dialogs from 0.1.1 to 1.0.0

Fix style of the sharing setting checkbox

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Bump @nextcloud/dialogs from 0.1.1 to 1.0.0

Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 0.1.1 to 1.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v0.1.1...v1.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #18594 from nextcloud/dependabot/npm_and_yarn/nextcloud/l10n-1.0.0

Bump @nextcloud/l10n from 0.2.1 to 1.0.0

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Move scroll container to inner element

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Merge pull request #18597 from nextcloud/dependabot/npm_and_yarn/style-loader-1.1.2

Bump style-loader from 1.1.1 to 1.1.2

Merge pull request #18599 from nextcloud/dependabot/npm_and_yarn/babel/core-7.7.7

Bump @babel/core from 7.7.5 to 7.7.7

Merge pull request #18595 from nextcloud/dependabot/npm_and_yarn/css-loader-3.4.0

Bump css-loader from 3.3.2 to 3.4.0

Bump css-loader from 3.3.2 to 3.4.0

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.3.2 to 3.4.0.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.3.2...v3.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Bump @babel/core from 7.7.5 to 7.7.7

Bumps [@babel/core](https://github.com/babel/babel) from 7.7.5 to 7.7.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.7.5...v7.7.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #18593 from nextcloud/dependabot/npm_and_yarn/babel/preset-env-7.7.7

Bump @babel/preset-env from 7.7.6 to 7.7.7

Bump @babel/preset-env from 7.7.6 to 7.7.7

Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.7.6 to 7.7.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.7.6...v7.7.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #18592 from nextcloud/dependabot/npm_and_yarn/webpack-4.41.5

Bump webpack from 4.41.2 to 4.41.5

Bump webpack from 4.41.2 to 4.41.5

Bumps [webpack](https://github.com/webpack/webpack) from 4.41.2 to 4.41.5.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.41.2...v4.41.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Split the menu entry for external shares in two

The external shares entry showed a "button" that, when pressed, replaced
the button with the input to set the remote share address. The "button"
was actually a label for the input, so when the label was focused it
transferred the focus to the input and thus pressing enter or space did
not show the input. Moreover, inputs inside links are not valid HTML,
and once shown there was no way to hide the input again.

Due to all this, and for consistency with the direct link input, the
external share input was moved to a different menu item that is shown
and hidden when the button, which nows is also a real button, is
clicked.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Format HTML elements

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Change menu toggle element from span to button

This makes possible to navigate to the menu toggle using the keyboard,
as well as being semantically more correct.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

[tx-robot] updated from transifex

Introduce new variable with the default answer to allow option --no-interaction for command occ db:convert-type
Variable is set to true for --no-interaction and false otherwise

Signed-off-by: Bernhard Ostertag <bernieo.code@gmx.de>

[tx-robot] updated from transifex

Bump style-loader from 1.1.1 to 1.1.2

Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/webpack-contrib/style-loader/releases)
- [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/style-loader/compare/v1.1.1...v1.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @nextcloud/l10n from 0.2.1 to 1.0.0

Bumps [@nextcloud/l10n](https://github.com/nextcloud/nextcloud-l10n) from 0.2.1 to 1.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-l10n/releases)
- [Commits](https://github.com/nextcloud/nextcloud-l10n/compare/v0.2.1...v1.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Clarify "Delete share" action in sharing sidebar (#18563)

Clarify "Delete share" action in sharing sidebar

Script to generate locales.json from icu data. (#18558)

Script to generate locales.json from icu data.