Allow local remotes in integration tests

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix unit tests

Signed-off-by: Joas Schilling <coding@schilljs.com>

Also disallow ; in remote urls

Signed-off-by: Joas Schilling <coding@schilljs.com>

Check all remotes for local access

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #20472 from nextcloud/fix/19848/make-sure-destination-is-not-a-directory

Verify that destination is not a directory.

Merge pull request #20470 from nextcloud/fix/noid/karma-coverage

Fix jsunit tests

Verify that destination is not a directory.

Otherwise file_put_contents will fail later.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Fix jsunit tests

JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Merge pull request #20469 from nextcloud/fix/sidebar/sharing/password-error-message

Properly display share error messages

Properly display share error messages

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

[tx-robot] updated from transifex

Merge pull request #20444 from nextcloud/dependabot/npm_and_yarn/url-loader-4.1.0

Bump url-loader from 4.0.0 to 4.1.0

Merge pull request #19852 from nextcloud/dav/provide-dav-setting-for-default-calendar

Provide dav setting for user's default calendar

Merge pull request #20460 from nextcloud/fix-app-not-listed-in-provisioning-integration-test

Fix app not listed in provisioning integration test

Bump url-loader from 4.0.0 to 4.1.0

Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/webpack-contrib/url-loader/releases)
- [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/url-loader/compare/v4.0.0...v4.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #20218 from nextcloud/dependabot/npm_and_yarn/marked-0.8.2

Bump marked from 0.8.1 to 0.8.2

Bump marked from 0.8.1 to 0.8.2

Bumps [marked](https://github.com/markedjs/marked) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Commits](https://github.com/markedjs/marked/compare/v0.8.1...v0.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #20445 from nextcloud/dependabot/npm_and_yarn/nextcloud/paths-1.1.2

Bump @nextcloud/paths from 1.1.1 to 1.1.2

Fix app not listed in provisioning integration test

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Only delete the default calendar setting when the default calendar
itself is deleted

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Provide dav setting for user's default calendar

And add tests to handle schedule-default-calendar-URL

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Bump @nextcloud/paths from 1.1.1 to 1.1.2

Bumps @nextcloud/paths from 1.1.1 to 1.1.2.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #20446 from nextcloud/dependabot/npm_and_yarn/css-loader-3.5.2

Bump css-loader from 3.4.1 to 3.5.2

Merge pull request #20427 from nextcloud/bug/noid/fix-password-reset-activity

Fix password reset saying Admin changed my password when reset from login page

Bump css-loader from 3.4.1 to 3.5.2

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.4.1 to 3.5.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.4.1...v3.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #20442 from nextcloud/dependabot/npm_and_yarn/build/jsdoc-3.6.4

Bump jsdoc from 3.6.3 to 3.6.4 in /build

[tx-robot] updated from transifex

Merge pull request #20418 from nextcloud/dependabot/npm_and_yarn/sinon-9.0.2

Bump sinon from 9.0.1 to 9.0.2

Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods

Show setup check for recommended php modules

Merge pull request #20439 from nextcloud/Valdnet-patch-3

Changing the translation catalog for "Share"

[tx-robot] updated from transifex

Changing the translation catalog for "Share"

Change "files" to "files_sharing".

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Bump jsdoc from 3.6.3 to 3.6.4 in /build

Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.3 to 3.6.4.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.4/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.3...3.6.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Merge pull request #20035 from nextcloud/bugfix/group-encode

Make sure group management works with all types of group names

Add tests for encoded group id

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Make sure the group id parameter gets properly encoded when used in URLs

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Make the groupId url encoded

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #20185 from azul/open-new_tab

Modify do_action so default ctrl-click opens tab

Merge pull request #20426 from nextcloud/techdebt/psr2

It is done

Merge pull request #20419 from nextcloud/dependabot/npm_and_yarn/various

Bump p-limit from 2.2.2 to 2.3.0, @nextcloud/auth from 1.2.2 to 1.2.3, @babel/preset-env from 7.8.7 to 7.9.5, @nextcloud/event-bus from 1.1.3 to 1.1.4, @nextcloud/password-confirmation from 1.0.0 to 1.0.1, @nextcloud/l10n from 1.2.2 to 1.2.3, @nextcloud/initial-state from 1.1.1 to 1.1.2, core-js from 3.6.4 to 3.6.5 …

[tx-robot] updated from transifex

Fix password reset saying Admin changed my password when reset from
login page

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Bump acceptance tests

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Bump coding standard lib for PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Format code according to PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add visibility to all constants

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add visibility to all methods and position of static keyword

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add visibility to all properties and move static keyword

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods

Format control structures, classes, methods and function

Merge pull request #19495 from nextcloud/preview-generate-batch

optimize batch generation of previews

Bump core-js from 1.4.1 to 1.5.0

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Format control structures, classes, methods and function

To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20403 from nextcloud/techdebt/utf8-encoding

Use utf8 encoding everywhere

fix preview generation tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #20402 from nextcloud/techdebt/elseif

Use elseif instead of else if

Show setup check for recommended php modules

Fixes #20393

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Bump core-js from 3.6.4 to 3.6.5

Bumps [core-js](https://github.com/zloirock/core-js) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/v3.6.5/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.6.4...v3.6.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @nextcloud/initial-state from 1.1.1 to 1.1.2

Bumps [@nextcloud/initial-state](https://github.com/nextcloud/nextcloud-initial-state) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/nextcloud/nextcloud-initial-state/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-initial-state/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-initial-state/compare/v1.1.1...v1.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @nextcloud/l10n from 1.2.2 to 1.2.3

Bumps [@nextcloud/l10n](https://github.com/nextcloud/nextcloud-l10n) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/nextcloud/nextcloud-l10n/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-l10n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-l10n/compare/v1.2.2...v1.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump sinon from 9.0.1 to 9.0.2

Bumps [sinon](https://github.com/sinonjs/sinon) from 9.0.1 to 9.0.2.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @nextcloud/password-confirmation from 1.0.0 to 1.0.1

Bumps [@nextcloud/password-confirmation](https://github.com/nextcloud/nextcloud-password-confirmation) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/nextcloud/nextcloud-password-confirmation/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-password-confirmation/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-password-confirmation/compare/v1.0.0...v1.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @nextcloud/event-bus from 1.1.3 to 1.1.4

Bumps [@nextcloud/event-bus](https://github.com/nextcloud/nextcloud-event-bus) from 1.1.3 to 1.1.4.
- [Release notes](https://github.com/nextcloud/nextcloud-event-bus/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-event-bus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-event-bus/compare/v1.1.3...v1.1.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @babel/preset-env from 7.8.7 to 7.9.5

Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.8.7 to 7.9.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.8.7...v7.9.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump @nextcloud/auth from 1.2.2 to 1.2.3

Bumps [@nextcloud/auth](https://github.com/nextcloud/nextcloud-auth) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/nextcloud/nextcloud-auth/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-auth/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-auth/compare/v1.2.2...v1.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bump p-limit from 2.2.2 to 2.3.0

Bumps [p-limit](https://github.com/sindresorhus/p-limit) from 2.2.2 to 2.3.0.
- [Release notes](https://github.com/sindresorhus/p-limit/releases)
- [Commits](https://github.com/sindresorhus/p-limit/compare/v2.2.2...v2.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Use utf8 encoding everywhere

PSR2 likes that and so do I

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Use elseif instead of else if

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20256 from nextcloud/dependabot/composer/nikic/php-parser-4.3.0

Bump nikic/php-parser from 4.2.1 to 4.3.0

Merge pull request #20281 from nextcloud/bugfix/noid/use-primary-element-color

Use the primary element color in case it primary color is too bright

Use the primary element color in case it primary color is too bright

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Merge pull request #20313 from nextcloud/dependabot/npm_and_yarn/underscore-1.10.2

Bump underscore from 1.9.2 to 1.10.2

Merge pull request #20385 from nextcloud/skeeable-http-harden

harden seekable http stream a bit against failures

Merge pull request #20390 from nextcloud/refactor/no-closing-tag

Do not use closing tags

[tx-robot] updated from transifex

Merge pull request #20391 from nextcloud/refactor/spaces-cleanup

Remove all extra whitespace PSR2 does not like

Allow opening files for editing in new tabs

In a file list files with a default action
have an href that will trigger the action.
This way ctrl-click and middle button click open the default action in a new tab.

In order to achieve this a new param `openfile` was introduced to the files app.
It will make the files app trigger the default action for the file in question.
This also allows linking to file content rather than just the details display.

Introduce fileList.getDefaultActionUrl()
to create a link with that param set.
It's overwritten in the trashbin fileList
so that anchors continue to have `#` as a href.

Fix the link generation for subfolders of public shares:
58a87d0 was the last commit that touched the linkTo function in public.js.
It included the params as arguments to the generateUrl function.
Turns out this completely ignores the dir parameter now.
The inclusion was reverted in other places
so revert it here as well.
Also change `dir` to `path` in the param as that is respected
when following the link.

Add Test for the new link url for files with default action.
Remove test for multiple selects with ctrl-click
as that is not what we are doing anymore.

Signed-off-by: Azul <azul@riseup.net>

Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords

Use php keywords in lowercase

Remove space between switch case and colon

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Make sure there is exactly one newline after imports

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Make sure every file ends with an empty newline

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Remove trailing whitespaces from comments

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Remove trailing and in between spaces

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Remove spaces after method or function call

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Do not use closing tags

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20383 from nextcloud/techdebt/function-spacing

Unify function spacing to PSR2 recommendation

Merge pull request #20376 from nextcloud/fix/tags-ellipsis

Fix systemtags overflow

harden seekable http stream a bit against failures

Signed-off-by: Robin Appelman <robin@icewind.nl>

Use php keywords in lowercase

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Unify function spacing to PSR2 recommendation

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20355 from nextcloud/fix/comments/clear-input/19585

Clear comment on successful post

Merge pull request #20379 from nextcloud/techdebt/blank-lines

Use one blank line after the opening tag and namespace declaration

optimize batch generation of previews

by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file

the main use case for this is the preview generator app (pr for that comming next)

in my local testing this saves about 25% of time when using the preview generator app

Signed-off-by: Robin Appelman <robin@icewind.nl>

allow generating multiple preview sizes for a single file at once

this saves having to do some of the overhead multiple times

Signed-off-by: Robin Appelman <robin@icewind.nl>

Use a blank line after the opening tag

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Use exactly one empty line after the namespace declaration

For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20375 from nextcloud/techdebt/fix-array-indent-style

Fix (array) indent style to always use one tab

Merge pull request #20303 from nextcloud/version/19/beta2

19 beta 2

Fix systemtags overflow

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

Fix (array) indent style to always use one tab

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #20368 from nextcloud/refactor/psr1

Migrate to PSR1 coding style