Fix option in the client code itself as well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Allow installing/updating of apps again

The Guzzle API changed. We shall now use sink

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

[tx-robot] updated from transifex

Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8

Don't try a transaction for the migrator on MySQL

Merge pull request #25039 from nextcloud/fix/libxml-use-internal-errors-deprecated

Only use libxml_disable_entity_loader on php older than 8

Only rollback when not MySQL

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #25048 from nextcloud/dependabot/npm_and_yarn/webdav-3.6.2

Merge pull request #25034 from nextcloud/bugfix/noid/load-authentication-for-app-upgrades

Make sure to do priority app upgrades first

Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db

Add setup check to verify that the used DB version is still supported…

Merge pull request #25073 from nextcloud/psalm/24521/remove-unneeded-casts

Remove unneeded casts that were found by Psalm

Bump webdav from 3.6.1 to 3.6.2

Bumps [webdav](https://github.com/perry-mitchell/webdav-client) from 3.6.1 to 3.6.2.
- [Release notes](https://github.com/perry-mitchell/webdav-client/releases)
- [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perry-mitchell/webdav-client/compare/v3.6.1...v3.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #25070 from nextcloud/feature/noid/card-ros-definitions

Deck Rich-Object-String definitions for deck boards and cards

Merge pull request #24910 from nextcloud/dependachristoph/composer/scss-1.4.0

Bump scssphp/scssphp from 1.0.3 to 1.4.0

Merge pull request #25069 from nextcloud/bugfix/noid/regression-dont-touch-assignable-column

Don't remove assignable column for now

Remove unneeded casts that were found by Psalm

In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Unquote string when removing the hash from a color

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Make SCSS compliant

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Bump scssphp/scssphp from 1.0.3 to 1.4.0

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Deck Rich-Object-String definitions for deck boards and cards

Signed-off-by: Joas Schilling <coding@schilljs.com>

Don't remove assignable column for now

It causes side effects.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Merge pull request #25049 from nextcloud/dependabot/npm_and_yarn/webpack-4.45.0

Bump webpack from 4.44.2 to 4.45.0

Bumps [webpack](https://github.com/webpack/webpack) from 4.44.2 to 4.45.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.44.2...v4.45.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #24661 from nextcloud/external-storage-cant-edit

dont offer to edit external config settings if we can't edit them

[tx-robot] updated from transifex

[tx-robot] updated from transifex

Merge pull request #25050 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

Merge pull request #25047 from nextcloud/dependabot/npm_and_yarn/sinon-9.2.3

[tx-robot] updated from transifex

Bump sinon from 9.2.2 to 9.2.3

Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.2 to 9.2.3.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v9.2.2...v9.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Only use libxml_disable_entity_loader on php older than 8

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Don't try a transaction for the migrator on MySQL

As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450
So now commit() fails because the internal PDO connection implicitly
commited already.

Signed-off-by: Joas Schilling <coding@schilljs.com>

adjust tests

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #24951 from nextcloud/version/21/beta5

21 beta5

dont offer to edit external config settings if we can't edit them

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #24948 from nextcloud/dependabot/composer/doctrine/dbal-3.0.0

Bump doctrine/dbal from 2.12.0 to 3.0.0

Merge pull request #22992 from nextcloud/password-urlencode

allow authenticating using urlencoded passwords

Update baseline.xml

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Add setup check to verify that the used DB version is still supported in the next major release

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Use specific docker image tags to allow drone to cache them and not run into docker pull rate limits

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Merge pull request #25017 from nextcloud/fix-clearing-the-label-of-a-share

Fix clearing the label of a share

Make sure to do priority app upgrades first

Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Rollback failed transactions in TestCase.php to not break followup tests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Remove "primary" option from schema builder argument $options as it is not used anymore and triggers an exception

See https://github.com/doctrine/dbal/commit/138eb85234a1faeaa2e6a32cd7bcc66bb51c64e8#diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Bump doctrine/dbal from 2.12.0 to 3.0.0

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #25031 from nextcloud/revert-25020-fix/noid/limitied-allowed-items-db-in

Revert "(LDAP) respect DB limits of arguments in an IN statement"

Revert "(LDAP) respect DB limits of arguments in an IN statement"

Fix clearing the label of a share

When the label is being edited its value is stored in "newLabel", and
the original label is shown only if "newLabel" is not set. However, as
it was checked against any falsy value instead of only undefined when
the label was cleared and thus it has an empty value the original label
was shown instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Merge pull request #25029 from nextcloud/rakekniven-patch-1

Change defaultapp in config.sample.php to dashboard to improve docs and align it to source code

Change defaultapp to dashboard

Result of discussion at https://help.nextcloud.com/t/enable-dashboard-on-per-user-basis/94872

Code reference:
https://github.com/nextcloud/server/blob/db86bea18ce41ad73e9c1a06f2b2d89d8d4f2ef8/lib/private/legacy/OC_Util.php#L1106

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>

Merge pull request #25015 from nextcloud/fix/no-double-intl-polyfill

Replace patchwork/utf8 with symfony-polyfill-*

Merge pull request #25020 from nextcloud/fix/noid/limitied-allowed-items-db-in

(LDAP) respect DB limits of arguments in an IN statement

Merge pull request #25021 from nextcloud/enhancement/occ-install-exception-trace

Print an exception trace for setup exceptions

Merge pull request #25025 from nextcloud-pr-bot/automated/noid/psalm-baseline-update

[Automated] Update psalm-baseline.xml

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Merge pull request #24892 from nextcloud/fix/use-symfony-dispatcher-correctly

Use the Symfony dispatcher correctly

Merge pull request #23261 from nextcloud/enh/external-storage-session-type

Expose session based authentication through mount point type

Replace patchwork/utf8 with symfony-polyfill-*

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #24989 from nextcloud/scanner-ignore-non-readable

ignore files that have no read permissions during scanning

Add more previous exceptions to database setup code

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

respect DB limits of arguments in a IN list

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #24934 from nextcloud/max_file_uploads

Remove useless ini_set calls

Print an exception trace for setup exceptions

Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #24969 from nextcloud/dependabot/npm_and_yarn/core-js-3.8.2

Bump core-js from 3.8.1 to 3.8.2

Merge pull request #25018 from nextcloud/fix-name-of-avatar-integration-tests-in-drone

Fix name of avatar integration tests in Drone

Merge pull request #24999 from nextcloud/bugfix/noid/email-footer-language

Set the user language when adding the footer

Fix name of avatar integration tests in Drone

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Set the user language when adding the footer

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Remove useless ini_set functions

Merge pull request #25011 from nextcloud/fix/23197/catch_throwable

Catch throwable instead of exception

Bump core-js from 3.8.1 to 3.8.2

Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.8.1...v3.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

Catch throwable instead of exception

The error that gets thrown can also be a type error etc. So we should
properly catch the Throwable.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #25010 from nextcloud/revert-24955-external-storage-login-ldap

Revert "allow using any ldap property as login name when using login credentials"

Revert "allow using any ldap property as login name when using login credentials"

Merge pull request #24955 from nextcloud/external-storage-login-ldap

allow using any ldap property as login name when using login credentials

Merge pull request #25003 from nextcloud/psalm/noid/phpdoc-fix-return-type

Fix return types for Archive::getStream

Merge pull request #25001 from nextcloud/bugfix/23044/fix-column-name-check

Fix column name to check prior to deleting

Merge pull request #25000 from nextcloud/bugfix/noid/hide-client-welcome-mail

Hide client link in welcome mail if an empty customclient_desktop config is set

Merge pull request #25004 from nextcloud/fix/noid/php8-optional-parameter-before-mandatory

Fix warning in PHP 8 about optional parameter before mandatory one

Fix warning in PHP 8 about optional parameter before mandatory one

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Fix return types for Archive::getStream

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Fix column name to check prior to deleting

Signed-off-by: Joas Schilling <coding@schilljs.com>

Hide client link in welcome mail if an empty customclient_desktop config is set

Signed-off-by: Julius Härtl <jus@bitgrid.net>

allow authenticating using urlencoded passwords

this allows authenticating with passwords that contain non ascii-characters in contexts that otherwise do not allow it (http basic)

Signed-off-by: Robin Appelman <robin@icewind.nl>

Merge pull request #24967 from nextcloud/dependabot/npm_and_yarn/nextcloud/axios-1.6.0

Merge pull request #24994 from nextcloud/ci/postgres_update

Update postgres version tests

Merge pull request #24911 from nextcloud/fix/tasks-calendar/undefined-index-search

Tasks search: make sure we have existing indexes before using them

Bump @nextcloud/axios from 1.5.0 to 1.6.0

Bumps [@nextcloud/axios](https://github.com/nextcloud/nextcloud-axios) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/nextcloud/nextcloud-axios/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-axios/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-axios/compare/v1.5.0...v1.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Update postgres version tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #24993 from nextcloud/ci/db_drop_mysql_5

No need to run mysql5 tests anymore

Merge pull request #24988 from nextcloud/enh/make_sure_cache_is_set

Set the JSCombiner cache if needed

[tx-robot] updated from transifex

No need to run mysql5 tests anymore

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #24986 from nextcloud/crl/update-revoked-transmission.crt

Update root.crl due to revocation of transmission.crt

ignore files that have no read permissions during scanning

Signed-off-by: Robin Appelman <robin@icewind.nl>

Set the JSCombiner cache if needed

Found while debugging a customer setup. They had to flush their Redis.
Hence the info was no longer there. Since they also used S3 this meant
requesting the files over and over on template render. Which on S3 is
not cheap.

Now we just write it back if we can't get it from the cache in the first
place. So that the next run has it cached properly again.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Merge pull request #24317 from SMillerDev/app_password_command

App password command

Update root.crl due to revocation of transmission.crt

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

Revert "Update root.crl due to revocation of transmission.crt"

This reverts commit 48197dced321f7f6ca276511652fa6d99bf75453.