Fix many issues with the tests

- Return type were not correct
- willReturn and with confusion

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Cleanup CardDav SyncService

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Summer cleanup of the federation app

- Use IEventDispatcher instead of deprecated symfony dispatcher
- Use LoggerInterface where possible
- Use php 7.4 properties
- Add type hinting where possible
- Move federation hooks to a seperate listener

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #32971 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

Merge pull request #32884 from nextcloud/typing/dav-sharing

Add typing to Sharing Backend

Add typing to Sharing Backend

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #32964 from nextcloud/feat/add-title-folderview

Add title to file name

Merge pull request #32242 from nextcloud/fix-logging-data-array

Fix logging data context to file

Merge pull request #32941 from nextcloud/dependabot/composer/guzzlehttp/guzzle-7.4.4

Bump guzzlehttp/guzzle from 7.4.0 to 7.4.4

Merge pull request #31475 from nextcloud/kofemann-patch-1

files: close open directory file descriptor on error path

Add title to file name

Fix #32157

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Bump guzzlehttp/guzzle from 7.4.0 to 7.4.4

See https://github.com/nextcloud/3rdparty/pull/1072

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #32823 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

Merge pull request #32924 from nextcloud/memcached-binary-protocol

Enable binary protocol again

Merge pull request #32954 from nextcloud/fix/replace-opis-closure-by-laravel-fork-cleanup

Sync back with 3rdparty master

Merge pull request #32902 from nextcloud/enh/noid/opcache-buffer-size-limit

do not display the buffer_size info if the size is already set to a c…

Merge pull request #32948 from nextcloud/dashboardFix

make 'text-overflow: ellipsis' possible again in dashboard

Sync back with 3rdparty master

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #32868 from nextcloud/fix/replace-opis-closure-by-laravel-fork

Replace opis/closure by laravel/serializable-closure

Merge pull request #32861 from nextcloud/fix/remove-at-matcher-in-user_ldap-tests

Remove deprecated at() matcher from user_ldap tests

Merge pull request #32900 from nextcloud/fix/remove-at-matcher-in-theming-tests

Remove at matcher in theming tests

Merge pull request #32901 from nextcloud/fix/remove-at-matcher-in-lib-tests

Remove at matcher uses in tests/lib

Explicitely only accept closures from our dependencies in ClosureJob

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

make 'text-overflow: ellipsis' possible again in dashboard

Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Update 3rdparty branch with opis/closure back

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Update 3rdparty branch with opis/closure back

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Update psalm baseline

Signed-off-by: GitHub <noreply@github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Add a test about unserializing data from opis/closure serialization

We need to be able to unserialize data from before upgrade.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #32881 from nextcloud/Valdnet-patch-2

l10n: Spelling unification

Merge pull request #32719 from nextcloud/fix/noid/email-shares-not-shown

Fix email shares not being shown to other users

Merge pull request #32910 from nextcloud/fix/profiler-invalid-utf8

Fix profiler trying to serialize invalid utf8

Fix profiler trying to serialize invalid utf8

The cookie value contains invalid utf8 characters most of the time so
let's just ignore it as it is also not that interesting to analyse.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Remove some more at matchers in tests/lib

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove deprecated expectException from theming tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

do not display the buffer_size info if the size is already set to a certain threshold

Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>

memcached should not throw arbitrary exceptions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Fix email shares not being shown to other users

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Enable binary protocol again

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #32874 from bill-mcgonigle/patch-1

Mention missing files subdir

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #32898 from nextcloud/fix/noid/logger-overwrites-vars

Fix logger overwriting vars in some circumstances

make placeholder a const for reuse

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

fix overwriting original vars when logging

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

add serializer test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Remove at matcher uses in tests/lib

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Remove deprecated at matcher from theming tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #32876 from nextcloud/fix/fix-string-interpolation

Use {$var} instead of ${var} for PHP 8.2 compatibility

Merge pull request #32878 from nextcloud/fix-default-toast-message-for-failed-uploads-with-http2

Fix default toast message for failed uploads with HTTP/2

Merge pull request #32584 from nextcloud/fix-ResetTokenBackgroundJob

Make sure ResetTokenBackgroundJob doesn't execute if config is read-only

Spelling unification

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>

l10n: Spelling unification

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>

l10n: Spelling unification

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>

Update tests after ResetTokenBackgroundJob changes

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Use OCP version of TimedJob instead of OC for ResetTokenBackgroundJob

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Make sure ResetTokenBackgroundJob doesn't execute if config is read-only

No need to try to delete the config key in config.php if we aren't
allowed to.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix default toast message for failed uploads with HTTP/2

When an upload fails a toast is shown with either a specific message or
just the textual part of the HTTP error code (which comes from the
upload failure handler and set by "jQuery.ajax()". However, if there
is neither a message nor an error then the toast will show the default
message from the Toastify-js library, which is an undescriptive "Hi
there!".

When HTTP/2 is used Chromium does not provide the textual part of the
HTTP error code, so when an upload fails the toast can receive an empty
message and thus just show "Hi there!". Now an explicit message is
provided as a fallback to prevent that.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Merge pull request #32351 from nextcloud/dav-handle-move-operation-properly

Handle the move operation properly between shared calendars

Remove bogus expects from user_ldap tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #32875 from nextcloud/fix/setup-set-up-2fa

Fix 2FA setup vs set up typo

Use {$var} instead of ${var} for PHP 8.2 compatibility

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Handle the move operation properly between shared calendars

- Introduce a new CalendarObjectMovedEvent typed event dedicated for
  this operation
- Handle the event in the activity backend and add new appropriate activity subjects

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Fix 2FA setup vs set up typo

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Mention missing files subdir

Many users are getting confused by the inaccurate error message "Home storage for user $user not writable" because the storage *is* writable.  The actual issue is a missing files/ subdirectory.  cf. https://help.nextcloud.com/t/home-storage-for-user-not-writable/10831/7
By mentioning the possible cause in the error message, users are going to be able to rapidly solve their problem rather than bang their heads against the screen, Google, and eventually forums to find out that the error message is wrong in their case.
Yes, it would be better to detect and precisely describe the fault, or fix the problem automatically, but until then, be kind to the users for the next however many years.

Merge pull request #32813 from nextcloud/debt/noid/check-for-3rdparty-updates

Run php tests when 3rdparty changed

Replace opis/closure with laravel/serializable-closure in code

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Replace opis/closure by laravel/serializable-closure

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Remove deprecated at() matcher from user_ldap tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #32853 from nextcloud/fix/update-acceptance-composer-lock

Update dependencies in acceptance tests composer.lock

Merge pull request #31966 from nextcloud/unencrypted-size

store unencrypted size in the unencrypted_size column

Merge pull request #32847 from nextcloud/followup/32748/fix-second-integration-test

Fix second integration test as well

Merge pull request #31637 from nextcloud/add-password-reset-typed-events

Add password reset typed events and modernize LostController

Merge pull request #32843 from nextcloud/bugfix/noid/correctly-log-failed-attempts

Correctly log failed attempts

Update dependencies in acceptance tests composer.lock

It should allow to run them on PHP>=8.0 with a recent phpunit.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #32774 from nextcloud/enh/a11y/keyboard-legacy-contacts-menu

Enable keyboard activation of legacy contacts menu

Merge pull request #31197 from nextcloud/acsfer-patch-1

Add memcached unix socket instructions

Fix second integration test as well

Signed-off-by: Joas Schilling <coding@schilljs.com>

Correctly log failed attempts

Signed-off-by: Joas Schilling <coding@schilljs.com>

Merge pull request #31345 from nextcloud/fix/31164/delete-additional-email

Fix deletion of additional emails

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Use unique key to prevent email component reuse

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Merge pull request #30368 from nextcloud/dav-allow-object-properties

Allow DAV Object properties

Merge pull request #31029 from nextcloud/expose-extra-emails-in-dav

Expose additional emails in {DAV:}alternate-URI-set

Make LostController use IInitialState and LoggerInterface

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Modernize the LostControllerTest test

Remove some depreciated at() calls

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Add password reset typed events

These hooks are only used in the Encryption app from what I can see.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Merge pull request #31622 from nextcloud/increase-loglevel-modernize-refresh-webcal

Increase loglevel of Webcal parsing errors and modernize code

Merge pull request #31771 from nextcloud/fix/hook-encryption-cron

Fix hook encryption with cron job

Merge pull request #32059 from cld4h/patch-1

Fix issue #31692 of occ files:scan

Merge pull request #32361 from nextcloud/dav-scheduling-default-calendar

Put calendar invites into the user's first available calendar