Make sure to not pass null to DateTime::createFromFormat

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #35140 from nextcloud/revert-35113-backport/35015/stable24

Revert "[stable24] Appropriate length check in Notification.php"

Merge pull request #35134 from nextcloud/backport/35093/stable24

[stable24] Run integration tests on 3rdparty bump

Revert "[stable24] Appropriate length check in Notification.php"

Merge pull request #35131 from nextcloud/backport/35070/stable24

[stable24] [LDAP] always create instance of own user manager

Run integration tests on 3rdparty bump

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[LDAP] always create instance of own user manager

- it is config specific and cannot be shared
- because the Access instance is bound later, it is not obvious from the
  constructor

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Merge pull request #35113 from nextcloud/backport/35015/stable24

[stable24] Appropriate length check in Notification.php

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Appropriate length check in Notification.php

There is an issue(bug) when using UTF-8 symbols in any method, which checks the length of string as `isset($id[64])`. You can set only 32 UTF-8 symbols because they are 2 byte, and this "array" check seems inapropriate in this case, as it throws unexpected exceptions.

Signed-off-by: natoponen <57988162+natoponen@users.noreply.github.com>

Merge pull request #35088 from nextcloud/backport/35074/stable24

[stable24] Make sure that path is normalized and then checked,

Merge pull request #35101 from nextcloud/backport/35077/stable24

[stable24] Fix PublicKeyTokenProviderTest import and mock

Fix PublicKeyTokenProviderTest import and mock

* IDBConnection import missing
* Atomic doesn't need a mock

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35049 from nextcloud/backport/34834/stable24

[stable24] Fix size calculation on copying the skeleton files

Make sure that path is normalized and then checked,

 and not the other way around

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #35065 from nextcloud/backport/35063/stable24

[stable24] Fix top margin in empty versions list

Merge pull request #35039 from nextcloud/backport/32211/stable24

[stable24] Add repair command to fix wrong share ownership

Fix top margin in empty versions list

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Merge pull request #35059 from nextcloud/backport/35042/stable24

[stable24] Add description for calendar uri

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #35061 from nextcloud/backport/35052/stable24

Fix sidebar not automatically hidden in Files app

Although the Files app creates the legacy sidebar (details view) it is
then replaced with the newer Vue app sidebar. Due to this ".detailsView"
no longer finds an element and therefore nothing was hidden when
"hideAppSidebar($('.detailsView'))" was called (for example, when
changing to another section).

However, "OC.Apps.hideAppSidebar()" does not properly work either with
the Vue sidebar used in the Files app (once hidden the sidebar is not
shown again). For simplicity, and to avoid any possible side effect in
other apps from changing "OC.Apps.hideAppSidebar", now
"OC.Files.Sidebar.close()" is used instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

Add description for calendar uri

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Use proper storage method for writing skeleton files

otherwise the filecache will have a wrong size for skeleton files

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

update autoloader

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix repairing non user shares when repairing all shares

Signed-off-by: Robin Appelman <robin@icewind.nl>

remove no longer needed code

Signed-off-by: Robin Appelman <robin@icewind.nl>

split repairing into two stages to prevent long open transaction

Signed-off-by: Robin Appelman <robin@icewind.nl>

update shares directly in db

Signed-off-by: Robin Appelman <robin@icewind.nl>

More verbose output for repair share ownership cmd

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

move share owner repair to occ command

Signed-off-by: Robin Appelman <robin@icewind.nl>

Add repair step to fix wrong share ownership

Signed-off-by: Louis Chemineau <louis@chmn.me>

Merge pull request #35022 from nextcloud/backport/32838/stable24

[stable24] Cast to int

Merge pull request #35019 from nextcloud/backport/34909/stable24

[stable24] Fix duplicate event email notifications

Cast to int #32837

Signed-off-by: Markus Zeller <git@markuszeller.com>

Merge pull request #35012 from nextcloud/backport/35007/stable24

[stable24] Fix unsuccessful token login logged as error

Fix duplicate event email notifications

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix unsuccessful token login logged as error

The condition of a non-existent login token can happen for concurrent
requests. Admins can not do anything about this. So this is to be
expected to happen occasionally. This event is only bad if none of the
requests is able to re-acquire a session. Luckily this happens rarely.

If a login loop persists an admin can still lower the log level to find
this info. But a default error log level will no longer write those
infos about the failed cookie login of one request.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Merge pull request #35005 from nextcloud/backport/34937/stable24

[stable24] Avoid a crash when a PHP extension has no version

Suppress false-positives from psalm, waiting for fix upstream

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Avoid a crash when a PHP extension has no version

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #33888 from nextcloud/dependabot/composer/build/integration/stable24/guzzlehttp/guzzle-7.5.0

Update guzzlehttp/guzzle requirement from 7.4.5 to 7.5.0 in /build/integration

Merge pull request #34659 from nextcloud/backport/34632/stable24

[stable24] Add rate limiting on lost password emails

Merge pull request #34855 from nextcloud/backport/34799/stable24

[stable24] Emit typed event when preview is requested

Merge pull request #34942 from nextcloud/backport/34577/stable24

[stable24] Avoid double ldap_unbind in Wizard.php

Merge pull request #34947 from nextcloud/backport/34804/stable24

[stable24] Skip general login with email for non-valid addresses and LDAP

Merge pull request #34949 from nextcloud/backport/32663/stable24

[stable24] Cleanup tempfiles after each cron job run

Merge pull request #34952 from nextcloud/backport/34379/stable24

[stable24] Run session token renewals in a database transaction

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix LostController test

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add rate limiting on lost password emails

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Run session token renewals in a database transaction

The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token

If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Cleanup tempfiles after each cron job run

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Skip general login with email for non-valid addresses and LDAP

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Avoid double ldap_unbind in Wizard.php

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix code style with codesniffer

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Merge pull request #34914 from nextcloud/release/24.0.7

24.0.7

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

24.0.7

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Emit typed event when preview is requested

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Merge pull request #34770 from nextcloud/backport/34579/stable24

[stable24] fix null error in getUnencryptedSize

Merge pull request #34838 from nextcloud/release/24.0.7_rc1

24.0.7 RC1

Merge pull request #34845 from nextcloud/dependaskjnldsv/32413/stable24

[stable24] Fix psalm errors fron the end of the baseline file

Fix psalm errors fron the end of the baseline file

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #34440 from nextcloud/backport/32635/stable24

Merge pull request #34798 from nextcloud/backport/33405/stable24

Merge pull request #34797 from nextcloud/backport/33540/stable24

[stable24] fix updating cached mounts that didn't have their mount provider set previously

Merge pull request #34840 from nextcloud/backport/34502/stable24

[stable24]  Propagate attributes when resharing

Merge pull request #34410 from nextcloud/backport/33566/stable24

Merge pull request #34032 from nextcloud/backport/34019/stable24

[stable24] Fix quota type to int

Merge pull request #34040 from nextcloud/backport/34001/stable24

Merge pull request #34460 from nextcloud/backport/31947/stable24

[stable24] Fix Error: Undefined index: redirect_url

Fix inverted profile picture

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Update ContactsStoreTest.php

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Update lib/private/Contacts/ContactsMenu/ContactsStore.php

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Tested no issues.

Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Update ContactsStore.php

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Apply suggestions from code review

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Fix User profile picture when performing the search

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
Before

After

Fix for #31065

DB mounts table: Add index for mount_provider_class

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Merge pull request #34584 from nextcloud/backport/34438/stable24

[stable24] return proper error code when reporting exception fails in remote.php

Merge pull request #34447 from nextcloud/backport/34302/stable24

[stable24] Fix: Prevent deadlocks during mtime/size/etag propagation

More fixes

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Small progress with fixing unit tests

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Propagate attributes when resharing

When updating a share, load the node from the initiator instead of the
owner similar to how this is done when creating the share.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Merge pull request #34355 from nextcloud/backport/34348/stable24

[stable24] Fix renaming in shared with you file list

24.0.7 RC1

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>