]> source.dussan.org Git - vaadin-framework.git/commit
Moved selection of selected rows in TableConnector to occur after the new rows are...
authorJarno Rantala <jarno.rantala@vaadin.com>
Wed, 11 Dec 2013 09:10:43 +0000 (11:10 +0200)
committerVaadin Code Review <review@vaadin.com>
Tue, 7 Jan 2014 08:41:21 +0000 (08:41 +0000)
commit0b95f8d6f6e3f278b51c0242e8ce2dfc82ed829e
tree6ef5846321221f1e10710ab0b7a2dc7d9737cca3
parente9a547ac4e153f85597e056f5c51ade60fe29c45
Moved selection of selected rows in TableConnector to occur after the new rows are created (#13008)

The selection of selected rows happened before the new rows were created. This resulted in situation
where the visible items on server side were different than the rows in scrollbody during the selection
of selected rows. Therefore, the selected keys in uidl contained wrong information and some selected
rows was marked as unselected even though they shouldn't. This again resulted in the original bug that
all the rows was not selected because the 'selectionRangeStart' row was not selected anymore.

Change-Id: I9f985cb45c97bacb6b71e36fa4bf077a1ac1311d
client/src/com/vaadin/client/ui/table/TableConnector.java
uitest/src/com/vaadin/tests/components/table/SelectAllRows.java [new file with mode: 0644]
uitest/src/com/vaadin/tests/components/table/SelectAllRowsTest.java [new file with mode: 0644]