]> source.dussan.org Git - gitea.git/commit
Replies to outdated code comments should also be outdated (#13217)
authorzeripath <art27@cantab.net>
Wed, 4 Nov 2020 22:55:15 +0000 (22:55 +0000)
committerGitHub <noreply@github.com>
Wed, 4 Nov 2020 22:55:15 +0000 (17:55 -0500)
commit3cab3bee5750a12da9ef8a9ba5cbe3da00594921
treedadb2ad8b8b52475f3e5464df338161bde612d51
parentfb756e773831d215fdb807b736d6276012669b6c
Replies to outdated code comments should also be outdated (#13217)

* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <art27@cantab.net>
* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
models/issue_comment.go
models/migrations/migrations.go
models/migrations/v158.go [new file with mode: 0644]
services/pull/review.go