]> source.dussan.org Git - gitea.git/commit
Use same action status svg icons on actions list as on action page (#24178)
authorHester Gong <hestergong@gmail.com>
Wed, 19 Apr 2023 05:42:53 +0000 (13:42 +0800)
committerGitHub <noreply@github.com>
Wed, 19 Apr 2023 05:42:53 +0000 (13:42 +0800)
commit5e7543fcf441afb30aba6188edac754ef32b9ac3
treecf86d64e7c2adcada59c24d2465df766d8bf9f98
parent5fcf328a8d825102a77cfc79b53ce7948d41bf33
Use same action status svg icons on actions list as on action page (#24178)

Close #24020

After:

These icons are the same now:

<img width="1287" alt="截屏2023-04-18 13 52 11"
src="https://user-images.githubusercontent.com/17645053/232684252-05ddc101-dc5b-41b5-b374-132c3d853a41.png">

<img width="1141" alt="截屏2023-04-18 13 54 48"
src="https://user-images.githubusercontent.com/17645053/232684261-6ebd864a-a9aa-4982-af32-2cea91c35be8.png">

In this PR, didn't use `ActionRunStatus.vue` because the mounting of the
component will cause flash of the icons like below:

https://user-images.githubusercontent.com/17645053/232682646-713202dc-9023-4b9c-a849-c3a1ae6dd155.mov

Instead, modified and used `status.tmpl` to make it the same as
`ActionRunStatus.vue` to avoid the ui flash (Welcomed to show how to use
`ActionRunStatus.vue` without flashing if there is a way).
Added comments to both of them for reminding synchronization of these
two files.

---------

Co-authored-by: Jason Song <i@wolfogre.com>
templates/repo/actions/runs_list.tmpl
templates/repo/actions/status.tmpl
web_src/js/components/ActionRunStatus.vue