]> source.dussan.org Git - vaadin-framework.git/commit
Avoid eagerly layouting from VScrollTable.updateFromUIDL (#13188)
authorTomi Virtanen <tltv@vaadin.com>
Sat, 15 Mar 2014 17:56:46 +0000 (19:56 +0200)
committerLeif Åstrand <leif@vaadin.com>
Thu, 17 Apr 2014 08:07:23 +0000 (08:07 +0000)
commit9fa230d416a74206a57b215ebf1e884e87d11f3e
tree2a12963087a481b8c9916f15928fe85b81784498
parent9c29442be7fbb150288ba4451ed9167bec2436ad
Avoid eagerly layouting from VScrollTable.updateFromUIDL (#13188)

Closing a modal sub-window at the same time when TreeTable item is
removed, caused the detached Window being re-opened by
WindowConnector.postLayout() call.

This change adds a check in postLayout: continue operation only if the
window is attached to DOM. Or else, log a warning message about the
invalid postLayout call. Another change is in TreeTableConnector and
VScrollTable to disallow Util.notifyParentOfSizeChange(Widget, boolean)
with a boolean 'false' argument, when rendering is in progress. 'false'
causes an immediate LayoutManager.layoutNow() call, which is the main
reason for this issue.

Change-Id: I6f3e331b0feff9e7814ae1d749f6f7812dcd49ac
client/src/com/vaadin/client/ui/VScrollTable.java
client/src/com/vaadin/client/ui/treetable/TreeTableConnector.java
client/src/com/vaadin/client/ui/window/WindowConnector.java
uitest/src/com/vaadin/tests/components/window/CloseModalSubWindow.java [new file with mode: 0644]
uitest/src/com/vaadin/tests/components/window/CloseModalSubWindowTest.java [new file with mode: 0644]