]> source.dussan.org Git - vaadin-framework.git/commit
Redesign ComboBox filtering, highlighting and selection behaviour.
authorSauli Tähkäpää <sauli@vaadin.com>
Thu, 8 Jan 2015 07:48:49 +0000 (09:48 +0200)
committerAnna Koskinen <anna@vaadin.com>
Thu, 26 Feb 2015 15:21:19 +0000 (17:21 +0200)
commitacb889336f80227d609b194e56ac6ae3ead0d338
treeb41488f3b5b6f31b19ed7a10841b05fb043394bb
parent5830a1f96b24186a68023258630ef1d89590d31e
Redesign ComboBox filtering, highlighting and selection behaviour.
(#15502, #9369)

Changes:
- When opening the popup, the first suggestion is always highlighted by
default unless adding new items is allowed.
- When filter matches currently selected item, that item will be
highlighted instead of the first item.
- Hitting enter or tab will always select the highlighted item.
- Closing the suggestions list by clicking outside the list no longer
selects an item to prevent accidental selections.

Test changes:
- Extended ComboBoxElement to help test filtering.
- Updated and tweaked ComboBoxResetValueTest,
ComboBoxIdenticalItemsTest and ComboboxScrollableWindowTest.
- Added ComboBoxSelectingTest and
ComboBoxSelectingWithNewItemsAllowedTest.
- Updated some tests that were using keyboard navigation.

Change-Id: Ia7745b624bdb0b1a1bb498157ebcb37bee219d76
18 files changed:
client/src/com/vaadin/client/ui/VFilterSelect.java
client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
uitest/src/com/vaadin/tests/components/combobox/ComboBoxIdenticalItemsTest.java
uitest/src/com/vaadin/tests/components/combobox/ComboBoxResetValue.java
uitest/src/com/vaadin/tests/components/combobox/ComboBoxResetValueTest.java
uitest/src/com/vaadin/tests/components/combobox/ComboBoxScrollingWithArrowsTest.java
uitest/src/com/vaadin/tests/components/combobox/ComboBoxSelecting.java [new file with mode: 0644]
uitest/src/com/vaadin/tests/components/combobox/ComboBoxSelectingTest.java [new file with mode: 0644]
uitest/src/com/vaadin/tests/components/combobox/ComboBoxSelectingWithNewItemsAllowed.java [new file with mode: 0644]
uitest/src/com/vaadin/tests/components/combobox/ComboBoxSelectingWithNewItemsAllowedTest.java [new file with mode: 0644]
uitest/src/com/vaadin/tests/components/window/ComboboxScrollableWindowTest.java
uitest/src/com/vaadin/tests/fonticon/FontIconsTest.java
uitest/src/com/vaadin/tests/tb3/newelements/ComboBoxElement.java [new file with mode: 0644]
uitest/tb2/com/vaadin/tests/components/combobox/ComboBoxBorder.html
uitest/tb2/com/vaadin/tests/components/combobox/ComboBoxCombinedWithEnterShortcut.html
uitest/tb2/com/vaadin/tests/components/combobox/ComboBoxLargeIcons.html
uitest/tb2/com/vaadin/tests/components/combobox/ComboBoxNavigation.html
uitest/tb2/com/vaadin/tests/components/combobox/ComboBoxSQLContainerFilteredValueChange.html