]> source.dussan.org Git - jgit.git/commit
Replace custom encoder `Constants#encode` by JDK implementation 42/1200642/1
authorMatthias Sohn <matthias.sohn@sap.com>
Fri, 6 Sep 2024 10:26:44 +0000 (12:26 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Fri, 6 Sep 2024 10:27:02 +0000 (12:27 +0200)
commite5d2898997462e0f2409c09497ab62c6cda2dbaf
tree304021423f1bead1d33d879ddbecc6b9ff052c52
parent3d0d754ae5aa593cba68ea0f50f87e5d1839e54e
Replace custom encoder `Constants#encode` by JDK implementation

Using the implementation provided in the JDK since Java 1.6 by
`String#getBytes(Charset)` reduces JGit maintenance effort and improves
performance.

The method Constants#encode was implemented when JGit still used Java
1.5. See [1].

Kudos to Marcin for proposing to use this improvement in RefWriter [2].
I think it should be used generally.

[1] https://repo.or.cz/jgit.git?a=commit;h=bfa3da225f198b19061158499b1135aff07d85b3
[2] https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/1195180

Also-By: Marcin Czech <maczech@gmail.com>
Change-Id: I361ed6286b98351a315b8a8ffc3cb845831d35b2
org.eclipse.jgit/src/org/eclipse/jgit/lib/Constants.java