From 04ae3b4441efde2c1b2c3f75d15fef6b6f1b0549 Mon Sep 17 00:00:00 2001 From: Dominik Stadler Date: Wed, 6 Sep 2023 09:53:29 +0000 Subject: [PATCH] Reduce flakiness of one test which compares two documents There are more places where a timestamp is stored in the zip-file, let's try to replace some more bytes to make comparison succeed more often. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912126 13f79535-47bb-0310-9956-ffa450edef68 --- .../ss/usermodel/BaseTestBugzillaIssues.java | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java index ebcdb5baf2..f4013dc8cc 100644 --- a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java +++ b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestBugzillaIssues.java @@ -1840,6 +1840,41 @@ public abstract class BaseTestBugzillaIssues { bytes[11] = 0; bytes[12] = 0; bytes[13] = 0; + + // there is a timestamp for every entry, so try to replace a few more byte-positions + // to reduce flakiness of this test, however we likely do not yet cover all entries + bytes[390] = 0; + bytes[391] = 0; + bytes[674] = 0; + bytes[883] = 0; + bytes[1207] = 0; + bytes[1208] = 0; + bytes[1433] = 0; + bytes[1434] = 0; + bytes[1817] = 0; + bytes[1818] = 0; + bytes[2098] = 0; + bytes[2099] = 0; + bytes[2762] = 0; + bytes[2763] = 0; + bytes[2382] = 0; + bytes[2383] = 0; + bytes[2827] = 0; + bytes[2828] = 0; + bytes[2884] = 0; + bytes[2885] = 0; + bytes[2946] = 0; + bytes[2947] = 0; + bytes[3009] = 0; + bytes[3010] = 0; + bytes[3075] = 0; + bytes[3076] = 0; + bytes[3134] = 0; + bytes[3135] = 0; + bytes[3195] = 0; + bytes[3196] = 0; + bytes[3267] = 0; + bytes[3268] = 0; } return bytes; -- 2.39.5