From 09e15e5451251ab6e4a1e13f07c200af3d0ee7f2 Mon Sep 17 00:00:00 2001 From: Klaudio Sinani Date: Wed, 30 Nov 2022 16:41:09 +0100 Subject: [PATCH] [NO-JIRA] Fix reported code smells --- .../sonar/server/component/ws/AppAction.java | 2 -- .../externalissue/sarif/package-info.java | 23 +++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 sonar-scanner-engine/src/main/java/org/sonar/scanner/externalissue/sarif/package-info.java diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ws/AppAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ws/AppAction.java index bd288f8e29a..d237f62a621 100644 --- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ws/AppAction.java +++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ws/AppAction.java @@ -85,7 +85,6 @@ public class AppAction implements ComponentsWsAction { @Override public void handle(Request request, Response response) { - int a = 100; try (DbSession session = dbClient.openSession(false)) { ComponentDto component = loadComponent(session, request); userSession.checkComponentPermission(UserRole.USER, component); @@ -97,7 +96,6 @@ public class AppAction implements ComponentsWsAction { String branch = request.param(PARAM_BRANCH); String pullRequest = request.param(PARAM_PULL_REQUEST); String componentKey = request.mandatoryParam(PARAM_COMPONENT); -int a = 9; return componentFinder.getByKeyAndOptionalBranchOrPullRequest(dbSession, componentKey, branch, pullRequest); } diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scanner/externalissue/sarif/package-info.java b/sonar-scanner-engine/src/main/java/org/sonar/scanner/externalissue/sarif/package-info.java new file mode 100644 index 00000000000..2a41eabc7de --- /dev/null +++ b/sonar-scanner-engine/src/main/java/org/sonar/scanner/externalissue/sarif/package-info.java @@ -0,0 +1,23 @@ +/* + * SonarQube + * Copyright (C) 2009-2022 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +@ParametersAreNonnullByDefault +package org.sonar.scanner.externalissue.sarif; + +import javax.annotation.ParametersAreNonnullByDefault; -- 2.39.5