From 0d7956367e37a47c21cb05a52b118b38a2c17b66 Mon Sep 17 00:00:00 2001 From: =?utf8?q?S=C3=A9bastien=20Lesaint?= Date: Tue, 9 Jan 2018 18:07:19 +0100 Subject: [PATCH] SONAR-10122 remove dead code in DefaultInputModule --- .../batch/fs/internal/DefaultInputModule.java | 17 ----------------- .../fs/internal/DefaultInputModuleTest.java | 3 --- 2 files changed, 20 deletions(-) diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/fs/internal/DefaultInputModule.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/fs/internal/DefaultInputModule.java index f2683b613a9..8bd22e1877a 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/fs/internal/DefaultInputModule.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/fs/internal/DefaultInputModule.java @@ -23,10 +23,8 @@ import java.io.File; import java.io.IOException; import java.nio.file.LinkOption; import java.nio.file.Path; -import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; -import java.util.List; import java.util.Map; import javax.annotation.CheckForNull; import javax.annotation.concurrent.Immutable; @@ -47,8 +45,6 @@ public class DefaultInputModule extends DefaultInputComponent implements InputMo private final String description; private final String keyWithBranch; private final String branch; - private final List sources; - private final List tests; private final Map properties; private final String moduleKey; @@ -72,8 +68,6 @@ public class DefaultInputModule extends DefaultInputComponent implements InputMo this.description = definition.getDescription(); this.keyWithBranch = definition.getKeyWithBranch(); this.branch = definition.getBranch(); - this.sources = Collections.unmodifiableList(new ArrayList<>(definition.sources())); - this.tests = Collections.unmodifiableList(new ArrayList<>(definition.tests())); this.properties = Collections.unmodifiableMap(new HashMap<>(definition.properties())); this.definition = definition; @@ -155,15 +149,4 @@ public class DefaultInputModule extends DefaultInputComponent implements InputMo return description; } - /** - * @return Source files and folders. - */ - public List sources() { - return sources; - } - - public List tests() { - return tests; - } - } diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/batch/fs/internal/DefaultInputModuleTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/batch/fs/internal/DefaultInputModuleTest.java index 9f03c27b11e..853a94c3fe5 100644 --- a/sonar-plugin-api/src/test/java/org/sonar/api/batch/fs/internal/DefaultInputModuleTest.java +++ b/sonar-plugin-api/src/test/java/org/sonar/api/batch/fs/internal/DefaultInputModuleTest.java @@ -21,7 +21,6 @@ package org.sonar.api.batch.fs.internal; import java.io.File; import java.io.IOException; -import java.util.Collections; import org.junit.Rule; import org.junit.Test; import org.junit.rules.TemporaryFolder; @@ -60,8 +59,6 @@ public class DefaultInputModuleTest { assertThat(module.getOriginalVersion()).isEqualTo("version"); assertThat(module.getDescription()).isEqualTo("desc"); assertThat(module.getWorkDir()).isEqualTo(workDir.toPath()); - assertThat(module.sources()).isEqualTo(Collections.singletonList("file1")); - assertThat(module.tests()).isEqualTo(Collections.singletonList("test1")); assertThat(module.properties()).hasSize(6); -- 2.39.5