From 1041a876cb2bbd6f6349986645018160be0ba6e2 Mon Sep 17 00:00:00 2001 From: Andreas Beeker Date: Sun, 10 Jan 2021 21:16:04 +0000 Subject: [PATCH] Sonar fixes JUnit5 test classes and methods should have default package visibility git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885340 13f79535-47bb-0310-9956-ffa450edef68 --- .../poi/ss/excelant/TestExcelAntPrecision.java | 2 +- .../apache/poi/ss/excelant/TestExcelAntSet.java | 2 +- .../ss/excelant/TestExcelAntSetDoubleCell.java | 2 +- .../TestExcelAntUserDefinedFunction.java | 2 +- .../util/TestExcelAntEvaluationResult.java | 2 +- .../excelant/util/TestExcelAntWorkbookUtil.java | 2 +- .../util/TestExcelAntWorkbookUtilFactory.java | 2 +- .../apache/poi/stress/BaseIntegrationTest.java | 6 ++++-- .../org/apache/poi/stress/HDGFFileHandler.java | 4 ++-- .../org/apache/poi/stress/HMEFFileHandler.java | 4 ++-- .../org/apache/poi/stress/HPBFFileHandler.java | 4 ++-- .../org/apache/poi/stress/HPSFFileHandler.java | 6 +++--- .../org/apache/poi/stress/HSLFFileHandler.java | 6 +++--- .../org/apache/poi/stress/HSMFFileHandler.java | 4 ++-- .../org/apache/poi/stress/HSSFFileHandler.java | 6 +++--- .../apache/poi/stress/HSSFRecordsStresser.java | 4 ++-- .../org/apache/poi/stress/HWPFFileHandler.java | 6 +++--- .../org/apache/poi/stress/OPCFileHandler.java | 4 ++-- .../org/apache/poi/stress/POIFSFileHandler.java | 4 ++-- .../org/apache/poi/stress/POIFileScanner.java | 8 ++++---- .../org/apache/poi/stress/TestAllFiles.java | 4 ++-- .../org/apache/poi/stress/XDGFFileHandler.java | 4 ++-- .../org/apache/poi/stress/XSLFFileHandler.java | 4 ++-- .../org/apache/poi/stress/XSSFBFileHandler.java | 11 ++++++++--- .../org/apache/poi/stress/XSSFFileHandler.java | 6 +++--- .../org/apache/poi/stress/XWPFFileHandler.java | 4 ++-- .../integration/java9/module-info.java | 2 ++ .../{CountifsTests.java => TestCountifs.java} | 2 +- ....java => TestConditionalFormattingEval.java} | 2 +- ...ratorTest.java => TestCombinedIterator.java} | 2 +- ...ryLeakTests.java => TestXSSFMemoryLeak.java} | 2 +- ...actNumTest.java => TestXWPFAbstractNum.java} | 2 +- ...atingTest.java => BaseTestPPTIterating.java} | 2 +- .../poi/hslf/dev/TestPPDrawingTextListing.java | 9 ++++----- .../org/apache/poi/hslf/dev/TestPPTXMLDump.java | 2 +- .../apache/poi/hslf/dev/TestSLWTListing.java | 3 +-- .../poi/hslf/dev/TestSLWTTextListing.java | 9 ++++----- .../hslf/dev/TestSlideAndNotesAtomListing.java | 11 +++++------ .../apache/poi/hslf/dev/TestSlideIdListing.java | 11 +++++------ .../poi/hslf/dev/TestSlideShowDumper.java | 3 +-- .../poi/hslf/dev/TestSlideShowRecordDumper.java | 3 +-- .../poi/hslf/dev/TestTextStyleListing.java | 9 ++++----- .../hslf/dev/TestUserEditAndPersistListing.java | 9 ++++----- ...tilsTest.java => TestAbstractWordUtils.java} | 2 +- .../model/{PlfLfoTest.java => TestPlfLfo.java} | 2 +- ...est.java => TestLFOLVLBaseAbstractType.java} | 2 +- ...tTypeTest.java => TestLVLFAbstractType.java} | 2 +- .../org/apache/poi/TestPOIDocumentMain.java | 2 +- .../org/apache/poi/TestPOITestCase.java | 2 +- .../org/apache/poi/ddf/TestEscherBSERecord.java | 2 +- .../apache/poi/ddf/TestEscherBlipRecord.java | 2 +- .../apache/poi/ddf/TestEscherBoolProperty.java | 2 +- .../poi/ddf/TestEscherChildAnchorRecord.java | 2 +- .../poi/ddf/TestEscherContainerRecord.java | 2 +- .../org/apache/poi/ddf/TestEscherDgRecord.java | 2 +- .../org/apache/poi/ddf/TestEscherDggRecord.java | 2 +- .../org/apache/poi/ddf/TestEscherOptRecord.java | 2 +- .../apache/poi/ddf/TestEscherSpgrRecord.java | 2 +- .../ddf/TestEscherSplitMenuColorsRecord.java | 2 +- .../apache/poi/ddf/TestUnknownEscherRecord.java | 2 +- .../org/apache/poi/hpsf/basic/TestBasic.java | 2 +- .../org/apache/poi/hpsf/basic/TestClassID.java | 2 +- .../poi/hpsf/basic/TestEmptyProperties.java | 2 +- .../org/apache/poi/hpsf/basic/TestHPSFBugs.java | 2 +- .../apache/poi/hpsf/basic/TestMetaDataIPI.java | 2 +- .../extractor/TestHPSFPropertiesExtractor.java | 2 +- .../hssf/eventmodel/TestAbortableListener.java | 2 +- .../hssf/eventmodel/TestEventRecordFactory.java | 3 +-- .../TestEventWorkbookBuilder.java | 2 +- .../TestFormatTrackingHSSFListener.java | 2 +- .../eventusermodel/TestHSSFEventFactory.java | 2 +- .../TestMissingRecordAwareHSSFListener.java | 2 +- .../poi/hssf/extractor/TestExcelExtractor.java | 2 +- .../hssf/extractor/TestOldExcelExtractor.java | 2 +- .../poi/hssf/model/TestDrawingManager2.java | 2 +- .../poi/hssf/model/TestFormulaParser.java | 2 +- .../poi/hssf/model/TestFormulaParserEval.java | 2 +- .../poi/hssf/model/TestFormulaParserIf.java | 2 +- .../apache/poi/hssf/model/TestLinkTable.java | 2 +- .../hssf/model/TestOperandClassTransformer.java | 2 +- .../org/apache/poi/hssf/model/TestRVA.java | 3 +-- .../poi/hssf/model/TestRowBlocksReader.java | 3 +-- .../org/apache/poi/hssf/model/TestSheet.java | 2 +- .../poi/hssf/model/TestSheetAdditional.java | 2 +- .../org/apache/poi/hssf/model/TestWorkbook.java | 2 +- .../apache/poi/hssf/record/TestArrayRecord.java | 2 +- .../hssf/record/TestAutoFilterInfoRecord.java | 2 +- .../apache/poi/hssf/record/TestBOFRecord.java | 2 +- .../poi/hssf/record/TestBoolErrRecord.java | 2 +- .../poi/hssf/record/TestBoundSheetRecord.java | 2 +- .../poi/hssf/record/TestCFHeaderRecord.java | 2 +- .../poi/hssf/record/TestCFRuleRecord.java | 2 +- .../poi/hssf/record/TestColumnInfoRecord.java | 2 +- .../record/TestCommonObjectDataSubRecord.java | 2 +- .../apache/poi/hssf/record/TestDVALRecord.java | 2 +- .../poi/hssf/record/TestDrawingGroupRecord.java | 2 +- .../poi/hssf/record/TestDrawingRecord.java | 2 +- .../record/TestEmbeddedObjectRefSubRecord.java | 2 +- .../poi/hssf/record/TestEndSubRecord.java | 2 +- .../poi/hssf/record/TestEscherAggregate.java | 2 +- .../poi/hssf/record/TestExtSSTRecord.java | 2 +- .../hssf/record/TestExtendedFormatRecord.java | 2 +- .../poi/hssf/record/TestExternalNameRecord.java | 2 +- .../apache/poi/hssf/record/TestFeatRecord.java | 2 +- .../apache/poi/hssf/record/TestFontRecord.java | 2 +- .../poi/hssf/record/TestFormulaRecord.java | 2 +- .../poi/hssf/record/TestFtCblsSubRecord.java | 2 +- .../poi/hssf/record/TestHyperlinkRecord.java | 2 +- .../poi/hssf/record/TestInterfaceEndRecord.java | 2 +- .../apache/poi/hssf/record/TestLabelRecord.java | 2 +- .../poi/hssf/record/TestLbsDataSubRecord.java | 2 +- .../poi/hssf/record/TestMergeCellsRecord.java | 5 +---- .../poi/hssf/record/TestNameCommentRecord.java | 2 +- .../apache/poi/hssf/record/TestNameRecord.java | 2 +- .../apache/poi/hssf/record/TestNoteRecord.java | 2 +- .../hssf/record/TestNoteStructureSubRecord.java | 2 +- .../apache/poi/hssf/record/TestObjRecord.java | 2 +- .../apache/poi/hssf/record/TestPLVRecord.java | 2 +- .../poi/hssf/record/TestPaletteRecord.java | 2 +- .../apache/poi/hssf/record/TestPaneRecord.java | 2 +- .../poi/hssf/record/TestRecalcIdRecord.java | 2 +- .../poi/hssf/record/TestRecordFactory.java | 6 ++++-- .../record/TestRecordFactoryInputStream.java | 2 +- .../poi/hssf/record/TestRecordInputStream.java | 2 +- .../apache/poi/hssf/record/TestSCLRecord.java | 2 +- .../poi/hssf/record/TestSSTDeserializer.java | 2 +- .../apache/poi/hssf/record/TestSSTRecord.java | 2 +- .../record/TestSSTRecordSizeCalculator.java | 2 +- .../hssf/record/TestSharedFormulaRecord.java | 2 +- .../poi/hssf/record/TestStringRecord.java | 3 +-- .../apache/poi/hssf/record/TestStyleRecord.java | 2 +- .../apache/poi/hssf/record/TestSubRecord.java | 2 +- .../poi/hssf/record/TestSupBookRecord.java | 2 +- .../apache/poi/hssf/record/TestTableRecord.java | 2 +- .../hssf/record/TestTextObjectBaseRecord.java | 2 +- .../poi/hssf/record/TestTextObjectRecord.java | 2 +- .../poi/hssf/record/TestUnicodeNameRecord.java | 2 +- .../poi/hssf/record/TestWriteAccessRecord.java | 2 +- .../aggregates/TestCFRecordsAggregate.java | 2 +- .../TestColumnInfoRecordsAggregate.java | 2 +- .../aggregates/TestFormulaRecordAggregate.java | 2 +- .../aggregates/TestPageSettingsBlock.java | 2 +- .../aggregates/TestRowRecordsAggregate.java | 2 +- .../aggregates/TestSharedValueManager.java | 2 +- .../aggregates/TestValueRecordsAggregate.java | 3 +-- .../poi/hssf/record/cf/TestCellRange.java | 2 +- .../hssf/record/chart/TestAreaFormatRecord.java | 2 +- .../poi/hssf/record/chart/TestAreaRecord.java | 2 +- .../record/chart/TestAxisLineFormatRecord.java | 2 +- .../record/chart/TestAxisOptionsRecord.java | 2 +- .../hssf/record/chart/TestAxisParentRecord.java | 2 +- .../poi/hssf/record/chart/TestAxisRecord.java | 2 +- .../hssf/record/chart/TestAxisUsedRecord.java | 2 +- .../poi/hssf/record/chart/TestBarRecord.java | 2 +- .../chart/TestCategorySeriesAxisRecord.java | 2 +- .../record/chart/TestChartFormatRecord.java | 2 +- .../poi/hssf/record/chart/TestChartRecord.java | 2 +- .../chart/TestChartTitleFormatRecord.java | 2 +- .../poi/hssf/record/chart/TestDatRecord.java | 2 +- .../hssf/record/chart/TestDataFormatRecord.java | 2 +- ...estDefaultDataLabelTextPropertiesRecord.java | 2 +- .../hssf/record/chart/TestFontBasisRecord.java | 2 +- .../hssf/record/chart/TestFontIndexRecord.java | 2 +- .../poi/hssf/record/chart/TestFrameRecord.java | 2 +- .../poi/hssf/record/chart/TestLegendRecord.java | 2 +- .../hssf/record/chart/TestLineFormatRecord.java | 2 +- .../hssf/record/chart/TestLinkedDataRecord.java | 2 +- .../chart/TestNumberFormatIndexRecord.java | 2 +- .../hssf/record/chart/TestObjectLinkRecord.java | 2 +- .../hssf/record/chart/TestPlotAreaRecord.java | 2 +- .../hssf/record/chart/TestPlotGrowthRecord.java | 2 +- .../chart/TestSeriesChartGroupIndexRecord.java | 2 +- .../record/chart/TestSeriesIndexRecord.java | 2 +- .../record/chart/TestSeriesLabelsRecord.java | 2 +- .../hssf/record/chart/TestSeriesListRecord.java | 2 +- .../poi/hssf/record/chart/TestSeriesRecord.java | 2 +- .../hssf/record/chart/TestSeriesTextRecord.java | 2 +- .../record/chart/TestSheetPropertiesRecord.java | 2 +- .../poi/hssf/record/chart/TestTextRecord.java | 2 +- .../poi/hssf/record/chart/TestTickRecord.java | 2 +- .../poi/hssf/record/chart/TestUnitsRecord.java | 2 +- .../hssf/record/chart/TestValueRangeRecord.java | 2 +- .../hssf/record/common/TestUnicodeString.java | 2 +- .../TestExtendedPivotTableViewFieldsRecord.java | 2 +- .../hssf/record/pivot/TestPageItemRecord.java | 2 +- .../hssf/record/pivot/TestViewFieldsRecord.java | 2 +- .../apache/poi/hssf/usermodel/TestBug42464.java | 2 +- .../org/apache/poi/hssf/usermodel/TestBugs.java | 2 +- .../poi/hssf/usermodel/TestCellStyle.java | 2 +- .../poi/hssf/usermodel/TestCloneSheet.java | 2 +- .../poi/hssf/usermodel/TestDataValidation.java | 2 +- .../poi/hssf/usermodel/TestEscherGraphics.java | 2 +- .../hssf/usermodel/TestEscherGraphics2d.java | 2 +- .../poi/hssf/usermodel/TestFontDetails.java | 2 +- .../usermodel/TestFormulaEvaluatorBugs.java | 3 +-- .../usermodel/TestFormulaEvaluatorDocs.java | 2 +- .../apache/poi/hssf/usermodel/TestFormulas.java | 2 +- .../apache/poi/hssf/usermodel/TestHSSFCell.java | 2 +- .../poi/hssf/usermodel/TestHSSFChart.java | 3 +-- .../hssf/usermodel/TestHSSFClientAnchor.java | 2 +- .../poi/hssf/usermodel/TestHSSFComment.java | 2 +- .../TestHSSFConditionalFormatting.java | 2 +- .../poi/hssf/usermodel/TestHSSFDataFormat.java | 2 +- .../usermodel/TestHSSFExternalFunctions.java | 2 +- .../apache/poi/hssf/usermodel/TestHSSFFont.java | 2 +- .../usermodel/TestHSSFFormulaEvaluator.java | 2 +- .../hssf/usermodel/TestHSSFHeaderFooter.java | 2 +- .../poi/hssf/usermodel/TestHSSFHyperlink.java | 2 +- .../poi/hssf/usermodel/TestHSSFOptimiser.java | 2 +- .../poi/hssf/usermodel/TestHSSFPalette.java | 2 +- .../poi/hssf/usermodel/TestHSSFPatriarch.java | 2 +- .../poi/hssf/usermodel/TestHSSFPicture.java | 2 +- .../poi/hssf/usermodel/TestHSSFPictureData.java | 2 +- .../hssf/usermodel/TestHSSFRichTextString.java | 2 +- .../apache/poi/hssf/usermodel/TestHSSFRow.java | 2 +- .../poi/hssf/usermodel/TestHSSFSheet.java | 2 +- .../usermodel/TestHSSFSheetAutosizeColumn.java | 4 ++-- .../hssf/usermodel/TestHSSFSheetShiftRows.java | 2 +- .../TestHSSFSheetUpdateArrayFormulas.java | 2 +- .../poi/hssf/usermodel/TestHSSFTextbox.java | 2 +- ...TestMatrixFormulasFromBinarySpreadsheet.java | 2 +- .../TestNonStandardWorkbookStreamNames.java | 2 +- .../poi/hssf/usermodel/TestOLE2Embeding.java | 2 +- .../poi/hssf/usermodel/TestReadWriteChart.java | 2 +- .../apache/poi/hssf/usermodel/TestRowStyle.java | 2 +- .../poi/hssf/usermodel/TestSanityChecker.java | 3 +-- .../poi/hssf/usermodel/TestSheetHiding.java | 13 ++++++------- .../poi/hssf/usermodel/TestUnfixedBugs.java | 2 +- .../poi/hssf/usermodel/TestUnicodeWorkbook.java | 2 +- .../apache/poi/hssf/usermodel/TestWorkbook.java | 17 +++++++++++++---- .../apache/poi/hssf/util/TestAreaReference.java | 2 +- .../apache/poi/hssf/util/TestCellReference.java | 2 +- .../org/apache/poi/hssf/util/TestHSSFColor.java | 2 +- .../org/apache/poi/hssf/util/TestRKUtil.java | 2 +- .../poifs/crypt/TestBiff8DecryptingStream.java | 2 +- .../TestPOIFSReaderRegistry.java | 2 +- .../poi/poifs/filesystem/TestDirectoryNode.java | 2 +- .../filesystem/TestDocumentDescriptor.java | 2 +- .../filesystem/TestDocumentInputStream.java | 2 +- .../filesystem/TestDocumentOutputStream.java | 2 +- .../poi/poifs/filesystem/TestEmptyDocument.java | 2 +- .../poifs/filesystem/TestFileSystemBugs.java | 2 +- .../filesystem/TestFilteringDirectoryNode.java | 2 +- .../poifs/filesystem/TestPOIFSDocumentPath.java | 3 +-- .../poifs/filesystem/TestPOIFSFileSystem.java | 2 +- .../poifs/filesystem/TestPOIFSMiniStore.java | 3 +-- .../poi/poifs/filesystem/TestPOIFSStream.java | 3 +-- .../poifs/filesystem/TestPropertySorter.java | 2 +- .../poifs/property/TestDirectoryProperty.java | 2 +- .../poifs/property/TestDocumentProperty.java | 2 +- .../poi/poifs/property/TestPropertyFactory.java | 2 +- .../poi/poifs/property/TestPropertyTable.java | 2 +- .../poi/poifs/property/TestRootProperty.java | 2 +- .../apache/poi/poifs/storage/TestBATBlock.java | 2 +- .../poifs/storage/TestHeaderBlockReading.java | 2 +- .../apache/poi/ss/TestSpreadsheetVersion.java | 2 +- .../poi/ss/formula/TestFormulaShifter.java | 2 +- .../poi/ss/formula/TestSheetNameFormatter.java | 9 ++++----- .../ss/formula/atp/TestYearFracCalculator.java | 2 +- .../TestYearFracCalculatorFromSpreadsheet.java | 2 +- .../constant/TestConstantValueParser.java | 2 +- .../poi/ss/formula/eval/TestAreaEval.java | 2 +- .../poi/ss/formula/eval/TestDivideEval.java | 2 +- .../poi/ss/formula/eval/TestEqualEval.java | 2 +- .../ss/formula/eval/TestExternalFunction.java | 2 +- .../poi/ss/formula/eval/TestFormulaBugs.java | 2 +- .../eval/TestHSSFCircularReferences.java | 2 +- .../ss/formula/eval/TestMinusZeroResult.java | 2 +- .../poi/ss/formula/eval/TestMissingArgEval.java | 2 +- .../poi/ss/formula/eval/TestMultiSheetEval.java | 2 +- .../ss/formula/eval/TestOperandResolver.java | 2 +- .../poi/ss/formula/eval/TestPercentEval.java | 2 +- .../poi/ss/formula/eval/TestPowerEval.java | 2 +- .../poi/ss/formula/eval/TestRangeEval.java | 2 +- .../poi/ss/formula/eval/TestUnaryPlusEval.java | 2 +- .../function/TestFunctionMetadataRegistry.java | 2 +- .../function/TestParseMissingBuiltInFuncs.java | 2 +- .../function/TestReadMissingBuiltInFuncs.java | 2 +- .../poi/ss/formula/functions/TestAddress.java | 2 +- .../poi/ss/formula/functions/TestAreas.java | 2 +- .../poi/ss/formula/functions/TestAverage.java | 2 +- .../poi/ss/formula/functions/TestBin2Dec.java | 2 +- .../functions/TestCalendarFieldFunction.java | 2 +- .../poi/ss/formula/functions/TestClean.java | 2 +- .../ss/formula/functions/TestCountFuncs.java | 2 +- .../poi/ss/formula/functions/TestDate.java | 2 +- .../poi/ss/formula/functions/TestDateValue.java | 2 +- .../poi/ss/formula/functions/TestDays360.java | 2 +- .../poi/ss/formula/functions/TestDec2Bin.java | 2 +- .../poi/ss/formula/functions/TestDec2Hex.java | 2 +- .../poi/ss/formula/functions/TestDelta.java | 2 +- .../poi/ss/formula/functions/TestFind.java | 2 +- .../poi/ss/formula/functions/TestFixed.java | 2 +- .../poi/ss/formula/functions/TestHex2Dec.java | 2 +- .../poi/ss/formula/functions/TestIPMT.java | 2 +- .../poi/ss/formula/functions/TestIndex.java | 2 +- .../TestIndexFunctionFromSpreadsheet.java | 2 +- .../poi/ss/formula/functions/TestIndirect.java | 2 +- .../TestIndirectFunctionFromSpreadsheet.java | 2 +- .../poi/ss/formula/functions/TestIntercept.java | 2 +- .../poi/ss/formula/functions/TestIrr.java | 2 +- .../poi/ss/formula/functions/TestIsBlank.java | 2 +- .../poi/ss/formula/functions/TestLen.java | 2 +- .../TestLookupFunctionsFromSpreadsheet.java | 2 +- .../poi/ss/formula/functions/TestMatch.java | 2 +- .../TestMatchFunctionsFromSpreadsheet.java | 2 +- .../poi/ss/formula/functions/TestMid.java | 2 +- .../poi/ss/formula/functions/TestMirr.java | 2 +- .../poi/ss/formula/functions/TestNper.java | 2 +- .../poi/ss/formula/functions/TestNpv.java | 2 +- .../poi/ss/formula/functions/TestOct2Dec.java | 2 +- .../poi/ss/formula/functions/TestOffset.java | 2 +- .../poi/ss/formula/functions/TestPPMT.java | 2 +- .../poi/ss/formula/functions/TestPmt.java | 3 +-- .../poi/ss/formula/functions/TestRank.java | 2 +- .../ss/formula/functions/TestRoundFuncs.java | 9 ++++----- .../poi/ss/formula/functions/TestRowCol.java | 2 +- .../poi/ss/formula/functions/TestSlope.java | 2 +- .../poi/ss/formula/functions/TestSubtotal.java | 2 +- .../poi/ss/formula/functions/TestSumif.java | 2 +- .../poi/ss/formula/functions/TestSumifs.java | 2 +- .../ss/formula/functions/TestSumproduct.java | 3 +-- .../poi/ss/formula/functions/TestTFunc.java | 2 +- .../poi/ss/formula/functions/TestText.java | 2 +- .../poi/ss/formula/functions/TestTime.java | 2 +- .../poi/ss/formula/functions/TestTrim.java | 2 +- .../poi/ss/formula/functions/TestTrunc.java | 2 +- .../poi/ss/formula/functions/TestValue.java | 2 +- .../functions/TestXYNumericFunction.java | 2 +- .../poi/ss/formula/ptg/TestArea3DPtg.java | 2 +- .../poi/ss/formula/ptg/TestAreaErrPtg.java | 2 +- .../apache/poi/ss/formula/ptg/TestAreaPtg.java | 2 +- .../apache/poi/ss/formula/ptg/TestArrayPtg.java | 2 +- .../apache/poi/ss/formula/ptg/TestAttrPtg.java | 2 +- .../apache/poi/ss/formula/ptg/TestErrPtg.java | 2 +- .../ptg/TestExternalFunctionFormulas.java | 2 +- .../formula/ptg/TestExternalNameReference.java | 2 +- .../apache/poi/ss/formula/ptg/TestFuncPtg.java | 2 +- .../poi/ss/formula/ptg/TestFuncVarPtg.java | 2 +- .../poi/ss/formula/ptg/TestIntersectionPtg.java | 2 +- .../poi/ss/formula/ptg/TestPercentPtg.java | 2 +- .../apache/poi/ss/formula/ptg/TestRangePtg.java | 2 +- .../apache/poi/ss/formula/ptg/TestRef3DPtg.java | 2 +- .../poi/ss/formula/ptg/TestReferencePtg.java | 2 +- .../apache/poi/ss/formula/ptg/TestUnionPtg.java | 2 +- .../poi/ss/usermodel/TestFractionFormat.java | 2 +- .../poi/ss/usermodel/TestHSSFBorderStyle.java | 2 +- .../poi/ss/usermodel/TestIndexedColors.java | 2 +- .../org/apache/poi/ss/util/TestCellAddress.java | 2 +- .../poi/ss/util/TestCellRangeAddress.java | 2 +- .../apache/poi/ss/util/TestCellRangeUtil.java | 2 +- .../apache/poi/ss/util/TestCellReference.java | 2 +- .../poi/ss/util/TestDateFormatConverter.java | 2 +- .../apache/poi/ss/util/TestExpandedDouble.java | 2 +- .../apache/poi/ss/util/TestNumberComparer.java | 2 +- .../poi/ss/util/TestNumberToTextConverter.java | 2 +- .../poi/ss/util/TestPropertyTemplate.java | 2 +- .../org/apache/poi/ss/util/TestRegionUtil.java | 8 ++++---- .../apache/poi/ss/util/TestSheetBuilder.java | 2 +- .../org/apache/poi/ss/util/TestSheetUtil.java | 16 ++++++++-------- .../apache/poi/ss/util/TestWorkbookUtil.java | 2 +- .../org/apache/poi/util/TestBitField.java | 2 +- .../org/apache/poi/util/TestByteField.java | 2 +- .../org/apache/poi/util/TestIOUtils.java | 2 +- .../org/apache/poi/util/TestIntList.java | 2 +- .../org/apache/poi/util/TestIntegerField.java | 2 +- .../org/apache/poi/util/TestLittleEndian.java | 2 +- .../poi/util/TestLittleEndianStreams.java | 2 +- .../org/apache/poi/util/TestLongField.java | 2 +- .../org/apache/poi/util/TestPOILogFactory.java | 2 +- .../org/apache/poi/util/TestShortField.java | 3 +-- 371 files changed, 463 insertions(+), 472 deletions(-) rename src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/{CountifsTests.java => TestCountifs.java} (99%) rename src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/{ConditionalFormattingEvalTest.java => TestConditionalFormattingEval.java} (99%) rename src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/{CombinedIteratorTest.java => TestCombinedIterator.java} (99%) rename src/ooxml/testcases/org/apache/poi/xssf/{XSSFMemoryLeakTests.java => TestXSSFMemoryLeak.java} (99%) rename src/ooxml/testcases/org/apache/poi/xwpf/usermodel/{XWPFAbstractNumTest.java => TestXWPFAbstractNum.java} (97%) rename src/scratchpad/testcases/org/apache/poi/hslf/dev/{BasePPTIteratingTest.java => BaseTestPPTIterating.java} (99%) rename src/scratchpad/testcases/org/apache/poi/hwpf/converter/{AbstractWordUtilsTest.java => TestAbstractWordUtils.java} (98%) rename src/scratchpad/testcases/org/apache/poi/hwpf/model/{PlfLfoTest.java => TestPlfLfo.java} (98%) rename src/scratchpad/testcases/org/apache/poi/hwpf/model/types/{LFOLVLBaseAbstractTypeTest.java => TestLFOLVLBaseAbstractType.java} (96%) rename src/scratchpad/testcases/org/apache/poi/hwpf/model/types/{LVLFAbstractTypeTest.java => TestLVLFAbstractType.java} (97%) diff --git a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java index e67ef0976d..2902144fde 100644 --- a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java +++ b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java @@ -23,7 +23,7 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public class TestExcelAntPrecision { +class TestExcelAntPrecision { private ExcelAntPrecision fixture ; diff --git a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java index eb7c0cac67..42f6cd256c 100644 --- a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java +++ b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java @@ -25,7 +25,7 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public class TestExcelAntSet { +class TestExcelAntSet { // This is abstract in nature, so we'll use a diff --git a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java index c2e246319c..45c4f53635 100644 --- a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java +++ b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java @@ -25,7 +25,7 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public class TestExcelAntSetDoubleCell { +class TestExcelAntSetDoubleCell { private ExcelAntSetDoubleCell fixture ; diff --git a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java index c8df0a55aa..52b580ac6f 100644 --- a/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java +++ b/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java @@ -22,7 +22,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public class TestExcelAntUserDefinedFunction { +class TestExcelAntUserDefinedFunction { private ExcelAntUserDefinedFunctionTestHelper fixture ; diff --git a/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java b/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java index aea7208ea1..dcb044a2eb 100644 --- a/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java +++ b/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java @@ -23,7 +23,7 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public class TestExcelAntEvaluationResult { +class TestExcelAntEvaluationResult { private ExcelAntEvaluationResult fixture; private boolean completedWithError; diff --git a/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java b/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java index 8d6fb45990..4f46084c6a 100644 --- a/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java +++ b/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java @@ -40,7 +40,7 @@ import org.apache.tools.ant.BuildException; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.Test; -public class TestExcelAntWorkbookUtil { +class TestExcelAntWorkbookUtil { private static final String mortgageCalculatorFileName = TestBuildFile.getDataDir() + "/spreadsheet/excelant.xls" ; diff --git a/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtilFactory.java b/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtilFactory.java index 5c160e2ecb..26e700fa8b 100644 --- a/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtilFactory.java +++ b/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtilFactory.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; /** * Tests for the ExcelAntWorbookUtilFactory. */ -public class TestExcelAntWorkbookUtilFactory { +class TestExcelAntWorkbookUtilFactory { private static final String mortgageCalculatorWorkbookFile = TestBuildFile.getDataDir() + "/spreadsheet/mortgage-calculation.xls" ; diff --git a/src/integrationtest/org/apache/poi/stress/BaseIntegrationTest.java b/src/integrationtest/org/apache/poi/stress/BaseIntegrationTest.java index a9d5f8e6db..bff0cb1ba8 100644 --- a/src/integrationtest/org/apache/poi/stress/BaseIntegrationTest.java +++ b/src/integrationtest/org/apache/poi/stress/BaseIntegrationTest.java @@ -29,6 +29,7 @@ import java.util.zip.ZipException; import org.apache.poi.EncryptedDocumentException; import org.apache.poi.OldFileFormatException; import org.apache.poi.poifs.filesystem.OfficeXmlFileException; +import org.junit.jupiter.api.Test; /** * This class is used for mass-regression testing via a @@ -37,7 +38,7 @@ import org.apache.poi.poifs.filesystem.OfficeXmlFileException; * types of files/exceptions, e.g. old file formats. * */ -public class BaseIntegrationTest { +class BaseIntegrationTest { private final File rootDir; private final String file; private FileHandler handler; @@ -48,7 +49,8 @@ public class BaseIntegrationTest { this.handler = handler; } - public void test() throws Exception { + @Test + void test() throws Exception { assertNotNull( handler, "Unknown file extension for file: " + file + ": " + TestAllFiles.getExtension(file) ); testOneFile(new File(rootDir, file)); } diff --git a/src/integrationtest/org/apache/poi/stress/HDGFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HDGFFileHandler.java index 8fb6c65827..1d2ca65d4c 100644 --- a/src/integrationtest/org/apache/poi/stress/HDGFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HDGFFileHandler.java @@ -31,7 +31,7 @@ import org.apache.poi.hdgf.streams.TrailerStream; import org.apache.poi.poifs.filesystem.POIFSFileSystem; import org.junit.jupiter.api.Test; -public class HDGFFileHandler extends POIFSFileHandler { +class HDGFFileHandler extends POIFSFileHandler { @Override public void handleFile(InputStream stream, String path) throws IOException { POIFSFileSystem poifs = new POIFSFileSystem(stream); @@ -54,7 +54,7 @@ public class HDGFFileHandler extends POIFSFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Override @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/diagram/44501.vsd"); InputStream stream = new FileInputStream(file); diff --git a/src/integrationtest/org/apache/poi/stress/HMEFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HMEFFileHandler.java index 91071adc23..34cf9ee5b9 100644 --- a/src/integrationtest/org/apache/poi/stress/HMEFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HMEFFileHandler.java @@ -32,7 +32,7 @@ import org.apache.poi.poifs.filesystem.FileMagic; import org.apache.poi.util.LittleEndian; import org.junit.jupiter.api.Test; -public class HMEFFileHandler extends AbstractFileHandler { +class HMEFFileHandler extends AbstractFileHandler { @Override public void handleExtracting(File file) throws Exception { @@ -64,7 +64,7 @@ public class HMEFFileHandler extends AbstractFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Test - public void test() throws Exception { + void test() throws Exception { String path = "test-data/hmef/quick-winmail.dat"; try (InputStream stream = new FileInputStream(path)) { handleFile(stream, path); diff --git a/src/integrationtest/org/apache/poi/stress/HPBFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HPBFFileHandler.java index a1152d58d4..419840d696 100644 --- a/src/integrationtest/org/apache/poi/stress/HPBFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HPBFFileHandler.java @@ -27,7 +27,7 @@ import org.apache.poi.hpbf.extractor.PublisherTextExtractor; import org.apache.poi.poifs.filesystem.POIFSFileSystem; import org.junit.jupiter.api.Test; -public class HPBFFileHandler extends POIFSFileHandler { +class HPBFFileHandler extends POIFSFileHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { HPBFDocument pub = new HPBFDocument(new POIFSFileSystem(stream)); @@ -42,7 +42,7 @@ public class HPBFFileHandler extends POIFSFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Override @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/publisher/SampleBrochure.pub"); InputStream stream = new FileInputStream(file); diff --git a/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java index aafb700982..65ee09b428 100644 --- a/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java @@ -43,7 +43,7 @@ import org.apache.poi.poifs.filesystem.POIFSFileSystem; import org.apache.poi.util.TempFile; import org.junit.jupiter.api.Test; -public class HPSFFileHandler extends POIFSFileHandler { +class HPSFFileHandler extends POIFSFileHandler { private static final String NL = System.getProperty("line.separator"); private static File copyOutput; @@ -120,7 +120,7 @@ public class HPSFFileHandler extends POIFSFileHandler { @Override @Test @SuppressWarnings("java:S2699") - public void test() throws Exception { + void test() throws Exception { String path = "test-data/diagram/44501.vsd"; try (InputStream stream = new FileInputStream(path)) { handleFile(stream, path); @@ -129,7 +129,7 @@ public class HPSFFileHandler extends POIFSFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Test - public void testExtractor() { + void testExtractor() { File file = new File("test-data/hpsf/TestBug44375.xls"); assertDoesNotThrow(() -> handleExtracting(file)); } diff --git a/src/integrationtest/org/apache/poi/stress/HSLFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HSLFFileHandler.java index a4ae15b090..3ea92dd078 100644 --- a/src/integrationtest/org/apache/poi/stress/HSLFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HSLFFileHandler.java @@ -29,7 +29,7 @@ import org.apache.poi.util.POILogger; import org.apache.poi.util.SystemOutLogger; import org.junit.jupiter.api.Test; -public class HSLFFileHandler extends SlideShowHandler { +class HSLFFileHandler extends SlideShowHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { HSLFSlideShowImpl slide = new HSLFSlideShowImpl(stream); @@ -51,14 +51,14 @@ public class HSLFFileHandler extends SlideShowHandler { } @Test - public void testOne() throws Exception { + void testOne() throws Exception { testOneFile(new File("test-data/slideshow/54880_chinese.ppt")); } // a test-case to test all .ppt files without executing the full TestAllFiles @Override @Test - public void test() throws Exception { + void test() throws Exception { File[] files = new File("test-data/slideshow/").listFiles((dir, name) -> name.endsWith(".ppt")); assertNotNull(files); diff --git a/src/integrationtest/org/apache/poi/stress/HSMFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HSMFFileHandler.java index 9fa3160cda..8a21781bc4 100644 --- a/src/integrationtest/org/apache/poi/stress/HSMFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HSMFFileHandler.java @@ -27,7 +27,7 @@ import org.apache.poi.hsmf.datatypes.AttachmentChunks; import org.apache.poi.hsmf.datatypes.DirectoryChunk; import org.junit.jupiter.api.Test; -public class HSMFFileHandler extends POIFSFileHandler { +class HSMFFileHandler extends POIFSFileHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { MAPIMessage mapi = new MAPIMessage(stream); @@ -77,7 +77,7 @@ public class HSMFFileHandler extends POIFSFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Override @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/hsmf/logsat.com_signatures_valid.msg"); try (InputStream stream = new FileInputStream(file)) { handleFile(stream, file.getPath()); diff --git a/src/integrationtest/org/apache/poi/stress/HSSFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HSSFFileHandler.java index 1069f23c25..9ee54b4790 100644 --- a/src/integrationtest/org/apache/poi/stress/HSSFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HSSFFileHandler.java @@ -36,7 +36,7 @@ import org.apache.poi.ss.usermodel.Sheet; import org.apache.poi.util.NullPrintStream; import org.junit.jupiter.api.Test; -public class HSSFFileHandler extends SpreadsheetHandler { +class HSSFFileHandler extends SpreadsheetHandler { private final POIFSFileHandler delegate = new POIFSFileHandler(); @Override public void handleFile(InputStream stream, String path) throws Exception { @@ -106,7 +106,7 @@ public class HSSFFileHandler extends SpreadsheetHandler { // a test-case to test this locally without executing the full TestAllFiles @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/spreadsheet/49219.xls"); try (InputStream stream = new FileInputStream(file)) { @@ -121,7 +121,7 @@ public class HSSFFileHandler extends SpreadsheetHandler { // a test-case to test this locally without executing the full TestAllFiles @Test @SuppressWarnings("java:S2699") - public void testExtractor() throws Exception { + void testExtractor() throws Exception { handleExtracting(new File("test-data/spreadsheet/BOOK_in_capitals.xls")); } } \ No newline at end of file diff --git a/src/integrationtest/org/apache/poi/stress/HSSFRecordsStresser.java b/src/integrationtest/org/apache/poi/stress/HSSFRecordsStresser.java index 24b30e8abd..e4bada54d4 100644 --- a/src/integrationtest/org/apache/poi/stress/HSSFRecordsStresser.java +++ b/src/integrationtest/org/apache/poi/stress/HSSFRecordsStresser.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; * Needs to be implemented in this package to have access to * HSSFWorkbook.getWorkbook() */ -public class HSSFRecordsStresser { +class HSSFRecordsStresser { public static void handleWorkbook(HSSFWorkbook wb) { List records = wb.getWorkbook().getRecords(); for(org.apache.poi.hssf.record.Record record : records) { @@ -65,7 +65,7 @@ public class HSSFRecordsStresser { // a test-case to test this locally without executing the full TestAllFiles @Test - public void test() throws Exception { + void test() throws Exception { try (InputStream stream = new FileInputStream(HSSFTestDataSamples.getSampleFile("15556.xls"))) { HSSFWorkbook wb = new HSSFWorkbook(stream); handleWorkbook(wb); diff --git a/src/integrationtest/org/apache/poi/stress/HWPFFileHandler.java b/src/integrationtest/org/apache/poi/stress/HWPFFileHandler.java index 260489c73e..da07a9b87b 100644 --- a/src/integrationtest/org/apache/poi/stress/HWPFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/HWPFFileHandler.java @@ -30,7 +30,7 @@ import org.apache.poi.hwpf.model.PicturesTable; import org.apache.poi.hwpf.usermodel.Picture; import org.junit.jupiter.api.Test; -public class HWPFFileHandler extends POIFSFileHandler { +class HWPFFileHandler extends POIFSFileHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { HWPFDocument doc = new HWPFDocument(stream); @@ -49,7 +49,7 @@ public class HWPFFileHandler extends POIFSFileHandler { @Override @Test @SuppressWarnings("java:S2699") - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/document/52117.doc"); try (InputStream stream = new FileInputStream(file)) { @@ -65,7 +65,7 @@ public class HWPFFileHandler extends POIFSFileHandler { } @Test - public void testExtractingOld() { + void testExtractingOld() { File file = new File("test-data/document/52117.doc"); assertDoesNotThrow(() -> handleExtracting(file)); } diff --git a/src/integrationtest/org/apache/poi/stress/OPCFileHandler.java b/src/integrationtest/org/apache/poi/stress/OPCFileHandler.java index 7746a37f49..c4f5485806 100644 --- a/src/integrationtest/org/apache/poi/stress/OPCFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/OPCFileHandler.java @@ -30,7 +30,7 @@ import org.apache.poi.openxml4j.opc.PackagePart; import org.apache.poi.xwpf.usermodel.XWPFRelation; import org.junit.jupiter.api.Test; -public class OPCFileHandler extends AbstractFileHandler { +class OPCFileHandler extends AbstractFileHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { // ignore password protected files @@ -61,7 +61,7 @@ public class OPCFileHandler extends AbstractFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/diagram/test.vsdx"); try (InputStream stream = new PushbackInputStream(new FileInputStream(file), 100000)) { diff --git a/src/integrationtest/org/apache/poi/stress/POIFSFileHandler.java b/src/integrationtest/org/apache/poi/stress/POIFSFileHandler.java index 99843096cd..b92f91f5f9 100644 --- a/src/integrationtest/org/apache/poi/stress/POIFSFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/POIFSFileHandler.java @@ -30,7 +30,7 @@ import org.apache.poi.hpsf.extractor.HPSFPropertiesExtractor; import org.apache.poi.poifs.filesystem.POIFSFileSystem; import org.junit.jupiter.api.Test; -public class POIFSFileHandler extends AbstractFileHandler { +class POIFSFileHandler extends AbstractFileHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { @@ -69,7 +69,7 @@ public class POIFSFileHandler extends AbstractFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/poifs/Notes.ole2"); try (InputStream stream = new FileInputStream(file)) { diff --git a/src/integrationtest/org/apache/poi/stress/POIFileScanner.java b/src/integrationtest/org/apache/poi/stress/POIFileScanner.java index 6d235f1566..b0703d3dc4 100644 --- a/src/integrationtest/org/apache/poi/stress/POIFileScanner.java +++ b/src/integrationtest/org/apache/poi/stress/POIFileScanner.java @@ -49,7 +49,7 @@ import org.junit.jupiter.api.Test; * * Can also be used to get the appropriate FileHandler for a single file. */ -public class POIFileScanner { +class POIFileScanner { private final static File ROOT_DIR; static { // when running in Gradle, current directory might be "build/integrationtest" @@ -195,7 +195,7 @@ public class POIFileScanner { @Disabled @Test @SuppressForbidden("Just an ignored test") - public void testInvalidFile() throws IOException, InterruptedException { + void testInvalidFile() throws IOException, InterruptedException { FileHandler fileHandler = POIFileScanner.getFileHandler(new File("/usbc/CommonCrawl"), "www.bgs.ac.uk_downloads_directdownload.cfm_id=2362&noexcl=true&t=west_20sussex_20-_20building_20stone_20quarries"); @@ -210,13 +210,13 @@ public class POIFileScanner { } @Test - public void testDetectUnnamedFile() throws IOException { + void testDetectUnnamedFile() throws IOException { File root = new File(ROOT_DIR, "spreadsheet"); assertDoesNotThrow(() -> POIFileScanner.detectUnnamedFile(root, "49156.xlsx")); } @Test - public void test() throws IOException { + void test() throws IOException { assertDoesNotThrow(() -> POIFileScanner.scan(ROOT_DIR)); } } diff --git a/src/integrationtest/org/apache/poi/stress/TestAllFiles.java b/src/integrationtest/org/apache/poi/stress/TestAllFiles.java index bd52eddef5..bc5d7abf61 100644 --- a/src/integrationtest/org/apache/poi/stress/TestAllFiles.java +++ b/src/integrationtest/org/apache/poi/stress/TestAllFiles.java @@ -68,7 +68,7 @@ import org.opentest4j.TestAbortedException; * here as well! This is to ensure that files that should not work really do not work, e.g. * that we do not remove expected sanity checks. */ -public class TestAllFiles { +class TestAllFiles { private static final File ROOT_DIR = new File("test-data"); private static final boolean IGNORE_SCRATCHPAD = Boolean.getBoolean("scratchpad.ignore"); @@ -384,7 +384,7 @@ public class TestAllFiles { // ... even when using a custom display name generator @ParameterizedTest(name = "#{index} {0}" ) @MethodSource("files") - public void testAllFiles(String file, FileHandler handler) throws Exception { + void testAllFiles(String file, FileHandler handler) throws Exception { assertNotNull(handler, "Did not find a handler for file " + file); // this also removes the password for non encrypted files diff --git a/src/integrationtest/org/apache/poi/stress/XDGFFileHandler.java b/src/integrationtest/org/apache/poi/stress/XDGFFileHandler.java index b48a8bafef..d588e4b496 100644 --- a/src/integrationtest/org/apache/poi/stress/XDGFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/XDGFFileHandler.java @@ -23,7 +23,7 @@ import org.apache.poi.openxml4j.opc.PackageAccess; import org.apache.poi.xdgf.usermodel.XmlVisioDocument; import org.junit.jupiter.api.Test; -public class XDGFFileHandler extends AbstractFileHandler { +class XDGFFileHandler extends AbstractFileHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { // ignore password protected files @@ -36,7 +36,7 @@ public class XDGFFileHandler extends AbstractFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Test @SuppressWarnings("java:S2699") - public void test() throws Exception { + void test() throws Exception { try (OPCPackage pkg = OPCPackage.open("test-data/diagram/test.vsdx", PackageAccess.READ)) { XmlVisioDocument doc = new XmlVisioDocument(pkg); new POIXMLDocumentHandler().handlePOIXMLDocument(doc); diff --git a/src/integrationtest/org/apache/poi/stress/XSLFFileHandler.java b/src/integrationtest/org/apache/poi/stress/XSLFFileHandler.java index 6c54be4f7e..da83b55823 100644 --- a/src/integrationtest/org/apache/poi/stress/XSLFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/XSLFFileHandler.java @@ -29,7 +29,7 @@ import org.apache.poi.xslf.usermodel.XMLSlideShow; import org.apache.poi.xslf.usermodel.XSLFSlideShow; import org.junit.jupiter.api.Test; -public class XSLFFileHandler extends SlideShowHandler { +class XSLFFileHandler extends SlideShowHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { XMLSlideShow slide = new XMLSlideShow(stream); @@ -71,7 +71,7 @@ public class XSLFFileHandler extends SlideShowHandler { // a test-case to test this locally without executing the full TestAllFiles @Override @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/slideshow/ca.ubc.cs.people_~emhill_presentations_HowWeRefactor.pptx"); try (InputStream stream = new FileInputStream(file)) { handleFile(stream, file.getPath()); diff --git a/src/integrationtest/org/apache/poi/stress/XSSFBFileHandler.java b/src/integrationtest/org/apache/poi/stress/XSSFBFileHandler.java index d2e4df1191..1bc23c49ed 100644 --- a/src/integrationtest/org/apache/poi/stress/XSSFBFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/XSSFBFileHandler.java @@ -16,7 +16,12 @@ ==================================================================== */ package org.apache.poi.stress; -import java.io.*; +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.File; +import java.io.FileInputStream; +import java.io.IOException; +import java.io.InputStream; import org.apache.poi.openxml4j.opc.OPCPackage; import org.apache.poi.openxml4j.opc.PackageAccess; @@ -26,7 +31,7 @@ import org.apache.poi.xssf.extractor.XSSFBEventBasedExcelExtractor; import org.apache.poi.xssf.usermodel.XSSFWorkbook; import org.junit.jupiter.api.Test; -public class XSSFBFileHandler extends AbstractFileHandler { +class XSSFBFileHandler extends AbstractFileHandler { static { //add expected failures here: @@ -81,7 +86,7 @@ public class XSSFBFileHandler extends AbstractFileHandler { } @Test - public void testLocal() throws Exception { + void testLocal() throws Exception { File file = new File("test-data/spreadsheet/Simple.xlsb"); try (FileInputStream stream = new FileInputStream(file)) { handleFile(stream, file.getPath()); diff --git a/src/integrationtest/org/apache/poi/stress/XSSFFileHandler.java b/src/integrationtest/org/apache/poi/stress/XSSFFileHandler.java index ec060dee05..68f07b55be 100644 --- a/src/integrationtest/org/apache/poi/stress/XSSFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/XSSFFileHandler.java @@ -57,7 +57,7 @@ import org.apache.poi.xssf.usermodel.XSSFWorkbook; import org.junit.jupiter.api.Test; import org.xml.sax.SAXException; -public class XSSFFileHandler extends SpreadsheetHandler { +class XSSFFileHandler extends SpreadsheetHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { // ignore password protected files if password is unknown @@ -205,7 +205,7 @@ public class XSSFFileHandler extends SpreadsheetHandler { // a test-case to test this locally without executing the full TestAllFiles @Test - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/spreadsheet/ref-56737.xlsx"); try (InputStream stream = new BufferedInputStream(new FileInputStream(file))) { @@ -216,7 +216,7 @@ public class XSSFFileHandler extends SpreadsheetHandler { } @Test - public void testAdditional() throws Exception { + void testAdditional() throws Exception { handleAdditional(new File("test-data/spreadsheet/poc-xmlbomb.xlsx")); } } diff --git a/src/integrationtest/org/apache/poi/stress/XWPFFileHandler.java b/src/integrationtest/org/apache/poi/stress/XWPFFileHandler.java index 92bfabbc49..c688c54758 100644 --- a/src/integrationtest/org/apache/poi/stress/XWPFFileHandler.java +++ b/src/integrationtest/org/apache/poi/stress/XWPFFileHandler.java @@ -24,7 +24,7 @@ import java.io.InputStream; import org.apache.poi.xwpf.usermodel.XWPFDocument; import org.junit.jupiter.api.Test; -public class XWPFFileHandler extends AbstractFileHandler { +class XWPFFileHandler extends AbstractFileHandler { @Override public void handleFile(InputStream stream, String path) throws Exception { // ignore password protected files @@ -38,7 +38,7 @@ public class XWPFFileHandler extends AbstractFileHandler { // a test-case to test this locally without executing the full TestAllFiles @Test @SuppressWarnings("java:S2699") - public void test() throws Exception { + void test() throws Exception { File file = new File("test-data/document/51921-Word-Crash067.docx"); try (InputStream stream = new BufferedInputStream(new FileInputStream(file))) { diff --git a/src/multimodule/integration/java9/module-info.java b/src/multimodule/integration/java9/module-info.java index 5dff7e4feb..b07b7079b7 100644 --- a/src/multimodule/integration/java9/module-info.java +++ b/src/multimodule/integration/java9/module-info.java @@ -24,4 +24,6 @@ module org.apache.poi.stress { requires org.apache.poi.examples; exports org.apache.poi.stress; + + opens org.apache.poi.stress to org.junit.platform.commons; } \ No newline at end of file diff --git a/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java b/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestCountifs.java similarity index 99% rename from src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java rename to src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestCountifs.java index 83aae9b297..902de11a80 100644 --- a/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java +++ b/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestCountifs.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; /** * Test the COUNTIFS() function */ -public class CountifsTests { +class TestCountifs { private Workbook workbook; diff --git a/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java b/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestConditionalFormattingEval.java similarity index 99% rename from src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java rename to src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestConditionalFormattingEval.java index d740699c16..4e6257c650 100644 --- a/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java +++ b/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestConditionalFormattingEval.java @@ -40,7 +40,7 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public class ConditionalFormattingEvalTest { +class TestConditionalFormattingEval { private XSSFWorkbook wb; private Sheet sheet; diff --git a/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java b/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/TestCombinedIterator.java similarity index 99% rename from src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java rename to src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/TestCombinedIterator.java index 03d739d83e..5679c28cd9 100644 --- a/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/CombinedIteratorTest.java +++ b/src/ooxml/testcases/org/apache/poi/xdgf/usermodel/section/TestCombinedIterator.java @@ -27,7 +27,7 @@ import java.util.TreeMap; import org.junit.jupiter.api.Test; -public class CombinedIteratorTest { +class TestCombinedIterator { void testIteration(CombinedIterable iterable, String... expected) { diff --git a/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java b/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFMemoryLeak.java similarity index 99% rename from src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java rename to src/ooxml/testcases/org/apache/poi/xssf/TestXSSFMemoryLeak.java index 63737632cc..bb9859998c 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFMemoryLeak.java @@ -46,7 +46,7 @@ import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTCell; * * E.g. verifies that objects are freed when stuff is removed from sheets or rows */ -public class XSSFMemoryLeakTests { +public class TestXSSFMemoryLeak { private final MemoryLeakVerifier verifier = new MemoryLeakVerifier(); // keep some items in memory, so checks in tearDown() actually diff --git a/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/XWPFAbstractNumTest.java b/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFAbstractNum.java similarity index 97% rename from src/ooxml/testcases/org/apache/poi/xwpf/usermodel/XWPFAbstractNumTest.java rename to src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFAbstractNum.java index 71974532e4..e71c3a2413 100644 --- a/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/XWPFAbstractNumTest.java +++ b/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFAbstractNum.java @@ -20,7 +20,7 @@ import static org.junit.jupiter.api.Assertions.assertNull; import org.junit.jupiter.api.Test; -public class XWPFAbstractNumTest { +public class TestXWPFAbstractNum { @Test void getXmlObject() { diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/BasePPTIteratingTest.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/BaseTestPPTIterating.java similarity index 99% rename from src/scratchpad/testcases/org/apache/poi/hslf/dev/BasePPTIteratingTest.java rename to src/scratchpad/testcases/org/apache/poi/hslf/dev/BaseTestPPTIterating.java index 24ea8ac966..869b96e4b8 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/BasePPTIteratingTest.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/BaseTestPPTIterating.java @@ -42,7 +42,7 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; -public abstract class BasePPTIteratingTest { +public abstract class BaseTestPPTIterating { protected static final Set OLD_FILES = new HashSet<>(); static { OLD_FILES.add("PPT95.ppt"); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPDrawingTextListing.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPDrawingTextListing.java index 5b135a5e88..206db2b20a 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPDrawingTextListing.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPDrawingTextListing.java @@ -16,16 +16,15 @@ ==================================================================== */ package org.apache.poi.hslf.dev; -import org.apache.poi.EmptyFileException; -import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.File; import java.io.IOException; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; +import org.apache.poi.EmptyFileException; +import org.junit.jupiter.api.Test; -public class TestPPDrawingTextListing extends BasePPTIteratingTest { +public class TestPPDrawingTextListing extends BaseTestPPTIterating { @Test void testMain() throws IOException { // calls System.exit(): PPDrawingTextListing.main(new String[0]); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPTXMLDump.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPTXMLDump.java index c70b25ec66..c0572750b6 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPTXMLDump.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestPPTXMLDump.java @@ -26,7 +26,7 @@ import org.apache.poi.EmptyFileException; import org.apache.poi.hslf.HSLFTestDataSamples; import org.junit.jupiter.api.Test; -public class TestPPTXMLDump extends BasePPTIteratingTest { +public class TestPPTXMLDump extends BaseTestPPTIterating { @Test void testMain() throws Exception { PPTXMLDump.main(new String[0]); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTListing.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTListing.java index 3dc19422f2..8ee2010fa7 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTListing.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTListing.java @@ -17,7 +17,6 @@ package org.apache.poi.hslf.dev; import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; import java.io.File; import java.io.IOException; @@ -29,7 +28,7 @@ import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; -public class TestSLWTListing extends BasePPTIteratingTest { +public class TestSLWTListing extends BaseTestPPTIterating { private static PrintStream oldStdErr; @BeforeAll diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTTextListing.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTTextListing.java index ced2727094..c61dd00b24 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTTextListing.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSLWTTextListing.java @@ -16,16 +16,15 @@ ==================================================================== */ package org.apache.poi.hslf.dev; -import org.apache.poi.EmptyFileException; -import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.File; import java.io.IOException; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; +import org.apache.poi.EmptyFileException; +import org.junit.jupiter.api.Test; -public class TestSLWTTextListing extends BasePPTIteratingTest { +public class TestSLWTTextListing extends BaseTestPPTIterating { @Test void testMain() throws IOException { // calls System.exit(): SLWTTextListing.main(new String[0]); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideAndNotesAtomListing.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideAndNotesAtomListing.java index cec26a035a..ea37f7d159 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideAndNotesAtomListing.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideAndNotesAtomListing.java @@ -16,17 +16,16 @@ ==================================================================== */ package org.apache.poi.hslf.dev; -import org.apache.poi.EmptyFileException; -import org.apache.poi.hslf.HSLFTestDataSamples; -import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.File; import java.io.IOException; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; +import org.apache.poi.EmptyFileException; +import org.apache.poi.hslf.HSLFTestDataSamples; +import org.junit.jupiter.api.Test; -public class TestSlideAndNotesAtomListing extends BasePPTIteratingTest { +public class TestSlideAndNotesAtomListing extends BaseTestPPTIterating { @Test void testMain() throws IOException { // calls System.exit(): SlideAndNotesAtomListing.main(new String[0]); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideIdListing.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideIdListing.java index 528b694886..b75bec5178 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideIdListing.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideIdListing.java @@ -16,17 +16,16 @@ ==================================================================== */ package org.apache.poi.hslf.dev; -import org.apache.poi.EmptyFileException; -import org.apache.poi.hslf.HSLFTestDataSamples; -import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.File; import java.io.IOException; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; +import org.apache.poi.EmptyFileException; +import org.apache.poi.hslf.HSLFTestDataSamples; +import org.junit.jupiter.api.Test; -public class TestSlideIdListing extends BasePPTIteratingTest { +public class TestSlideIdListing extends BaseTestPPTIterating { @Test void testMain() throws IOException { // calls System.exit(): SlideIdListing.main(new String[0]); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowDumper.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowDumper.java index d39cbdcfc1..51b9ee5d69 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowDumper.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowDumper.java @@ -17,7 +17,6 @@ package org.apache.poi.hslf.dev; import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; import java.io.File; import java.io.FileNotFoundException; @@ -31,7 +30,7 @@ import org.apache.poi.hslf.HSLFTestDataSamples; import org.apache.poi.util.IOUtils; import org.junit.jupiter.api.Test; -public class TestSlideShowDumper extends BasePPTIteratingTest { +public class TestSlideShowDumper extends BaseTestPPTIterating { private static final Set FAILING = new HashSet<>(); static { FAILING.add("cryptoapi-proc2356.ppt"); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowRecordDumper.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowRecordDumper.java index 8d24389302..4392ec603a 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowRecordDumper.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestSlideShowRecordDumper.java @@ -17,7 +17,6 @@ package org.apache.poi.hslf.dev; import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; import java.io.File; import java.io.IOException; @@ -26,7 +25,7 @@ import org.apache.poi.EmptyFileException; import org.apache.poi.hslf.HSLFTestDataSamples; import org.junit.jupiter.api.Test; -public class TestSlideShowRecordDumper extends BasePPTIteratingTest { +public class TestSlideShowRecordDumper extends BaseTestPPTIterating { @Test void testMain() throws IOException { SlideShowRecordDumper.main(new String[] { diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestTextStyleListing.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestTextStyleListing.java index d5c4892e18..5a5d826ef1 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestTextStyleListing.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestTextStyleListing.java @@ -16,18 +16,17 @@ ==================================================================== */ package org.apache.poi.hslf.dev; -import org.apache.poi.EmptyFileException; -import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.File; import java.io.IOException; import java.util.HashSet; import java.util.Set; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; +import org.apache.poi.EmptyFileException; +import org.junit.jupiter.api.Test; -public class TestTextStyleListing extends BasePPTIteratingTest { +public class TestTextStyleListing extends BaseTestPPTIterating { private static Set FAILING = new HashSet<>(); static { FAILING.add("empty_textbox.ppt"); diff --git a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestUserEditAndPersistListing.java b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestUserEditAndPersistListing.java index cfa2575e50..c284ce1ba3 100644 --- a/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestUserEditAndPersistListing.java +++ b/src/scratchpad/testcases/org/apache/poi/hslf/dev/TestUserEditAndPersistListing.java @@ -16,16 +16,15 @@ ==================================================================== */ package org.apache.poi.hslf.dev; -import org.apache.poi.EmptyFileException; -import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.File; import java.io.IOException; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; +import org.apache.poi.EmptyFileException; +import org.junit.jupiter.api.Test; -public class TestUserEditAndPersistListing extends BasePPTIteratingTest { +public class TestUserEditAndPersistListing extends BaseTestPPTIterating { @Test void testMain() throws IOException { // calls System.exit(): UserEditAndPersistListing.main(new String[0]); diff --git a/src/scratchpad/testcases/org/apache/poi/hwpf/converter/AbstractWordUtilsTest.java b/src/scratchpad/testcases/org/apache/poi/hwpf/converter/TestAbstractWordUtils.java similarity index 98% rename from src/scratchpad/testcases/org/apache/poi/hwpf/converter/AbstractWordUtilsTest.java rename to src/scratchpad/testcases/org/apache/poi/hwpf/converter/TestAbstractWordUtils.java index 840e90264f..f666517e51 100644 --- a/src/scratchpad/testcases/org/apache/poi/hwpf/converter/AbstractWordUtilsTest.java +++ b/src/scratchpad/testcases/org/apache/poi/hwpf/converter/TestAbstractWordUtils.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for {@link AbstractWordUtils} */ -public class AbstractWordUtilsTest { +public class TestAbstractWordUtils { /** * Test case for {@link AbstractWordUtils#buildTableCellEdgesArray(Table)} */ diff --git a/src/scratchpad/testcases/org/apache/poi/hwpf/model/PlfLfoTest.java b/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlfLfo.java similarity index 98% rename from src/scratchpad/testcases/org/apache/poi/hwpf/model/PlfLfoTest.java rename to src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlfLfo.java index c1ae598fb0..a18902ad8d 100644 --- a/src/scratchpad/testcases/org/apache/poi/hwpf/model/PlfLfoTest.java +++ b/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlfLfo.java @@ -24,7 +24,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; import org.junit.jupiter.api.Test; -public class PlfLfoTest { +public class TestPlfLfo { @Test void testAdd() { PlfLfo p = new PlfLfo(new byte[] {0, 0, 0, 0}, 0, 0); diff --git a/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/LFOLVLBaseAbstractTypeTest.java b/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/TestLFOLVLBaseAbstractType.java similarity index 96% rename from src/scratchpad/testcases/org/apache/poi/hwpf/model/types/LFOLVLBaseAbstractTypeTest.java rename to src/scratchpad/testcases/org/apache/poi/hwpf/model/types/TestLFOLVLBaseAbstractType.java index 3cae7ce951..aa986a558f 100644 --- a/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/LFOLVLBaseAbstractTypeTest.java +++ b/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/TestLFOLVLBaseAbstractType.java @@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for {@link LFOLVLBaseAbstractType} */ -public class LFOLVLBaseAbstractTypeTest { +class TestLFOLVLBaseAbstractType { @Test void testGetSize() { assertEquals( 8, LFOLVLBaseAbstractType.getSize() ); diff --git a/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/LVLFAbstractTypeTest.java b/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/TestLVLFAbstractType.java similarity index 97% rename from src/scratchpad/testcases/org/apache/poi/hwpf/model/types/LVLFAbstractTypeTest.java rename to src/scratchpad/testcases/org/apache/poi/hwpf/model/types/TestLVLFAbstractType.java index 2f3d1d90a5..d48fa9e4f5 100644 --- a/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/LVLFAbstractTypeTest.java +++ b/src/scratchpad/testcases/org/apache/poi/hwpf/model/types/TestLVLFAbstractType.java @@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for {@link LVLFAbstractType} */ -public class LVLFAbstractTypeTest { +class TestLVLFAbstractType { @Test void testGetSize() { assertEquals( 28, LVLFAbstractType.getSize() ); diff --git a/src/testcases/org/apache/poi/TestPOIDocumentMain.java b/src/testcases/org/apache/poi/TestPOIDocumentMain.java index 69311605d9..c2c44529b8 100644 --- a/src/testcases/org/apache/poi/TestPOIDocumentMain.java +++ b/src/testcases/org/apache/poi/TestPOIDocumentMain.java @@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test; * This is part 1 of 2 of the tests - it only does the POIDocuments * which are part of the Main (not scratchpad) */ -public final class TestPOIDocumentMain { +final class TestPOIDocumentMain { // The POI Documents to work on private POIDocument doc; private POIDocument doc2; diff --git a/src/testcases/org/apache/poi/TestPOITestCase.java b/src/testcases/org/apache/poi/TestPOITestCase.java index ffb65c3919..862d0d7e46 100644 --- a/src/testcases/org/apache/poi/TestPOITestCase.java +++ b/src/testcases/org/apache/poi/TestPOITestCase.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; /** * A class for testing the POI Junit TestCase utility class */ -public final class TestPOITestCase { +final class TestPOITestCase { @Test void assertStartsWith() { POITestCase.assertStartsWith("Apache POI", ""); diff --git a/src/testcases/org/apache/poi/ddf/TestEscherBSERecord.java b/src/testcases/org/apache/poi/ddf/TestEscherBSERecord.java index 1ddb8afa3e..43edb89d0c 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherBSERecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherBSERecord.java @@ -28,7 +28,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestEscherBSERecord { +final class TestEscherBSERecord { @Test void testFillFields() { String data = "01 00 00 00 24 00 00 00 05 05 01 02 03 04 " + diff --git a/src/testcases/org/apache/poi/ddf/TestEscherBlipRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherBlipRecord.java index 7ce2f22a2e..a081f61c65 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherBlipRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherBlipRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Test read/serialize of escher blip records */ -public final class TestEscherBlipRecord { +final class TestEscherBlipRecord { private static final POIDataSamples _samples = POIDataSamples.getDDFInstance(); //test reading/serializing of a PNG blip diff --git a/src/testcases/org/apache/poi/ddf/TestEscherBoolProperty.java b/src/testcases/org/apache/poi/ddf/TestEscherBoolProperty.java index 3d62c6a457..4957c063d5 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherBoolProperty.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherBoolProperty.java @@ -21,7 +21,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import org.junit.jupiter.api.Test; -public final class TestEscherBoolProperty { +final class TestEscherBoolProperty { @Test void testToString() { EscherBoolProperty p = new EscherBoolProperty(EscherPropertyTypes.GEOMETRY__FILLOK, 1); diff --git a/src/testcases/org/apache/poi/ddf/TestEscherChildAnchorRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherChildAnchorRecord.java index cd70f8223f..9f24b6d18d 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherChildAnchorRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherChildAnchorRecord.java @@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestEscherChildAnchorRecord { +final class TestEscherChildAnchorRecord { @Test void testSerialize() { EscherChildAnchorRecord r = createRecord(); diff --git a/src/testcases/org/apache/poi/ddf/TestEscherContainerRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherContainerRecord.java index fb8559e89d..df13975197 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherContainerRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherContainerRecord.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link EscherContainerRecord} */ -public final class TestEscherContainerRecord { +final class TestEscherContainerRecord { private static final POIDataSamples _samples = POIDataSamples.getDDFInstance(); @Test diff --git a/src/testcases/org/apache/poi/ddf/TestEscherDgRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherDgRecord.java index 5407c23339..ad84a54585 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherDgRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherDgRecord.java @@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestEscherDgRecord { +final class TestEscherDgRecord { @Test void testSerialize() { EscherDgRecord r = createRecord(); diff --git a/src/testcases/org/apache/poi/ddf/TestEscherDggRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherDggRecord.java index 75d3cdcbc3..f8f8b58115 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherDggRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherDggRecord.java @@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestEscherDggRecord { +final class TestEscherDggRecord { @Test void testSerialize() { EscherDggRecord r = createRecord(); diff --git a/src/testcases/org/apache/poi/ddf/TestEscherOptRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherOptRecord.java index bac1991a6b..c09dc223c2 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherOptRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherOptRecord.java @@ -27,7 +27,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestEscherOptRecord { +final class TestEscherOptRecord { @Test void testFillFields() { diff --git a/src/testcases/org/apache/poi/ddf/TestEscherSpgrRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherSpgrRecord.java index 6e3ae093ef..8aa7aa86d9 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherSpgrRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherSpgrRecord.java @@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestEscherSpgrRecord { +final class TestEscherSpgrRecord { @Test void testSerialize() { EscherSpgrRecord r = createRecord(); diff --git a/src/testcases/org/apache/poi/ddf/TestEscherSplitMenuColorsRecord.java b/src/testcases/org/apache/poi/ddf/TestEscherSplitMenuColorsRecord.java index 59584ec0e7..1aa96edc5c 100644 --- a/src/testcases/org/apache/poi/ddf/TestEscherSplitMenuColorsRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestEscherSplitMenuColorsRecord.java @@ -23,7 +23,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestEscherSplitMenuColorsRecord { +final class TestEscherSplitMenuColorsRecord { @Test void testSerialize() { EscherSplitMenuColorsRecord r = createRecord(); diff --git a/src/testcases/org/apache/poi/ddf/TestUnknownEscherRecord.java b/src/testcases/org/apache/poi/ddf/TestUnknownEscherRecord.java index d6afeaa8ff..d84f8bccee 100644 --- a/src/testcases/org/apache/poi/ddf/TestUnknownEscherRecord.java +++ b/src/testcases/org/apache/poi/ddf/TestUnknownEscherRecord.java @@ -25,7 +25,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestUnknownEscherRecord { +final class TestUnknownEscherRecord { @Test void testFillFields() { String testData = diff --git a/src/testcases/org/apache/poi/hpsf/basic/TestBasic.java b/src/testcases/org/apache/poi/hpsf/basic/TestBasic.java index 34a6169aa1..6d95b38450 100644 --- a/src/testcases/org/apache/poi/hpsf/basic/TestBasic.java +++ b/src/testcases/org/apache/poi/hpsf/basic/TestBasic.java @@ -48,7 +48,7 @@ import org.junit.jupiter.api.Test; /** *

Tests the basic HPSF functionality.

*/ -public final class TestBasic { +final class TestBasic { private static final POIDataSamples samples = POIDataSamples.getHPSFInstance(); diff --git a/src/testcases/org/apache/poi/hpsf/basic/TestClassID.java b/src/testcases/org/apache/poi/hpsf/basic/TestClassID.java index fc93ddcec9..ac50ec591d 100644 --- a/src/testcases/org/apache/poi/hpsf/basic/TestClassID.java +++ b/src/testcases/org/apache/poi/hpsf/basic/TestClassID.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; /** * Tests ClassID structure. */ -public final class TestClassID { +final class TestClassID { private static final byte[] BUF16 = {1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16}; diff --git a/src/testcases/org/apache/poi/hpsf/basic/TestEmptyProperties.java b/src/testcases/org/apache/poi/hpsf/basic/TestEmptyProperties.java index aec8860068..9ef1289461 100644 --- a/src/testcases/org/apache/poi/hpsf/basic/TestEmptyProperties.java +++ b/src/testcases/org/apache/poi/hpsf/basic/TestEmptyProperties.java @@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test; * Test case for OLE2 files with empty properties. * An empty property's type is {@link Variant#VT_EMPTY}. */ -public final class TestEmptyProperties { +final class TestEmptyProperties { private static final POIDataSamples samples = POIDataSamples.getHPSFInstance(); diff --git a/src/testcases/org/apache/poi/hpsf/basic/TestHPSFBugs.java b/src/testcases/org/apache/poi/hpsf/basic/TestHPSFBugs.java index db5a866523..6205713fa3 100644 --- a/src/testcases/org/apache/poi/hpsf/basic/TestHPSFBugs.java +++ b/src/testcases/org/apache/poi/hpsf/basic/TestHPSFBugs.java @@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test; /** * Tests various bugs have been fixed */ -public final class TestHPSFBugs { +final class TestHPSFBugs { private static final POIDataSamples _samples = POIDataSamples.getHPSFInstance(); /** diff --git a/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java b/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java index 989a83d384..f8fb0aad13 100644 --- a/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java +++ b/src/testcases/org/apache/poi/hpsf/basic/TestMetaDataIPI.java @@ -46,7 +46,7 @@ import org.junit.jupiter.api.Test; * This class tests reading and writing of meta data. No actual document is created. All information * is stored in a virtual document in a ByteArrayOutputStream */ -public final class TestMetaDataIPI { +final class TestMetaDataIPI { private POIFSFileSystem poifs ; private DocumentSummaryInformation dsi; diff --git a/src/testcases/org/apache/poi/hpsf/extractor/TestHPSFPropertiesExtractor.java b/src/testcases/org/apache/poi/hpsf/extractor/TestHPSFPropertiesExtractor.java index 3f05f1729d..85d7d02b89 100644 --- a/src/testcases/org/apache/poi/hpsf/extractor/TestHPSFPropertiesExtractor.java +++ b/src/testcases/org/apache/poi/hpsf/extractor/TestHPSFPropertiesExtractor.java @@ -32,7 +32,7 @@ import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.apache.poi.poifs.filesystem.POIFSFileSystem; import org.junit.jupiter.api.Test; -public final class TestHPSFPropertiesExtractor { +final class TestHPSFPropertiesExtractor { private static final POIDataSamples _samples = POIDataSamples.getHPSFInstance(); @Test diff --git a/src/testcases/org/apache/poi/hssf/eventmodel/TestAbortableListener.java b/src/testcases/org/apache/poi/hssf/eventmodel/TestAbortableListener.java index c3f43af19e..058e1eda09 100644 --- a/src/testcases/org/apache/poi/hssf/eventmodel/TestAbortableListener.java +++ b/src/testcases/org/apache/poi/hssf/eventmodel/TestAbortableListener.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link AbortableHSSFListener} */ -public final class TestAbortableListener { +final class TestAbortableListener { private POIFSFileSystem openSample() throws IOException { ByteArrayInputStream is = new ByteArrayInputStream(HSSFITestDataProvider.instance diff --git a/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java b/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java index 49ef3a0e44..8bb1b6771c 100644 --- a/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java +++ b/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java @@ -39,14 +39,13 @@ import org.apache.poi.hssf.record.RecordFactory; import org.apache.poi.hssf.record.StandardRecord; import org.apache.poi.hssf.record.TestcaseRecordInputStream; import org.apache.poi.hssf.record.UnknownRecord; -import org.apache.poi.util.NotImplemented; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; /** * enclosing_type describe the purpose here */ -public final class TestEventRecordFactory { +final class TestEventRecordFactory { private static final byte[][] CONTINUE_DATA = { // an unknown record with 0 length {0, -1, 0, 0,}, diff --git a/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java b/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java index 75e9289121..fcd9d81dbc 100644 --- a/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java +++ b/src/testcases/org/apache/poi/hssf/eventusermodel/TestEventWorkbookBuilder.java @@ -42,7 +42,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link EventWorkbookBuilder} */ -public final class TestEventWorkbookBuilder { +final class TestEventWorkbookBuilder { private final List fRecs = new ArrayList<>(); private SheetRecordCollectingListener listener; diff --git a/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java b/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java index 4b2672cfff..74ac31845d 100644 --- a/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java +++ b/src/testcases/org/apache/poi/hssf/eventusermodel/TestFormatTrackingHSSFListener.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * Tests for FormatTrackingHSSFListener */ -public final class TestFormatTrackingHSSFListener { +final class TestFormatTrackingHSSFListener { private FormatTrackingHSSFListener listener; private MockHSSFListener mockListen; diff --git a/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java b/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java index 37bc38eb37..24fba3e492 100644 --- a/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java +++ b/src/testcases/org/apache/poi/hssf/eventusermodel/TestHSSFEventFactory.java @@ -46,7 +46,7 @@ import org.junit.jupiter.api.Test; /** * Testing for {@link HSSFEventFactory} */ -public final class TestHSSFEventFactory { +final class TestHSSFEventFactory { private final List records = new ArrayList<>(); private void openSample(String sampleFileName) throws IOException { diff --git a/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java b/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java index 98e7c1c4d9..852f07e9de 100644 --- a/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java +++ b/src/testcases/org/apache/poi/hssf/eventusermodel/TestMissingRecordAwareHSSFListener.java @@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test; /** * Tests for MissingRecordAwareHSSFListener */ -public final class TestMissingRecordAwareHSSFListener { +final class TestMissingRecordAwareHSSFListener { private final List _records = new ArrayList<>(); diff --git a/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java b/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java index 20ca15d581..7a5ceef5f1 100644 --- a/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java +++ b/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; /** * */ -public final class TestExcelExtractor { +final class TestExcelExtractor { private static ExcelExtractor createExtractor(String sampleFileName) throws IOException { File file = HSSFTestDataSamples.getSampleFile(sampleFileName); POIFSFileSystem fs = new POIFSFileSystem(file); diff --git a/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java b/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java index c2085841d7..3fb037c93e 100644 --- a/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java +++ b/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java @@ -46,7 +46,7 @@ import org.junit.jupiter.api.Test; * Unit tests for the Excel 5/95 and Excel 4 (and older) text * extractor */ -public final class TestOldExcelExtractor { +final class TestOldExcelExtractor { private static OldExcelExtractor createExtractor(String sampleFileName) throws IOException { File file = HSSFTestDataSamples.getSampleFile(sampleFileName); return new OldExcelExtractor(file); diff --git a/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java b/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java index a9bd7a9015..7dfcd66940 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java +++ b/src/testcases/org/apache/poi/hssf/model/TestDrawingManager2.java @@ -24,7 +24,7 @@ import org.apache.poi.ddf.EscherDggRecord; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public final class TestDrawingManager2 { +final class TestDrawingManager2 { private DrawingManager2 drawingManager2; private EscherDggRecord dgg; diff --git a/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java b/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java index 024960310f..0e8964daee 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java +++ b/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java @@ -57,7 +57,7 @@ import org.junit.jupiter.api.Test; * Test the low level formula parser functionality. High level tests are to * be done via usermodel/HSSFCell.setFormulaValue(). */ -public final class TestFormulaParser { +final class TestFormulaParser { /** * @return parsed token array already confirmed not null diff --git a/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java b/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java index 6447fa21bf..8b41f96879 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java +++ b/src/testcases/org/apache/poi/hssf/model/TestFormulaParserEval.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; * but using parts which need to use * HSSFFormulaEvaluator. */ -public final class TestFormulaParserEval { +final class TestFormulaParserEval { @Test void testWithNamedRange() { diff --git a/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java b/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java index 066408104a..f9c06bbedb 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java +++ b/src/testcases/org/apache/poi/hssf/model/TestFormulaParserIf.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; /** * Tests FormulaParser specifically with respect to IF() functions */ -public final class TestFormulaParserIf { +final class TestFormulaParserIf { private static Ptg[] parseFormula(String formula) { return TestFormulaParser.parseFormula(formula); } diff --git a/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java b/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java index d9ce8b98fb..32e3736d0c 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java +++ b/src/testcases/org/apache/poi/hssf/model/TestLinkTable.java @@ -49,7 +49,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link LinkTable} */ -public final class TestLinkTable { +final class TestLinkTable { /** * The example file attached to bugzilla 45046 is a clear example of Name records being present diff --git a/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java b/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java index 6d752d1f40..f36ee053a8 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java +++ b/src/testcases/org/apache/poi/hssf/model/TestOperandClassTransformer.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; /** * Tests specific formula examples in OperandClassTransformer. */ -public final class TestOperandClassTransformer { +final class TestOperandClassTransformer { private static Ptg[] parseFormula(String formula) { Ptg[] result = HSSFFormulaParser.parse(formula, null); diff --git a/src/testcases/org/apache/poi/hssf/model/TestRVA.java b/src/testcases/org/apache/poi/hssf/model/TestRVA.java index c8c4e2ee9b..488a9e6fc5 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestRVA.java +++ b/src/testcases/org/apache/poi/hssf/model/TestRVA.java @@ -19,7 +19,6 @@ package org.apache.poi.hssf.model; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; import java.util.ArrayList; import java.util.List; @@ -45,7 +44,7 @@ import org.junit.jupiter.params.provider.MethodSource; * OperandClassTransformer by comparing its results with those * directly produced by Excel (in a sample spreadsheet). */ -public final class TestRVA { +final class TestRVA { private static final String NEW_LINE = System.getProperty("line.separator"); private static POIFSFileSystem poifs; diff --git a/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java b/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java index 5affa8bae9..fde901216b 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java +++ b/src/testcases/org/apache/poi/hssf/model/TestRowBlocksReader.java @@ -21,7 +21,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; import java.util.Arrays; @@ -39,7 +38,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestRowBlocksReader { +final class TestRowBlocksReader { @Test void testAbnormalPivotTableRecords_bug46280() { int SXVIEW_SID = ViewDefinitionRecord.sid; diff --git a/src/testcases/org/apache/poi/hssf/model/TestSheet.java b/src/testcases/org/apache/poi/hssf/model/TestSheet.java index 5818285a67..aef0c5e40b 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestSheet.java +++ b/src/testcases/org/apache/poi/hssf/model/TestSheet.java @@ -50,7 +50,7 @@ import org.junit.jupiter.api.Test; /** * Unit test for the {@link InternalSheet} class. */ -public final class TestSheet { +final class TestSheet { private static InternalSheet createSheet(List inRecs) { return InternalSheet.createSheet(new RecordStream(inRecs, 0)); } diff --git a/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java b/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java index de076476d3..c58dd39849 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java +++ b/src/testcases/org/apache/poi/hssf/model/TestSheetAdditional.java @@ -23,7 +23,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import org.apache.poi.hssf.record.ColumnInfoRecord; import org.junit.jupiter.api.Test; -public final class TestSheetAdditional { +final class TestSheetAdditional { @Test void testGetCellWidth() { InternalSheet sheet = InternalSheet.createSheet(); diff --git a/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java b/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java index 687225b9fe..ba63dc70b7 100644 --- a/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java +++ b/src/testcases/org/apache/poi/hssf/model/TestWorkbook.java @@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test; /** * Unit test for the Workbook class. */ -public final class TestWorkbook { +final class TestWorkbook { @Test void testFontStuff() throws IOException { HSSFWorkbook hwb = new HSSFWorkbook(); diff --git a/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java b/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java index 7018ff54ae..8433fb4cb1 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestArrayRecord.java @@ -33,7 +33,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestArrayRecord { +final class TestArrayRecord { @Test void testRead() { diff --git a/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java b/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java index 3288b75131..9c855f8b3e 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestAutoFilterInfoRecord.java @@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test; /** * Tests the AutoFilterInfoRecord class. */ -public final class TestAutoFilterInfoRecord { +final class TestAutoFilterInfoRecord { private final byte[] data = new byte[] { 0x05, 0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java b/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java index 45af19a12e..bbf5bf3549 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestBOFRecord.java @@ -26,7 +26,7 @@ import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.apache.poi.ss.usermodel.Sheet; import org.junit.jupiter.api.Test; -public final class TestBOFRecord { +final class TestBOFRecord { @Test void testBOFRecord() throws IOException { // This used to throw an error before - #42794 diff --git a/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java b/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java index 04ab3d3bb2..700f415f07 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestBoolErrRecord.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link BoolErrRecord} */ -public final class TestBoolErrRecord { +final class TestBoolErrRecord { @Test void testError() { diff --git a/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java b/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java index 79ea46e9d7..3ee14a90ba 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestBoundSheetRecord.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Tests BoundSheetRecord. */ -public final class TestBoundSheetRecord { +final class TestBoundSheetRecord { @Test void testRecordLength() { diff --git a/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java b/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java index 6551b42d50..0a43dbfdb6 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestCFHeaderRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the {@link CFHeaderRecord} * and {@link CFHeader12Record} classes works correctly. */ -public final class TestCFHeaderRecord { +final class TestCFHeaderRecord { @Test void testCreateCFHeaderRecord () { CFHeaderRecord record = new CFHeaderRecord(); diff --git a/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java b/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java index ac8346d053..81689f140c 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestCFRuleRecord.java @@ -48,7 +48,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the TestCFRuleRecord * class works correctly. */ -public final class TestCFRuleRecord { +final class TestCFRuleRecord { @Test void testConstructors () throws IOException { try (HSSFWorkbook workbook = new HSSFWorkbook()) { diff --git a/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java b/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java index dff4b02a04..6d472b9c2b 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestColumnInfoRecord.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link ColumnInfoRecord} */ -public final class TestColumnInfoRecord { +final class TestColumnInfoRecord { @Test void testBasic() { diff --git a/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java b/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java index 49ae12cb3b..5fccfd0975 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestCommonObjectDataSubRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestCommonObjectDataSubRecord { +final class TestCommonObjectDataSubRecord { byte[] data = new byte[] { (byte)0x12,(byte)0x00,(byte)0x01,(byte)0x00, (byte)0x01,(byte)0x00,(byte)0x11,(byte)0x60, diff --git a/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java b/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java index e95f4d31ab..00b25ac225 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestDVALRecord.java @@ -25,7 +25,7 @@ import java.io.ByteArrayInputStream; import org.apache.poi.util.LittleEndian; import org.junit.jupiter.api.Test; -public final class TestDVALRecord { +final class TestDVALRecord { @Test void testRead() { byte[] data = new byte[22]; diff --git a/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java b/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java index 0526812a0d..e7c97e86ec 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestDrawingGroupRecord.java @@ -25,7 +25,7 @@ import org.apache.poi.ddf.EscherSpRecord; import org.apache.poi.util.HexDump; import org.junit.jupiter.api.Test; -public final class TestDrawingGroupRecord { +final class TestDrawingGroupRecord { private static final int MAX_RECORD_SIZE = 8228; private static final int MAX_DATA_SIZE = MAX_RECORD_SIZE - 4; diff --git a/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java b/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java index 764f25fe29..bac766e08a 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestDrawingRecord.java @@ -29,7 +29,7 @@ import java.util.List; import org.junit.jupiter.api.Test; -public final class TestDrawingRecord { +final class TestDrawingRecord { /** * Check that RecordFactoryInputStream properly handles continued DrawingRecords diff --git a/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java b/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java index b33166ebbb..0f936fd405 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestEmbeddedObjectRefSubRecord.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the TestEmbeddedObjectRefSubRecord * class works correctly. Test data taken directly from a real Excel file. */ -public final class TestEmbeddedObjectRefSubRecord { +final class TestEmbeddedObjectRefSubRecord { private static final short EORSR_SID = EmbeddedObjectRefSubRecord.sid; diff --git a/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java b/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java index 3a13816982..0a69b6554f 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestEndSubRecord.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the EndSubRecord * class works correctly. Test data taken directly from a real Excel file. */ -public final class TestEndSubRecord { +final class TestEndSubRecord { private static final byte[] data = { }; @Test diff --git a/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java b/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java index a8f1c1f170..3578a8d99b 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java +++ b/src/testcases/org/apache/poi/hssf/record/TestEscherAggregate.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Tests the EscherAggregate class. */ -public final class TestEscherAggregate { +final class TestEscherAggregate { /** * Tests that the create aggregate method correctly rejoins escher records together. */ diff --git a/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java b/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java index d1fd7dd97e..6b0933cc31 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestExtSSTRecord.java @@ -26,7 +26,7 @@ import java.io.IOException; import org.apache.poi.poifs.storage.RawDataUtil; import org.junit.jupiter.api.Test; -public final class TestExtSSTRecord { +final class TestExtSSTRecord { /** * ExtSSTRecord can be continued. Ensure we properly read the continue remainder. diff --git a/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java b/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java index 322ce95bdf..f4d191d69f 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestExtendedFormatRecord.java @@ -22,7 +22,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import org.junit.jupiter.api.Test; -public final class TestExtendedFormatRecord { +final class TestExtendedFormatRecord { private static final byte[] data = { 0, 0, // Font 0 diff --git a/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java b/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java index 9fb1602b20..41372882c6 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestExternalNameRecord.java @@ -28,7 +28,7 @@ import org.apache.poi.util.HexDump; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestExternalNameRecord { +final class TestExternalNameRecord { private static final byte[] dataFDS = { 0, 0, 0, 0, 0, 0, 3, 0, 70, 68, 83, 0, 0, diff --git a/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java b/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java index a7a34a58e2..c6a9cd9581 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestFeatRecord.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; /** * Tests for FeatRecord */ -public final class TestFeatRecord { +final class TestFeatRecord { @Test void testWithoutFeatRecord() throws Exception { HSSFWorkbook hssf = diff --git a/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java b/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java index a9fb1aea28..2dbaeb4818 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestFontRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the {@link FontRecord} * class works correctly. Test data taken directly from a real Excel file. */ -public final class TestFontRecord { +final class TestFontRecord { private static final int SID = 0x31; private static final byte[] data = { diff --git a/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java b/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java index af4bb2c927..623588ffee 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestFormulaRecord.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link FormulaRecord} */ -public final class TestFormulaRecord { +final class TestFormulaRecord { @Test void testCreateFormulaRecord () { diff --git a/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java b/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java index fa0aa8882f..2804fe3d71 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestFtCblsSubRecord.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the FtCblsSubRecord * class works correctly. */ -public final class TestFtCblsSubRecord { +final class TestFtCblsSubRecord { private final byte[] data = new byte[] { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x64, 0x00, 0x01, 0x00, 0x0A, 0x00, 0x00, 0x00, 0x10, 0x00, 0x01, 0x00 diff --git a/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java b/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java index 2ac1126ba8..a372d11685 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestHyperlinkRecord.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; /** * Test HyperlinkRecord */ -public final class TestHyperlinkRecord { +final class TestHyperlinkRecord { //link to http://www.lakings.com/ private static final byte[] data1 = { diff --git a/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java b/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java index 47e92fbed6..169efaf2ad 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestInterfaceEndRecord.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestInterfaceEndRecord { +final class TestInterfaceEndRecord { @Test void testCreate() { diff --git a/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java b/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java index dd005ed4f8..84946bd6b2 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestLabelRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Tests for LabelRecord */ -public final class TestLabelRecord { +final class TestLabelRecord { @Test void testEmptyString() throws IOException { diff --git a/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java b/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java index 759181a605..afd988fb37 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestLbsDataSubRecord.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; /** * Tests the serialization and deserialization of the LbsDataSubRecord class works correctly. */ -public final class TestLbsDataSubRecord { +final class TestLbsDataSubRecord { /** * test read-write round trip diff --git a/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java b/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java index 6ab7a1dec5..7e9e1da0d0 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestMergeCellsRecord.java @@ -19,12 +19,9 @@ package org.apache.poi.hssf.record; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotSame; -import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertTrue; -import java.util.ArrayList; import java.util.Collections; -import java.util.List; import org.apache.poi.hssf.model.RecordStream; import org.apache.poi.hssf.record.aggregates.MergedCellsTable; @@ -35,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Make sure the merge cells record behaves */ -public final class TestMergeCellsRecord { +final class TestMergeCellsRecord { /** * Make sure when a clone is called, we actually clone it. diff --git a/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java b/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java index 555153e409..9884379747 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestNameCommentRecord.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; /** * Tests the NameCommentRecord serializes/deserializes correctly */ -public final class TestNameCommentRecord { +final class TestNameCommentRecord { @Test void testReserialize() { final byte[] data = HexRead diff --git a/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java b/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java index 34475b59aa..12da160752 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestNameRecord.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; /** * Tests the NameRecord serializes/deserializes correctly */ -public final class TestNameRecord { +final class TestNameRecord { /** * Makes sure that additional name information is parsed properly such as menu/description diff --git a/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java b/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java index eec2c29929..b59541da10 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestNoteRecord.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestNoteRecord { +final class TestNoteRecord { private final byte[] testData = HexRead.readFromString( "06 00 01 00 02 00 02 04 " + "1A 00 00 " + diff --git a/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java b/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java index 5f55d50c33..9aa690b79f 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestNoteStructureSubRecord.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestNoteStructureSubRecord { +final class TestNoteStructureSubRecord { private final byte[] data = new byte[] { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, (byte)0x80, 0x00, 0x00, 0x00, 0x00, 0x00, (byte)0xBF, 0x00, 0x00, 0x00, 0x00, 0x00, (byte)0x81, 0x01, diff --git a/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java b/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java index 325bfbac01..f797358de9 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestObjRecord.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the ObjRecord class works correctly. * Test data taken directly from a real Excel file. */ -public final class TestObjRecord { +final class TestObjRecord { /** * OBJ record data containing two sub-records. * The data taken directly from a real Excel file. diff --git a/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java b/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java index bae54fad14..3f27f64108 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestPLVRecord.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; * https://issues.apache.org/bugzilla/show_bug.cgi?id=53972 */ -public final class TestPLVRecord { +final class TestPLVRecord { private final static String DV_DEFINITION = "$A$1:$A$5"; private final static String XLS_FILENAME = "53972.xls"; private final static String SHEET_NAME = "S2"; diff --git a/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java b/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java index e0816996e7..ac97d99d4e 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestPaletteRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Verifies that custom palette editing works correctly */ -public final class TestPaletteRecord { +final class TestPaletteRecord { /** * Tests that the default palette matches the constants of HSSFColor diff --git a/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java b/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java index 3ffcc521cd..c20209cf5b 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestPaneRecord.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestPaneRecord { +final class TestPaneRecord { byte[] data = new byte[] { (byte)0x01, (byte)0x00, (byte)0x02, (byte)0x00, diff --git a/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java b/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java index 707f2a0538..670e2fe70c 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestRecalcIdRecord.java @@ -24,7 +24,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import org.apache.poi.util.HexRead; import org.junit.jupiter.api.Test; -public final class TestRecalcIdRecord { +final class TestRecalcIdRecord { private static RecalcIdRecord create(byte[] data) { RecordInputStream in = TestcaseRecordInputStream.create(RecalcIdRecord.sid, data); diff --git a/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java b/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java index 0518d40ca4..11f66367e1 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java +++ b/src/testcases/org/apache/poi/hssf/record/TestRecordFactory.java @@ -17,7 +17,9 @@ package org.apache.poi.hssf.record; -import static org.junit.jupiter.api.Assertions.*; +import static org.junit.jupiter.api.Assertions.assertArrayEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; @@ -32,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * Tests the record factory */ -public final class TestRecordFactory { +final class TestRecordFactory { /** diff --git a/src/testcases/org/apache/poi/hssf/record/TestRecordFactoryInputStream.java b/src/testcases/org/apache/poi/hssf/record/TestRecordFactoryInputStream.java index 7eadb13863..9c7d6be428 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestRecordFactoryInputStream.java +++ b/src/testcases/org/apache/poi/hssf/record/TestRecordFactoryInputStream.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestRecordFactoryInputStream { +final class TestRecordFactoryInputStream { /** * Hex dump of a BOF record and most of a FILEPASS record. * A 16 byte saltHash should be added to complete the second record diff --git a/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java b/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java index aebd43e05f..0956350283 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java +++ b/src/testcases/org/apache/poi/hssf/record/TestRecordInputStream.java @@ -28,7 +28,7 @@ import org.junit.jupiter.params.provider.CsvSource; /** * Tests for {@link RecordInputStream} */ -public final class TestRecordInputStream { +final class TestRecordInputStream { /** * Data inspired by attachment 22626 of bug 45866
diff --git a/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java b/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java index f9e7ca4e39..92e5abff02 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestSCLRecord.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestSCLRecord { +final class TestSCLRecord { byte[] data = new byte[] { (byte)0x3,(byte)0x0,(byte)0x4,(byte)0x0 }; diff --git a/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java b/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java index 5b920e5b87..7bde03cb06 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java +++ b/src/testcases/org/apache/poi/hssf/record/TestSSTDeserializer.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; * * @author Glen Stampoultzis (glens at apache.org) */ -public final class TestSSTDeserializer { +final class TestSSTDeserializer { private static final int FAKE_SID = -5555; private static byte[] concat(byte[] a, byte[] b) { diff --git a/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java b/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java index d4bbb5e2bd..b2206b86b7 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestSSTRecord.java @@ -41,7 +41,7 @@ import org.apache.poi.util.LittleEndian; import org.apache.poi.util.LocaleUtil; import org.junit.jupiter.api.Test; -public final class TestSSTRecord { +final class TestSSTRecord { /** * decodes hexdump files and concatenates the results diff --git a/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java b/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java index 2fd22d799e..db0593f344 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java +++ b/src/testcases/org/apache/poi/hssf/record/TestSSTRecordSizeCalculator.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests that records size calculates correctly. */ -public final class TestSSTRecordSizeCalculator { +final class TestSSTRecordSizeCalculator { private static final String SMALL_STRING = "Small string"; private static final int COMPRESSED_PLAIN_STRING_OVERHEAD = 3; private static final int OPTION_FIELD_SIZE = 1; diff --git a/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java b/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java index 899668642f..17855c08de 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestSharedFormulaRecord.java @@ -41,7 +41,7 @@ import org.apache.poi.ss.usermodel.CellValue; import org.apache.poi.util.LittleEndianInput; import org.junit.jupiter.api.Test; -public final class TestSharedFormulaRecord { +final class TestSharedFormulaRecord { /** * A sample spreadsheet known to have one sheet with 4 shared formula ranges diff --git a/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java b/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java index 1261b8a2ad..18d345213e 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestStringRecord.java @@ -20,7 +20,6 @@ package org.apache.poi.hssf.record; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; import java.io.IOException; @@ -34,7 +33,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestStringRecord { +final class TestStringRecord { private static final byte[] data = HexRead.readFromString( "0B 00 " + // length "00 " + // option diff --git a/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java b/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java index b77916504d..ed47560caf 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestStyleRecord.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link StyleRecord} */ -public final class TestStyleRecord { +final class TestStyleRecord { @Test void testUnicodeReadName() { byte[] data = HexRead.readFromString( diff --git a/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java b/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java index dc8accf556..b10800d5a3 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestSubRecord.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * Tests Subrecord components of an OBJ record. Test data taken directly * from a real Excel file. */ -public final class TestSubRecord { +final class TestSubRecord { /* The following is a dump of the OBJ record corresponding to an auto-filter drop-down list. The 3rd subrecord beginning at offset 0x002e (type=0x0013) diff --git a/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java b/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java index 8a412703c2..1766c514dd 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestSupBookRecord.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the SupBook record * class works correctly. */ -public final class TestSupBookRecord { +final class TestSupBookRecord { /** * This contains a fake data section of a SubBookRecord */ diff --git a/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java b/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java index 22c8ab41fc..58cd682df2 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestTableRecord.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestTableRecord { +final class TestTableRecord { byte[] header = new byte[] { 0x36, 02, 0x10, 00, // sid=x236, 16 bytes long }; diff --git a/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java b/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java index 02acfc7877..6af2622dcb 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestTextObjectBaseRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestTextObjectBaseRecord { +final class TestTextObjectBaseRecord { /** data for one TXO rec and two continue recs */ private static final byte[] data = HexRead.readFromString( "B6 01 " + // TextObjectRecord.sid diff --git a/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java b/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java index a9d4f3ff82..272b1802e1 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestTextObjectRecord.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; * * @author Yegor Kozlov */ -public final class TestTextObjectRecord { +final class TestTextObjectRecord { private static final byte[] simpleData = HexRead.readFromString( "B6 01 12 00 " + diff --git a/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java b/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java index 355321fab6..773b8666c1 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestUnicodeNameRecord.java @@ -27,7 +27,7 @@ import org.apache.poi.hssf.usermodel.HSSFSheet; import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.junit.jupiter.api.Test; -public final class TestUnicodeNameRecord { +final class TestUnicodeNameRecord { @Test void testReadBook() throws IOException { diff --git a/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java b/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java index 04d49eca32..364e478932 100644 --- a/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/TestWriteAccessRecord.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link WriteAccessRecord} */ -public final class TestWriteAccessRecord { +final class TestWriteAccessRecord { private static final String HEX_SIXTYFOUR_SPACES = "" + "20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 " diff --git a/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java b/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java index d471a4983e..b400b76c24 100644 --- a/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java +++ b/src/testcases/org/apache/poi/hssf/record/aggregates/TestCFRecordsAggregate.java @@ -48,7 +48,7 @@ import org.junit.jupiter.api.Test; * class works correctly. */ @SuppressWarnings("resource") -public final class TestCFRecordsAggregate { +final class TestCFRecordsAggregate { @Test void testCFRecordsAggregate() { HSSFWorkbook workbook = new HSSFWorkbook(); diff --git a/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java b/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java index bcade8e406..6fae73f041 100644 --- a/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java +++ b/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java @@ -27,7 +27,7 @@ import org.apache.poi.hssf.record.ColumnInfoRecord; import org.apache.poi.hssf.record.RecordBase; import org.junit.jupiter.api.Test; -public final class TestColumnInfoRecordsAggregate { +final class TestColumnInfoRecordsAggregate { @Test void testGetRecordSize() { diff --git a/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java b/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java index d9eb109964..8bfc6576c2 100644 --- a/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java +++ b/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java @@ -34,7 +34,7 @@ import org.apache.poi.ss.formula.ptg.Ptg; import org.apache.poi.ss.util.CellRangeAddress; import org.junit.jupiter.api.Test; -public final class TestFormulaRecordAggregate { +final class TestFormulaRecordAggregate { @Test void testBasic() { diff --git a/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java b/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java index aa33e44488..243e1adc2e 100644 --- a/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java +++ b/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java @@ -60,7 +60,7 @@ import org.junit.jupiter.api.Test; /** * Tess for {@link PageSettingsBlock} */ -public final class TestPageSettingsBlock { +final class TestPageSettingsBlock { @Test void testPrintSetup_bug46548() { // PageSettingBlock in this file contains PLS (sid=x004D) record diff --git a/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java b/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java index 8926ab0822..41ad8fbcb5 100644 --- a/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java +++ b/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java @@ -47,7 +47,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link RowRecordsAggregate} */ -public final class TestRowRecordsAggregate { +final class TestRowRecordsAggregate { @Test void testRowGet() { diff --git a/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java b/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java index 4c89b919cd..31b4f92548 100644 --- a/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java +++ b/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link SharedValueManager} */ -public final class TestSharedValueManager { +final class TestSharedValueManager { /** * This Excel workbook contains two sheets that each have a pair of overlapping shared formula diff --git a/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java b/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java index 82d9765299..38018f3627 100644 --- a/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java +++ b/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java @@ -23,7 +23,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; import java.io.IOException; import java.io.InputStream; @@ -52,7 +51,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link ValueRecordsAggregate} */ -public final class TestValueRecordsAggregate { +final class TestValueRecordsAggregate { private static final String ABNORMAL_SHARED_FORMULA_FLAG_TEST_FILE = "AbnormalSharedFormulaFlag.xls"; private final ValueRecordsAggregate valueRecord = new ValueRecordsAggregate(); diff --git a/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java b/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java index 61921d6d2e..cb0a6a548b 100644 --- a/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java +++ b/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; /** * Tests CellRange operations. */ -public final class TestCellRange { +final class TestCellRange { private static final CellRangeAddress biggest = createCR( 0, -1, 0,-1); private static final CellRangeAddress tenthColumn = createCR( 0, -1,10,10); private static final CellRangeAddress tenthRow = createCR(10, 10, 0,-1); diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java index fe81173573..c0cb666800 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestAreaFormatRecord { +final class TestAreaFormatRecord { byte[] data = new byte[] { (byte)0xFF,(byte)0xFF,(byte)0xFF,(byte)0x00, // forecolor (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00, // backcolor diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java index 971030de6c..638b32635c 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestAreaRecord { +final class TestAreaRecord { byte[] data = new byte[] { (byte)0x02,(byte)0x00 // format flags }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java index d59ff0f9c8..7e1a07f651 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestAxisLineFormatRecord { +final class TestAxisLineFormatRecord { byte[] data = new byte[] { (byte)0x01,(byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java index f4da9d33d3..06c03ee0ca 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestAxisOptionsRecord { +final class TestAxisOptionsRecord { private static final byte[] data = { (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x01, (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x01,(byte)0x00, diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java index 8aecd9fb6a..0c77fbcf2d 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestAxisParentRecord { +final class TestAxisParentRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00, // axis type (byte)0x1D,(byte)0x02,(byte)0x00,(byte)0x00, // x diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java index 3471aad2ff..70b504c6ac 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestAxisRecord { +final class TestAxisRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00, // type (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00, diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java index 3c4cfeb1f4..4a494d2f8b 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestAxisUsedRecord { +final class TestAxisUsedRecord { byte[] data = new byte[] { (byte)0x01,(byte)0x00, }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java index 6133b146e8..975f6c998f 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestBarRecord { +final class TestBarRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00, // bar space (byte)0x96,(byte)0x00, // category space diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java index 6a2ea9c6b4..87f020479b 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestCategorySeriesAxisRecord { +final class TestCategorySeriesAxisRecord { byte[] data = new byte[] { (byte)0x01,(byte)0x00, // crossing point (byte)0x01,(byte)0x00, // label frequency diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java index 51652848c9..1341bce4b8 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * Tests for {@link ChartFormatRecord} Test data taken directly from a real * Excel file. */ -public final class TestChartFormatRecord { +final class TestChartFormatRecord { /** * This rather uninteresting data came from attachment 23347 of bug 46693 at * offsets 0x6BB2 and 0x7BAF diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java index bfe73a5056..a2eaa8fa43 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestChartRecord { +final class TestChartRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00, (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00, diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java index 29c4ed46b8..e719910ddf 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java @@ -31,7 +31,7 @@ import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.apache.poi.poifs.filesystem.POIFSFileSystem; import org.junit.jupiter.api.Test; -public final class TestChartTitleFormatRecord { +final class TestChartTitleFormatRecord { @Test void testRecord() throws Exception { diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java index 13af42e0c8..8511d1cdf5 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestDatRecord { +final class TestDatRecord { byte[] data = new byte[] { (byte)0x0D,(byte)0x00 // options }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java index 0a0bc16ee0..a146408400 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestDataFormatRecord { +final class TestDataFormatRecord { byte[] data = new byte[] { (byte)0xFF,(byte)0xFF, // point number (byte)0x00,(byte)0x00, // series index diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java index 0eccb1ef4c..6ebf3a6191 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestDefaultDataLabelTextPropertiesRecord { +final class TestDefaultDataLabelTextPropertiesRecord { byte[] data = new byte[] { (byte)0x02,(byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java index e0e0916f43..5042e5663d 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestFontBasisRecord { +final class TestFontBasisRecord { byte[] data = new byte[] { (byte)0x28,(byte)0x1A, // x basis (byte)0x9C,(byte)0x0F, // y basis diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java index e7ec924ca3..ca92378c8c 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestFontIndexRecord { +final class TestFontIndexRecord { byte[] data = new byte[] { (byte)0x05,(byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java index 57c8174e33..ca8ec3ca9b 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestFrameRecord { +final class TestFrameRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00, // border type (byte)0x02,(byte)0x00 // options diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java index fba93251aa..d5c995fd5b 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the LegendRecord class works * correctly. Test data taken directly from a real Excel file. */ -public final class TestLegendRecord { +final class TestLegendRecord { byte[] data = new byte[] { (byte) 0x76, (byte) 0x0E, (byte) 0x00, (byte) 0x00, (byte) 0x86, (byte) 0x07, (byte) 0x00, (byte) 0x00, (byte) 0x19, (byte) 0x01, (byte) 0x00, (byte) 0x00, (byte) 0x8B, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x03, diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java index a03b7be146..89fd5e48e4 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestLineFormatRecord { +final class TestLineFormatRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00, // colour (byte)0x00,(byte)0x00, // pattern diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java index 977a446c02..b21fd2d71d 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestLinkedDataRecord { +final class TestLinkedDataRecord { /* The records below are records that would appear in a simple bar chart diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java index 3c0ad353f2..12c7cc7342 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestNumberFormatIndexRecord { +final class TestNumberFormatIndexRecord { byte[] data = new byte[] { 0x05,0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java index 8d10c0c2cf..cd0b87bbc8 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestObjectLinkRecord { +final class TestObjectLinkRecord { byte[] data = new byte[] { (byte)0x03,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java index badc114313..2c9d42a8dc 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestPlotAreaRecord { +final class TestPlotAreaRecord { byte[] data = new byte[] { }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java index 444dbf659a..30435c76b7 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestPlotGrowthRecord { +final class TestPlotGrowthRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00,(byte)0x01,(byte)0x00, // horizontal (byte)0x00,(byte)0x00,(byte)0x01,(byte)0x00 // vertical diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java index 162ac4b396..1c6e886c90 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestSeriesChartGroupIndexRecord { +final class TestSeriesChartGroupIndexRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java index ddd1a01fad..b4bad1d191 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestSeriesIndexRecord { +final class TestSeriesIndexRecord { byte[] data = new byte[] { (byte)0x03,(byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java index b0e51325a5..f20184d3ba 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestSeriesLabelsRecord { +final class TestSeriesLabelsRecord { byte[] data = new byte[] { (byte)0x03,(byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java index ad8a3f2617..b75c579147 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestSeriesListRecord { +final class TestSeriesListRecord { private static final byte[] data = { (byte)0x02,(byte)0x00,(byte)0x01,(byte)0x20,(byte)0xff,(byte)0xf0 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java index 5f76b07a39..8aac948d0c 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestSeriesRecord { +final class TestSeriesRecord { byte[] data = new byte[] { (byte)0x01,(byte)0x00, // category data type (byte)0x01,(byte)0x00, // values data type diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java index 4e698a5c9e..6e56904996 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * Tests the serialization and deserialization of the SeriesTextRecord class * works correctly. Test data taken directly from a real Excel file. */ -public final class TestSeriesTextRecord { +final class TestSeriesTextRecord { private static final byte[] SIMPLE_DATA = HexRead .readFromString("00 00 0C 00 56 61 6C 75 65 20 4E 75 6D 62 65 72"); diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java index b918c7d2a2..21f03302c6 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * Tests for {@link SheetPropertiesRecord} * Test data taken directly from a real Excel file. */ -public final class TestSheetPropertiesRecord { +final class TestSheetPropertiesRecord { private static final byte[] data = { (byte)0x0A,(byte)0x00, (byte)0x00, diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java index bcedd6e648..7628d9ce4f 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestTextRecord { +final class TestTextRecord { byte[] data = new byte[] { (byte)0x02, // horiz align (byte)0x02, // vert align diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java index c6ab270fbd..dc1a0405bd 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestTickRecord { +final class TestTickRecord { private static final byte[] data = { (byte)0x02, (byte)0x00, (byte)0x03, (byte)0x01, (byte)0x00, (byte)0x00, (byte)0x00, (byte)0x00, (byte)0x00, diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java index 33973f3ab2..8d1294fa9b 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestUnitsRecord { +final class TestUnitsRecord { byte[] data = new byte[] { (byte)0x00, (byte)0x00 }; diff --git a/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java b/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java index f0bfff2300..0dc470d417 100644 --- a/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * class works correctly. Test data taken directly from a real * Excel file. */ -public final class TestValueRangeRecord { +final class TestValueRangeRecord { byte[] data = new byte[] { (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00, // min axis value (byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00,(byte)0x00, // max axis value diff --git a/src/testcases/org/apache/poi/hssf/record/common/TestUnicodeString.java b/src/testcases/org/apache/poi/hssf/record/common/TestUnicodeString.java index 400b8694df..45151b90ff 100644 --- a/src/testcases/org/apache/poi/hssf/record/common/TestUnicodeString.java +++ b/src/testcases/org/apache/poi/hssf/record/common/TestUnicodeString.java @@ -50,7 +50,7 @@ import org.junit.jupiter.api.Test; * * @author Jason Height (jheight at apache.org) */ -public final class TestUnicodeString { +final class TestUnicodeString { private static final int MAX_DATA_SIZE = RecordInputStream.MAX_RECORD_DATA_SIZE; /** a 4 character string requiring 16 bit encoding */ diff --git a/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java b/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java index e810bb94b2..3cfe1dc277 100644 --- a/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link ExtendedPivotTableViewFieldsRecord} */ -public final class TestExtendedPivotTableViewFieldsRecord { +final class TestExtendedPivotTableViewFieldsRecord { @Test void testSubNameNotPresent_bug46693() { diff --git a/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java b/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java index afebcc4ec5..ff6ac5d019 100644 --- a/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link PageItemRecord} */ -public final class TestPageItemRecord { +final class TestPageItemRecord { @Test void testMoreThanOneInfoItem_bug46917() { byte[] data = HexRead.readFromString("01 02 03 04 05 06 07 08 09 0A 0B 0C"); diff --git a/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java b/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java index a0898efa64..ee05e1a4f4 100644 --- a/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java +++ b/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link ViewFieldsRecord} */ -public final class TestViewFieldsRecord { +final class TestViewFieldsRecord { @Test void testUnicodeFlag_bug46693() { diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java index f8f0b52e1c..8a3008cb45 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * */ -public final class TestBug42464 { +final class TestBug42464 { @Test void testOKFile() throws Exception { diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java index a6347fbe57..b30f9f71ec 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java @@ -101,7 +101,7 @@ import org.junit.jupiter.params.provider.CsvSource; * YK: If a bug can be tested in terms of common ss interfaces, * define the test in the base class {@link BaseTestBugzillaIssues} */ -public final class TestBugs extends BaseTestBugzillaIssues { +final class TestBugs extends BaseTestBugzillaIssues { public TestBugs() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java b/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java index d873775683..d80f000368 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java @@ -55,7 +55,7 @@ import org.junit.jupiter.api.Test; * Class to test cell styling functionality */ -public final class TestCellStyle { +final class TestCellStyle { private static HSSFWorkbook openSample(String sampleFileName) { return HSSFTestDataSamples.openSampleWorkbook(sampleFileName); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java b/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java index 421b6e0061..cb3d92d113 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; * add that record to the sheet in the testCloneSheetBasic method. * @author avik */ -public final class TestCloneSheet extends BaseTestCloneSheet { +final class TestCloneSheet extends BaseTestCloneSheet { public TestCloneSheet() { super(HSSFITestDataProvider.instance); } diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java b/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java index f8426f9248..4a120b2ac6 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java @@ -53,7 +53,7 @@ import org.junit.jupiter.api.Test; * * @author Dragos Buleandra ( dragos.buleandra@trade2b.ro ) */ -public final class TestDataValidation extends BaseTestDataValidation { +final class TestDataValidation extends BaseTestDataValidation { public TestDataValidation(){ super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java b/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java index 27a12e2d9e..3ddac1b794 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; * one anchored at 0,0,1022,255 and another anchored * at 20,30,500,200 */ -public final class TestEscherGraphics { +final class TestEscherGraphics { private HSSFWorkbook workbook; private HSSFPatriarch patriarch; private HSSFShapeGroup escherGroupA; diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java b/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java index 9e4422bdbd..e6aaf092b6 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Tests the Graphics2d drawing capability. */ -public final class TestEscherGraphics2d { +final class TestEscherGraphics2d { private HSSFWorkbook workbook; private HSSFShapeGroup escherGroup; private EscherGraphics2d graphics; diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java b/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java index 30b358c9ef..7341a43b1f 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; /** * Tests the implementation of the FontDetails class. */ -public final class TestFontDetails { +final class TestFontDetails { private FontDetails fontDetails; @BeforeEach diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java index 1bb3585e89..0ddc016d29 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java @@ -26,7 +26,6 @@ import static org.junit.jupiter.api.Assertions.fail; import java.io.File; import java.io.FileOutputStream; import java.util.Calendar; -import java.util.Iterator; import org.apache.poi.hssf.HSSFTestDataSamples; import org.apache.poi.hssf.record.FormulaRecord; @@ -54,7 +53,7 @@ import org.junit.jupiter.api.Test; /** * */ -public final class TestFormulaEvaluatorBugs { +final class TestFormulaEvaluatorBugs { private static boolean OUTPUT_TEST_FILES; private static String tmpDirName; diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java index 046a08ff86..ef8cd2538a 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * https://poi.apache.org/hssf/eval.html * all actually works as we'd expect them to */ -public final class TestFormulaEvaluatorDocs { +final class TestFormulaEvaluatorDocs { /** * https://poi.apache.org/hssf/eval.html#EvaluateAll diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java index ac85a2d273..836ed32bae 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java @@ -43,7 +43,7 @@ import org.apache.poi.util.LocaleUtil; import org.apache.poi.util.TempFile; import org.junit.jupiter.api.Test; -public final class TestFormulas { +final class TestFormulas { private static HSSFWorkbook openSample(String sampleFileName) { return HSSFTestDataSamples.openSampleWorkbook(sampleFileName); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java index c140e905ce..57f0fbc19d 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java @@ -51,7 +51,7 @@ import org.junit.jupiter.api.Test; * Tests various functionality having to do with {@link HSSFCell}. For instance support for * particular datatypes, etc. */ -public final class TestHSSFCell extends BaseTestCell { +final class TestHSSFCell extends BaseTestCell { public TestHSSFCell() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java index 64d029fca8..a6555e3f6c 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java @@ -26,7 +26,6 @@ import static org.junit.jupiter.api.Assertions.assertNull; import java.io.IOException; import org.apache.poi.hssf.HSSFITestDataProvider; -import org.apache.poi.hssf.HSSFTestDataSamples; import org.apache.poi.hssf.record.chart.SeriesRecord; import org.apache.poi.hssf.usermodel.HSSFChart.HSSFSeries; import org.apache.poi.ss.util.CellRangeAddress; @@ -36,7 +35,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link HSSFChart} */ -public final class TestHSSFChart { +final class TestHSSFChart { @Test void testSingleChart() { diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java index 8c9dbe6cc9..1cc79736c1 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Various tests for HSSFClientAnchor. */ -public final class TestHSSFClientAnchor { +final class TestHSSFClientAnchor { @Test void testGetAnchorHeightInPoints() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java index 673849b8ef..0068f98305 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java @@ -51,7 +51,7 @@ import org.junit.jupiter.api.Test; * * @author Yegor Kozlov */ -public final class TestHSSFComment extends BaseTestCellComment { +final class TestHSSFComment extends BaseTestCellComment { public TestHSSFComment() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java index 9bb01384b1..b6a472ad38 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java @@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test; /** * HSSF-specific Conditional Formatting tests */ -public final class TestHSSFConditionalFormatting extends BaseTestConditionalFormatting { +final class TestHSSFConditionalFormatting extends BaseTestConditionalFormatting { public TestHSSFConditionalFormatting(){ super(HSSFITestDataProvider.instance); } diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java index 0f1b6a46a1..1ebca4a34d 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link HSSFDataFormat} */ -public final class TestHSSFDataFormat extends BaseTestDataFormat { +final class TestHSSFDataFormat extends BaseTestDataFormat { private static final POILogger _logger = POILogFactory.getLogger(TestHSSFDataFormat.class); public TestHSSFDataFormat() { diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFExternalFunctions.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFExternalFunctions.java index cb897c6c2e..552e028aff 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFExternalFunctions.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFExternalFunctions.java @@ -23,7 +23,7 @@ import org.apache.poi.ss.formula.BaseTestExternalFunctions; /** * Tests setting and evaluating user-defined functions in HSSF */ -public final class TestHSSFExternalFunctions extends BaseTestExternalFunctions { +final class TestHSSFExternalFunctions extends BaseTestExternalFunctions { public TestHSSFExternalFunctions() { super(HSSFITestDataProvider.instance, "atp.xls"); } diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFont.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFont.java index 541b34708a..e4859923ff 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFont.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFont.java @@ -27,7 +27,7 @@ import org.junit.jupiter.params.provider.Arguments; /** * Tests various functionality having to do with {@link org.apache.poi.ss.usermodel.Name}. */ -public final class TestHSSFFont extends BaseTestFont { +final class TestHSSFFont extends BaseTestFont { public TestHSSFFont() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java index 9ddc17a9f3..afe96936fd 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java @@ -39,7 +39,7 @@ import org.apache.poi.ss.usermodel.CellType; import org.apache.poi.ss.usermodel.CellValue; import org.junit.jupiter.api.Test; -public final class TestHSSFFormulaEvaluator extends BaseTestFormulaEvaluator { +final class TestHSSFFormulaEvaluator extends BaseTestFormulaEvaluator { public TestHSSFFormulaEvaluator() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java index cb4178ab7a..a104bba25f 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link HSSFHeader} / {@link HSSFFooter} */ -public final class TestHSSFHeaderFooter { +final class TestHSSFHeaderFooter { /** * Tests that get header retrieves the proper values. diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java index e5e9deb692..67cb04010d 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java @@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test; * * @author Yegor Kozlov */ -public final class TestHSSFHyperlink extends BaseTestHyperlink { +final class TestHSSFHyperlink extends BaseTestHyperlink { public TestHSSFHyperlink() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java index 1a58009863..95364a33c2 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java @@ -28,7 +28,7 @@ import org.apache.poi.ss.usermodel.Row; import org.apache.poi.ss.usermodel.Workbook; import org.junit.jupiter.api.Test; -public final class TestHSSFOptimiser { +final class TestHSSFOptimiser { @Test void testDoesNoHarmIfNothingToDo() { HSSFWorkbook wb = new HSSFWorkbook(); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java index 088bcf0e6b..1f6460e920 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java @@ -36,7 +36,7 @@ import org.apache.poi.ss.usermodel.Font; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public final class TestHSSFPalette { +final class TestHSSFPalette { private HSSFPalette _hssfPalette; diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java index 5d4608a7c1..64b91fc516 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java @@ -25,7 +25,7 @@ import org.apache.poi.hssf.HSSFTestDataSamples; import org.apache.poi.ss.usermodel.ClientAnchor.AnchorType; import org.junit.jupiter.api.Test; -public final class TestHSSFPatriarch { +final class TestHSSFPatriarch { @Test void testBasic() throws IOException { diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPicture.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPicture.java index 471ab0c601..98b32575c8 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPicture.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPicture.java @@ -39,7 +39,7 @@ import org.apache.poi.ss.usermodel.PictureData; import org.apache.poi.ss.usermodel.Workbook; import org.junit.jupiter.api.Test; -public final class TestHSSFPicture extends BaseTestPicture { +final class TestHSSFPicture extends BaseTestPicture { public TestHSSFPicture() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java index b2f767465b..dd1de44da9 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; * Test HSSFPictureData. * The code to retrieve images from a workbook provided by Trejkaz (trejkaz at trypticon dot org) in Bug 41223. */ -public final class TestHSSFPictureData { +final class TestHSSFPictureData { @BeforeAll public static void setUpClass() { final String tmpDirProperty = System.getProperty("java.io.tmpdir"); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java index 45c084e47d..44ae5b4fcf 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java @@ -21,7 +21,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import org.junit.jupiter.api.Test; -public final class TestHSSFRichTextString { +final class TestHSSFRichTextString { @Test void testApplyFont() { HSSFRichTextString r = new HSSFRichTextString("testing"); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java index ce0cdcb4b8..b588f1375c 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; * * @author Glen Stampoultzis (glens at apache.org) */ -public final class TestHSSFRow extends BaseTestRow { +final class TestHSSFRow extends BaseTestRow { public TestHSSFRow() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java index 358b44fa54..b6c9c918d2 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java @@ -56,7 +56,7 @@ import org.junit.jupiter.api.Test; /** * Tests HSSFSheet. This test case is very incomplete at the moment. */ -public final class TestHSSFSheet extends BaseTestSheet { +final class TestHSSFSheet extends BaseTestSheet { public TestHSSFSheet() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetAutosizeColumn.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetAutosizeColumn.java index 7538d4acbb..5f9f0fb246 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetAutosizeColumn.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetAutosizeColumn.java @@ -18,14 +18,14 @@ package org.apache.poi.hssf.usermodel; import org.apache.poi.hssf.HSSFITestDataProvider; -import org.apache.poi.ss.usermodel.*; +import org.apache.poi.ss.usermodel.BaseTestSheetAutosizeColumn; /** * Test auto-sizing columns in HSSF * * @author Yegor Kozlov */ -public final class TestHSSFSheetAutosizeColumn extends BaseTestSheetAutosizeColumn { +final class TestHSSFSheetAutosizeColumn extends BaseTestSheetAutosizeColumn { public TestHSSFSheetAutosizeColumn() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftRows.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftRows.java index 8c4c08d4fa..d78c3bf660 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftRows.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftRows.java @@ -23,7 +23,7 @@ import org.apache.poi.ss.usermodel.BaseTestSheetShiftRows; /** * @author Yegor Kozlov */ -public final class TestHSSFSheetShiftRows extends BaseTestSheetShiftRows { +final class TestHSSFSheetShiftRows extends BaseTestSheetShiftRows { public TestHSSFSheetShiftRows() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java index 9142347640..33f6607988 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java @@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test; /** * Test array formulas in HSSF */ -public final class TestHSSFSheetUpdateArrayFormulas extends BaseTestSheetUpdateArrayFormulas { +final class TestHSSFSheetUpdateArrayFormulas extends BaseTestSheetUpdateArrayFormulas { public TestHSSFSheetUpdateArrayFormulas() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java index 692c487a31..5d08d77e4c 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; /** * Test HSSFTextbox. */ -public final class TestHSSFTextbox { +final class TestHSSFTextbox { /** * Test that accessors to horizontal and vertical alignment work properly diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestMatrixFormulasFromBinarySpreadsheet.java b/src/testcases/org/apache/poi/hssf/usermodel/TestMatrixFormulasFromBinarySpreadsheet.java index 3ccd2a9e43..6d5a9da58a 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestMatrixFormulasFromBinarySpreadsheet.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestMatrixFormulasFromBinarySpreadsheet.java @@ -44,7 +44,7 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; -public final class TestMatrixFormulasFromBinarySpreadsheet { +final class TestMatrixFormulasFromBinarySpreadsheet { private static final POILogger LOG = POILogFactory.getLogger(TestMatrixFormulasFromBinarySpreadsheet.class); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java b/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java index 4a8bfc97e1..6f8bc8dfbb 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; * with a WORKBOOK or BOOK directory entry (instead of * the more usual, Workbook) */ -public final class TestNonStandardWorkbookStreamNames { +final class TestNonStandardWorkbookStreamNames { private final String xlsA = "WORKBOOK_in_capitals.xls"; private final String xlsB = "BOOK_in_capitals.xls"; diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java b/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java index b7f67c84d4..1183c5f6b5 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java @@ -37,7 +37,7 @@ import org.apache.poi.ss.usermodel.CreationHelper; import org.apache.poi.util.LocaleUtil; import org.junit.jupiter.api.Test; -public final class TestOLE2Embeding { +final class TestOLE2Embeding { @Test void testEmbeding() throws Exception { diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java b/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java index 44bd3d8caa..f1e9f0ef1f 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; /** * @author Glen Stampoultzis (glens at apache.org) */ -public final class TestReadWriteChart { +final class TestReadWriteChart { /** * In the presence of a chart we need to make sure BOF/EOF records still exist. diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java b/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java index 36fb392f74..5bde759a5c 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; /** * Class to test row styling functionality */ -public final class TestRowStyle { +final class TestRowStyle { /** * TEST NAME: Test Write Sheet Font

diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java b/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java index b77f98edfb..428fb3030e 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java @@ -18,7 +18,6 @@ package org.apache.poi.hssf.usermodel; import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; import java.util.ArrayList; import java.util.Arrays; @@ -39,7 +38,7 @@ import org.junit.jupiter.api.Test; * * @author Glen Stampoultzis (glens at apache.org) */ -public final class TestSanityChecker { +final class TestSanityChecker { private static final Record INTERFACEHDR = new InterfaceHdrRecord(InterfaceHdrRecord.CODEPAGE); private static BoundSheetRecord createBoundSheetRec() { return new BoundSheetRecord("Sheet1"); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java b/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java index 5a1e8f05b1..2bda96ce2c 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java @@ -17,19 +17,18 @@ package org.apache.poi.hssf.usermodel; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + import org.apache.poi.hssf.HSSFITestDataProvider; import org.apache.poi.hssf.model.InternalWorkbook; import org.apache.poi.ss.usermodel.BaseTestSheetHiding; import org.apache.poi.ss.usermodel.SheetVisibility; import org.junit.jupiter.api.Test; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; - -public final class TestSheetHiding extends BaseTestSheetHiding { +final class TestSheetHiding extends BaseTestSheetHiding { public TestSheetHiding() { super(HSSFITestDataProvider.instance, "TwoSheetsOneHidden.xls", "TwoSheetsNoneHidden.xls"); diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java b/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java index 855d82eec2..76701fd1dd 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java @@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test; * Bugzilla id's PLEASE MOVE tests from this class to TestBugs once the bugs are * fixed, so that they are then run automatically. */ -public final class TestUnfixedBugs { +final class TestUnfixedBugs { @Test void testFormulaRecordAggregate_1() throws Exception { // fails at formula "=MEHRFACH.OPERATIONEN(E$3;$B$5;$D4)" diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java b/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java index ec5d519275..1ced954a27 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java @@ -25,7 +25,7 @@ import java.io.IOException; import org.apache.poi.hssf.HSSFTestDataSamples; import org.junit.jupiter.api.Test; -public final class TestUnicodeWorkbook { +final class TestUnicodeWorkbook { /** * Tests Bug38230 diff --git a/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java b/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java index 4d2f395b23..e3ca2f4247 100644 --- a/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java +++ b/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java @@ -17,6 +17,12 @@ package org.apache.poi.hssf.usermodel; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + import java.io.IOException; import org.apache.poi.hssf.HSSFTestDataSamples; @@ -24,16 +30,19 @@ import org.apache.poi.hssf.model.InternalWorkbook; import org.apache.poi.hssf.record.BackupRecord; import org.apache.poi.hssf.record.LabelSSTRecord; import org.apache.poi.hssf.record.aggregates.RecordAggregate.RecordVisitor; -import org.apache.poi.ss.usermodel.*; +import org.apache.poi.ss.usermodel.Cell; +import org.apache.poi.ss.usermodel.CellType; +import org.apache.poi.ss.usermodel.Name; +import org.apache.poi.ss.usermodel.Row; +import org.apache.poi.ss.usermodel.Sheet; +import org.apache.poi.ss.usermodel.Workbook; import org.apache.poi.ss.util.CellRangeAddress; import org.junit.jupiter.api.Test; -import static org.junit.jupiter.api.Assertions.*; - /** * Class to test Workbook functionality */ -public final class TestWorkbook { +final class TestWorkbook { private static final String LAST_NAME_KEY = "lastName"; private static final String FIRST_NAME_KEY = "firstName"; private static final String SSN_KEY = "ssn"; diff --git a/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java b/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java index 24bbe95c70..1fe92ec022 100644 --- a/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java +++ b/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java @@ -46,7 +46,7 @@ import org.apache.poi.ss.util.AreaReference; import org.apache.poi.ss.util.CellReference; import org.junit.jupiter.api.Test; -public final class TestAreaReference { +final class TestAreaReference { @Test void testAreaRef1() { diff --git a/src/testcases/org/apache/poi/hssf/util/TestCellReference.java b/src/testcases/org/apache/poi/hssf/util/TestCellReference.java index d0b197d7db..f761e251dd 100644 --- a/src/testcases/org/apache/poi/hssf/util/TestCellReference.java +++ b/src/testcases/org/apache/poi/hssf/util/TestCellReference.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * Tests for the HSSF and SS versions of CellReference. * See also {@link org.apache.poi.ss.util.TestCellReference} */ -public final class TestCellReference { +final class TestCellReference { @Test void testColNumConversion() { assertEquals(0, CellReference.convertColStringToIndex("A")); diff --git a/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java b/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java index 64cbd3df06..ff3ec06277 100644 --- a/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java +++ b/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java @@ -25,7 +25,7 @@ import java.util.Map; import org.apache.poi.hssf.util.HSSFColor.HSSFColorPredefined; import org.junit.jupiter.api.Test; -public final class TestHSSFColor { +final class TestHSSFColor { @Test void testBasics() { assertTrue(HSSFColorPredefined.YELLOW.getIndex() > 0); diff --git a/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java b/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java index a976666e57..15190f93ab 100644 --- a/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java +++ b/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; /** * Tests the {@link RKUtil} class. */ -public final class TestRKUtil { +final class TestRKUtil { /** * Check we can decode correctly. diff --git a/src/testcases/org/apache/poi/poifs/crypt/TestBiff8DecryptingStream.java b/src/testcases/org/apache/poi/poifs/crypt/TestBiff8DecryptingStream.java index fc6e613ef5..959565cfeb 100644 --- a/src/testcases/org/apache/poi/poifs/crypt/TestBiff8DecryptingStream.java +++ b/src/testcases/org/apache/poi/poifs/crypt/TestBiff8DecryptingStream.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link Biff8DecryptingStream} */ -public final class TestBiff8DecryptingStream { +final class TestBiff8DecryptingStream { /** * A mock {@link InputStream} that keeps track of position and also produces diff --git a/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java b/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java index cad76dd749..1eb939f961 100644 --- a/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java +++ b/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; * * @author Marc Johnson */ -public final class TestPOIFSReaderRegistry { +final class TestPOIFSReaderRegistry { private final POIFSReaderListener[] listeners = { new Listener(), new Listener(), new Listener(), new Listener() diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java b/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java index b9642326fa..9212aa6c8f 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; /** * Class to test DirectoryNode functionality */ -public final class TestDirectoryNode { +final class TestDirectoryNode { /** * test trivial constructor (a DirectoryNode with no children) diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java b/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java index 17a2fb9def..17c1b572d5 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java @@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test; /** * Class to test DocumentDescriptor functionality */ -public final class TestDocumentDescriptor { +final class TestDocumentDescriptor { /** * test equality diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java b/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java index 27bb00974a..c0d4de1353 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; /** * Class to test DocumentInputStream functionality */ -public final class TestDocumentInputStream { +final class TestDocumentInputStream { private DocumentNode _workbook_n; private byte[] _workbook_data; private static final int _workbook_size = 5000; diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java b/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java index dadd8dd944..d2815e0254 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Class to test DocumentOutputStream functionality */ -public final class TestDocumentOutputStream { +final class TestDocumentOutputStream { /** * test write(int) behavior diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java b/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java index f83572b2f4..b44b5d5d53 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java @@ -29,7 +29,7 @@ import org.apache.poi.util.POILogFactory; import org.apache.poi.util.POILogger; import org.junit.jupiter.api.Test; -public final class TestEmptyDocument { +final class TestEmptyDocument { private static final POILogger LOG = POILogFactory.getLogger(TestEmptyDocument.class); @Test diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java b/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java index 42028da91d..ef504aca69 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; /** * Tests bugs for POIFSFileSystem */ -public final class TestFileSystemBugs { +final class TestFileSystemBugs { private static final POIDataSamples _samples = POIDataSamples.getPOIFSInstance(); private static final POIDataSamples _ssSamples = POIDataSamples.getSpreadSheetInstance(); diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java b/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java index 8297eb1606..aa9c8883af 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; /** * Class to test FilteringDirectoryNode functionality */ -public final class TestFilteringDirectoryNode { +final class TestFilteringDirectoryNode { private POIFSFileSystem fs; private DirectoryEntry dirA; private DirectoryEntry dirAA; diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java index 1d6fbcb933..94d8e73e9c 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java @@ -22,7 +22,6 @@ import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; import java.util.Arrays; @@ -31,7 +30,7 @@ import org.junit.jupiter.api.Test; /** * Class to test POIFSDocumentPath functionality */ -public final class TestPOIFSDocumentPath { +final class TestPOIFSDocumentPath { /** diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java index 2bf0493cb9..8682bad46b 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java @@ -46,7 +46,7 @@ import org.junit.jupiter.api.Test; /** * Tests for the older OPOIFS-based POIFSFileSystem */ -public final class TestPOIFSFileSystem { +final class TestPOIFSFileSystem { private final POIDataSamples _samples = POIDataSamples.getPOIFSInstance(); /** diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java index 98493fb530..fcc1e4bcf1 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java @@ -22,7 +22,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; import java.io.ByteArrayInputStream; import java.nio.ByteBuffer; @@ -38,7 +37,7 @@ import org.junit.jupiter.api.Test; * Tests for the Mini Store in the NIO POIFS */ @SuppressWarnings("CatchMayIgnoreException") -public final class TestPOIFSMiniStore { +final class TestPOIFSMiniStore { private static final POIDataSamples _inst = POIDataSamples.getPOIFSInstance(); /** diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java index 07cccaf1b8..2a2a8122d1 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java @@ -26,7 +26,6 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; import static org.junit.jupiter.api.Assumptions.assumeTrue; import java.io.ByteArrayInputStream; @@ -60,7 +59,7 @@ import org.junit.jupiter.api.Test; /** * Tests {@link POIFSStream} */ -public final class TestPOIFSStream { +final class TestPOIFSStream { private static final POIDataSamples _inst = POIDataSamples.getPOIFSInstance(); /** diff --git a/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java b/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java index 7e54151c8e..29ed3001f0 100644 --- a/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java +++ b/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java @@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test; * See bug 39234 in bugzilla. Thanks to Bill Seddon for providing the solution. *

*/ -public final class TestPropertySorter { +final class TestPropertySorter { //the correct order of entries in the test file private static final String[] _entries = { diff --git a/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java b/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java index 1cc6b85c19..49b6553012 100644 --- a/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java +++ b/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; /** * Class to test DirectoryProperty functionality */ -public final class TestDirectoryProperty { +final class TestDirectoryProperty { private DirectoryProperty _property; private byte[] _testblock; diff --git a/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java b/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java index ee538cb561..17145cd9db 100644 --- a/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java +++ b/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * Class to test DocumentProperty functionality */ -public final class TestDocumentProperty { +final class TestDocumentProperty { @Test void testConstructor() throws IOException { diff --git a/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java b/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java index c141bc344c..6d67310ff6 100644 --- a/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java +++ b/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * Class to test PropertyFactory functionality */ -public final class TestPropertyFactory { +final class TestPropertyFactory { @Test void testConvertToProperties() throws IOException { diff --git a/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java b/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java index 3ec51c918e..e6ce6610f5 100644 --- a/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java +++ b/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java @@ -42,7 +42,7 @@ import org.junit.jupiter.api.Test; /** * Class to test PropertyTable functionality */ -public final class TestPropertyTable { +final class TestPropertyTable { private static void confirmBlockEncoding(String expectedDataStr, PropertyTable table) throws IOException { final ByteArrayOutputStream bos = new ByteArrayOutputStream(); diff --git a/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java b/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java index 19de78ceeb..4b311a8ec8 100644 --- a/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java +++ b/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * * @author Marc Johnson */ -public final class TestRootProperty { +final class TestRootProperty { private RootProperty _property; private byte[] _testblock; diff --git a/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java b/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java index 40cb3c787e..8190b151b6 100644 --- a/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java +++ b/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Class to test BATBlock functionality */ -public final class TestBATBlock { +final class TestBATBlock { @Test diff --git a/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java b/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java index 9c30f75d9a..bb08ae3965 100644 --- a/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java +++ b/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Class to test HeaderBlockReader functionality */ -public final class TestHeaderBlockReading { +final class TestHeaderBlockReading { @Test void testConstructors() throws IOException { diff --git a/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java b/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java index 71f5a843b4..4da0ab5b05 100644 --- a/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java +++ b/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java @@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test; /** * Check that all enum values are properly set */ -public final class TestSpreadsheetVersion { +final class TestSpreadsheetVersion { @Test void testExcel97(){ diff --git a/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java b/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java index 51d3f5742d..37e2131ee0 100644 --- a/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java +++ b/src/testcases/org/apache/poi/ss/formula/TestFormulaShifter.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link FormulaShifter}. */ -public final class TestFormulaShifter { +final class TestFormulaShifter { // Note - the expected result row coordinates here were determined/verified // in Excel 2007 by manually testing. diff --git a/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java b/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java index f96b2a824f..484e5597cb 100644 --- a/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java +++ b/src/testcases/org/apache/poi/ss/formula/TestSheetNameFormatter.java @@ -17,20 +17,19 @@ package org.apache.poi.ss.formula; -import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; import java.io.IOException; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; +import org.junit.jupiter.api.Test; /** * Tests for {@link SheetNameFormatter} * * @author Josh Micich */ -public final class TestSheetNameFormatter { +final class TestSheetNameFormatter { /** * Tests main public method 'format' */ diff --git a/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java b/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java index 29747bebd4..57875af9cd 100644 --- a/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java +++ b/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculator.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Specific test cases for YearFracCalculator */ -public final class TestYearFracCalculator { +final class TestYearFracCalculator { @Test void testBasis1() { diff --git a/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java b/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java index e556858e7a..1ac4f2576b 100644 --- a/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java +++ b/src/testcases/org/apache/poi/ss/formula/atp/TestYearFracCalculatorFromSpreadsheet.java @@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test; /** * Tests YearFracCalculator using test-cases listed in a sample spreadsheet */ -public final class TestYearFracCalculatorFromSpreadsheet { +final class TestYearFracCalculatorFromSpreadsheet { private static final class SS { diff --git a/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java b/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java index 46ddea521b..0f9c0ee60a 100644 --- a/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java +++ b/src/testcases/org/apache/poi/ss/formula/constant/TestConstantValueParser.java @@ -29,7 +29,7 @@ import org.apache.poi.util.LittleEndianByteArrayOutputStream; import org.apache.poi.util.LittleEndianInput; import org.junit.jupiter.api.Test; -public final class TestConstantValueParser { +final class TestConstantValueParser { private static final Object[] SAMPLE_VALUES = { Boolean.TRUE, null, diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java index 8f8f136695..40b9a09715 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestAreaEval.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; /** * Tests for AreaEval */ -public final class TestAreaEval { +final class TestAreaEval { @Test void testGetValue_bug44950() { diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java index 092d6fbd55..3155ba5b37 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestDivideEval.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; /** * Test for divide operator evaluator. */ -public final class TestDivideEval { +final class TestDivideEval { private static void confirm(ValueEval arg0, ValueEval arg1, double expectedResult) { ValueEval[] args = { diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java index f67b6dbce0..8d8e29f2f0 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestEqualEval.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Test for EqualEval */ -public final class TestEqualEval { +final class TestEqualEval { /** * Test for bug observable at svn revision 692218 (Sep 2008)
* The value from a 1x1 area should be taken immediately, regardless of srcRow and srcCol diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java b/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java index ee9da53893..e4eba2c296 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestExternalFunction.java @@ -34,7 +34,7 @@ import org.apache.poi.ss.formula.udf.DefaultUDFFinder; import org.apache.poi.ss.formula.udf.UDFFinder; import org.junit.jupiter.api.Test; -public final class TestExternalFunction { +final class TestExternalFunction { private static ValueEval myFunc1(ValueEval[] args, OperationEvaluationContext ec) { if (args.length != 1 || !(args[0] instanceof StringEval)) { diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java b/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java index fa6ce1b86a..b82532592d 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestFormulaBugs.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; * Miscellaneous tests for bugzilla entries.

The test name contains the * bugzilla bug id. */ -public final class TestFormulaBugs { +final class TestFormulaBugs { /** * Bug 27349 - VLOOKUP with reference to another sheet.

This test was diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestHSSFCircularReferences.java b/src/testcases/org/apache/poi/ss/formula/eval/TestHSSFCircularReferences.java index f1e21b42d7..90d9739efb 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestHSSFCircularReferences.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestHSSFCircularReferences.java @@ -24,7 +24,7 @@ import org.apache.poi.hssf.HSSFITestDataProvider; * * @author Josh Micich */ -public final class TestHSSFCircularReferences extends BaseTestCircularReferences { +final class TestHSSFCircularReferences extends BaseTestCircularReferences { public TestHSSFCircularReferences() { super(HSSFITestDataProvider.instance); } diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java b/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java index c239f1f933..f5a73d186d 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestMinusZeroResult.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; *

  • Comparison operators have slightly different rules regarding '-0.0'.
    • * */ -public final class TestMinusZeroResult { +final class TestMinusZeroResult { private static final double MINUS_ZERO = -0.0; @Test diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java index 4eeffce2bc..a89db5837f 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestMissingArgEval.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link MissingArgEval} */ -public final class TestMissingArgEval { +final class TestMissingArgEval { @Test void testEvaluateMissingArgs() throws IOException { diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java index 88050c8bb6..981a94fe69 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestMultiSheetEval.java @@ -44,7 +44,7 @@ import org.junit.jupiter.params.provider.MethodSource; /** * Tests formulas for multi sheet reference (i.e. SUM(Sheet1:Sheet5!A1)) */ -public final class TestMultiSheetEval { +final class TestMultiSheetEval { /** * This class defines constants for navigating around the test data spreadsheet used for these tests. */ diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java b/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java index dbf333cb1e..f37b818142 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestOperandResolver.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Tests for OperandResolver */ -public final class TestOperandResolver { +final class TestOperandResolver { @Test void testParseDouble_bug48472() { // bug 48472 - StringIndexOutOfBoundsException diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java index d03b1b4dfb..3727cc1c71 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestPercentEval.java @@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test; /** * Test for percent operator evaluator. */ -public final class TestPercentEval { +final class TestPercentEval { private static void confirm(ValueEval arg, double expectedResult) { ValueEval[] args = { diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java index 300be69851..78b0d49ac8 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestPowerEval.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; /** * Tests for power operator evaluator. */ -public final class TestPowerEval { +final class TestPowerEval { @Test void testPositiveValues() { confirm(0, 0, 1); diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java index 458e74df90..f67d8a92ff 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestRangeEval.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; /** * Test for unary plus operator evaluator. */ -public final class TestRangeEval { +final class TestRangeEval { @Test void testPermutations() { diff --git a/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java b/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java index d3c63547b9..febecbe359 100644 --- a/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java +++ b/src/testcases/org/apache/poi/ss/formula/eval/TestUnaryPlusEval.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; /** * Test for unary plus operator evaluator. */ -public final class TestUnaryPlusEval { +final class TestUnaryPlusEval { /** * Test for bug observable at svn revision 618865 (5-Feb-2008)
    diff --git a/src/testcases/org/apache/poi/ss/formula/function/TestFunctionMetadataRegistry.java b/src/testcases/org/apache/poi/ss/formula/function/TestFunctionMetadataRegistry.java index 84ad7d58fb..29853a410d 100644 --- a/src/testcases/org/apache/poi/ss/formula/function/TestFunctionMetadataRegistry.java +++ b/src/testcases/org/apache/poi/ss/formula/function/TestFunctionMetadataRegistry.java @@ -22,7 +22,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; import org.junit.jupiter.api.Test; -public final class TestFunctionMetadataRegistry { +final class TestFunctionMetadataRegistry { @Test void testWellKnownFunctions() { confirmFunction(0, "COUNT"); diff --git a/src/testcases/org/apache/poi/ss/formula/function/TestParseMissingBuiltInFuncs.java b/src/testcases/org/apache/poi/ss/formula/function/TestParseMissingBuiltInFuncs.java index d3837d57a9..c95eae8871 100644 --- a/src/testcases/org/apache/poi/ss/formula/function/TestParseMissingBuiltInFuncs.java +++ b/src/testcases/org/apache/poi/ss/formula/function/TestParseMissingBuiltInFuncs.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * Tests parsing of some built-in functions that were not properly * registered in POI as of bug #44675, #44733 (March/April 2008). */ -public final class TestParseMissingBuiltInFuncs { +final class TestParseMissingBuiltInFuncs { private static Ptg[] parse(String formula) throws IOException { HSSFWorkbook book = new HSSFWorkbook(); diff --git a/src/testcases/org/apache/poi/ss/formula/function/TestReadMissingBuiltInFuncs.java b/src/testcases/org/apache/poi/ss/formula/function/TestReadMissingBuiltInFuncs.java index 6dc3800160..c26220dbd8 100644 --- a/src/testcases/org/apache/poi/ss/formula/function/TestReadMissingBuiltInFuncs.java +++ b/src/testcases/org/apache/poi/ss/formula/function/TestReadMissingBuiltInFuncs.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; * Tests reading from a sample spreadsheet some built-in functions that were not properly * registered in POI as of bug #44675, #44733 (March/April 2008). */ -public final class TestReadMissingBuiltInFuncs { +final class TestReadMissingBuiltInFuncs { /** * This spreadsheet has examples of calls to the interesting built-in functions in cells A1:A7 diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestAddress.java b/src/testcases/org/apache/poi/ss/formula/functions/TestAddress.java index b9bf41f854..766ccc303e 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestAddress.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestAddress.java @@ -25,7 +25,7 @@ import org.apache.poi.ss.usermodel.CellType; import org.apache.poi.ss.usermodel.CellValue; import org.junit.jupiter.api.Test; -public final class TestAddress { +final class TestAddress { @Test void testAddress() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestAreas.java b/src/testcases/org/apache/poi/ss/formula/functions/TestAreas.java index 8f9828e004..3137614d3a 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestAreas.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestAreas.java @@ -26,7 +26,7 @@ import org.apache.poi.ss.usermodel.CellType; import org.apache.poi.ss.usermodel.CellValue; import org.junit.jupiter.api.Test; -public final class TestAreas { +final class TestAreas { @Test void testAreas() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestAverage.java b/src/testcases/org/apache/poi/ss/formula/functions/TestAverage.java index 5f12764210..bfee8f6ad6 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestAverage.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestAverage.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Tests for Excel function AVERAGE() */ -public final class TestAverage { +final class TestAverage { private static ValueEval invokeAverage(ValueEval[] args) { return AggregateFunction.AVERAGE.evaluate(args, -1, (short)-1); diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestBin2Dec.java b/src/testcases/org/apache/poi/ss/formula/functions/TestBin2Dec.java index 314d22a8a9..e873ba227c 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestBin2Dec.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestBin2Dec.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * * @author cedric dot walter @ gmail dot com */ -public final class TestBin2Dec { +final class TestBin2Dec { private static ValueEval invokeValue(String number1) { ValueEval[] args = new ValueEval[] { new StringEval(number1) }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestCalendarFieldFunction.java b/src/testcases/org/apache/poi/ss/formula/functions/TestCalendarFieldFunction.java index 96d4becd54..b59eb221a4 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestCalendarFieldFunction.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestCalendarFieldFunction.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; /** * Test for YEAR / MONTH / DAY / HOUR / MINUTE / SECOND */ -public final class TestCalendarFieldFunction { +final class TestCalendarFieldFunction { private HSSFCell cell11; private HSSFFormulaEvaluator evaluator; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestClean.java b/src/testcases/org/apache/poi/ss/formula/functions/TestClean.java index 9a11fe69cc..1ab4f90ea0 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestClean.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestClean.java @@ -25,7 +25,7 @@ import org.apache.poi.ss.usermodel.CellType; import org.apache.poi.ss.usermodel.CellValue; import org.junit.jupiter.api.Test; -public final class TestClean { +final class TestClean { @Test void testClean() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestCountFuncs.java b/src/testcases/org/apache/poi/ss/formula/functions/TestCountFuncs.java index 174a71e24d..6b351fbe0d 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestCountFuncs.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestCountFuncs.java @@ -46,7 +46,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for COUNT(), COUNTA() COUNTIF(), COUNTBLANK() */ -public final class TestCountFuncs { +final class TestCountFuncs { private static final String NULL = null; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestDate.java b/src/testcases/org/apache/poi/ss/formula/functions/TestDate.java index 390ba8b286..82d0e82742 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestDate.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestDate.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * @author Pavel Krupets (pkrupets at palmtreebusiness dot com) */ -public final class TestDate { +final class TestDate { private HSSFCell cell11; private HSSFFormulaEvaluator evaluator; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestDateValue.java b/src/testcases/org/apache/poi/ss/formula/functions/TestDateValue.java index 8a63924c4c..fe487b6815 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestDateValue.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestDateValue.java @@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test; * * @author Milosz Rembisz */ -public final class TestDateValue { +final class TestDateValue { @BeforeAll public static void init() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestDays360.java b/src/testcases/org/apache/poi/ss/formula/functions/TestDays360.java index d994077853..b796a4d5b9 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestDays360.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestDays360.java @@ -31,7 +31,7 @@ import org.apache.poi.ss.usermodel.DateUtil; import org.apache.poi.util.LocaleUtil; import org.junit.jupiter.api.Test; -public final class TestDays360 { +final class TestDays360 { /** * @param month 1-based diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Bin.java b/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Bin.java index d3b481d95b..d745603a5a 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Bin.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Bin.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; * * @author cedric dot walter @ gmail dot com */ -public final class TestDec2Bin { +final class TestDec2Bin { private static ValueEval invokeValue(String number1) { ValueEval[] args = new ValueEval[] { new StringEval(number1) }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Hex.java b/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Hex.java index 4548b9a476..125f9c4396 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Hex.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestDec2Hex.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; * * @author cedric dot walter @ gmail dot com */ -public final class TestDec2Hex { +final class TestDec2Hex { private static ValueEval invokeValue(String number1, String number2) { ValueEval[] args = new ValueEval[] { new StringEval(number1), new StringEval(number2), }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestDelta.java b/src/testcases/org/apache/poi/ss/formula/functions/TestDelta.java index 0271ac36de..83aee557f3 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestDelta.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestDelta.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * * @author cedric dot walter @ gmail dot com */ -public final class TestDelta { +final class TestDelta { private static ValueEval invokeValue(String number1, String number2) { ValueEval[] args = new ValueEval[] { new StringEval(number1), new StringEval(number2), }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestFind.java b/src/testcases/org/apache/poi/ss/formula/functions/TestFind.java index daa7130dec..31e50331d0 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestFind.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestFind.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link Financed} */ -public final class TestFind { +final class TestFind { @Test void testFind() throws IOException { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestFixed.java b/src/testcases/org/apache/poi/ss/formula/functions/TestFixed.java index 31ba9da1d7..63f01cdbb6 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestFixed.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestFixed.java @@ -37,7 +37,7 @@ import org.apache.poi.ss.usermodel.FormulaError; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -public final class TestFixed { +final class TestFixed { private HSSFCell cell11; private HSSFFormulaEvaluator evaluator; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestHex2Dec.java b/src/testcases/org/apache/poi/ss/formula/functions/TestHex2Dec.java index 40190a2701..ba5bae0b1f 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestHex2Dec.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestHex2Dec.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * * @author cedric dot walter @ gmail dot com */ -public final class TestHex2Dec { +final class TestHex2Dec { private static ValueEval invokeValue(String number1) { ValueEval[] args = new ValueEval[] { new StringEval(number1) }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIPMT.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIPMT.java index 309bacfd57..e11a2b87c1 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIPMT.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIPMT.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * Test cases for IPMT() * */ -public final class TestIPMT { +final class TestIPMT { /** diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIndex.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIndex.java index 5e71f608a8..b39e396c04 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIndex.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIndex.java @@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test; * Another test: {@link TestIndexFunctionFromSpreadsheet} operates from a higher level * and has far greater coverage of input permutations.
    */ -public final class TestIndex { +final class TestIndex { private static final Index FUNC_INST = new Index(); private static final double[] TEST_VALUES0 = { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIndexFunctionFromSpreadsheet.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIndexFunctionFromSpreadsheet.java index c477104ffb..8bf6ffc1a9 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIndexFunctionFromSpreadsheet.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIndexFunctionFromSpreadsheet.java @@ -24,7 +24,7 @@ import org.junit.jupiter.params.provider.Arguments; /** * Tests INDEX() as loaded from a test data spreadsheet.

    */ -public final class TestIndexFunctionFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { +final class TestIndexFunctionFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { public static Stream data() throws Exception { return data(TestIndexFunctionFromSpreadsheet.class, "IndexFunctionTestCaseData.xls"); } diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIndirect.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIndirect.java index 341e4ad6a1..45422e19e7 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIndirect.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIndirect.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; /** * Tests for the INDIRECT() function.

    */ -public final class TestIndirect { +final class TestIndirect { // convenient access to namespace // private static final ErrorEval EE = null; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIndirectFunctionFromSpreadsheet.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIndirectFunctionFromSpreadsheet.java index 8f7f15fffb..f3a8cccb4f 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIndirectFunctionFromSpreadsheet.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIndirectFunctionFromSpreadsheet.java @@ -28,7 +28,7 @@ import org.junit.jupiter.params.provider.Arguments; * (TestXxxx) of the target (Xxxx) implementor, where execution can be observed * more easily. */ -public final class TestIndirectFunctionFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { +final class TestIndirectFunctionFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { public static Stream data() throws Exception { return data(TestIndirectFunctionFromSpreadsheet.class, "IndirectFunctionTestCaseData.xls"); } diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIntercept.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIntercept.java index b1453c4677..03dac3cef2 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIntercept.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIntercept.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; * * @author Johan Karlsteen */ -public final class TestIntercept { +final class TestIntercept { private static final Function INTERCEPT = new Intercept(); private static ValueEval invoke(Function function, ValueEval xArray, ValueEval yArray) { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java index 73b9e75132..6764ebdc2b 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIrr.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link Irr} */ -public final class TestIrr { +final class TestIrr { @Test void testIrr() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestIsBlank.java b/src/testcases/org/apache/poi/ss/formula/functions/TestIsBlank.java index 749139d240..9f6ece060c 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestIsBlank.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestIsBlank.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestIsBlank { +final class TestIsBlank { @Test void test3DArea() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestLen.java b/src/testcases/org/apache/poi/ss/formula/functions/TestLen.java index 5283b969ac..b4d8aa7a13 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestLen.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestLen.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestLen { +final class TestLen { private static ValueEval invokeLen(ValueEval text) { ValueEval[] args = new ValueEval[] { text, }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestLookupFunctionsFromSpreadsheet.java b/src/testcases/org/apache/poi/ss/formula/functions/TestLookupFunctionsFromSpreadsheet.java index ad0a60ec9b..84d3674b70 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestLookupFunctionsFromSpreadsheet.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestLookupFunctionsFromSpreadsheet.java @@ -30,7 +30,7 @@ import org.junit.jupiter.params.provider.Arguments; * (TestXxxx) of the target (Xxxx) implementor, where execution can be observed * more easily. */ -public final class TestLookupFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { +final class TestLookupFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { public static Stream data() throws Exception { return data(TestLookupFunctionsFromSpreadsheet.class, "LookupFunctionsTestCaseData.xls"); } diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestMatch.java b/src/testcases/org/apache/poi/ss/formula/functions/TestMatch.java index fd434fb23c..3721c688df 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestMatch.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestMatch.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for MATCH() */ -public final class TestMatch { +final class TestMatch { /** less than or equal to */ private static final NumberEval MATCH_LARGEST_LTE = new NumberEval(1); private static final NumberEval MATCH_EXACT = new NumberEval(0); diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestMatchFunctionsFromSpreadsheet.java b/src/testcases/org/apache/poi/ss/formula/functions/TestMatchFunctionsFromSpreadsheet.java index ef7ee77195..7f6f8ca2e6 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestMatchFunctionsFromSpreadsheet.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestMatchFunctionsFromSpreadsheet.java @@ -28,7 +28,7 @@ import org.junit.jupiter.params.provider.Arguments; * (TestXxxx) of the target (Xxxx) implementor, where execution can be observed * more easily. */ -public final class TestMatchFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { +final class TestMatchFunctionsFromSpreadsheet extends BaseTestFunctionsFromSpreadsheet { public static Stream data() throws Exception { return data(TestMatchFunctionsFromSpreadsheet.class, "MatchFunctionTestCaseData.xls"); } diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestMid.java b/src/testcases/org/apache/poi/ss/formula/functions/TestMid.java index 7046329998..866c65fb4a 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestMid.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestMid.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestMid { +final class TestMid { private static ValueEval invokeMid(ValueEval text, ValueEval startPos, ValueEval numChars) { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestMirr.java b/src/testcases/org/apache/poi/ss/formula/functions/TestMirr.java index db7bc7f17d..f640cb54ee 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestMirr.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestMirr.java @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; * @author Cedric Walter (cedric dot walter at gmail dot com) * @see org.apache.poi.ss.formula.functions.TestIrr */ -public final class TestMirr { +final class TestMirr { @Test void testMirr() throws EvaluationException { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestNper.java b/src/testcases/org/apache/poi/ss/formula/functions/TestNper.java index 9ced557280..9f958f0205 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestNper.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestNper.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link FinanceFunction#NPER} */ -public final class TestNper { +final class TestNper { @Test void testSimpleEvaluate() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java b/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java index 35d91b732b..191ff37fef 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestNpv.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; * * @see Excel Help */ -public final class TestNpv { +final class TestNpv { @Test void testEvaluateInSheetExample2() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestOct2Dec.java b/src/testcases/org/apache/poi/ss/formula/functions/TestOct2Dec.java index a714044d92..89c19277d2 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestOct2Dec.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestOct2Dec.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * * @author cedric dot walter @ gmail dot com */ -public final class TestOct2Dec { +final class TestOct2Dec { private static ValueEval invokeValue(String number1) { ValueEval[] args = new ValueEval[] { new StringEval(number1) }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestOffset.java b/src/testcases/org/apache/poi/ss/formula/functions/TestOffset.java index deaafbbd20..fd2ada7b97 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestOffset.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestOffset.java @@ -39,7 +39,7 @@ import org.junit.jupiter.params.provider.CsvSource; * * @author Josh Micich */ -public final class TestOffset { +final class TestOffset { /** * Excel's double to int conversion (for function 'OFFSET()') behaves more like Math.floor(). diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestPPMT.java b/src/testcases/org/apache/poi/ss/formula/functions/TestPPMT.java index f928a1dcd8..0b908063fc 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestPPMT.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestPPMT.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * Test cases for PPMT() * */ -public final class TestPPMT { +final class TestPPMT { /** diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestPmt.java b/src/testcases/org/apache/poi/ss/formula/functions/TestPmt.java index b2b8bab366..0640450a03 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestPmt.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestPmt.java @@ -20,7 +20,6 @@ package org.apache.poi.ss.formula.functions; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotEquals; -import static org.junit.jupiter.api.Assertions.fail; import org.apache.poi.ss.formula.eval.ErrorEval; import org.apache.poi.ss.formula.eval.NumberEval; @@ -28,7 +27,7 @@ import org.apache.poi.ss.formula.eval.ValueEval; import org.apache.poi.ss.usermodel.FormulaError; import org.junit.jupiter.api.Test; -public final class TestPmt { +final class TestPmt { private static void confirm(double expected, NumberEval ne) { // only asserting accuracy to 4 fractional digits diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestRank.java b/src/testcases/org/apache/poi/ss/formula/functions/TestRank.java index a6b8e650e0..90da6fdb0a 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestRank.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestRank.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for RANK() */ -public final class TestRank { +final class TestRank { @Test void testFromFile() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestRoundFuncs.java b/src/testcases/org/apache/poi/ss/formula/functions/TestRoundFuncs.java index 3a73915f71..4450528822 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestRoundFuncs.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestRoundFuncs.java @@ -19,20 +19,19 @@ package org.apache.poi.ss.formula.functions; import static org.junit.jupiter.api.Assertions.assertEquals; -import org.junit.jupiter.api.Disabled; -import org.junit.jupiter.api.Test; - import org.apache.poi.ss.formula.eval.ErrorEval; -import org.apache.poi.ss.formula.eval.ValueEval; import org.apache.poi.ss.formula.eval.NumberEval; import org.apache.poi.ss.formula.eval.StringEval; +import org.apache.poi.ss.formula.eval.ValueEval; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; /** * Test cases for ROUND(), ROUNDUP(), ROUNDDOWN() * * @author Josh Micich */ -public final class TestRoundFuncs { +final class TestRoundFuncs { // github-43 // https://github.com/apache/poi/pull/43 @Disabled("ROUNDUP(3987*0.2, 2) currently fails by returning 797.41") diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestRowCol.java b/src/testcases/org/apache/poi/ss/formula/functions/TestRowCol.java index efdb2dad87..eb2812e0e4 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestRowCol.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestRowCol.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestRowCol { +final class TestRowCol { @Test void testCol() { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java b/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java index 76bc55d0a3..5c8bc1eb33 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestSlope.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * * @author Johan Karlsteen */ -public final class TestSlope { +final class TestSlope { private static final Function SLOPE = new Slope(); private static ValueEval invoke(Function function, ValueEval xArray, ValueEval yArray) { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java b/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java index f42e21c68d..3f4eb88dd8 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestSubtotal.java @@ -42,7 +42,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link Subtotal} */ -public final class TestSubtotal { +final class TestSubtotal { private static final int FUNCTION_AVERAGE = 1; private static final int FUNCTION_COUNT = 2; private static final int FUNCTION_MAX = 4; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java b/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java index 582e330e22..4bd60295a8 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestSumif.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for SUMPRODUCT() */ -public final class TestSumif { +final class TestSumif { private static final NumberEval _30 = new NumberEval(30); private static final NumberEval _40 = new NumberEval(40); private static final NumberEval _50 = new NumberEval(50); diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java b/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java index 2170872874..6aa1962953 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestSumifs.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; /** * Test cases for SUMIFS() */ -public final class TestSumifs { +final class TestSumifs { private static final OperationEvaluationContext EC = new OperationEvaluationContext(null, null, 0, 1, 0, null); diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java b/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java index 17384986e1..35ee48d26c 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestSumproduct.java @@ -19,7 +19,6 @@ package org.apache.poi.ss.formula.functions; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; import org.apache.poi.ss.formula.eval.AreaEval; import org.apache.poi.ss.formula.eval.ErrorEval; @@ -34,7 +33,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestSumproduct { +final class TestSumproduct { private static ValueEval invokeSumproduct(ValueEval[] args) { // srcCellRow and srcCellColumn are ignored by SUMPRODUCT diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java b/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java index a6fd25a68e..03cb480e47 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestTFunc.java @@ -36,7 +36,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestTFunc { +final class TestTFunc { /** * @return the result of calling function T() with the specified argument diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestText.java b/src/testcases/org/apache/poi/ss/formula/functions/TestText.java index acf2fae2f5..ddcdd35165 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestText.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestText.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * Test case for TEXT() */ -public final class TestText { +final class TestText { @Test void testTextWithStringFirstArg() { ValueEval strArg = new StringEval("abc"); diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java b/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java index 24c4deed1e..d45787b2a5 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestTime.java @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link TimeFunc} */ -public final class TestTime { +final class TestTime { private static final int SECONDS_PER_MINUTE = 60; private static final int SECONDS_PER_HOUR = 60 * SECONDS_PER_MINUTE; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java b/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java index edc39f7706..efee41b996 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestTrim.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestTrim { +final class TestTrim { private static ValueEval invokeTrim(ValueEval text) { diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java b/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java index da6c969a93..6e1d5d8cac 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestTrunc.java @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; * * @author Stephen Wolke (smwolke at geistig.com) */ -public final class TestTrunc extends BaseTestNumeric { +final class TestTrunc extends BaseTestNumeric { private static final NumericFunction F = null; @Test diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java b/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java index cf65c42817..a733f243de 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestValue.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link Value} */ -public final class TestValue { +final class TestValue { private static ValueEval invokeValue(String strText) { ValueEval[] args = new ValueEval[] { new StringEval(strText), }; diff --git a/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java b/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java index 077061c316..b97e80171e 100644 --- a/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java +++ b/src/testcases/org/apache/poi/ss/formula/functions/TestXYNumericFunction.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; * * @author Josh Micich */ -public final class TestXYNumericFunction { +final class TestXYNumericFunction { private static final Function SUM_SQUARES = new Sumx2py2(); private static final Function DIFF_SQUARES = new Sumx2my2(); private static final Function SUM_SQUARES_OF_DIFFS = new Sumxmy2(); diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java index 6a5c1af504..51b8c32f28 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestArea3DPtg.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for Area3DPtg */ -public final class TestArea3DPtg extends BaseTestPtg { +final class TestArea3DPtg extends BaseTestPtg { /** * confirms that sheet names get properly escaped diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java index 70b73f0c78..91e76c08ef 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaErrPtg.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link AreaErrPtg}. */ -public final class TestAreaErrPtg extends BaseTestPtg { +final class TestAreaErrPtg extends BaseTestPtg { /** * Tests reading a file containing this ptg. */ diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java index 71789d3c94..ea5a2cee50 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestAreaPtg.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link AreaPtg}. */ -public final class TestAreaPtg { +final class TestAreaPtg { AreaPtg relative; AreaPtg absolute; diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java index 6f8c09ad08..c5a1b44bd0 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestArrayPtg.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; /** * Tests for ArrayPtg */ -public final class TestArrayPtg { +final class TestArrayPtg { private static final byte[] ENCODED_PTG_DATA = { 0x40, diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java index e09463ef10..142f4a574f 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestAttrPtg.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link AttrPtg}. */ -public final class TestAttrPtg extends BaseTestPtg { +final class TestAttrPtg extends BaseTestPtg { /** * Fix for bug visible around svn r706772. diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java index 4b5a4b8c19..bddba7ff54 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestErrPtg.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link ErrPtg}. */ -public final class TestErrPtg extends BaseTestPtg { +final class TestErrPtg extends BaseTestPtg { /** * Tests reading a file containing this ptg. */ diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java index bdc92a70a9..fedc639764 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalFunctionFormulas.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; /** * Tests for functions from external workbooks (e.g. YEARFRAC). */ -public final class TestExternalFunctionFormulas { +final class TestExternalFunctionFormulas { /** * tests NameXPtg.toFormulaString(Workbook) and logic in Workbook below that diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java index 7e3a9a44f8..0c582c5cf7 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestExternalNameReference.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Tests for proper calculation of named ranges from external workbooks. */ -public final class TestExternalNameReference { +final class TestExternalNameReference { double MARKUP_COST_1 = 1.8d; double MARKUP_COST_2 = 1.5d; double PART_COST = 12.3d; diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java index dd91bff392..fd6027fa93 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncPtg.java @@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test; /** * Make sure the FuncPtg performs as expected */ -public final class TestFuncPtg { +final class TestFuncPtg { @Test void testRead() { diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java index 83c13ce1a1..2eb91217cb 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestFuncVarPtg.java @@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test; /** * @author Josh Micich */ -public final class TestFuncVarPtg { +final class TestFuncVarPtg { /** * The first fix for bugzilla 44675 broke the encoding of SUM formulas (and probably others). diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java index ac6ad197b6..91ed33b1e9 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestIntersectionPtg.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link IntersectionPtg}. */ -public final class TestIntersectionPtg extends BaseTestPtg { +final class TestIntersectionPtg extends BaseTestPtg { /** * Tests reading a file containing this ptg. */ diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java index 309db5bac7..7a806f15cd 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestPercentPtg.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link PercentPtg}. */ -public final class TestPercentPtg extends BaseTestPtg { +final class TestPercentPtg extends BaseTestPtg { /** * Tests reading a file containing this ptg. */ diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java index 189af759b2..6ff906c96c 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestRangePtg.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link RangePtg}. */ -public final class TestRangePtg extends BaseTestPtg { +final class TestRangePtg extends BaseTestPtg { /** * Tests reading a file containing this ptg. */ diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java index 965428340a..2a1b44e6fc 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestRef3DPtg.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for Ref3DPtg */ -public final class TestRef3DPtg extends BaseTestPtg { +final class TestRef3DPtg extends BaseTestPtg { @Test void testToFormulaString() throws IOException { diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java index af571ecddd..cc67d4304a 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestReferencePtg.java @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link RefPtg}. */ -public final class TestReferencePtg { +final class TestReferencePtg { /** * Tests reading a file containing this ptg. */ diff --git a/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java b/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java index bde83c06b3..7b85995a02 100644 --- a/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java +++ b/src/testcases/org/apache/poi/ss/formula/ptg/TestUnionPtg.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link UnionPtg}. */ -public final class TestUnionPtg extends BaseTestPtg { +final class TestUnionPtg extends BaseTestPtg { /** * Tests reading a file containing this ptg. */ diff --git a/src/testcases/org/apache/poi/ss/usermodel/TestFractionFormat.java b/src/testcases/org/apache/poi/ss/usermodel/TestFractionFormat.java index f68c1143bb..7a45018569 100644 --- a/src/testcases/org/apache/poi/ss/usermodel/TestFractionFormat.java +++ b/src/testcases/org/apache/poi/ss/usermodel/TestFractionFormat.java @@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test; * Tests for the Fraction Formatting part of DataFormatter. * Largely taken from bug #54686 */ -public final class TestFractionFormat { +final class TestFractionFormat { @Test void testSingle() { FractionFormat f = new FractionFormat("", "##"); diff --git a/src/testcases/org/apache/poi/ss/usermodel/TestHSSFBorderStyle.java b/src/testcases/org/apache/poi/ss/usermodel/TestHSSFBorderStyle.java index 721464573f..202ffae308 100644 --- a/src/testcases/org/apache/poi/ss/usermodel/TestHSSFBorderStyle.java +++ b/src/testcases/org/apache/poi/ss/usermodel/TestHSSFBorderStyle.java @@ -22,7 +22,7 @@ import org.apache.poi.hssf.HSSFITestDataProvider; /** * @author Yegor Kozlov */ -public final class TestHSSFBorderStyle extends BaseTestBorderStyle { +final class TestHSSFBorderStyle extends BaseTestBorderStyle { public TestHSSFBorderStyle() { super(HSSFITestDataProvider.instance); diff --git a/src/testcases/org/apache/poi/ss/usermodel/TestIndexedColors.java b/src/testcases/org/apache/poi/ss/usermodel/TestIndexedColors.java index 40889cae75..d336ea95cd 100644 --- a/src/testcases/org/apache/poi/ss/usermodel/TestIndexedColors.java +++ b/src/testcases/org/apache/poi/ss/usermodel/TestIndexedColors.java @@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test; /** * @author Yegor Kozlov */ -public final class TestIndexedColors { +final class TestIndexedColors { @Test void fromInt() { diff --git a/src/testcases/org/apache/poi/ss/util/TestCellAddress.java b/src/testcases/org/apache/poi/ss/util/TestCellAddress.java index fa67df58fc..044203f3c2 100644 --- a/src/testcases/org/apache/poi/ss/util/TestCellAddress.java +++ b/src/testcases/org/apache/poi/ss/util/TestCellAddress.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Tests that the common CellAddress works as we need it to. */ -public final class TestCellAddress { +final class TestCellAddress { @Test void testConstructors() { CellAddress cellAddress; diff --git a/src/testcases/org/apache/poi/ss/util/TestCellRangeAddress.java b/src/testcases/org/apache/poi/ss/util/TestCellRangeAddress.java index 46c8363895..01d12f41c3 100644 --- a/src/testcases/org/apache/poi/ss/util/TestCellRangeAddress.java +++ b/src/testcases/org/apache/poi/ss/util/TestCellRangeAddress.java @@ -34,7 +34,7 @@ import org.apache.poi.hssf.record.TestcaseRecordInputStream; import org.apache.poi.util.LittleEndianOutputStream; import org.junit.jupiter.api.Test; -public final class TestCellRangeAddress { +final class TestCellRangeAddress { static final byte[] data = new byte[] { 0x02, 0x00, 0x04, 0x00, 0x00, 0x00, 0x03, 0x00, diff --git a/src/testcases/org/apache/poi/ss/util/TestCellRangeUtil.java b/src/testcases/org/apache/poi/ss/util/TestCellRangeUtil.java index 9d6c42cc64..5b402a3bcd 100644 --- a/src/testcases/org/apache/poi/ss/util/TestCellRangeUtil.java +++ b/src/testcases/org/apache/poi/ss/util/TestCellRangeUtil.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; * * @see org.apache.poi.ss.util.CellRangeUtil */ -public final class TestCellRangeUtil { +final class TestCellRangeUtil { private static final CellRangeAddress A1 = new CellRangeAddress(0, 0, 0, 0); private static final CellRangeAddress B1 = new CellRangeAddress(0, 0, 1, 1); diff --git a/src/testcases/org/apache/poi/ss/util/TestCellReference.java b/src/testcases/org/apache/poi/ss/util/TestCellReference.java index d174d64235..0d2d791374 100644 --- a/src/testcases/org/apache/poi/ss/util/TestCellReference.java +++ b/src/testcases/org/apache/poi/ss/util/TestCellReference.java @@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test; * Note - some additional testing is also done in the HSSF class, * {@link org.apache.poi.hssf.util.TestCellReference} */ -public final class TestCellReference { +final class TestCellReference { @Test void testConstructors() { CellReference cellReference; diff --git a/src/testcases/org/apache/poi/ss/util/TestDateFormatConverter.java b/src/testcases/org/apache/poi/ss/util/TestDateFormatConverter.java index fb5e1169e2..3113bc95e9 100644 --- a/src/testcases/org/apache/poi/ss/util/TestDateFormatConverter.java +++ b/src/testcases/org/apache/poi/ss/util/TestDateFormatConverter.java @@ -48,7 +48,7 @@ import org.apache.poi.util.LocaleID; import org.apache.poi.util.TempFile; import org.junit.jupiter.api.Test; -public final class TestDateFormatConverter { +final class TestDateFormatConverter { private void outputLocaleDataFormats( Date date, boolean dates, boolean times, int style, String styleName ) throws Exception { try (Workbook workbook = new HSSFWorkbook()) { String sheetName; diff --git a/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java b/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java index 937b53a036..30f84a3eb7 100644 --- a/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java +++ b/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link ExpandedDouble} */ -public final class TestExpandedDouble { +final class TestExpandedDouble { private static final BigInteger BIG_POW_10 = BigInteger.valueOf(1000000000); @Test diff --git a/src/testcases/org/apache/poi/ss/util/TestNumberComparer.java b/src/testcases/org/apache/poi/ss/util/TestNumberComparer.java index d5f95cf407..42a0edd841 100644 --- a/src/testcases/org/apache/poi/ss/util/TestNumberComparer.java +++ b/src/testcases/org/apache/poi/ss/util/TestNumberComparer.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link NumberComparer} */ -public final class TestNumberComparer { +final class TestNumberComparer { @Test void testAllComparisonExamples() { diff --git a/src/testcases/org/apache/poi/ss/util/TestNumberToTextConverter.java b/src/testcases/org/apache/poi/ss/util/TestNumberToTextConverter.java index 0cf5d6f818..387980d870 100644 --- a/src/testcases/org/apache/poi/ss/util/TestNumberToTextConverter.java +++ b/src/testcases/org/apache/poi/ss/util/TestNumberToTextConverter.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Tests for {@link NumberToTextConverter} */ -public final class TestNumberToTextConverter { +final class TestNumberToTextConverter { /** * Confirms that ExcelNumberToTextConverter.toText(d) produces the right results. * As part of preparing this test class, the ExampleConversion instances should be set diff --git a/src/testcases/org/apache/poi/ss/util/TestPropertyTemplate.java b/src/testcases/org/apache/poi/ss/util/TestPropertyTemplate.java index 603bbb0d59..bd57735706 100644 --- a/src/testcases/org/apache/poi/ss/util/TestPropertyTemplate.java +++ b/src/testcases/org/apache/poi/ss/util/TestPropertyTemplate.java @@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test; * * @see org.apache.poi.ss.util.PropertyTemplate */ -public final class TestPropertyTemplate { +final class TestPropertyTemplate { @Test void getNumBorders() throws IOException { CellRangeAddress a1 = new CellRangeAddress(0, 0, 0, 0); diff --git a/src/testcases/org/apache/poi/ss/util/TestRegionUtil.java b/src/testcases/org/apache/poi/ss/util/TestRegionUtil.java index afa0ec0dfc..1fcd52ca80 100644 --- a/src/testcases/org/apache/poi/ss/util/TestRegionUtil.java +++ b/src/testcases/org/apache/poi/ss/util/TestRegionUtil.java @@ -17,7 +17,9 @@ package org.apache.poi.ss.util; -import static org.junit.jupiter.api.Assertions.*; +import static org.junit.jupiter.api.Assertions.assertEquals; + +import java.io.IOException; import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.apache.poi.ss.usermodel.BorderStyle; @@ -31,12 +33,10 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -import java.io.IOException; - /** * Tests that the common RegionUtil works as we need it to. */ -public final class TestRegionUtil { +final class TestRegionUtil { private static final CellRangeAddress A1C3 = new CellRangeAddress(0, 2, 0, 2); private static final BorderStyle NONE = BorderStyle.NONE; private static final BorderStyle THIN = BorderStyle.THIN; diff --git a/src/testcases/org/apache/poi/ss/util/TestSheetBuilder.java b/src/testcases/org/apache/poi/ss/util/TestSheetBuilder.java index 895766c7b3..e258895c8f 100644 --- a/src/testcases/org/apache/poi/ss/util/TestSheetBuilder.java +++ b/src/testcases/org/apache/poi/ss/util/TestSheetBuilder.java @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; * * @see org.apache.poi.ss.util.SheetBuilder */ -public final class TestSheetBuilder { +final class TestSheetBuilder { private static Object[][] testData = new Object[][]{ {1, 2, 3}, diff --git a/src/testcases/org/apache/poi/ss/util/TestSheetUtil.java b/src/testcases/org/apache/poi/ss/util/TestSheetUtil.java index 709b6deb9b..c61ba56401 100644 --- a/src/testcases/org/apache/poi/ss/util/TestSheetUtil.java +++ b/src/testcases/org/apache/poi/ss/util/TestSheetUtil.java @@ -17,6 +17,13 @@ package org.apache.poi.ss.util; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.io.IOException; + import org.apache.poi.hssf.usermodel.HSSFWorkbook; import org.apache.poi.ss.usermodel.Cell; import org.apache.poi.ss.usermodel.Row; @@ -24,19 +31,12 @@ import org.apache.poi.ss.usermodel.Sheet; import org.apache.poi.ss.usermodel.Workbook; import org.junit.jupiter.api.Test; -import java.io.IOException; - -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertNotNull; -import static org.junit.jupiter.api.Assertions.assertNull; -import static org.junit.jupiter.api.Assertions.assertTrue; - /** * Tests SheetUtil. * * @see org.apache.poi.ss.util.SheetUtil */ -public final class TestSheetUtil { +final class TestSheetUtil { @Test void testCellWithMerges() throws Exception { try (Workbook wb = new HSSFWorkbook()) { diff --git a/src/testcases/org/apache/poi/ss/util/TestWorkbookUtil.java b/src/testcases/org/apache/poi/ss/util/TestWorkbookUtil.java index 3725c63940..bb4094a470 100644 --- a/src/testcases/org/apache/poi/ss/util/TestWorkbookUtil.java +++ b/src/testcases/org/apache/poi/ss/util/TestWorkbookUtil.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; * * @see org.apache.poi.ss.util.WorkbookUtil */ -public final class TestWorkbookUtil { +final class TestWorkbookUtil { /** * borrowed test cases from * {@link org.apache.poi.hssf.record.TestBoundSheetRecord#testValidNames()} diff --git a/src/testcases/org/apache/poi/util/TestBitField.java b/src/testcases/org/apache/poi/util/TestBitField.java index 2834466979..55c30087fa 100644 --- a/src/testcases/org/apache/poi/util/TestBitField.java +++ b/src/testcases/org/apache/poi/util/TestBitField.java @@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test; /** * Class to test BitField functionality */ -public final class TestBitField { +final class TestBitField { private static BitField bf_multi = BitFieldFactory.getInstance(0x3F80); private static BitField bf_single = BitFieldFactory.getInstance(0x4000); diff --git a/src/testcases/org/apache/poi/util/TestByteField.java b/src/testcases/org/apache/poi/util/TestByteField.java index 782a87b032..8c37667fbc 100644 --- a/src/testcases/org/apache/poi/util/TestByteField.java +++ b/src/testcases/org/apache/poi/util/TestByteField.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Unit test for ByteField class */ -public final class TestByteField { +final class TestByteField { private static final byte[] _test_array = { Byte.MIN_VALUE, ( byte ) -1, ( byte ) 0, ( byte ) 1, Byte.MAX_VALUE diff --git a/src/testcases/org/apache/poi/util/TestIOUtils.java b/src/testcases/org/apache/poi/util/TestIOUtils.java index a4a3513ba5..196fcf401b 100644 --- a/src/testcases/org/apache/poi/util/TestIOUtils.java +++ b/src/testcases/org/apache/poi/util/TestIOUtils.java @@ -45,7 +45,7 @@ import org.junit.jupiter.api.Test; /** * Class to test IOUtils */ -public final class TestIOUtils { +final class TestIOUtils { private static File TMP; private static final long LENGTH = 300+new Random().nextInt(9000); diff --git a/src/testcases/org/apache/poi/util/TestIntList.java b/src/testcases/org/apache/poi/util/TestIntList.java index 38e8cc2cc3..3483933ce4 100644 --- a/src/testcases/org/apache/poi/util/TestIntList.java +++ b/src/testcases/org/apache/poi/util/TestIntList.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; * * @author Marc Johnson */ -public final class TestIntList { +final class TestIntList { @Test void testConstructors() { IntList list = new IntList(); diff --git a/src/testcases/org/apache/poi/util/TestIntegerField.java b/src/testcases/org/apache/poi/util/TestIntegerField.java index 96740ce464..d8e2f1b66f 100644 --- a/src/testcases/org/apache/poi/util/TestIntegerField.java +++ b/src/testcases/org/apache/poi/util/TestIntegerField.java @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Test IntegerField code */ -public final class TestIntegerField { +final class TestIntegerField { private static final int[] _test_array = {Integer.MIN_VALUE, -1, 0, 1, Integer.MAX_VALUE}; diff --git a/src/testcases/org/apache/poi/util/TestLittleEndian.java b/src/testcases/org/apache/poi/util/TestLittleEndian.java index 268dba5621..27e5e3fe1a 100644 --- a/src/testcases/org/apache/poi/util/TestLittleEndian.java +++ b/src/testcases/org/apache/poi/util/TestLittleEndian.java @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; /** * Class to test LittleEndian functionality */ -public final class TestLittleEndian { +final class TestLittleEndian { /** * test the getShort() method diff --git a/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java b/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java index dfeff3cc04..54ebefa5b5 100644 --- a/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java +++ b/src/testcases/org/apache/poi/util/TestLittleEndianStreams.java @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; /** * Class to test {@link LittleEndianInputStream} and {@link LittleEndianOutputStream} */ -public final class TestLittleEndianStreams { +final class TestLittleEndianStreams { @Test void testRead() throws IOException { diff --git a/src/testcases/org/apache/poi/util/TestLongField.java b/src/testcases/org/apache/poi/util/TestLongField.java index 164c6ceb01..8cd39aba92 100644 --- a/src/testcases/org/apache/poi/util/TestLongField.java +++ b/src/testcases/org/apache/poi/util/TestLongField.java @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; /** * Test LongField code */ -public final class TestLongField { +final class TestLongField { static private final long[] _test_array = { diff --git a/src/testcases/org/apache/poi/util/TestPOILogFactory.java b/src/testcases/org/apache/poi/util/TestPOILogFactory.java index 9fa8fe8271..05553887d6 100644 --- a/src/testcases/org/apache/poi/util/TestPOILogFactory.java +++ b/src/testcases/org/apache/poi/util/TestPOILogFactory.java @@ -19,7 +19,7 @@ package org.apache.poi.util; import org.junit.jupiter.api.Test; -public final class TestPOILogFactory { +final class TestPOILogFactory { /** diff --git a/src/testcases/org/apache/poi/util/TestShortField.java b/src/testcases/org/apache/poi/util/TestShortField.java index 73f22250ca..8c863ee074 100644 --- a/src/testcases/org/apache/poi/util/TestShortField.java +++ b/src/testcases/org/apache/poi/util/TestShortField.java @@ -19,7 +19,6 @@ package org.apache.poi.util; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.junit.jupiter.api.Assertions.fail; import java.io.ByteArrayInputStream; import java.io.IOException; @@ -29,7 +28,7 @@ import org.junit.jupiter.api.Test; /** * Test ShortField code */ -public final class TestShortField { +final class TestShortField { private static final short[] _test_array = {Short.MIN_VALUE, -1, 0, 1, Short.MAX_VALUE}; -- 2.39.5