From 1303c4562196a5f34348c3884d3a9580c58b49a3 Mon Sep 17 00:00:00 2001
From: Stas Vilchik <stas.vilchik@sonarsource.com>
Date: Thu, 23 Aug 2018 16:57:16 +0200
Subject: [PATCH] SONAR-10678 Make global navigation links on the right side
 discernible

---
 .../app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx   | 3 ++-
 .../src/main/js/app/components/nav/global/GlobalNavPlus.tsx    | 3 ++-
 .../src/main/js/app/components/nav/global/GlobalNavUser.tsx    | 2 +-
 .../global/__tests__/__snapshots__/GlobalNavUser-test.tsx.snap | 3 +++
 sonar-core/src/main/resources/org/sonar/l10n/core.properties   | 1 +
 5 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx b/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx
index f9671bc289e..ff39f16ad71 100644
--- a/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx
+++ b/server/sonar-web/src/main/js/app/components/embed-docs-modal/EmbedDocsPopupHelper.tsx
@@ -23,6 +23,7 @@ import { CurrentUser } from '../../types';
 import Toggler from '../../../components/controls/Toggler';
 import HelpIcon from '../../../components/icons-components/HelpIcon';
 import { lazyLoad } from '../../../components/lazyLoad';
+import { translate } from '../../../helpers/l10n';
 
 const EmbedDocsPopup = lazyLoad(() => import('./EmbedDocsPopup'));
 
@@ -90,7 +91,7 @@ export default class EmbedDocsPopupHelper extends React.PureComponent<Props, Sta
               suggestions={this.props.suggestions}
             />
           }>
-          <a className="navbar-help" href="#" onClick={this.handleClick}>
+          <a className="navbar-help" href="#" onClick={this.handleClick} title={translate('help')}>
             <HelpIcon />
           </a>
         </Toggler>
diff --git a/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavPlus.tsx b/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavPlus.tsx
index 629bdc20180..a191797ca53 100644
--- a/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavPlus.tsx
+++ b/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavPlus.tsx
@@ -88,7 +88,8 @@ export default class GlobalNavPlus extends React.PureComponent<Props, State> {
               aria-haspopup="true"
               className="navbar-plus"
               href="#"
-              onClick={onToggleClick}>
+              onClick={onToggleClick}
+              title={translate('my_account.create_new_project_or_organization')}>
               <PlusIcon />
             </a>
 
diff --git a/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavUser.tsx b/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavUser.tsx
index af85d305412..8d11216b9f7 100644
--- a/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavUser.tsx
+++ b/server/sonar-web/src/main/js/app/components/nav/global/GlobalNavUser.tsx
@@ -101,7 +101,7 @@ export default class GlobalNavUser extends React.PureComponent<Props> {
           </ul>
         }
         tagName="li">
-        <a className="dropdown-toggle navbar-avatar" href="#">
+        <a className="dropdown-toggle navbar-avatar" href="#" title={currentUser.name}>
           <Avatar
             hash={currentUser.avatar}
             name={currentUser.name}
diff --git a/server/sonar-web/src/main/js/app/components/nav/global/__tests__/__snapshots__/GlobalNavUser-test.tsx.snap b/server/sonar-web/src/main/js/app/components/nav/global/__tests__/__snapshots__/GlobalNavUser-test.tsx.snap
index 316ff4a8e44..8b49b3f0961 100644
--- a/server/sonar-web/src/main/js/app/components/nav/global/__tests__/__snapshots__/GlobalNavUser-test.tsx.snap
+++ b/server/sonar-web/src/main/js/app/components/nav/global/__tests__/__snapshots__/GlobalNavUser-test.tsx.snap
@@ -52,6 +52,7 @@ exports[`should not render user organizations when they are not activated 1`] =
   <a
     className="dropdown-toggle navbar-avatar"
     href="#"
+    title="foo"
   >
     <Connect(Avatar)
       hash="abcd1234"
@@ -126,6 +127,7 @@ exports[`should render the right interface for logged in user 1`] = `
   <a
     className="dropdown-toggle navbar-avatar"
     href="#"
+    title="foo"
   >
     <Connect(Avatar)
       hash="abcd1234"
@@ -232,6 +234,7 @@ exports[`should render user organizations 1`] = `
   <a
     className="dropdown-toggle navbar-avatar"
     href="#"
+    title="foo"
   >
     <Connect(Avatar)
       hash="abcd1234"
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 9e99464d8f4..8fa0eb0de7e 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -1495,6 +1495,7 @@ my_account.search_project=Search Project
 my_account.set_notifications_for=Set notifications for
 my_account.analyze_new_project=Analyze new project
 my_account.create_new_organization=Create new organization
+my_account.create_new_project_or_organization=Create new project or organization
 
 
 #------------------------------------------------------------------------------
-- 
2.39.5