From 1402650134da47f48f6631b98b102f499936c752 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Scott=20Gonz=C3=A1lez?= Date: Mon, 8 Feb 2010 01:17:04 +0000 Subject: [PATCH] Autocomplete: Fixed a few places that got missed during the change to always keep the menu element around. Fixes a bug where opening the menu using the arrow keys would cycle through the options, but not show the menu. There's now a bug where you have to arrow too many times to get into the menu when showing the menu by using the arrow keys. --- ui/jquery.ui.autocomplete.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js index 470ae1636..c6d2e5578 100644 --- a/ui/jquery.ui.autocomplete.js +++ b/ui/jquery.ui.autocomplete.js @@ -92,7 +92,7 @@ $.widget( "ui.autocomplete", { this.response = function() { return self._response.apply( self, arguments ); }; - this.menu = $("") + this.menu = $( "" ) .addClass( "ui-autocomplete" ) .appendTo( this.element.parent() ) .menu({ @@ -139,9 +139,7 @@ $.widget( "ui.autocomplete", { .removeAttr( "role" ) .removeAttr( "aria-autocomplete" ) .removeAttr( "aria-haspopup" ); - if ( this.menu ) { - this.menu.element.remove(); - } + this.menu.element.remove(); $.Widget.prototype.destroy.call( this ); }, @@ -237,8 +235,7 @@ $.widget( "ui.autocomplete", { }, _suggest: function( items ) { - this.menu.element.empty(); - var ul = this.menu.element; + var ul = this.menu.element.empty(); $.each( items, function( index, item ) { $( "
  • " ) .data( "item.autocomplete", item ) @@ -253,7 +250,7 @@ $.widget( "ui.autocomplete", { }, _move: function( direction, event ) { - if ( !this.menu ) { + if ( !this.menu.element.is(":visible") ) { this.search( null, event ); return; } -- 2.39.5