From 1480dd77272d6531aa383e2a1a983bf1259a213e Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Mon, 14 Dec 2015 09:41:43 +0100 Subject: [PATCH] SONAR-6939 decrease maximum nb of decimal digits to 5 More than 5 breaks the support of big numbers --- .../src/main/java/org/sonar/api/measures/Metric.java | 2 +- .../src/test/java/org/sonar/api/measures/MetricTest.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java index 8fdb94f44a6..4783b6e178e 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java @@ -51,7 +51,7 @@ public class Metric implements Serializable, org.sonar.a * The maximum supported value of scale for decimal metrics * @since 5.3 */ - public static final int MAX_DECIMAL_SCALE = 20; + public static final int MAX_DECIMAL_SCALE = 5; /** * A metric bigger value means a degradation diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/measures/MetricTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/measures/MetricTest.java index 0a088f53d3a..e5765d51961 100644 --- a/sonar-plugin-api/src/test/java/org/sonar/api/measures/MetricTest.java +++ b/sonar-plugin-api/src/test/java/org/sonar/api/measures/MetricTest.java @@ -84,10 +84,10 @@ public class MetricTest { @Test public void fail_if_decimal_scale_is_greater_than_max_supported_value() { expectedException.expect(IllegalArgumentException.class); - expectedException.expectMessage("Scale of decimal metric [foo] must be less than or equal 20: 21"); + expectedException.expectMessage("Scale of decimal metric [foo] must be less than or equal 5: 6"); new Metric.Builder("foo", "Foo", Metric.ValueType.FLOAT) - .setDecimalScale(Metric.MAX_DECIMAL_SCALE + 1) + .setDecimalScale(6) .create(); } -- 2.39.5