From 14e0a6bdba5a6b49741cc131021fcf5c0b873c98 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sun, 31 Dec 2017 01:34:39 +0000 Subject: [PATCH] Use reverse_each instead of reverse.each (#27671). Patch by Timur Tarasenko. git-svn-id: http://svn.redmine.org/redmine/trunk@17137 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/views/activities/index.html.erb | 2 +- app/views/my/blocks/_timelog.html.erb | 2 +- app/views/users/show.html.erb | 2 +- app/views/wiki/date_index.html.erb | 2 +- lib/diff.rb | 2 +- .../lib/open_id_authentication/db_store.rb | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/views/activities/index.html.erb b/app/views/activities/index.html.erb index c3026fb63..196984d64 100644 --- a/app/views/activities/index.html.erb +++ b/app/views/activities/index.html.erb @@ -2,7 +2,7 @@

<%= l(:label_date_from_to, :start => format_date(@date_to - @days), :end => format_date(@date_to-1)) %>

-<% @events_by_day.keys.sort.reverse.each do |day| %> +<% @events_by_day.keys.sort.reverse_each do |day| %>

<%= format_activity_day(day) %>

<% sort_activity_events(@events_by_day[day]).each do |e, in_group| -%> diff --git a/app/views/my/blocks/_timelog.html.erb b/app/views/my/blocks/_timelog.html.erb index 350cbaec8..f96ee6c2e 100644 --- a/app/views/my/blocks/_timelog.html.erb +++ b/app/views/my/blocks/_timelog.html.erb @@ -37,7 +37,7 @@ <%= l(:field_hours) %> -<% entries_by_day.keys.sort.reverse.each do |day| %> +<% entries_by_day.keys.sort.reverse_each do |day| %> <%= day == User.current.today ? l(:label_today).titleize : format_date(day) %> diff --git a/app/views/users/show.html.erb b/app/views/users/show.html.erb index 943ee3821..3907d6192 100644 --- a/app/views/users/show.html.erb +++ b/app/views/users/show.html.erb @@ -53,7 +53,7 @@ :from => @events_by_day.keys.first %>
-<% @events_by_day.keys.sort.reverse.each do |day| %> +<% @events_by_day.keys.sort.reverse_each do |day| %>

<%= format_activity_day(day) %>

<% sort_activity_events(@events_by_day[day]).each do |e, in_group| -%> diff --git a/app/views/wiki/date_index.html.erb b/app/views/wiki/date_index.html.erb index 69a6960b4..274f19a8a 100644 --- a/app/views/wiki/date_index.html.erb +++ b/app/views/wiki/date_index.html.erb @@ -14,7 +14,7 @@

<%= l(:label_no_data) %>

<% end %> -<% @pages_by_date.keys.sort.reverse.each do |date| %> +<% @pages_by_date.keys.sort.reverse_each do |date| %>

<%= format_date(date) %>

    <% @pages_by_date[date].each do |page| %> diff --git a/lib/diff.rb b/lib/diff.rb index 9e1653f14..90adc7e33 100644 --- a/lib/diff.rb +++ b/lib/diff.rb @@ -32,7 +32,7 @@ module RedmineDiff aelem = a[aindex] next unless bmatches.has_key? aelem k = nil - bmatches[aelem].reverse.each { |bindex| + bmatches[aelem].reverse_each { |bindex| if k && (thresh[k] > bindex) && (thresh[k-1] < bindex) thresh[k] = bindex else diff --git a/lib/plugins/open_id_authentication/lib/open_id_authentication/db_store.rb b/lib/plugins/open_id_authentication/lib/open_id_authentication/db_store.rb index 780fb6ad2..f696d4dcc 100644 --- a/lib/plugins/open_id_authentication/lib/open_id_authentication/db_store.rb +++ b/lib/plugins/open_id_authentication/lib/open_id_authentication/db_store.rb @@ -29,7 +29,7 @@ module OpenIdAuthentication Association.find_all_by_server_url_and_handle(server_url, handle) end - assocs.reverse.each do |assoc| + assocs.reverse_each do |assoc| a = assoc.from_record if a.expires_in == 0 assoc.destroy -- 2.39.5