From 17f2cfbb9c6edeeab3e29718209eb88946335d55 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Tue, 27 Jan 2015 00:45:37 +0100 Subject: [PATCH] Use `file_exists` to verify that config file exists There might be the case that `fopen($file, 'r')` returns false and thus ownCloud might believe that the config file is empty and thus potentially leading to an overwrite of the config file. This changeset introduces `file_exists` again which was used in ownCloud 5 where no such problems where reported and should not be affected by such problems. Ref https://github.com/owncloud/core/issues/12785#issuecomment-71548720 --- lib/private/config.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/private/config.php b/lib/private/config.php index 586e8c20587..31e536221dd 100644 --- a/lib/private/config.php +++ b/lib/private/config.php @@ -166,7 +166,9 @@ class Config { // Include file and merge config foreach ($configFiles as $file) { $filePointer = @fopen($file, 'r'); - if($file === $this->configFilePath && $filePointer === false) { + if($file === $this->configFilePath && + $filePointer === false && + @!file_exists($this->configFilePath)) { // Opening the main config might not be possible, e.g. if the wrong // permissions are set (likely on a new installation) continue; -- 2.39.5