From 19468c3b39f5b6cb8248920370775c354c0a49c6 Mon Sep 17 00:00:00 2001 From: Fabrice Bellingard Date: Tue, 15 May 2012 16:56:59 +0200 Subject: [PATCH] SONAR-2706 Should start displaying the 'loading' icon sooner => Before initiating the request (I guess the ITs are failing because of this) --- .../app/views/project_reviews/_review_command_form.html.erb | 2 +- .../WEB-INF/app/views/reviews/_violation_comment_form.html.erb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb index 5d356a3fe82..b0dcfa5e799 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb +++ b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb @@ -7,7 +7,7 @@ Review.command_label(@review_command), :url => {:action => 'run_review_command'}, :html => {:id => "submit_btn"}, - :loading => "$('loading').show();", + :before => "$('loading').show();", :update => 'review' -%>   <%= link_to_remote message('cancel'), :url => {:action => 'show', :id => params[:id]}, :update => 'review' -%> diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb index 755afb57add..1f8c3c71696 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb +++ b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb @@ -37,7 +37,7 @@ button_label, :url => {:action => 'violation_save_comment'}, :html => {:id => "submit_btn"+params[:id]}.merge(@review_command ? {} : {:disabled => "true"}), - :loading => "$('loading-#{params[:id]}').show();", + :before => "$('loading-#{params[:id]}').show();", :update => 'vId'+params[:id] -%>   <%= link_to_function message('cancel'), "cancelViolationAction(#{params[:id]})" -%> -- 2.39.5