From 1b9d6194f360d84a25d5b41b75d06760d76907cf Mon Sep 17 00:00:00 2001
From: Ferdinand Thiessen <opensource@fthiessen.de>
Date: Tue, 25 Jun 2024 00:24:22 +0200
Subject: [PATCH] refactor(files): Resort imports and fix doc comment

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
---
 .../FileEntry/FileEntryCheckbox.vue           |  8 +++++--
 .../FilesListTableHeaderActions.vue           | 21 +++++++++++--------
 apps/files/src/services/Files.ts              |  2 +-
 .../src/actions/restoreAction.ts              |  4 ++--
 4 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/apps/files/src/components/FileEntry/FileEntryCheckbox.vue b/apps/files/src/components/FileEntry/FileEntryCheckbox.vue
index abf3e32d450..059e2f89f5f 100644
--- a/apps/files/src/components/FileEntry/FileEntryCheckbox.vue
+++ b/apps/files/src/components/FileEntry/FileEntryCheckbox.vue
@@ -14,9 +14,13 @@
 </template>
 
 <script lang="ts">
-import { Node, FileType } from '@nextcloud/files'
+import type { Node } from '@nextcloud/files'
+import type { PropType } from 'vue'
+import type { FileSource } from '../../types.ts'
+
+import { FileType } from '@nextcloud/files'
 import { translate as t } from '@nextcloud/l10n'
-import { type PropType, defineComponent } from 'vue'
+import { defineComponent } from 'vue'
 
 import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch.js'
 import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
diff --git a/apps/files/src/components/FilesListTableHeaderActions.vue b/apps/files/src/components/FilesListTableHeaderActions.vue
index 30e460b8acf..5e32a07eae1 100644
--- a/apps/files/src/components/FilesListTableHeaderActions.vue
+++ b/apps/files/src/components/FilesListTableHeaderActions.vue
@@ -26,21 +26,25 @@
 </template>
 
 <script lang="ts">
-import { Node, NodeStatus, View, getFileActions } from '@nextcloud/files'
+import type { Node, View } from '@nextcloud/files'
+import type { PropType } from 'vue'
+import type { FileSource } from '../types'
+
+import { NodeStatus, getFileActions } from '@nextcloud/files'
 import { showError, showSuccess } from '@nextcloud/dialogs'
 import { translate } from '@nextcloud/l10n'
+import { defineComponent } from 'vue'
+
 import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'
 import NcActions from '@nextcloud/vue/dist/Components/NcActions.js'
 import NcIconSvgWrapper from '@nextcloud/vue/dist/Components/NcIconSvgWrapper.js'
 import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
-import Vue, { defineComponent, type PropType } from 'vue'
 
 import { useActionsMenuStore } from '../store/actionsmenu.ts'
 import { useFilesStore } from '../store/files.ts'
 import { useSelectionStore } from '../store/selection.ts'
 import filesListWidthMixin from '../mixins/filesListWidth.ts'
 import logger from '../logger.ts'
-import type { FileSource } from '../types'
 
 // The registered actions list
 const actions = getFileActions()
@@ -136,11 +140,10 @@ export default defineComponent({
 		/**
 		 * Get a cached note from the store
 		 *
-		 * @param {number} fileId the file id to get
-		 * @return {Folder|File}
+		 * @param source The source of the node to get
 		 */
-		getNode(fileId) {
-			return this.filesStore.getNode(fileId)
+		getNode(source: string): Node|undefined {
+			return this.filesStore.getNode(source)
 		},
 
 		async onActionClick(action) {
@@ -150,7 +153,7 @@ export default defineComponent({
 				// Set loading markers
 				this.loading = action.id
 				this.nodes.forEach(node => {
-					Vue.set(node, 'status', NodeStatus.LOADING)
+					this.$set(node, 'status', NodeStatus.LOADING)
 				})
 
 				// Dispatch action execution
@@ -190,7 +193,7 @@ export default defineComponent({
 				// Remove loading markers
 				this.loading = null
 				this.nodes.forEach(node => {
-					Vue.set(node, 'status', undefined)
+					this.$set(node, 'status', undefined)
 				})
 			}
 		},
diff --git a/apps/files/src/services/Files.ts b/apps/files/src/services/Files.ts
index 10e553592fe..86d9f9b8e80 100644
--- a/apps/files/src/services/Files.ts
+++ b/apps/files/src/services/Files.ts
@@ -8,7 +8,7 @@ import type { FileStat, ResponseDataDetailed } from 'webdav'
 import { CancelablePromise } from 'cancelable-promise'
 import { File, Folder, davGetDefaultPropfind, davResultToNode, davRootPath } from '@nextcloud/files'
 import { client } from './WebdavClient.ts'
-import logger from '../logger.js'
+import logger from '../logger.ts'
 
 /**
  * Slim wrapper over `@nextcloud/files` `davResultToNode` to allow using the function with `Array.map`
diff --git a/apps/files_trashbin/src/actions/restoreAction.ts b/apps/files_trashbin/src/actions/restoreAction.ts
index cda82fda466..31160183d83 100644
--- a/apps/files_trashbin/src/actions/restoreAction.ts
+++ b/apps/files_trashbin/src/actions/restoreAction.ts
@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 import { emit } from '@nextcloud/event-bus'
+import { encodePath } from '@nextcloud/paths'
 import { generateRemoteUrl } from '@nextcloud/router'
 import { getCurrentUser } from '@nextcloud/auth'
 import { Permission, Node, View, registerFileAction, FileAction } from '@nextcloud/files'
@@ -10,8 +11,7 @@ import { translate as t } from '@nextcloud/l10n'
 import axios from '@nextcloud/axios'
 import History from '@mdi/svg/svg/history.svg?raw'
 
-import logger from '../../../files/src/logger.js'
-import { encodePath } from '@nextcloud/paths'
+import logger from '../../../files/src/logger.ts'
 
 registerFileAction(new FileAction({
 	id: 'restore',
-- 
2.39.5