From 1c02ab27903725462417d4bdc71f0dfaab899f3b Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Fri, 28 Jun 2013 09:01:06 +0200 Subject: [PATCH] Fix quality flaws --- .../java/org/sonar/server/issue/IssueFilterParameters.java | 3 +++ .../src/main/java/org/sonar/server/user/RubyUserSession.java | 4 ++++ .../src/main/java/org/sonar/server/user/UserSession.java | 5 +++-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterParameters.java b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterParameters.java index beeb98d21c6..c4b6d9c92db 100644 --- a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterParameters.java +++ b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterParameters.java @@ -63,4 +63,7 @@ public class IssueFilterParameters { } })); + private IssueFilterParameters() { + // Utility class + } } diff --git a/sonar-server/src/main/java/org/sonar/server/user/RubyUserSession.java b/sonar-server/src/main/java/org/sonar/server/user/RubyUserSession.java index 056ccd1a80d..e603cde6813 100644 --- a/sonar-server/src/main/java/org/sonar/server/user/RubyUserSession.java +++ b/sonar-server/src/main/java/org/sonar/server/user/RubyUserSession.java @@ -32,4 +32,8 @@ public class RubyUserSession { UserSession.set(session); } + private RubyUserSession() { + // Utility class + } + } diff --git a/sonar-server/src/main/java/org/sonar/server/user/UserSession.java b/sonar-server/src/main/java/org/sonar/server/user/UserSession.java index 79f79aaf697..81509c4346e 100644 --- a/sonar-server/src/main/java/org/sonar/server/user/UserSession.java +++ b/sonar-server/src/main/java/org/sonar/server/user/UserSession.java @@ -25,10 +25,10 @@ import org.sonar.core.user.AuthorizationDao; import org.sonar.server.exceptions.ForbiddenException; import org.sonar.server.exceptions.UnauthorizedException; import org.sonar.server.platform.Platform; -import org.sonar.server.ui.JRubyI18n; import javax.annotation.CheckForNull; import javax.annotation.Nullable; + import java.util.List; import java.util.Locale; @@ -82,11 +82,12 @@ public class UserSession { } public UserSession checkLoggedIn() { - if (login==null) { + if (login == null) { throw new UnauthorizedException(); } return this; } + /** * Ensures that user implies the specified permission. If not a {@link org.sonar.server.exceptions.ForbiddenException} is thrown. */ -- 2.39.5