From 1e53a32c7ed61b53d9d13ff9fd47a326f6c05de9 Mon Sep 17 00:00:00 2001
From: Julien Lancelot <julien.lancelot@gmail.com>
Date: Tue, 12 Feb 2013 11:28:57 +0100
Subject: [PATCH] Do not display sidebar when zooming on a file

---
 .../app/controllers/dashboard_controller.rb     |  3 ++-
 .../app/views/dashboard/no_dashboard.html.erb   | 17 ++++++-----------
 .../app/views/layouts/_breadcrumb.html.erb      |  2 ++
 .../WEB-INF/app/views/layouts/_layout.html.erb  |  9 +++++++--
 .../src/main/webapp/javascripts/application.js  |  4 ++--
 5 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/dashboard_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/dashboard_controller.rb
index 8ad90815c07..35384ae8095 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/dashboard_controller.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/dashboard_controller.rb
@@ -31,7 +31,8 @@ class DashboardController < ApplicationController
       load_dashboard()
       load_authorized_widget_definitions()
     elsif @snapshot
-      # display the layout of the parent, usually the directory, but display the file viewers
+      # display the layout of the parent without the sidebar, usually the directory, but display the file viewers
+      @hide_sidebar = true
       @file = @resource
       @project = @snapshot.parent.project
       render :action => 'no_dashboard'
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/no_dashboard.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/no_dashboard.html.erb
index be9f086e585..e125579a9e4 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/no_dashboard.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/no_dashboard.html.erb
@@ -1,10 +1,10 @@
 <%= render :partial => 'gwt/base', :locals => {:resource => nil, :popup => false, :metric => nil} -%>
 <%= render :partial => 'gwt/resource_viewers' -%>
 
-<img id="page_loading" src="<%= ApplicationController.root_context -%>/images/loading.gif">
-<div id="resource_container"></div>
+<div id="accordion-panel"></div>
 
 <script type="text/javascript">
+
   // see if an anchor has been passed
   var anchor;
   var stripped_url = document.location.toString().split("#");
@@ -12,16 +12,11 @@
     anchor = stripped_url[1];
   }
 
-  // and call the resource page
-  new Ajax.Updater('resource_container', '<%= url_for params.merge({:controller => 'resource', :action => :index, :id => @file.id}) -%>',
-    {
-      asynchronous:true,
-      evalScripts:true,
-      onComplete:function (transport) {
-        $('page_loading').hide();
+  openAccordionItem('<%= url_for(params.merge({:controller => 'resource', :action => :index, :id => @file.id, :display_title => 'false', :popup => 'false'})) -%>', this, false)
+      .done(function () {
         if (anchor != null) {
           window.location.hash = anchor;
         }
-      }
-    });
+      });
+
 </script>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_breadcrumb.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_breadcrumb.html.erb
index 1cef8792693..e5a4e6cb113 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_breadcrumb.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_breadcrumb.html.erb
@@ -40,6 +40,8 @@
   
 <% elsif displayed_resource %>
 
+  <% puts "### dis "+ displayed_resource.to_s %>
+
   <div id="crumbs">
     <ul id="crumbs-ops">
       <% if displayed_resource && !@review %>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb
index 1434353b822..9bb70302df7 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb
@@ -41,7 +41,7 @@
   </div>
   <%= render 'layouts/breadcrumb' if @breadcrumbs || selected_section==Navigation::SECTION_RESOURCE -%>
   <div id="body">
-    <% if selected_section %>
+    <% if selected_section && (!@hide_sidebar) %>
       <div id="sidebar">
         <ul class="sidebar blue-sidebar">
           <% if selected_section==Navigation::SECTION_HOME %>
@@ -160,7 +160,12 @@
         </ul>
       </div>
     <% end %>
-    <div <%= "id='content' class='with_sidebar'" if selected_section -%>>
+    <%
+      html_id_class = ''
+      html_id_class = "id='content' class='with_sidebar'" if selected_section
+      html_id_class = "id='content'" if @hide_sidebar
+    %>
+    <div <%= html_id_class -%>>
       <% if @project %>
         <div class="print"><h2><%= h @project.name(true) %></h2></div>
       <% end %>
diff --git a/sonar-server/src/main/webapp/javascripts/application.js b/sonar-server/src/main/webapp/javascripts/application.js
index 4d8f272d273..7fb13201a7c 100644
--- a/sonar-server/src/main/webapp/javascripts/application.js
+++ b/sonar-server/src/main/webapp/javascripts/application.js
@@ -355,7 +355,7 @@ function openAccordionItem(url, elt, updateCurrentElement) {
   }
 
   // Get content from url
-  $j.get(url,function (html) {
+  var ajaxRequest = $j.get(url,function (html) {
     if (currentElement.length) {
       var body = currentElement.find('.accordion-item-body');
       if (!updateCurrentElement && !body.hasClass('accordion-item-body-medium')) {
@@ -392,7 +392,7 @@ function openAccordionItem(url, elt, updateCurrentElement) {
         loading.remove();
       });
 
-  return false;
+  return ajaxRequest;
 }
 
 function expandAccordionItem(elt) {
-- 
2.39.5