From 20201c28549a318937910ef847ec8be0ed6a3179 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=B6rn=20Zaefferer?= Date: Thu, 17 Sep 2009 14:56:03 +0000 Subject: [PATCH] dialog: filter invalid option-position values, convert title argument to string (ala closeText) --- ui/jquery.ui.dialog.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index d03537c31..07d1defb1 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -382,6 +382,8 @@ $.widget("ui.dialog", { // deep extending converts arrays to objects in jQuery <= 1.3.2 :-( // if (typeof position == 'string' || $.isArray(position)) { // myAt = $.isArray(position) ? position : position.split(' '); + if (!position || (typeof positon != "string" && typeof positon != "object")) + return if (typeof position == 'string' || '0' in position) { myAt = position.split ? position.split(' ') : [position[0], position[1]]; if (myAt.length == 1) { @@ -468,7 +470,8 @@ $.widget("ui.dialog", { (isResizable || (value !== false && self._makeResizable(value))); break; case "title": - $(".ui-dialog-title", self.uiDialogTitlebar).html(value || ' '); + // convert whatever was passed in o a string, for html() to not throw up + $(".ui-dialog-title", self.uiDialogTitlebar).html("" + (value || ' ')); break; case "width": resize = true; -- 2.39.5