From 20c81961de9c92422410a5657ed48a3093742bde Mon Sep 17 00:00:00 2001 From: stanislavh Date: Tue, 16 May 2023 18:27:46 +0200 Subject: [PATCH] SONAR-19236 Implement new design for hotspot header --- .../src/components/FormField.tsx | 74 ++++++++ .../src/components/SearchSelectDropdown.tsx | 14 +- .../SearchSelectDropdownControl.tsx | 4 +- .../design-system/src/components/Text.tsx | 12 ++ .../components/__tests__/FormField-test.tsx | 46 +++++ .../design-system/src/components/buttons.tsx | 2 +- .../src/components/icons/RequiredIcon.tsx | 33 ++++ .../src/components/icons/index.ts | 1 + .../design-system/src/components/index.ts | 1 + .../SecurityHotspotsAppRenderer.tsx | 58 +++--- .../__tests__/SecurityHotspotsApp-it.tsx | 50 +---- .../security-hotspots/components/Assignee.tsx | 129 +++++++++++++ .../components/EmptyHotspotsPage.tsx | 13 +- .../components/HotspotHeader.tsx | 116 ++++++++---- .../components/HotspotHeaderRightSection.tsx | 78 ++++++++ .../components/HotspotViewer.tsx | 28 +-- .../components/HotspotViewerRenderer.tsx | 35 ++-- .../components/assignee/Assignee.tsx | 110 ----------- .../components/assignee/AssigneeRenderer.tsx | 79 -------- .../components/assignee/AssigneeSelection.tsx | 178 ------------------ .../assignee/AssigneeSelectionRenderer.tsx | 85 --------- .../components/status/Status.tsx | 64 ++----- .../components/status/StatusDescription.tsx | 28 +-- .../components/status/StatusSelection.tsx | 119 +++++------- .../status/StatusSelectionRenderer.tsx | 110 ++++++----- .../main/js/apps/security-hotspots/styles.css | 6 - .../js/components/common/FormattingTips.tsx | 42 ++--- .../common/__tests__/FormattingTips-test.tsx | 24 +-- .../FormattingTips-test.tsx.snap | 36 ---- .../AssigneeSelection.css => types/misc.ts} | 12 +- .../resources/org/sonar/l10n/core.properties | 8 +- 31 files changed, 721 insertions(+), 874 deletions(-) create mode 100644 server/sonar-web/design-system/src/components/FormField.tsx create mode 100644 server/sonar-web/design-system/src/components/__tests__/FormField-test.tsx create mode 100644 server/sonar-web/design-system/src/components/icons/RequiredIcon.tsx create mode 100644 server/sonar-web/src/main/js/apps/security-hotspots/components/Assignee.tsx create mode 100644 server/sonar-web/src/main/js/apps/security-hotspots/components/HotspotHeaderRightSection.tsx delete mode 100644 server/sonar-web/src/main/js/apps/security-hotspots/components/assignee/Assignee.tsx delete mode 100644 server/sonar-web/src/main/js/apps/security-hotspots/components/assignee/AssigneeRenderer.tsx delete mode 100644 server/sonar-web/src/main/js/apps/security-hotspots/components/assignee/AssigneeSelection.tsx delete mode 100644 server/sonar-web/src/main/js/apps/security-hotspots/components/assignee/AssigneeSelectionRenderer.tsx delete mode 100644 server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/FormattingTips-test.tsx.snap rename server/sonar-web/src/main/js/{apps/security-hotspots/components/assignee/AssigneeSelection.css => types/misc.ts} (76%) diff --git a/server/sonar-web/design-system/src/components/FormField.tsx b/server/sonar-web/design-system/src/components/FormField.tsx new file mode 100644 index 00000000000..a6bac58d5e8 --- /dev/null +++ b/server/sonar-web/design-system/src/components/FormField.tsx @@ -0,0 +1,74 @@ +/* + * SonarQube + * Copyright (C) 2009-2023 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +import styled from '@emotion/styled'; +import { ReactNode } from 'react'; +import tw from 'twin.macro'; +import { Highlight, Note } from './Text'; +import { RequiredIcon } from './icons'; + +interface Props { + ariaLabel?: string; + children: ReactNode; + className?: string; + description?: string | ReactNode; + help?: ReactNode; + htmlFor?: string; + id?: string; + label: string | ReactNode; + required?: boolean; + title?: string; +} + +export function FormField({ + children, + className, + description, + help, + id, + required, + label, + htmlFor, + title, + ariaLabel, +}: Props) { + return ( + + + + {children} + + {description && {description}} + + ); +} + +const FieldWrapper = styled.div` + ${tw`sw-flex sw-flex-col sw-w-full`} + + &:not(:last-of-type) { + ${tw`sw-mb-6`} + } +`; diff --git a/server/sonar-web/design-system/src/components/SearchSelectDropdown.tsx b/server/sonar-web/design-system/src/components/SearchSelectDropdown.tsx index 67987e450bd..7493c146ea6 100644 --- a/server/sonar-web/design-system/src/components/SearchSelectDropdown.tsx +++ b/server/sonar-web/design-system/src/components/SearchSelectDropdown.tsx @@ -52,6 +52,7 @@ export interface SearchSelectDropdownProps< Group extends GroupBase