From 212b6a4fce06b7435bbe9d8494e470881badacc6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Mon, 20 Mar 2023 17:13:31 +0100 Subject: [PATCH] Build: Only install Playwright dependencies when needed PR gh-5190 added support for running tests on Playwright WebKit in CI. For efficiency reasons, Playwright dependencies are only installed for the `test:browser` npm script. However, that same script is also used for Firefox ESR testing. This change makes Playwright dependencies installed only for cases where `WebKitHeadless` exists on the list of tested browsers. Closes gh-5204 Ref gh-5190 (cherry picked from commit e77bd9d64fc696cadfe1f8c9ebb50d7609a97b07) --- .github/workflows/node.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 51b7b60fd..bd296f1b6 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -69,7 +69,7 @@ jobs: - name: Install Playwright dependencies run: npx playwright-webkit install-deps - if: "matrix.NPM_SCRIPT == 'test:browser'" + if: "matrix.NPM_SCRIPT == 'test:browser' && contains(matrix.BROWSERS, 'WebkitHeadless')" - name: Run tests env: -- 2.39.5