From 21dc97110af112fb338c1b05283a67be70939286 Mon Sep 17 00:00:00 2001 From: Nick Burch Date: Tue, 27 May 2008 12:36:00 +0000 Subject: [PATCH] More merging, plus tests for embeded ooxml files git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@660488 13f79535-47bb-0310-9956-ffa450edef68 --- build.xml | 2 + src/documentation/content/xdocs/changes.xml | 1 + src/documentation/content/xdocs/status.xml | 1 + .../poi/hssf/extractor/ExcelExtractor.java | 17 ++++ .../xssf/extractor/XSSFExcelExtractor.java | 27 ++++-- .../testcases/org/apache/poi/TestEmbeded.java | 83 ++++++++++++++++++ .../apache/poi/hssf/data/WithCheckBoxes.xls | Bin 0 -> 16896 bytes .../hssf/extractor/TestExcelExtractor.java | 22 +++++ 8 files changed, 145 insertions(+), 8 deletions(-) create mode 100644 src/ooxml/testcases/org/apache/poi/TestEmbeded.java create mode 100644 src/testcases/org/apache/poi/hssf/data/WithCheckBoxes.xls diff --git a/build.xml b/build.xml index e1cb26c353..bcb2535364 100644 --- a/build.xml +++ b/build.xml @@ -650,6 +650,7 @@ under the License. + @@ -799,6 +800,7 @@ under the License. + diff --git a/src/documentation/content/xdocs/changes.xml b/src/documentation/content/xdocs/changes.xml index f26c6271b9..1381dd8d28 100644 --- a/src/documentation/content/xdocs/changes.xml +++ b/src/documentation/content/xdocs/changes.xml @@ -46,6 +46,7 @@ Created a common interface for handling Excel files, irrespective of if they are .xls or .xlsx + 45043 - Support for getting excel cell comments when extracting text Extend the support for specifying a policy to HSSF on missing / blank cells when fetching, to be able to specify the policy at the HSSFWorkbook level 45025 - improved FormulaParser parse error messages 45046 - allowed EXTERNALBOOK(0x01AE) to be optional in the LinkTable diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml index 4fc778a5f9..35e3ab7514 100644 --- a/src/documentation/content/xdocs/status.xml +++ b/src/documentation/content/xdocs/status.xml @@ -43,6 +43,7 @@ Created a common interface for handling Excel files, irrespective of if they are .xls or .xlsx + 45043 - Support for getting excel cell comments when extracting text Extend the support for specifying a policy to HSSF on missing / blank cells when fetching, to be able to specify the policy at the HSSFWorkbook level 45025 - improved FormulaParser parse error messages 45046 - allowed EXTERNALBOOK(0x01AE) to be optional in the LinkTable diff --git a/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java b/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java index 2a9c455cac..75a73c654d 100644 --- a/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java +++ b/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java @@ -20,6 +20,7 @@ import java.io.IOException; import org.apache.poi.POIOLE2TextExtractor; import org.apache.poi.hssf.usermodel.HSSFCell; +import org.apache.poi.hssf.usermodel.HSSFComment; import org.apache.poi.hssf.usermodel.HSSFRichTextString; import org.apache.poi.hssf.usermodel.HSSFRow; import org.apache.poi.hssf.usermodel.HSSFSheet; @@ -39,6 +40,7 @@ public class ExcelExtractor extends POIOLE2TextExtractor { private HSSFWorkbook wb; private boolean includeSheetNames = true; private boolean formulasNotResults = false; + private boolean includeCellComments = false; public ExcelExtractor(HSSFWorkbook wb) { super(wb); @@ -62,6 +64,12 @@ public class ExcelExtractor extends POIOLE2TextExtractor { public void setFormulasNotResults(boolean formulasNotResults) { this.formulasNotResults = formulasNotResults; } + /** + * Should cell comments be included? Default is true + */ + public void setIncludeCellComments(boolean includeCellComments) { + this.includeCellComments = includeCellComments; + } /** * Retreives the text contents of the file @@ -128,6 +136,15 @@ public class ExcelExtractor extends POIOLE2TextExtractor { break; } + // Output the comment, if requested and exists + HSSFComment comment = cell.getCellComment(); + if(includeCellComments && comment != null) { + // Replace any newlines with spaces, otherwise it + // breaks the output + String commentText = comment.getString().getString().replace('\n', ' '); + text.append(" Comment by "+comment.getAuthor()+": "+commentText); + } + // Output a tab if we're not on the last cell if(outputContents && k < (lastCell-1)) { text.append("\t"); diff --git a/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFExcelExtractor.java b/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFExcelExtractor.java index 9ebb3f053b..2d27f5d33d 100644 --- a/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFExcelExtractor.java +++ b/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFExcelExtractor.java @@ -16,25 +16,20 @@ ==================================================================== */ package org.apache.poi.xssf.extractor; -import java.io.File; import java.io.IOException; import java.util.Iterator; import org.apache.poi.POIXMLTextExtractor; import org.apache.poi.ss.usermodel.Cell; +import org.apache.poi.ss.usermodel.Comment; import org.apache.poi.ss.usermodel.Row; import org.apache.poi.ss.usermodel.Sheet; import org.apache.poi.ss.usermodel.Workbook; import org.apache.poi.xssf.usermodel.XSSFCell; -import org.apache.poi.xssf.usermodel.XSSFSheet; import org.apache.poi.xssf.usermodel.XSSFWorkbook; import org.apache.xmlbeans.XmlException; import org.openxml4j.exceptions.OpenXML4JException; import org.openxml4j.opc.Package; -import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTCell; -import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTRow; -import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTSheet; -import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTWorksheet; /** * Helper class to extract text from an OOXML Excel file @@ -43,6 +38,7 @@ public class XSSFExcelExtractor extends POIXMLTextExtractor { private Workbook workbook; private boolean includeSheetNames = true; private boolean formulasNotResults = false; + private boolean includeCellComments = false; public XSSFExcelExtractor(String path) throws XmlException, OpenXML4JException, IOException { this(new XSSFWorkbook(path)); @@ -79,6 +75,12 @@ public class XSSFExcelExtractor extends POIXMLTextExtractor { public void setFormulasNotResults(boolean formulasNotResults) { this.formulasNotResults = formulasNotResults; } + /** + * Should cell comments be included? Default is true + */ + public void setIncludeCellComments(boolean includeCellComments) { + this.includeCellComments = includeCellComments; + } /** * Retreives the text contents of the file @@ -94,8 +96,8 @@ public class XSSFExcelExtractor extends POIXMLTextExtractor { for (Object rawR : sheet) { Row row = (Row)rawR; - for(Iterator ri = row.cellIterator(); ri.hasNext();) { - Cell cell = (Cell)ri.next(); + for(Iterator ri = row.cellIterator(); ri.hasNext();) { + Cell cell = ri.next(); // Is it a formula one? if(cell.getCellType() == Cell.CELL_TYPE_FORMULA && formulasNotResults) { @@ -107,6 +109,15 @@ public class XSSFExcelExtractor extends POIXMLTextExtractor { text.append(xc.getRawValue()); } + // Output the comment, if requested and exists + Comment comment = cell.getCellComment(); + if(includeCellComments && comment != null) { + // Replace any newlines with spaces, otherwise it + // breaks the output + String commentText = comment.getString().getString().replace('\n', ' '); + text.append(" Comment by "+comment.getAuthor()+": "+commentText); + } + if(ri.hasNext()) text.append("\t"); } diff --git a/src/ooxml/testcases/org/apache/poi/TestEmbeded.java b/src/ooxml/testcases/org/apache/poi/TestEmbeded.java new file mode 100644 index 0000000000..5e127e21c6 --- /dev/null +++ b/src/ooxml/testcases/org/apache/poi/TestEmbeded.java @@ -0,0 +1,83 @@ + +/* ==================================================================== + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +==================================================================== */ + + +package org.apache.poi; + +import java.io.File; +import java.util.Iterator; + +import org.apache.poi.util.IOUtils; +import org.apache.poi.xslf.XSLFSlideShow; +import org.apache.poi.xssf.usermodel.XSSFWorkbook; +import org.apache.poi.xwpf.XWPFDocument; +import org.openxml4j.opc.Package; +import org.openxml4j.opc.PackagePart; + +import junit.framework.TestCase; + +/** + * Class to test that we handle embeded bits in + * OOXML files properly + */ +public class TestEmbeded extends TestCase +{ + public String dirname; + + public void setUp() { + dirname = System.getProperty("OOXML.testdata.path"); + assertNotNull(dirname); + } + + public void testExcel() throws Exception { + File f = new File(dirname, "ExcelWithAttachments.xlsx"); + assertTrue(f.exists()); + + POIXMLDocument doc = new XSSFWorkbook(Package.open(f.toString())); + test(doc, 0); + } + + public void testWord() throws Exception { + File f = new File(dirname, "WordWithAttachments.docx"); + assertTrue(f.exists()); + + POIXMLDocument doc = new XWPFDocument(Package.open(f.toString())); + test(doc, 4); + } + + public void testPowerPoint() throws Exception { + File f = new File(dirname, "PPTWithAttachments.pptx"); + assertTrue(f.exists()); + + POIXMLDocument doc = new XSLFSlideShow(Package.open(f.toString())); + test(doc, 0); + } + + private void test(POIXMLDocument doc, int expectedCount) throws Exception { + assertNotNull(doc.getAllEmbedds()); + assertEquals(expectedCount, doc.getAllEmbedds().size()); + + for(int i=0; i 0); + } + } +} diff --git a/src/testcases/org/apache/poi/hssf/data/WithCheckBoxes.xls b/src/testcases/org/apache/poi/hssf/data/WithCheckBoxes.xls new file mode 100644 index 0000000000000000000000000000000000000000..66dd9185ea57a7973ab29dc8a6421c0bac9392be GIT binary patch literal 16896 zcmeHO3tUuH{y+CJz<{CyqNyp4V2UU>FJMSf=Eb8xOngqhIgm6`m%zjN<}8A2EB-@ni9f6wr}=iJ}@ zo!9UD&hPy0IhRB4L?2(jwf70uCX8eu>_T${3k#qNNE3L_FeV~FxX|3(ED;$)^1tEV zNCH2gt(`D<-2oL43ecE`18N`why*$V7;+W`bOE{o(Lf&{2IvOF0zClIhpQ0x1bP9z zfvbVOKtCW3ARfYh!!Ij=vCNI1k7=2M)gbn;nHZgphaS)vr3Yjiv}&>lj5YEr%a$VP zy3Tpx&JF7h2qCy_9465wqIM6P!Af~MW(2Z#C>_H@ULNTrwWA}MsD*PO^8fU%F`>pgpkjDm@S21rO>9W$1=s(p@ zbCcqZW}YT9(wNaaq%pbF{3jbhHXv~RQ=Mc30_Q*35wZd8&402LWCLjalO50k{egHO z0T=*W0}KQP0g1q1APE=(3=G93U6S1Fi$E2l9aeU^Gw&i~*=z(vl)z955c3089kv*^P31GvZ?4 z7GN?k1t;z>E?z&)oBMw+0T)Xk>W}fFYe$B*_N#adRKX^erX(P#Vl9 zCn`6^gX2{FSs1PQ3JK3|9_uQz)>eigcxfjLQ*Uef!?9!!COLS5MPXCAU z=+bo3$@cg!MyFES+t8)OwKol)4+X|2IZl;1R z32e8Z1~C723G55@UPxEQn%;u_1!q%FT+tM6i%4Hc_Xw08#)Kvh_(T@oGywNM4$VIz z!5}n^q&%w8vp@NB#o3d!i*Nntp-wOVu17QL4LX&rgsjZoO);Rg8EYj|Cm1J zsfH4<)SB^LdAE%Et2!A8qtc zJ@(J^?<;#mpkP=s#*5xxx$YcZtb`Hwc5|(*Y%GTVoZOt-Sh34-FJtb zf9|C@U+*nG+t81}Y@Q2T~cFlkFvp;p;bMo`3)xI_FB`teNBmSf2 z4>K3O)MID3BYIJT_N93TN^e|sa_xrIC&QOK5$o8SpSt-EAu}F2XuNUwroqoXzxC+# ziC;XtYUe#0w#0|bDR)-PFFZ4O#>o@E*_0T!srs|)7oKdq?Skd}!JCJN71T#A?fz^Wlm8mW01!JayBtn(xp4`Tf~nAK&rVb7Q_a z^5xu_zwUnFi}Sq~@BOIg!8cYP*?i-wS2mwn^W7Tb?N_O**L<)r?nwInkMBLOYsF2o zuRC{o&_2h=3H|1-EnfP@ux?NEey`UXPrf?q!Ovf-bALGGSWU04Z+vh~-Ks7V*L)Ch zcEdULaBAhmaaW&=^oPDxvf-KA;_}zbsaf;!!7mT~{!p*N&&-ZH=5O5d#S>#s3~xx@ zeEXO6zpKA-+1Nv26HfPC`s>JduI;-lZ&LEFBKn1$KD}!6^j;Aon)`-+f8Kib(@}RV zavt9Kht=t`7Tr5NZ}E;d>q5S&vmGfLe)7(y_#cKeKe&I7=gc?r?p^XtuWeD+fB)Ww z+()ikcFJ()d+9rNH+TR0N44E|4t{L=sNDzEwh#9hUO%65A+jN1SHXeO-WmC&Jsx{- zZ%o*mhlhG6_D?*UbNc+Q{hvSi(Tp(H+xP4_J>-V3zfD>@%=zZ{l{@AR`QCYEEMWj_xOgyt3@94@NM>#MAp z+KhL4HLHT?pmh>sIRh0+^X?WfJ^)1FPC$_&T-mNX z9nGI>P}%vXzdBq{I%d=qPEX?WA^bX@Q~cmj!Zl=hSYM$5Pj;)QE^5*O&b^Rd*OT7> z4l-i`%$d?;#*UL`k8pgH0B2mJQpGO3`_xiN5Nc7wDFRB6h+Wwa5DDGD2qJs{V@WkI z_E&a@`qFd&Y4oFsT1h1dXku3u(zFHXu1wXGNHiAFM1#;ah%A!lLqqun3-Q;3X+>v= zPGxBzKQD%tUQVRpRavN>PUs_ES8x&Fh-P6}n~_#C|6Y=d4KE2UygbanON<*1Ke^*5 ziz^9@#k2h7I0UhZzdl4a(eqp2Qg?@9sKL=)OOz4O{b{hFA|jWWh>{}UaB0zAQ+$#j zHvVY?3qjwq-JWW1isJpJNcByltN~%97{j*Xje)VO0BT>7S2(Jqu7u+!2wy_X(!1I# z0^e(t7BOl{`+65F-FKnAznIQJ@%Yf7t*ttz570S02nbvz{5~sy%4H(mlUyjY%A})W zID$$4i-|#MG{63gVhE@uI4SfHSlB?w?iDx;k%%W_($IXm8gK&?NVH*NAKy+}BxSf+ zjQj0KOXG*PbndS-H`_sD?C;lg-F(L?L*b@@%OXsF8~4vkZD}c`8=u~K;EsZMmL&(i zSn*EWlD(v-Xb_+6FuQzfhUyXEa!GeI{{`3>Wh&{1YVoHVsx2tub8M(qd7^Gxc-sa_ z%`d>#1y!MR2IaSO@e|%L+M$&=TCdXX7x7+MAQPgL#%Fvx#cWAED(!zY9piBzOA$9< zF6>=MrX=uLN7D4>Ob#&36>3LE@(c&l_1L7KFa^IN?DLI5jQ7jS4jSygQBleuccg$D zz_gfj5+SgD+QYisK=o6<6}9R}{z+h}lo=`S|7941dPP>0Pj%7+DAKf~?pIRYSSf{_ zym%!gj_4`tusEVmOGG;ops~Kae!=9l;2~OE$YU@*li((UY5$Cjw zsvsPqcKc~ZkM>%dn-l3Cl9$EEbx&%Iw8wc39`uDPL~)Y;YLT9qSgxqUJsAdEv*=26 z3QF3Hgt$PeM~$b;>4D7Env(eY!XcsZ=dX+979+^u_q8K5B;)Bt@hv(Um~Y zs4dF961Sy42*NZX$|0A09E5RVE^m{PuQgVqeI?-7rN1*TlnFhsu~Uo*Xy(IV!d(JH zpU#8<@`DQOhte+z3`UGg23XUP(!=dZXP=OlBQ=$pOM$8yAtkT)df~Tw; z+*MZPWMO&b(d^lAp1LTjqrO({_PS#GjB{1jvMQ&~Wp{Zh!)_A?tgzO3eeUYcm9tcK zjlt%w@u@xTs)kjxp7{Bm?NBX*rYtqOYVT0(qRwp56$#5T-Y@5)SV_kr&9^05;t-5p za3IH>bhSU3PJ}!;zEzG%)ZfWVN+jG>8s63NGbhi19Sr%NZmBdWP|pADpvGJyrHUX! zi_pNY0@KU)f%W}()&xH7XgY)~WzoD-B6G;`OgZj>rQAgCdUQT9k2mECFYS+?2Bk^k zN47)?R6#C4dq-Nfo^Fw%XFSP5vP9UozPsfICW%Ui6_;w@TTYx%pqL1l4Z=wk@1k5t zDD>kTw*xsrcHM+?n(Uuo*ArkzQlOCuuqFw3iMkdhNIL(^fhn@!ghUUD4W~Q>_!VMZ zkthX_w+$SH@EIhE^4Co|^Qz?MR~^aM9uHO%?*AxlXpg5YjV#?hdbdUh^uO9#D2e0JSH=IL^HFNU zrMac2_aS;aR7wZdec4FHKaHw?BUKOmNx_+20-p=YJn%sKreai_IBg^yt%PQ} zppC_t3#7O7+zV7dQ?-~2v^o>r1&%`SXY*O&K-n~l9BdNii~}i-YRQM?IyyWo^Gxc)49GVMH0N{#{_IBi>&Eyhq7Okfo5MGZB3o zjo&!*%!|`iFWTjToQ&WliVqs?=JKMvbhclLyoG4F1MRoK3i$B68nRVpxjYa&N^F_q z23U`5ta*0yz=XP!F-lfYEJ*1=)8j4~u%p~mxsMh+m3&u|OgF%Xm3m=B+}evVd<@$k zV;gT@HLf*i@xK~=!GIRlAl@TAbl{vQWJ*_`AF7Q{7fxUBZ;+2?b2hP4XviPjZ61cviQ}|6fL+f zN5=&g+oBy7c)r=_pM&=_9euJOZAU+n(R%We4V*?ALApcUvW@rDhMZQeOBP%e?FjCt z9V13xzZ9TMX_c$SD0?x+Q&BeQV=?rZcr1vOm2e!N2eo+CI+M-3hh#U3&|X^WsOKr* ztcSj|ZwFfWE>}Wi(odu~qV7H3TeB!dEV;X&(~IO>i11ldco-%Mj6P3_M68kDPH5VZ z)t25ylvU(PVk$@AvpDz?HkP);1NS*%`3SXrlWA`5E(Y^8H$RRoD;}t8b#RZQh6#ce zgez&}Pt5~a{v!4M)OPOp5BA{ND4@C31UBhk2Qs^teG`o zpCDA_s4sI>`G;s&h-!k>^3A6j7TN%o`M?5TAwc^EcObqKSPU!y?gEwqcLVnT%Yb`< z0aX4o zh@X|ybpJfkn}IFBR$v?O0zl7RLQIo}{2RL8f%p~RRp2$5wo8uj`2T%SO{}cZr|q5# zRiLEN5I&F8qrh4A!Zr<4k)EV&O2EOFYK+G{-Bsq(M_#32VJfe$++F2bS)yT)#3Mi4 z^*TK(tf;6gb9Jwyv~-|zs<(zk_@SC10-NHv%~@54{feF+YOuj3Z+F|efD8HC1dema1pbw-yYipwKdZERR>2%C>X(32_^Hm3V9ML>(od^k>HEK7`?9wtU+ zijm=>M~GF2hQ&mPF?IqntZrR|7;G-Fv^fce6kP(=cH6bZ6Z1yHX)X57^!i-YYNMezq|A`w zgLj%xnD5Y9;Fh|poxVzUO*lSJ6c*U|7=|vi7y3tX=RS45{ZW7P{eGdrZh&WMw(Cr` zWVoc+mSnw7Z`CGS?T%Ex-C{}gTTT8@!(zMtfvI?fsMcmzR=K?XVw=0V+FhdxV+ECE z9=F$xmj`XpG^fV}zp*eoJJ05T(_dUrRG4DV@0_1-r)EKcRlYOqj3>B%F@PEUPy%tI9j>6k;m{{Lbar#LP-00o zGZmaZLz>QPGubsdtJUg%xGSWQS$bO1v-J)*o9W3GhusX{OJ_7BTP$$8l8t&>n$DJ$ zZcVjXQq^hjschp59CP)>+UjXu*HnK^alW?DX2~zgQjNn4L~SuQ&OOa3x~wv*ImJ~U zSDsrwK9eQ*$){n8Q?rhHHI{d~?m3Jjgl>C;u(7@NyzZB#SCM-ms_VLFG^BUow8xZ<$#`Xp>h(SDKi z?n~a5l2QsKniK>ah_(O2SFGbPk@%wJ2QvY)YHlb1a=Vx&Z!OW`zqDHg{|;#ir=^JX ztPY)BcKBeyqf2g_IAZBTBXC5IVx^rXiACDO64-*fTrGQEGv#7vd60S*AxkNge=#K& z9u&Q+bTWvF6-wIfZ$oA5U9_XU@HD#IUO)qQ4Jb~e<|+1=?rAecF*0R7QhwSvm6QV2 zgnUWvFG3@~vTU52i^GtHVHh*EFlVdxC@36_L_wZyY+(@+D3Oqciz5xwGM}12 zy#Wz5M)sFwLQ4#*p41+_Oxq#H%Ow{1 zO3iEgLWLc7u{WOoST-=EI?@uV8C=TB&Lt!3^k6w|k&b+SpB%4~E2igsRSo(4)32U9 z^1LDIndkKTJI}s(BWX)Io}zlYVo|w4#fn#)&kZUxm(D~ag9>|!MMe5*#Z_NUjlpWc zL)*p-mg!1kwn%Jz*3l~@3pvt8b&1yYFrH{_zZf7|+e3V!S=)Skk1-Kx61BKN#MJf+ zeWFF%B?&f4P0Us@wm3}0WNTA8WE>TXPXKa}Ny=`*Q6vHXTrf{6>9ViV`GFt#6ky`F zSZnO<^MWCE*|sW<8!4f*PDqwJgib{x*2_b1g7gPLGQ$FYrr1~I1g0nF;Lp@SLJKVD z2B`%8uOy^Wea~o*PBv}4pW*0=thn$Gv02oo9$Lpdb-(UCYaOlAS&|aT({S! zb=3P@HRbp(oV=O}_bpM8Ejp~voNY844fZsXF4>lyp-a~5ZQ03Yhsl_%(^+)3482~b zOSQ}y4sT+3ODmvM(3l--YrK z49-g8IlgG^-@hxIrg`>0H5)SMg%5S0(V{@ciJoTxqm{!2)qsc%KP)_|0=Uk9(!aJ|HcYNutVWe{TJVV z`~5X3S8G;2fc_8t?s@9}ae%BX^?wXNdOr!E`CJ9iIhYTizTFN`zZU{HvF7_nB#-+6 zlFv>cP##1ps&v6ZdbO4utYEnBI;ayb6UmFlaj1-VXnCP4T7pey(T# H&h`Hf@o5l7 literal 0 HcmV?d00001 diff --git a/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java b/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java index 63d67ee771..9bb137ff69 100644 --- a/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java +++ b/src/testcases/org/apache/poi/hssf/extractor/TestExcelExtractor.java @@ -165,6 +165,28 @@ public final class TestExcelExtractor extends TestCase { ); } + public void testWithComments() throws Exception { + ExcelExtractor extractor = createExtractor("SimpleWithComments.xls"); + extractor.setIncludeSheetNames(false); + + // Check without comments + assertEquals( + "1.0\tone\n" + + "2.0\ttwo\n" + + "3.0\tthree\n", + extractor.getText() + ); + + // Now with + extractor.setIncludeCellComments(true); + assertEquals( + "1.0\tone Comment by Yegor Kozlov: Yegor Kozlov: first cell\n" + + "2.0\ttwo Comment by Yegor Kozlov: Yegor Kozlov: second cell\n" + + "3.0\tthree Comment by Yegor Kozlov: Yegor Kozlov: third cell\n", + extractor.getText() + ); + } + /** * Embded in a non-excel file -- 2.39.5