From 22dc3e73991462bdd99fb34d4ebc2e4b8831a618 Mon Sep 17 00:00:00 2001 From: acolyer Date: Thu, 5 Aug 2004 13:33:18 +0000 Subject: [PATCH] added a comment indicating how and where to fix 42743 should we decide to do so. --- weaver/src/org/aspectj/weaver/bcel/BcelShadow.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java index e81c43ff2..bbb56b777 100644 --- a/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java +++ b/weaver/src/org/aspectj/weaver/bcel/BcelShadow.java @@ -1234,6 +1234,12 @@ public class BcelShadow extends Shadow { InstructionList handler = new InstructionList(); BcelVar exceptionVar = genTempVar(catchType); exceptionVar.appendStore(handler, fact); + + // ENH 42743 suggests that we don't soften runtime exceptions. + // To implement that, would need to add instructions into the handler + // stream here to test if exceptionVar is an instanceof RuntimeException, + // and if it is, just re-throw it without softening. + // (Not yet implemented obviously). handler.append(fact.createNew(NameMangler.SOFT_EXCEPTION_TYPE)); handler.append(InstructionFactory.createDup(1)); -- 2.39.5