From 23b537d98fe681bf12d04ef7a8b17a92e59c2e18 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Vilain Date: Fri, 26 Apr 2013 13:52:03 +0200 Subject: [PATCH] SONAR-3893 Renamed column in SNAPSHOT_DATA from data to value --- .../batch/index/ComponentDataPersister.java | 2 +- .../should_persist_component_data-result.xml | 4 +- .../core/source/HtmlSourceDecorator.java | 6 +- .../core/source/jdbc/SnapshotDataDto.java | 10 +- .../org/sonar/core/persistence/schema-h2.ddl | 2 +- .../core/source/jdbc/SnapshotDataMapper.xml | 10 +- .../core/source/jdbc/SnapshotDataDaoTest.java | 6 +- .../shouldDeleteSnapshot-result.xml | 2 +- .../shouldDeleteSnapshot.xml | 4 +- .../shouldPurgeSnapshot-result.xml | 2 +- .../PurgeCommandsTest/shouldPurgeSnapshot.xml | 4 +- .../source/HtmlSourceDecoratorTest/shared.xml | 8 +- .../jdbc/SnapshotDataDaoTest/shared.xml | 4 +- .../sonar/api/config/PropertyDefinition.java | 1 + .../WEB-INF/app/models/measure_color.rb | 2 + .../main/webapp/WEB-INF/config/environment.rb | 205 +++++++++--------- .../db/migrate/387_create_snapshot_data.rb | 2 +- 17 files changed, 142 insertions(+), 132 deletions(-) diff --git a/sonar-batch/src/main/java/org/sonar/batch/index/ComponentDataPersister.java b/sonar-batch/src/main/java/org/sonar/batch/index/ComponentDataPersister.java index d0ef14aebeb..5a875e32312 100644 --- a/sonar-batch/src/main/java/org/sonar/batch/index/ComponentDataPersister.java +++ b/sonar-batch/src/main/java/org/sonar/batch/index/ComponentDataPersister.java @@ -47,7 +47,7 @@ public class ComponentDataPersister implements ScanPersister { dto.setSnapshotId(snapshot.getId()); dto.setResourceId(snapshot.getResourceId()); dto.setDataType(dataEntry.key()); - dto.setData(dataEntry.value().writeString()); + dto.setValue(dataEntry.value().writeString()); // TODO bulk insert dao.insert(dto); diff --git a/sonar-batch/src/test/resources/org/sonar/batch/index/ComponentDataPersisterTest/should_persist_component_data-result.xml b/sonar-batch/src/test/resources/org/sonar/batch/index/ComponentDataPersisterTest/should_persist_component_data-result.xml index 2795b1bee33..559c33319a2 100644 --- a/sonar-batch/src/test/resources/org/sonar/batch/index/ComponentDataPersisterTest/should_persist_component_data-result.xml +++ b/sonar-batch/src/test/resources/org/sonar/batch/index/ComponentDataPersisterTest/should_persist_component_data-result.xml @@ -1,5 +1,5 @@ - - + + \ No newline at end of file diff --git a/sonar-core/src/main/java/org/sonar/core/source/HtmlSourceDecorator.java b/sonar-core/src/main/java/org/sonar/core/source/HtmlSourceDecorator.java index 91936ce34ee..085f8eb4990 100644 --- a/sonar-core/src/main/java/org/sonar/core/source/HtmlSourceDecorator.java +++ b/sonar-core/src/main/java/org/sonar/core/source/HtmlSourceDecorator.java @@ -73,11 +73,11 @@ public class HtmlSourceDecorator implements ServerComponent { } private void loadSnapshotData(DecorationDataHolder decorationDataHolder, SnapshotDataDto snapshotDataEntry) { - if(!Strings.isNullOrEmpty(snapshotDataEntry.getData())) { + if(!Strings.isNullOrEmpty(snapshotDataEntry.getValue())) { if (SnapshotDataType.isSyntaxHighlighting(snapshotDataEntry.getDataType())) { - decorationDataHolder.loadSyntaxHighlightingData(snapshotDataEntry.getData()); + decorationDataHolder.loadSyntaxHighlightingData(snapshotDataEntry.getValue()); } else if (SnapshotDataType.isSymbolHighlighting(snapshotDataEntry.getDataType())) { - decorationDataHolder.loadSymbolReferences(snapshotDataEntry.getData()); + decorationDataHolder.loadSymbolReferences(snapshotDataEntry.getValue()); } } } diff --git a/sonar-core/src/main/java/org/sonar/core/source/jdbc/SnapshotDataDto.java b/sonar-core/src/main/java/org/sonar/core/source/jdbc/SnapshotDataDto.java index 5d70fda1689..e42c122bd94 100644 --- a/sonar-core/src/main/java/org/sonar/core/source/jdbc/SnapshotDataDto.java +++ b/sonar-core/src/main/java/org/sonar/core/source/jdbc/SnapshotDataDto.java @@ -28,7 +28,7 @@ public class SnapshotDataDto { private long id; private long snapshotId; private long resourceId; - private String data; + private String value; private String dataType; public long getSnapshotId() { @@ -39,8 +39,8 @@ public class SnapshotDataDto { return resourceId; } - public String getData() { - return data; + public String getValue() { + return value; } public String getDataType() { @@ -63,8 +63,8 @@ public class SnapshotDataDto { this.resourceId = resourceId; } - public void setData(String data) { - this.data = data; + public void setValue(String value) { + this.value = value; } public void setDataType(String dataType) { diff --git a/sonar-core/src/main/resources/org/sonar/core/persistence/schema-h2.ddl b/sonar-core/src/main/resources/org/sonar/core/persistence/schema-h2.ddl index 0a9816efc1a..598a8a1f50b 100644 --- a/sonar-core/src/main/resources/org/sonar/core/persistence/schema-h2.ddl +++ b/sonar-core/src/main/resources/org/sonar/core/persistence/schema-h2.ddl @@ -554,7 +554,7 @@ CREATE TABLE "SNAPSHOT_DATA" ( "ID" INTEGER NOT NULL GENERATED BY DEFAULT AS IDENTITY (START WITH 1, INCREMENT BY 1), "SNAPSHOT_ID" INTEGER, "RESOURCE_ID" INTEGER, - "DATA" VARCHAR(16777215), + "VALUE" VARCHAR(16777215), "DATA_TYPE" VARCHAR(50), "CREATED_AT" TIMESTAMP, "UPDATED_AT" TIMESTAMP, diff --git a/sonar-core/src/main/resources/org/sonar/core/source/jdbc/SnapshotDataMapper.xml b/sonar-core/src/main/resources/org/sonar/core/source/jdbc/SnapshotDataMapper.xml index 23b52c89411..ca10588f169 100644 --- a/sonar-core/src/main/resources/org/sonar/core/source/jdbc/SnapshotDataMapper.xml +++ b/sonar-core/src/main/resources/org/sonar/core/source/jdbc/SnapshotDataMapper.xml @@ -6,7 +6,7 @@