From 252450b44cf34ae861e0bbc55712a9941e223aa2 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Tue, 22 Oct 2019 12:41:21 +0000 Subject: [PATCH] code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 5 ----- app/controllers/application_controller.rb | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 14e1519ce..24d070e6d 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -526,11 +526,6 @@ Performance/FixedSize: - 'test/integration/api_test/issues_test.rb' - 'test/integration/attachments_test.rb' -# Cop supports --auto-correct. -Performance/RedundantBlockCall: - Exclude: - - 'app/controllers/application_controller.rb' - # Cop supports --auto-correct. Performance/RedundantMatch: Exclude: diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 06e2d702c..02612e36f 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -486,7 +486,7 @@ class ApplicationController < ActionController::Base if args.any? redirect_to *args elsif block_given? - block.call + yield else raise "#redirect_to_referer_or takes arguments or a block" end -- 2.39.5