From 317f47f43459de8ac70603c0c278193976f0e60b Mon Sep 17 00:00:00 2001 From: Javen O'Neal Date: Sun, 9 Oct 2016 10:59:34 +0000 Subject: [PATCH] bug 60228: getCellTypeEnum should not be deprecated until after getCellType returns a CellType enum git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763960 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/poi/hssf/usermodel/HSSFCell.java | 2 -- src/java/org/apache/poi/ss/usermodel/Cell.java | 2 -- src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java | 6 ++---- src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java | 3 --- 4 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFCell.java b/src/java/org/apache/poi/hssf/usermodel/HSSFCell.java index cfe998e059..981cbd4829 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFCell.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFCell.java @@ -457,7 +457,6 @@ public class HSSFCell implements Cell { /** * get the cells type (numeric, formula or string) * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3 * Will be deleted when we make the CellType enum transition. See bug 59791. */ @Override @@ -1167,7 +1166,6 @@ public class HSSFCell implements Cell { * {@link CellType#BOOLEAN}, {@link CellType#ERROR}) depending * on the cached value of the formula * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3 * Will be deleted when we make the CellType enum transition. See bug 59791. */ @Override diff --git a/src/java/org/apache/poi/ss/usermodel/Cell.java b/src/java/org/apache/poi/ss/usermodel/Cell.java index 13d8608230..a6f4f6387b 100644 --- a/src/java/org/apache/poi/ss/usermodel/Cell.java +++ b/src/java/org/apache/poi/ss/usermodel/Cell.java @@ -176,7 +176,6 @@ public interface Cell { * * @return the cell type * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3 * Will be renamed to getCellType() when we make the CellType enum transition in POI 4.0. See bug 59791. */ @Removal(version="4.2") @@ -201,7 +200,6 @@ public interface Cell { * {@link CellType#BOOLEAN}, {@link CellType#ERROR}) depending * on the cached value of the formula * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3 * Will be renamed to getCachedFormulaResultType() when we make the CellType enum transition in POI 4.0. See bug 59791. */ CellType getCachedFormulaResultTypeEnum(); diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java index 99a4648a7c..3a1d85cb03 100644 --- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java +++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java @@ -162,6 +162,7 @@ public class SXSSFCell implements Cell { * Return the cell type. * * @return the cell type + * @deprecated 3.15. Will return a {@link CellType} enum in the future. */ @Override public int getCellType() @@ -174,10 +175,8 @@ public class SXSSFCell implements Cell { * * @return the cell type * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3 * Will be deleted when we make the CellType enum transition. See bug 59791. */ - @Internal(since="POI 3.15 beta 3") @Override public CellType getCellTypeEnum() { @@ -189,6 +188,7 @@ public class SXSSFCell implements Cell { * @return one of ({@link CellType#NUMERIC}, {@link CellType#STRING}, * {@link CellType#BOOLEAN}, {@link CellType#ERROR}) depending * on the cached value of the formula + * @deprecated 3.15. Will return a {@link CellType} enum in the future. */ @Override public int getCachedFormulaResultType() @@ -202,10 +202,8 @@ public class SXSSFCell implements Cell { * {@link CellType#BOOLEAN}, {@link CellType#ERROR}) depending * on the cached value of the formula * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3. * Will be deleted when we make the CellType enum transition. See bug 59791. */ - @Internal(since="POI 3.15 beta 3") @Override public CellType getCachedFormulaResultTypeEnum() { diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java index c7932d167b..f1f1ca381b 100644 --- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java +++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCell.java @@ -680,10 +680,8 @@ public final class XSSFCell implements Cell { * * @return the cell type * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3 * Will be deleted when we make the CellType enum transition. See bug 59791. */ - @Internal(since="POI 3.15 beta 3") @Override public CellType getCellTypeEnum() { if (isFormulaCell()) return CellType.FORMULA; @@ -713,7 +711,6 @@ public final class XSSFCell implements Cell { * {@link CellType#BOOLEAN}, {@link CellType#ERROR}) depending * on the cached value of the formula * @since POI 3.15 beta 3 - * @deprecated POI 3.15 beta 3 * Will be deleted when we make the CellType enum transition. See bug 59791. */ @Override -- 2.39.5