From 352deaddc1daec7dce9656be6f2ce8dd7845cc72 Mon Sep 17 00:00:00 2001
From: Josh Micich <josh@apache.org>
Date: Wed, 16 Dec 2009 21:08:36 +0000
Subject: [PATCH] changed short param to int in AreaEval.containsColumn()
 method

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@891425 13f79535-47bb-0310-9956-ffa450edef68
---
 .../org/apache/poi/hssf/record/formula/eval/AreaEval.java   | 2 +-
 .../apache/poi/hssf/record/formula/eval/AreaEvalBase.java   | 6 +++---
 .../poi/hssf/record/formula/eval/OperandResolver.java       | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/java/org/apache/poi/hssf/record/formula/eval/AreaEval.java b/src/java/org/apache/poi/hssf/record/formula/eval/AreaEval.java
index 4c5fb9f681..733a6253e4 100644
--- a/src/java/org/apache/poi/hssf/record/formula/eval/AreaEval.java
+++ b/src/java/org/apache/poi/hssf/record/formula/eval/AreaEval.java
@@ -68,7 +68,7 @@ public interface AreaEval extends TwoDEval {
      * returns true if the specified col is in range
      * @param col
      */
-    boolean containsColumn(short col);
+    boolean containsColumn(int col);
 
     /**
      * returns true if the specified row is in range
diff --git a/src/java/org/apache/poi/hssf/record/formula/eval/AreaEvalBase.java b/src/java/org/apache/poi/hssf/record/formula/eval/AreaEvalBase.java
index 12e21cf9ad..4d04fd126f 100644
--- a/src/java/org/apache/poi/hssf/record/formula/eval/AreaEvalBase.java
+++ b/src/java/org/apache/poi/hssf/record/formula/eval/AreaEvalBase.java
@@ -87,11 +87,11 @@ public abstract class AreaEvalBase implements AreaEval {
 	}
 
 	public final boolean containsRow(int row) {
-		return (_firstRow <= row) && (_lastRow >= row);
+		return _firstRow <= row && _lastRow >= row;
 	}
 
-	public final boolean containsColumn(short col) {
-		return (_firstColumn <= col) && (_lastColumn >= col);
+	public final boolean containsColumn(int col) {
+		return _firstColumn <= col && _lastColumn >= col;
 	}
 
 	public final boolean isColumn() {
diff --git a/src/java/org/apache/poi/hssf/record/formula/eval/OperandResolver.java b/src/java/org/apache/poi/hssf/record/formula/eval/OperandResolver.java
index 50e9dd058d..f18abce008 100644
--- a/src/java/org/apache/poi/hssf/record/formula/eval/OperandResolver.java
+++ b/src/java/org/apache/poi/hssf/record/formula/eval/OperandResolver.java
@@ -102,7 +102,7 @@ public final class OperandResolver {
 	 */
 	public static ValueEval chooseSingleElementFromArea(AreaEval ae,
 			int srcCellRow, int srcCellCol) throws EvaluationException {
-		ValueEval result = chooseSingleElementFromAreaInternal(ae, srcCellRow, (short) srcCellCol);
+		ValueEval result = chooseSingleElementFromAreaInternal(ae, srcCellRow, srcCellCol);
 		if(result == null) {
 			// This seems to be required because AreaEval.values() array may contain nulls.
 			// perhaps that should not be allowed.
@@ -119,7 +119,7 @@ public final class OperandResolver {
 	 * @return possibly <tt>ErrorEval</tt>, and <code>null</code>
 	 */
 	private static ValueEval chooseSingleElementFromAreaInternal(AreaEval ae,
-			int srcCellRow, short srcCellCol) throws EvaluationException {
+			int srcCellRow, int srcCellCol) throws EvaluationException {
 
 		if(false) {
 			// this is too simplistic
-- 
2.39.5