From 370f291c359cd159c5f3f0abd6e9e53e81234a07 Mon Sep 17 00:00:00 2001 From: Andy Clement Date: Thu, 7 Mar 2019 11:50:24 -0800 Subject: [PATCH] 1.9.3.RC1 final bits --- README.md | 3 ++ docs/dist/doc/README-193.html | 30 +++++++++++++++++++ .../internal/core/builder/AjBuildManager.java | 9 +++++- .../tools/ant/taskdefs/AjcTaskTest.java | 3 ++ 4 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 docs/dist/doc/README-193.html diff --git a/README.md b/README.md index 2ec5a574e..871f341af 100644 --- a/README.md +++ b/README.md @@ -22,3 +22,6 @@ This will build all the modules, run all the tests and install the key artifacts Once you have imported all the projects using `m2e`, close the `org.eclipse.jdt.core` project (TOBEFIXED), then there is a special module called `run-all-junit-tests` and within that a `RunTheseBeforeYouCommitTests` class that can be run with the JUnit launcher. This will execute all the tests in each module plus the compiler tests in the `tests` module. When you close `org.eclipse.jdt.core` you might need to do a maven refresh on the `run-all-junit-tests` project. +## Setting version for release: + +mvn versions:set -DgroupId=org.aspectj -DartifactId=* -DoldVersion=1.9.3.BUILD-SNAPSHOT -DnewVersion=1.9.3 diff --git a/docs/dist/doc/README-193.html b/docs/dist/doc/README-193.html new file mode 100644 index 000000000..6bcf89e75 --- /dev/null +++ b/docs/dist/doc/README-193.html @@ -0,0 +1,30 @@ + + +AspectJ 1.9.3 Readme + + + + +
+© Copyright 2018 Contributors. +All rights reserved. +
+

The full list of resolved issues in 1.9.3 is available +here.

+ +

Available: 1.9.3.RC1 available 7-Mar-2019

+ +

+ + + + + diff --git a/org.aspectj.ajdt.core/src/main/java/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java b/org.aspectj.ajdt.core/src/main/java/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java index 25557035a..e7419680e 100644 --- a/org.aspectj.ajdt.core/src/main/java/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java +++ b/org.aspectj.ajdt.core/src/main/java/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java @@ -1340,6 +1340,13 @@ public class AjBuildManager implements IOutputClassFileNameProvider, IBinarySour if (buildConfig == null || buildConfig.getFullClasspath() == null) { return "no classpath specified"; } + + for (String s: buildConfig.getFullClasspath()) { + if (s.endsWith("runtime/target/classes")) { + // doing an AspectJ build + return null; + } + } String ret = null; for (Iterator it = buildConfig.getFullClasspath().iterator(); it.hasNext();) { @@ -1362,7 +1369,7 @@ public class AjBuildManager implements IOutputClassFileNameProvider, IBinarySour } } // assume that users of development aspectjrt.jar know what they're doing - if (Version.DEVELOPMENT.equals(version)) { + if (Version.DEVELOPMENT.equals(version) || version.endsWith("BUILD-SNAPSHOT")) { // MessageUtil.info(holder, // "running with development version of aspectjrt.jar in " + // p.getAbsolutePath()); diff --git a/taskdefs/src/test/java/org/aspectj/tools/ant/taskdefs/AjcTaskTest.java b/taskdefs/src/test/java/org/aspectj/tools/ant/taskdefs/AjcTaskTest.java index f7f3908c3..b12dc4fe8 100644 --- a/taskdefs/src/test/java/org/aspectj/tools/ant/taskdefs/AjcTaskTest.java +++ b/taskdefs/src/test/java/org/aspectj/tools/ant/taskdefs/AjcTaskTest.java @@ -1027,6 +1027,9 @@ public class AjcTaskTest extends TestCase { holder, kind + " expected " + num + " got " + actual); } + if (num != actual){ + System.out.println("===\n"+Arrays.toString(holder.getMessages(kind, false))+"\n===\n"); + } assertEquals(kind.toString(), num, actual); } } -- 2.39.5