From 379a7d804e0d8aaeeab6d6e226ba25501ac1963f Mon Sep 17 00:00:00 2001 From: David Cho-Lerat Date: Mon, 29 Jul 2024 10:45:00 +0200 Subject: [PATCH] SONAR-22303 Fix aria-label misuse (Deque issue #1742007) --- .../main/js/app/components/nav/global/MainSonarQubeBar.tsx | 4 +++- sonar-core/src/main/resources/org/sonar/l10n/core.properties | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx b/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx index 05e799562df..3ecb9d32f1b 100644 --- a/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx +++ b/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx @@ -32,7 +32,9 @@ function LogoWithAriaText() { const customLogoUrl = settings[GlobalSettingKeys.LogoUrl]; const customLogoWidth = settings[GlobalSettingKeys.LogoWidth] ?? DEFAULT_CUSTOM_LOGO_WIDTH_IN_PX; - const title = translate('layout.nav.home_logo_alt'); + const title = customLogoUrl + ? translate('layout.nav.home_logo_alt') + : translate('layout.nav.home_sonarqube_logo_alt'); return (
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties index 1d28a55a9ba..d8dff3b0c34 100644 --- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties +++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties @@ -585,6 +585,7 @@ layout.settings.VW=Portfolio Settings layout.settings.SVW=Portfolio Settings layout.security_reports=Security Reports layout.nav.home_logo_alt=Logo, link to homepage +layout.nav.home_sonarqube_logo_alt=SonarQube logo, link to homepage layout.must_be_configured=This will be available once your project is configured and analyzed. layout.all_project_must_be_accessible=You need access to all projects within this {0} to access it. -- 2.39.5