From 3984215fbd1647fcf7a1a8afa8883b7d6e27a630 Mon Sep 17 00:00:00 2001 From: Javen O'Neal Date: Fri, 17 Jun 2016 08:56:10 +0000 Subject: [PATCH] bug 59279: add Comment.equals and hashCode methods git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748814 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/poi/hssf/usermodel/HSSFComment.java | 14 ++++++++++++++ .../apache/poi/xssf/usermodel/XSSFComment.java | 15 +++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFComment.java b/src/java/org/apache/poi/hssf/usermodel/HSSFComment.java index 23126d451f..0013bd12e1 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFComment.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFComment.java @@ -320,4 +320,18 @@ public class HSSFComment extends HSSFTextbox implements Comment { setPropertyValue(new EscherSimpleProperty(EscherProperties.GROUPSHAPE__PRINT, false, false, property.getPropertyValue() & GROUP_SHAPE_NOT_HIDDEN_MASK)); } } + + @Override + public boolean equals(Object obj) { + if (!(obj instanceof HSSFComment)) { + return false; + } + HSSFComment other = (HSSFComment) obj; + return getNoteRecord().equals(other.getNoteRecord()); + } + + @Override + public int hashCode() { + return ((getRow()*17) + getColumn())*31; + } } diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFComment.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFComment.java index 4449757a76..ce891a4b96 100644 --- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFComment.java +++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFComment.java @@ -239,4 +239,19 @@ public class XSSFComment implements Comment { protected CTShape getCTShape(){ return _vmlShape; } + + @Override + public boolean equals(Object obj) { + if (!(obj instanceof XSSFComment)) { + return false; + } + XSSFComment other = (XSSFComment) obj; + return ((getCTComment() == other.getCTComment()) && + (getCTShape() == other.getCTShape())); + } + + @Override + public int hashCode() { + return ((getRow()*17) + getColumn())*31; + } } -- 2.39.5