From 3a05334f188e81d5012262602e4198843029e01a Mon Sep 17 00:00:00 2001 From: nhirokinet Date: Fri, 16 Oct 2020 23:59:43 +0900 Subject: [PATCH] manifest to report correct favicon size In the environment where php-imagick with SVG support is correctly installed, this endpoint returns 512x512 image. https://github.com/nextcloud/server/blob/d9015a8c94bfd71fe484618a06d276701d3bf9ff/apps/theming/lib/Controller/IconController.php#L146 The problem is in the environment without php-imagick or without SVG support, this will fall back to original, whose default is 128x128; but I thought this is a separate problem. (For this, default image may be enlarged. Should I create another issue if this is important one?) Signed-off-by: nhirokinet --- apps/theming/lib/Controller/ThemingController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php index 8957d305883..692a0f6234e 100644 --- a/apps/theming/lib/Controller/ThemingController.php +++ b/apps/theming/lib/Controller/ThemingController.php @@ -383,7 +383,7 @@ class ThemingController extends Controller { 'src' => $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon', ['app' => $app]) . '?v=' . $cacheBusterValue, 'type' => 'image/png', - 'sizes' => '128x128' + 'sizes' => '512x512' ], [ 'src' => $this->urlGenerator->linkToRoute('theming.Icon.getFavicon', -- 2.39.5