From 3aa835258106b80076aedf462ab135bd7aabb236 Mon Sep 17 00:00:00 2001 From: =?utf8?q?S=C3=A9bastien=20Lesaint?= Date: Wed, 17 Jun 2015 18:00:25 +0200 Subject: [PATCH] add NewMeasureBuilder overrides without data parameter --- .../server/computation/measure/Measure.java | 16 ++++++++++++++++ .../server/computation/measure/MeasureTest.java | 10 +++++----- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/measure/Measure.java b/server/sonar-server/src/main/java/org/sonar/server/computation/measure/Measure.java index 8d4ae73406c..a29b36f5c72 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/computation/measure/Measure.java +++ b/server/sonar-server/src/main/java/org/sonar/server/computation/measure/Measure.java @@ -165,18 +165,34 @@ public final class Measure { return new Measure(ValueType.BOOLEAN, ruleId, characteristicId, value ? 1.0d : 0.0d, data, null, description, qualityGateStatus, variations); } + public Measure create(boolean value) { + return create(value, null); + } + public Measure create(int value, @Nullable String data) { return new Measure(ValueType.INT, ruleId, characteristicId, (double) value, data, null, description, qualityGateStatus, variations); } + public Measure create(int value) { + return create(value, null); + } + public Measure create(long value, @Nullable String data) { return new Measure(ValueType.LONG, ruleId, characteristicId, (double) value, data, null, description, qualityGateStatus, variations); } + public Measure create(long value) { + return create(value, null); + } + public Measure create(double value, @Nullable String data) { return new Measure(ValueType.DOUBLE, ruleId, characteristicId, value, data, null, description, qualityGateStatus, variations); } + public Measure create(double value) { + return create(value, null); + } + public Measure create(String value) { return new Measure(ValueType.STRING, ruleId, characteristicId, null, requireNonNull(value), null, description, qualityGateStatus, variations); } diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureTest.java index 28b09179c32..4303f0566c4 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureTest.java @@ -40,12 +40,12 @@ import static org.assertj.core.api.Assertions.assertThat; @RunWith(DataProviderRunner.class) public class MeasureTest { - private static final Measure INT_MEASURE = Measure.newMeasure().create((int) 1, null); - private static final Measure LONG_MEASURE = Measure.newMeasure().create(1l, null); - private static final Measure DOUBLE_MEASURE = Measure.newMeasure().create(1d, null); + private static final Measure INT_MEASURE = Measure.newMeasure().create((int) 1); + private static final Measure LONG_MEASURE = Measure.newMeasure().create(1l); + private static final Measure DOUBLE_MEASURE = Measure.newMeasure().create(1d); private static final Measure STRING_MEASURE = Measure.newMeasure().create("some_sT ring"); - private static final Measure TRUE_MEASURE = Measure.newMeasure().create(true, null); - private static final Measure FALSE_MEASURE = Measure.newMeasure().create(false, null); + private static final Measure TRUE_MEASURE = Measure.newMeasure().create(true); + private static final Measure FALSE_MEASURE = Measure.newMeasure().create(false); private static final Measure LEVEL_MEASURE = Measure.newMeasure().create(Measure.Level.OK); private static final Measure NO_VALUE_MEASURE = Measure.newMeasure().createNoValue(); -- 2.39.5