From 3ba74a5b31180ecd73aa3d7fb9d3c04a2739ec98 Mon Sep 17 00:00:00 2001
From: aclement <aclement>
Date: Mon, 9 Feb 2009 20:13:16 +0000
Subject: [PATCH] 124460: simple basic control of weaving via aop.xml

---
 tests/features164/aopconfig/design.txt   | 43 ++++++++++++++++++++++++
 tests/features164/aopconfig/one/A.java   |  3 ++
 tests/features164/aopconfig/one/A2.java  |  3 ++
 tests/features164/aopconfig/one/B.java   |  2 ++
 tests/features164/aopconfig/one/B2.java  |  2 ++
 tests/features164/aopconfig/one/foo.xml  |  6 ++++
 tests/features164/aopconfig/one/foo2.xml |  7 ++++
 7 files changed, 66 insertions(+)
 create mode 100644 tests/features164/aopconfig/design.txt
 create mode 100644 tests/features164/aopconfig/one/A.java
 create mode 100644 tests/features164/aopconfig/one/A2.java
 create mode 100644 tests/features164/aopconfig/one/B.java
 create mode 100644 tests/features164/aopconfig/one/B2.java
 create mode 100644 tests/features164/aopconfig/one/foo.xml
 create mode 100644 tests/features164/aopconfig/one/foo2.xml

diff --git a/tests/features164/aopconfig/design.txt b/tests/features164/aopconfig/design.txt
new file mode 100644
index 000000000..c8bf2f8b1
--- /dev/null
+++ b/tests/features164/aopconfig/design.txt
@@ -0,0 +1,43 @@
+This is to cover https://bugs.eclipse.org/bugs/show_bug.cgi?id=124460 which relates
+to the use of aop.xml configure compile time and binary weaving, in addition to
+load time weaving.
+
+For source compilation and binary weaving the goal is to offer the same experience 
+users will get when using their aop.xml for LTW.
+
+Additionally for source compilation it also offers a way to control
+aspects when they are extracted from source src zip and then used across some
+set of source folders they were never originally intended for (see the
+compiling spring bug where a test aspect is leaking across all the source folders
+in the whole of spring).
+
+So - that means consuming aspects from either the inpath/aspectpath or source folders
+should include aop.xml searching.  Or they can be specified directly as source
+entries perhaps when passing source files:
+
+ajc A.java B.java foo.xml
+
+
+--
+Testing
+
+- basic aop.xml that includes one aspect
+- the variety of mungers (checkers/itd members/advice/decp/deca)
+- wildcarded includes/excludes
+- compound type patterns for scope
+- new messages: ignoring weaver sections, scoping aspects, excluding aspects, problems processing aop.xml
+- aspect supertypes included if subtypes excluded?
+- annotation style
+- inner aspects
+- needs a command line option to switch support for this on/off (ie. to make it search
+  for xml files on aspectpath/inpath - we dont want unexpected behaviour)
+
+--
+Implementation Notes
+
+- Just because the contents of the aspect are not used in weaving, doesnt mean
+  the aspect shouldn't be fully compiled/resolved and written to the bin folder
+  correctly as a valid aspect for later consumption.  So we can't short circuit
+  resolution if the aspect is included - we really just want to exclude inclusion
+  of that aspect in the crosscuttingset - or maybe even later we just want to
+  skip any mungers that came from it (but what about inherited mungers from supertypes?)
diff --git a/tests/features164/aopconfig/one/A.java b/tests/features164/aopconfig/one/A.java
new file mode 100644
index 000000000..57dba05ce
--- /dev/null
+++ b/tests/features164/aopconfig/one/A.java
@@ -0,0 +1,3 @@
+aspect A {
+  before():staticinitialization(*) {}
+}
diff --git a/tests/features164/aopconfig/one/A2.java b/tests/features164/aopconfig/one/A2.java
new file mode 100644
index 000000000..54cc278cb
--- /dev/null
+++ b/tests/features164/aopconfig/one/A2.java
@@ -0,0 +1,3 @@
+aspect A2 {
+  before():staticinitialization(*) {}
+}
diff --git a/tests/features164/aopconfig/one/B.java b/tests/features164/aopconfig/one/B.java
new file mode 100644
index 000000000..66dd24ce6
--- /dev/null
+++ b/tests/features164/aopconfig/one/B.java
@@ -0,0 +1,2 @@
+public class B {
+}
diff --git a/tests/features164/aopconfig/one/B2.java b/tests/features164/aopconfig/one/B2.java
new file mode 100644
index 000000000..d66167754
--- /dev/null
+++ b/tests/features164/aopconfig/one/B2.java
@@ -0,0 +1,2 @@
+public class B2 {
+}
diff --git a/tests/features164/aopconfig/one/foo.xml b/tests/features164/aopconfig/one/foo.xml
new file mode 100644
index 000000000..37f298152
--- /dev/null
+++ b/tests/features164/aopconfig/one/foo.xml
@@ -0,0 +1,6 @@
+<aspectj>
+<aspects>
+  <aspect name="A"/>
+  <!-- <aspect name="A2"/> -->
+</aspects>
+</aspectj>
diff --git a/tests/features164/aopconfig/one/foo2.xml b/tests/features164/aopconfig/one/foo2.xml
new file mode 100644
index 000000000..4d452a3d4
--- /dev/null
+++ b/tests/features164/aopconfig/one/foo2.xml
@@ -0,0 +1,7 @@
+<!-- A is scoped to only affect certain types matching the scope -->
+<aspectj>
+<aspects>
+  <aspect name="A" scope="B"/>
+  <!-- <aspect name="A2"/> -->
+</aspects>
+</aspectj>
-- 
2.39.5