From 3e087ada55f8b0e83b146578b695552db9dc8d97 Mon Sep 17 00:00:00 2001 From: James Moger Date: Wed, 27 Apr 2011 20:55:38 -0400 Subject: [PATCH] Integrated pagelinks into RepositoryPage. Fixed string encoding. --- src/com/gitblit/utils/JGitUtils.java | 7 +- src/com/gitblit/utils/StringUtils.java | 26 ++- src/com/gitblit/wicket/RepositoryPage.html | 30 ++++ src/com/gitblit/wicket/RepositoryPage.java | 149 +++++++++++++++-- .../gitblit/wicket/pages/BlobDiffPage.html | 3 - src/com/gitblit/wicket/pages/BlobPage.html | 3 - .../gitblit/wicket/pages/BranchesPage.html | 3 - .../gitblit/wicket/pages/CommitDiffPage.html | 3 - src/com/gitblit/wicket/pages/CommitPage.html | 3 - src/com/gitblit/wicket/pages/DocsPage.html | 3 - src/com/gitblit/wicket/pages/HistoryPage.html | 3 - src/com/gitblit/wicket/pages/LogPage.html | 3 - .../gitblit/wicket/pages/MarkdownPage.html | 3 - .../gitblit/wicket/pages/MarkdownPage.java | 25 +-- src/com/gitblit/wicket/pages/SearchPage.html | 3 - src/com/gitblit/wicket/pages/SummaryPage.html | 3 - src/com/gitblit/wicket/pages/TagPage.html | 3 - src/com/gitblit/wicket/pages/TagsPage.html | 3 - src/com/gitblit/wicket/pages/TicketPage.html | 3 - src/com/gitblit/wicket/pages/TicketsPage.html | 3 - src/com/gitblit/wicket/pages/TreePage.html | 3 - .../gitblit/wicket/panels/PageLinksPanel.html | 21 --- .../gitblit/wicket/panels/PageLinksPanel.java | 150 ------------------ src/com/gitblit/wicket/resources/gitblit.css | 18 +-- 24 files changed, 215 insertions(+), 259 deletions(-) create mode 100644 src/com/gitblit/wicket/RepositoryPage.html delete mode 100644 src/com/gitblit/wicket/panels/PageLinksPanel.html delete mode 100644 src/com/gitblit/wicket/panels/PageLinksPanel.java diff --git a/src/com/gitblit/utils/JGitUtils.java b/src/com/gitblit/utils/JGitUtils.java index e5dbfd2d..8814c1f4 100644 --- a/src/com/gitblit/utils/JGitUtils.java +++ b/src/com/gitblit/utils/JGitUtils.java @@ -4,6 +4,7 @@ import java.io.ByteArrayOutputStream; import java.io.File; import java.io.IOException; import java.io.InputStream; +import java.nio.charset.Charset; import java.text.DateFormat; import java.text.ParseException; import java.text.SimpleDateFormat; @@ -264,12 +265,14 @@ public class JGitUtils { } public static String getRawContentAsString(Repository r, RevBlob blob) { - return new String(getRawContent(r, blob)); + byte [] content = getRawContent(r, blob); + return new String(content, Charset.forName("UTF-8")); } public static String getRawContentAsString(Repository r, RevCommit commit, String blobPath) { RevObject obj = getRevObject(r, commit.getTree(), blobPath); - return new String(getRawContent(r, (RevBlob) obj)); + byte [] content = getRawContent(r, (RevBlob) obj); + return new String(content, Charset.forName("UTF-8")); } public static List getFilesInPath(Repository r, String basePath, String objectId) { diff --git a/src/com/gitblit/utils/StringUtils.java b/src/com/gitblit/utils/StringUtils.java index 6d646df8..ff9fac4f 100644 --- a/src/com/gitblit/utils/StringUtils.java +++ b/src/com/gitblit/utils/StringUtils.java @@ -1,12 +1,18 @@ package com.gitblit.utils; +import java.io.IOException; +import java.io.StringReader; +import java.io.StringWriter; import java.io.UnsupportedEncodingException; import java.security.MessageDigest; import java.security.NoSuchAlgorithmException; import java.util.List; +import org.tautua.markdownpapers.Markdown; +import org.tautua.markdownpapers.parser.ParseException; + public class StringUtils { - + public static boolean isEmpty(String value) { return value == null || value.trim().length() == 0; } @@ -107,4 +113,22 @@ public class StringUtils { } } + public static String transformMarkdown(String markdown) throws java.text.ParseException { + // Read raw markdown content and transform it to html + StringReader reader = new StringReader(markdown); + StringWriter writer = new StringWriter(); + try { + Markdown md = new Markdown(); + md.transform(reader, writer); + return writer.toString(); + } catch (ParseException p) { + throw new java.text.ParseException(p.getMessage(), 0); + } finally { + reader.close(); + try { + writer.close(); + } catch (IOException e) { + } + } + } } diff --git a/src/com/gitblit/wicket/RepositoryPage.html b/src/com/gitblit/wicket/RepositoryPage.html new file mode 100644 index 00000000..4b3f2e78 --- /dev/null +++ b/src/com/gitblit/wicket/RepositoryPage.html @@ -0,0 +1,30 @@ + + + + + + +
+ +
+ +
+ + + +
+ + + + +
+ + \ No newline at end of file diff --git a/src/com/gitblit/wicket/RepositoryPage.java b/src/com/gitblit/wicket/RepositoryPage.java index 30e41a5f..28cdcd03 100644 --- a/src/com/gitblit/wicket/RepositoryPage.java +++ b/src/com/gitblit/wicket/RepositoryPage.java @@ -1,5 +1,7 @@ package com.gitblit.wicket; +import java.util.ArrayList; +import java.util.Arrays; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -7,7 +9,16 @@ import java.util.Map; import org.apache.wicket.Component; import org.apache.wicket.PageParameters; import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.form.DropDownChoice; +import org.apache.wicket.markup.html.form.StatelessForm; +import org.apache.wicket.markup.html.form.TextField; +import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.apache.wicket.markup.html.panel.Fragment; +import org.apache.wicket.markup.repeater.Item; +import org.apache.wicket.markup.repeater.data.DataView; +import org.apache.wicket.markup.repeater.data.ListDataProvider; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.Model; import org.eclipse.jgit.diff.DiffEntry.ChangeType; import org.eclipse.jgit.lib.PersonIdent; import org.eclipse.jgit.lib.Repository; @@ -20,9 +31,15 @@ import com.gitblit.Keys; import com.gitblit.utils.JGitUtils; import com.gitblit.utils.JGitUtils.SearchType; import com.gitblit.utils.StringUtils; +import com.gitblit.wicket.pages.BranchesPage; +import com.gitblit.wicket.pages.DocsPage; +import com.gitblit.wicket.pages.LogPage; import com.gitblit.wicket.pages.RepositoriesPage; import com.gitblit.wicket.pages.SearchPage; -import com.gitblit.wicket.panels.PageLinksPanel; +import com.gitblit.wicket.pages.SummaryPage; +import com.gitblit.wicket.pages.TagsPage; +import com.gitblit.wicket.pages.TicketsPage; +import com.gitblit.wicket.pages.TreePage; import com.gitblit.wicket.panels.RefsPanel; public abstract class RepositoryPage extends BasePage { @@ -34,7 +51,21 @@ public abstract class RepositoryPage extends BasePage { private transient Repository r = null; private final Logger logger = LoggerFactory.getLogger(RepositoryPage.class); - + + private final Map knownPages = new HashMap() { + + private static final long serialVersionUID = 1L; + + { + put("summary", "gb.summary"); + put("log", "gb.log"); + put("branches", "gb.branches"); + put("tags", "gb.tags"); + put("tree", "gb.tree"); + put("tickets", "gb.tickets"); + } + }; + public RepositoryPage(PageParameters params) { super(params); if (!params.containsKey("r")) { @@ -46,14 +77,71 @@ public abstract class RepositoryPage extends BasePage { Repository r = getRepository(); - // setup the page links and disable this page's link - PageLinksPanel pageLinks = new PageLinksPanel("pageLinks", r, repositoryName, getPageName()); - add(pageLinks); - pageLinks.disablePageLink(getPageName()); + // standard page links + add(new BookmarkablePageLink("summary", SummaryPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + add(new BookmarkablePageLink("log", LogPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + add(new BookmarkablePageLink("branches", BranchesPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + add(new BookmarkablePageLink("tags", TagsPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + add(new BookmarkablePageLink("tree", TreePage.class, WicketUtils.newRepositoryParameter(repositoryName))); + + // per-repository extra page links + List extraPageLinks = new ArrayList(); + + // Conditionally add tickets page + boolean checkTickets = JGitUtils.getRepositoryUseTickets(r); + if (checkTickets && JGitUtils.getTicketsBranch(r) != null) { + extraPageLinks.add("tickets"); + } + + // Conditionally add docs page + boolean checkDocs = JGitUtils.getRepositoryUseDocs(r); + if (checkDocs) { + extraPageLinks.add("docs"); + } + + ListDataProvider extrasDp = new ListDataProvider(extraPageLinks); + DataView extrasView = new DataView("extra", extrasDp) { + private static final long serialVersionUID = 1L; + + public void populateItem(final Item item) { + String extra = item.getModelObject(); + if (extra.equals("tickets")) { + item.add(new Label("extraSeparator", " | ")); + item.add(new LinkPanel("extraLink", null, getString("gb.tickets"), TicketsPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + } else if (extra.equals("docs")) { + item.add(new Label("extraSeparator", " | ")); + item.add(new LinkPanel("extraLink", null, getString("gb.docs"), DocsPage.class, WicketUtils.newRepositoryParameter(repositoryName))); + } + } + }; + add(extrasView); + + // disable current page + disablePageLink(getPageName()); + // add floating search form + SearchForm searchForm = new SearchForm("searchForm", repositoryName); + add(searchForm); + searchForm.setTranslatedAttributes(); + + // set stateless page preference setStatelessHint(true); } + public void disablePageLink(String pageName) { + for (String wicketId : knownPages.keySet()) { + String key = knownPages.get(wicketId); + String linkName = getString(key); + if (linkName.equals(pageName)) { + Component c = get(wicketId); + if (c != null) { + c.setEnabled(false); + } + break; + } + } + } + protected Repository getRepository() { if (r == null) { Repository r = GitBlit.self().getRepository(repositoryName); @@ -108,7 +196,6 @@ public abstract class RepositoryPage extends BasePage { protected abstract String getPageName(); - protected Component createPersonPanel(String wicketId, PersonIdent identity, SearchType searchType) { boolean showEmail = GitBlit.self().settings().getBoolean(Keys.web.showEmailAddresses, false); if (!showEmail || StringUtils.isEmpty(identity.getName()) || StringUtils.isEmpty(identity.getEmailAddress())) { @@ -130,14 +217,14 @@ public abstract class RepositoryPage extends BasePage { LinkPanel nameLink = new LinkPanel("personName", "list", identity.getName(), SearchPage.class, WicketUtils.newSearchParameter(repositoryName, objectId, identity.getName(), searchType)); setPersonSearchTooltip(nameLink, identity.getName(), searchType); fullPerson.add(nameLink); - + LinkPanel addressLink = new LinkPanel("personAddress", "list", "<" + identity.getEmailAddress() + ">", SearchPage.class, WicketUtils.newSearchParameter(repositoryName, objectId, identity.getEmailAddress(), searchType)); setPersonSearchTooltip(addressLink, identity.getEmailAddress(), searchType); fullPerson.add(addressLink); return fullPerson; } } - + protected void setPersonSearchTooltip(Component component, String value, SearchType searchType) { if (searchType.equals(SearchType.AUTHOR)) { WicketUtils.setHtmlTooltip(component, getString("gb.searchForAuthor") + " " + value); @@ -145,7 +232,7 @@ public abstract class RepositoryPage extends BasePage { WicketUtils.setHtmlTooltip(component, getString("gb.searchForCommitter") + " " + value); } } - + protected void setChangeTypeTooltip(Component container, ChangeType type) { switch (type) { case ADD: @@ -163,7 +250,7 @@ public abstract class RepositoryPage extends BasePage { break; } } - + @Override protected void onBeforeRender() { // dispose of repository object @@ -191,4 +278,44 @@ public abstract class RepositoryPage extends BasePage { protected PageParameters newPathParameter(String path) { return WicketUtils.newPathParameter(repositoryName, objectId, path); } + + class SearchForm extends StatelessForm { + private static final long serialVersionUID = 1L; + + private final String repositoryName; + + private final IModel searchBoxModel = new Model(""); + + private final IModel searchTypeModel = new Model(SearchType.COMMIT); + + public SearchForm(String id, String repositoryName) { + super(id); + this.repositoryName = repositoryName; + DropDownChoice searchType = new DropDownChoice("searchType", Arrays.asList(SearchType.values())); + searchType.setModel(searchTypeModel); + add(searchType.setVisible(GitBlit.self().settings().getBoolean(Keys.web.showSearchTypeSelection, false))); + TextField searchBox = new TextField("searchBox", searchBoxModel); + add(searchBox); + } + + void setTranslatedAttributes() { + WicketUtils.setHtmlTooltip(get("searchType"), getString("gb.searchTypeTooltip")); + WicketUtils.setHtmlTooltip(get("searchBox"), getString("gb.searchTooltip")); + WicketUtils.setInputPlaceholder(get("searchBox"), getString("gb.search")); + } + + @Override + public void onSubmit() { + SearchType searchType = searchTypeModel.getObject(); + String searchString = searchBoxModel.getObject(); + for (SearchType type : SearchType.values()) { + if (searchString.toLowerCase().startsWith(type.name().toLowerCase() + ":")) { + searchType = type; + searchString = searchString.substring(type.name().toLowerCase().length() + 1).trim(); + break; + } + } + setResponsePage(SearchPage.class, WicketUtils.newSearchParameter(repositoryName, null, searchString, searchType)); + } + } } diff --git a/src/com/gitblit/wicket/pages/BlobDiffPage.html b/src/com/gitblit/wicket/pages/BlobDiffPage.html index 12271696..4818aa8c 100644 --- a/src/com/gitblit/wicket/pages/BlobDiffPage.html +++ b/src/com/gitblit/wicket/pages/BlobDiffPage.html @@ -6,9 +6,6 @@ - - -
[page links]