From 3f6c969d83faa23379d79ac678c75c22926a5fe1 Mon Sep 17 00:00:00 2001
From: Thomas Lehmann <t.lehmann@strato.de>
Date: Thu, 14 Nov 2024 12:15:02 +0100
Subject: [PATCH] feat(Mailer): hide admin settings for "null" transport

When the mail transport is configured as null transport, the
configuration UI would not work.

== Background

The null transport is meant for situations where operators
implement mail delivery via custom mechanisms like REST APIs.

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
---
 .../settings/templates/settings/admin/additional-mail.php | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/apps/settings/templates/settings/admin/additional-mail.php b/apps/settings/templates/settings/admin/additional-mail.php
index ecc2973f085..6d6c036e813 100644
--- a/apps/settings/templates/settings/admin/additional-mail.php
+++ b/apps/settings/templates/settings/admin/additional-mail.php
@@ -34,6 +34,13 @@ $mail_sendmailmode = [
 ?>
 
 <div class="section" id="mail_general_settings">
+<?php if ($_['mail_smtpmode'] === 'null') { ?>
+	<h2><?php p($l->t('Email server'));?></h2>
+
+	<p>
+	 <?php p($l->t('Mail delivery is disabled by instance config "%s".', ['mail_smtpmode'])); ?>
+	</p>
+<?php } else { ?>
 	<form id="mail_general_settings_form" class="mail_settings">
 		<h2><?php p($l->t('Email server'));?></h2>
 		<a 	target="_blank"
@@ -143,4 +150,5 @@ $mail_sendmailmode = [
 	<em><?php p($l->t('Test and verify email settings')); ?></em>
 	<input type="submit" name="sendtestemail" id="sendtestemail" value="<?php p($l->t('Send email')); ?>"/>
 	<span id="sendtestmail_msg" class="msg"></span>
+<?php } ?>
 </div>
-- 
2.39.5