From 4237a3a071c080bfdb739849a6ad6517b3b51fcd Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Sun, 12 May 2019 16:51:55 +0200 Subject: [PATCH] SONAR-11950 autoconfig of SCM revision on Buildkite --- .../sonar/scanner/ci/vendors/Buildkite.java | 55 +++++++++++++++ .../scanner/scan/ProjectScanContainer.java | 2 + .../scanner/ci/vendors/BuildkiteTest.java | 69 +++++++++++++++++++ 3 files changed, 126 insertions(+) create mode 100644 sonar-scanner-engine/src/main/java/org/sonar/scanner/ci/vendors/Buildkite.java create mode 100644 sonar-scanner-engine/src/test/java/org/sonar/scanner/ci/vendors/BuildkiteTest.java diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scanner/ci/vendors/Buildkite.java b/sonar-scanner-engine/src/main/java/org/sonar/scanner/ci/vendors/Buildkite.java new file mode 100644 index 00000000000..3999ae27606 --- /dev/null +++ b/sonar-scanner-engine/src/main/java/org/sonar/scanner/ci/vendors/Buildkite.java @@ -0,0 +1,55 @@ +/* + * SonarQube + * Copyright (C) 2009-2019 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +package org.sonar.scanner.ci.vendors; + +import org.sonar.api.utils.System2; +import org.sonar.scanner.ci.CiConfiguration; +import org.sonar.scanner.ci.CiConfigurationImpl; +import org.sonar.scanner.ci.CiVendor; + +/** + * Support of https://buildkite.com + * + * Environment variables: https://buildkite.com/docs/pipelines/environment-variables + */ +public class Buildkite implements CiVendor { + + private final System2 system; + + public Buildkite(System2 system) { + this.system = system; + } + + @Override + public String getName() { + return "Buildkite"; + } + + @Override + public boolean isDetected() { + return "true".equals(system.envVariable("CI")) && "true".equals(system.envVariable("BUILDKITE")); + } + + @Override + public CiConfiguration loadConfiguration() { + String revision = system.envVariable("BUILDKITE_COMMIT"); + return new CiConfigurationImpl(revision); + } +} diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java index ceed297c4eb..d6a502a90b7 100644 --- a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java +++ b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java @@ -48,6 +48,7 @@ import org.sonar.scanner.bootstrap.PostJobExtensionDictionnary; import org.sonar.scanner.bootstrap.ProcessedScannerProperties; import org.sonar.scanner.ci.CiConfigurationProvider; import org.sonar.scanner.ci.vendors.BitbucketPipelines; +import org.sonar.scanner.ci.vendors.Buildkite; import org.sonar.scanner.ci.vendors.CircleCi; import org.sonar.scanner.ci.vendors.CirrusCi; import org.sonar.scanner.ci.vendors.DroneCi; @@ -272,6 +273,7 @@ public class ProjectScanContainer extends ComponentContainer { // CI new CiConfigurationProvider(), BitbucketPipelines.class, + Buildkite.class, CircleCi.class, CirrusCi.class, DroneCi.class, diff --git a/sonar-scanner-engine/src/test/java/org/sonar/scanner/ci/vendors/BuildkiteTest.java b/sonar-scanner-engine/src/test/java/org/sonar/scanner/ci/vendors/BuildkiteTest.java new file mode 100644 index 00000000000..eaecced743a --- /dev/null +++ b/sonar-scanner-engine/src/test/java/org/sonar/scanner/ci/vendors/BuildkiteTest.java @@ -0,0 +1,69 @@ +/* + * SonarQube + * Copyright (C) 2009-2019 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +package org.sonar.scanner.ci.vendors; + +import javax.annotation.Nullable; +import org.junit.Test; +import org.sonar.api.utils.System2; +import org.sonar.scanner.ci.CiVendor; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class BuildkiteTest { + + private System2 system = mock(System2.class); + private CiVendor underTest = new Buildkite(system); + + @Test + public void getName() { + assertThat(underTest.getName()).isEqualTo("Buildkite"); + } + + @Test + public void isDetected() { + setEnvVariable("CI", "true"); + setEnvVariable("BUILDKITE", "true"); + assertThat(underTest.isDetected()).isTrue(); + + setEnvVariable("CI", "true"); + setEnvVariable("SEMAPHORE", "true"); + setEnvVariable("BUILDKITE", null); + assertThat(underTest.isDetected()).isFalse(); + + setEnvVariable("CI", "false"); + setEnvVariable("BUILDKITE", "true"); + assertThat(underTest.isDetected()).isFalse(); + } + + @Test + public void loadConfiguration() { + setEnvVariable("CI", "true"); + setEnvVariable("BUILDKITE", "true"); + setEnvVariable("BUILDKITE_COMMIT", "abd12fc"); + + assertThat(underTest.loadConfiguration().getScmRevision()).hasValue("abd12fc"); + } + + private void setEnvVariable(String key, @Nullable String value) { + when(system.envVariable(key)).thenReturn(value); + } +} -- 2.39.5