From 426e153608926c74328fe4ead614efe82a0e6dcb Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Wed, 22 Apr 2015 11:39:49 +0200 Subject: [PATCH] Fix quality flaws --- .../src/main/java/org/sonar/server/view/index/ViewIndexer.java | 2 -- .../src/main/java/org/sonar/server/ws/WebServiceEngine.java | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/view/index/ViewIndexer.java b/server/sonar-server/src/main/java/org/sonar/server/view/index/ViewIndexer.java index 1b8a12356b3..93944e0cb38 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/view/index/ViewIndexer.java +++ b/server/sonar-server/src/main/java/org/sonar/server/view/index/ViewIndexer.java @@ -38,12 +38,10 @@ import static com.google.common.collect.Maps.newHashMap; public class ViewIndexer extends BaseIndexer { private final DbClient dbClient; - private final EsClient esClient; public ViewIndexer(DbClient dbClient, EsClient esClient) { super(esClient, 300, ViewIndexDefinition.INDEX, ViewIndexDefinition.TYPE_VIEW, "updatedAt"); this.dbClient = dbClient; - this.esClient = esClient; } /** diff --git a/server/sonar-server/src/main/java/org/sonar/server/ws/WebServiceEngine.java b/server/sonar-server/src/main/java/org/sonar/server/ws/WebServiceEngine.java index c27b2bb7132..dd386b375c0 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/ws/WebServiceEngine.java +++ b/server/sonar-server/src/main/java/org/sonar/server/ws/WebServiceEngine.java @@ -21,12 +21,12 @@ package org.sonar.server.ws; import com.google.common.base.Charsets; import org.picocontainer.Startable; -import org.sonar.api.utils.log.Loggers; import org.sonar.api.ServerComponent; import org.sonar.api.i18n.I18n; import org.sonar.api.server.ws.Request; import org.sonar.api.server.ws.WebService; import org.sonar.api.server.ws.internal.ValidatingRequest; +import org.sonar.api.utils.log.Loggers; import org.sonar.api.utils.text.JsonWriter; import org.sonar.server.exceptions.BadRequestException; import org.sonar.server.exceptions.Errors; @@ -91,7 +91,6 @@ public class WebServiceEngine implements ServerComponent, Startable { } catch (ServerException e) { sendErrors(response, e.httpCode(), new Errors().add(Message.of(e.getMessage()))); } catch (Exception e) { - // TODO implement Request.toString() Loggers.get(getClass()).error("Fail to process request " + request, e); sendErrors(response, 500, new Errors().add(Message.of(e.getMessage()))); } -- 2.39.5