From 44fbf9709b76d89db14f8dba0cc7ca15fb3e7954 Mon Sep 17 00:00:00 2001 From: Vsevolod Stakhov Date: Thu, 6 Jun 2013 14:35:31 +0100 Subject: [PATCH] Remove endless counter incrementing. In some cases it is not enough to perform compare and exchange and we still can get race condition in atomic incrementing. Therefore, it is better to loose a history event than to log error message each time. --- src/roll_history.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/roll_history.c b/src/roll_history.c index 69f141762..4206a6a8b 100644 --- a/src/roll_history.c +++ b/src/roll_history.c @@ -101,7 +101,8 @@ rspamd_roll_history_update (struct roll_history *history, struct worker_task *ta row->completed = FALSE; } else { - msg_err ("internal error with history roll occured, row number is invalid: %d", row_num); + /* Race condition */ + history->cur_row = 0; return; } -- 2.39.5